Patrick Venture | 22e3875 | 2018-11-21 08:52:49 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2018 Google Inc. |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 17 | #include "firmware_handler.hpp" |
| 18 | |
Patrick Venture | a78e39f | 2018-11-06 18:37:06 -0800 | [diff] [blame] | 19 | #include "image_handler.hpp" |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 20 | #include "util.hpp" |
Patrick Venture | 26a1726 | 2019-05-20 11:03:35 -0700 | [diff] [blame] | 21 | #include "verify.hpp" |
Patrick Venture | a78e39f | 2018-11-06 18:37:06 -0800 | [diff] [blame] | 22 | |
Patrick Venture | 137ad2c | 2018-11-06 11:30:43 -0800 | [diff] [blame] | 23 | #include <algorithm> |
Patrick Venture | 192d60f | 2018-11-06 11:11:59 -0800 | [diff] [blame] | 24 | #include <cstdint> |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 25 | #include <cstring> |
Patrick Venture | b3b4db7 | 2019-05-15 11:30:24 -0700 | [diff] [blame] | 26 | #include <fstream> |
Patrick Venture | 68cf64f | 2018-11-06 10:46:51 -0800 | [diff] [blame] | 27 | #include <memory> |
Patrick Venture | d333a87 | 2018-12-03 16:24:26 -0800 | [diff] [blame] | 28 | #include <phosphor-logging/log.hpp> |
Patrick Venture | fa6c4d9 | 2018-11-02 18:34:53 -0700 | [diff] [blame] | 29 | #include <string> |
| 30 | #include <vector> |
| 31 | |
Patrick Venture | d333a87 | 2018-12-03 16:24:26 -0800 | [diff] [blame] | 32 | using namespace phosphor::logging; |
| 33 | |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 34 | namespace ipmi_flash |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 35 | { |
Patrick Venture | b3b4db7 | 2019-05-15 11:30:24 -0700 | [diff] [blame] | 36 | |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 37 | std::unique_ptr<blobs::GenericBlobInterface> |
Patrick Venture | 148cd65 | 2018-11-06 10:59:47 -0800 | [diff] [blame] | 38 | FirmwareBlobHandler::CreateFirmwareBlobHandler( |
Patrick Venture | 3ecb350 | 2019-05-17 11:03:51 -0700 | [diff] [blame] | 39 | const std::vector<HandlerPack>& firmwares, |
Patrick Venture | 74059d6 | 2019-05-17 10:40:26 -0700 | [diff] [blame] | 40 | const std::vector<DataHandlerPack>& transports, |
Patrick Venture | 27ac582 | 2019-05-20 17:39:31 -0700 | [diff] [blame] | 41 | std::unique_ptr<VerificationInterface> verification, |
| 42 | std::unique_ptr<UpdateInterface> update) |
Patrick Venture | 68cf64f | 2018-11-06 10:46:51 -0800 | [diff] [blame] | 43 | { |
Patrick Venture | 5285462 | 2018-11-06 12:30:00 -0800 | [diff] [blame] | 44 | /* There must be at least one. */ |
| 45 | if (!firmwares.size()) |
| 46 | { |
Patrick Venture | d333a87 | 2018-12-03 16:24:26 -0800 | [diff] [blame] | 47 | log<level::ERR>("Must provide at least one firmware handler."); |
Patrick Venture | 5285462 | 2018-11-06 12:30:00 -0800 | [diff] [blame] | 48 | return nullptr; |
| 49 | } |
Patrick Venture | 1cde5f9 | 2018-11-07 08:26:47 -0800 | [diff] [blame] | 50 | if (!transports.size()) |
| 51 | { |
| 52 | return nullptr; |
| 53 | } |
Patrick Venture | 5285462 | 2018-11-06 12:30:00 -0800 | [diff] [blame] | 54 | |
Patrick Venture | a78e39f | 2018-11-06 18:37:06 -0800 | [diff] [blame] | 55 | std::vector<std::string> blobs; |
| 56 | for (const auto& item : firmwares) |
| 57 | { |
| 58 | blobs.push_back(item.blobName); |
| 59 | } |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 60 | |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 61 | if (0 == std::count(blobs.begin(), blobs.end(), hashBlobId)) |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 62 | { |
| 63 | return nullptr; |
| 64 | } |
Patrick Venture | 4cceb8e | 2018-11-06 11:56:48 -0800 | [diff] [blame] | 65 | |
Patrick Venture | 1cde5f9 | 2018-11-07 08:26:47 -0800 | [diff] [blame] | 66 | std::uint16_t bitmask = 0; |
| 67 | for (const auto& item : transports) |
| 68 | { |
| 69 | /* TODO: can use std::accumulate() unless I'm mistaken. :D */ |
| 70 | bitmask |= item.bitmask; |
| 71 | } |
| 72 | |
Patrick Venture | 3ecb350 | 2019-05-17 11:03:51 -0700 | [diff] [blame] | 73 | return std::make_unique<FirmwareBlobHandler>( |
Patrick Venture | 27ac582 | 2019-05-20 17:39:31 -0700 | [diff] [blame] | 74 | firmwares, blobs, transports, bitmask, std::move(verification), |
| 75 | std::move(update)); |
Patrick Venture | 68cf64f | 2018-11-06 10:46:51 -0800 | [diff] [blame] | 76 | } |
| 77 | |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 78 | /* Check if the path is in our supported list (or active list). */ |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 79 | bool FirmwareBlobHandler::canHandleBlob(const std::string& path) |
| 80 | { |
Patrick Venture | 6032dc0 | 2019-05-17 11:01:44 -0700 | [diff] [blame] | 81 | return (std::count(blobIDs.begin(), blobIDs.end(), path) > 0); |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 82 | } |
Patrick Venture | 5397796 | 2018-11-02 18:59:35 -0700 | [diff] [blame] | 83 | |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 84 | /* |
| 85 | * Grab the list of supported firmware. |
| 86 | * |
| 87 | * If there's an open firmware session, it'll already be present in the |
| 88 | * list as "/flash/active/image", and if the hash has started, |
| 89 | * "/flash/active/hash" regardless of mechanism. This is done in the open |
| 90 | * comamnd, no extra work is required here. |
| 91 | */ |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 92 | std::vector<std::string> FirmwareBlobHandler::getBlobIds() |
| 93 | { |
Patrick Venture | 4cceb8e | 2018-11-06 11:56:48 -0800 | [diff] [blame] | 94 | return blobIDs; |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 95 | } |
Patrick Venture | 5397796 | 2018-11-02 18:59:35 -0700 | [diff] [blame] | 96 | |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 97 | /* |
| 98 | * Per the design, this mean abort, and this will trigger whatever |
| 99 | * appropriate actions are required to abort the process. |
Patrick Venture | 9e5aab2 | 2018-11-09 20:49:28 -0800 | [diff] [blame] | 100 | * |
| 101 | * You cannot delete a blob that has an open handle in the system, therefore |
| 102 | * this is never called if there's an open session. Guaranteed by the blob |
| 103 | * manager. |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 104 | */ |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 105 | bool FirmwareBlobHandler::deleteBlob(const std::string& path) |
| 106 | { |
Patrick Venture | 9e5aab2 | 2018-11-09 20:49:28 -0800 | [diff] [blame] | 107 | const std::string* toDelete; |
| 108 | |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 109 | /* You cannot delete the verify blob -- trying to delete it, currently has |
| 110 | * no impact. |
| 111 | * TODO: Should trying to delete this cause an abort? |
| 112 | */ |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 113 | if (path == verifyBlobId) |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 114 | { |
| 115 | return false; |
| 116 | } |
| 117 | |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 118 | if (path == hashBlobId || path == activeHashBlobId) |
Patrick Venture | 9e5aab2 | 2018-11-09 20:49:28 -0800 | [diff] [blame] | 119 | { |
| 120 | /* They're deleting the hash. */ |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 121 | toDelete = &activeHashBlobId; |
Patrick Venture | 9e5aab2 | 2018-11-09 20:49:28 -0800 | [diff] [blame] | 122 | } |
| 123 | else |
| 124 | { |
| 125 | /* They're deleting the image. */ |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 126 | toDelete = &activeImageBlobId; |
Patrick Venture | 9e5aab2 | 2018-11-09 20:49:28 -0800 | [diff] [blame] | 127 | } |
| 128 | |
| 129 | auto it = std::find_if( |
| 130 | blobIDs.begin(), blobIDs.end(), |
| 131 | [toDelete](const auto& iter) { return (iter == *toDelete); }); |
| 132 | if (it == blobIDs.end()) |
| 133 | { |
| 134 | /* Somehow they've asked to delete something we didn't say we could |
| 135 | * handle. |
| 136 | */ |
| 137 | return false; |
| 138 | } |
| 139 | |
| 140 | blobIDs.erase(it); |
| 141 | |
| 142 | /* TODO: Handle aborting the process and fixing up the state. */ |
| 143 | |
| 144 | return true; |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 145 | } |
Patrick Venture | 5397796 | 2018-11-02 18:59:35 -0700 | [diff] [blame] | 146 | |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 147 | /* |
| 148 | * Stat on the files will return information such as what supported |
| 149 | * transport mechanisms are available. |
| 150 | * |
| 151 | * Stat on an active file or hash will return information such as the size |
| 152 | * of the data cached, and any additional pertinent information. The |
| 153 | * blob_state on the active files will return the state of the update. |
| 154 | */ |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 155 | bool FirmwareBlobHandler::stat(const std::string& path, |
| 156 | struct blobs::BlobMeta* meta) |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 157 | { |
Patrick Venture | 46637c8 | 2018-11-06 15:20:24 -0800 | [diff] [blame] | 158 | /* We know we support this path because canHandle is called ahead */ |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 159 | if (path == verifyBlobId) |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 160 | { |
Patrick Venture | 699750d | 2019-05-15 09:24:09 -0700 | [diff] [blame] | 161 | /* TODO: We need to return information for the verify state -- did they |
| 162 | * call commit() did things start? |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 163 | */ |
| 164 | } |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 165 | else if (path == activeImageBlobId) |
Patrick Venture | 46637c8 | 2018-11-06 15:20:24 -0800 | [diff] [blame] | 166 | { |
Patrick Venture | 699750d | 2019-05-15 09:24:09 -0700 | [diff] [blame] | 167 | /* TODO: We need to return information for the image that's staged. */ |
Patrick Venture | 46637c8 | 2018-11-06 15:20:24 -0800 | [diff] [blame] | 168 | } |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 169 | else if (path == activeHashBlobId) |
Patrick Venture | 46637c8 | 2018-11-06 15:20:24 -0800 | [diff] [blame] | 170 | { |
Patrick Venture | 699750d | 2019-05-15 09:24:09 -0700 | [diff] [blame] | 171 | /* TODO: We need to return information for the hash that's staged. */ |
Patrick Venture | 46637c8 | 2018-11-06 15:20:24 -0800 | [diff] [blame] | 172 | } |
| 173 | else |
| 174 | { |
| 175 | /* They are requesting information about the generic blob_id. */ |
Patrick Venture | 1cde5f9 | 2018-11-07 08:26:47 -0800 | [diff] [blame] | 176 | meta->blobState = bitmask; |
Patrick Venture | 46637c8 | 2018-11-06 15:20:24 -0800 | [diff] [blame] | 177 | meta->size = 0; |
| 178 | |
| 179 | /* The generic blob_ids state is only the bits related to the transport |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 180 | * mechanisms. |
| 181 | */ |
Patrick Venture | 46637c8 | 2018-11-06 15:20:24 -0800 | [diff] [blame] | 182 | return true; |
| 183 | } |
| 184 | |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 185 | return false; |
| 186 | } |
Patrick Venture | 5397796 | 2018-11-02 18:59:35 -0700 | [diff] [blame] | 187 | |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 188 | /* |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 189 | * Return stat information on an open session. It therefore must be an active |
| 190 | * handle to either the active image or active hash. |
| 191 | * |
| 192 | * The stat() and sessionstat() commands will return the same information in |
| 193 | * many cases, therefore the logic will be combined. |
| 194 | * |
| 195 | * TODO: combine the logic for stat and sessionstat(). |
| 196 | */ |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 197 | bool FirmwareBlobHandler::stat(uint16_t session, struct blobs::BlobMeta* meta) |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 198 | { |
Patrick Venture | cc7d160 | 2018-11-15 13:58:33 -0800 | [diff] [blame] | 199 | auto item = lookup.find(session); |
| 200 | if (item == lookup.end()) |
| 201 | { |
| 202 | return false; |
| 203 | } |
| 204 | |
Patrick Venture | b3b4db7 | 2019-05-15 11:30:24 -0700 | [diff] [blame] | 205 | /* The size here refers to the size of the file -- of something analagous. |
| 206 | */ |
| 207 | meta->size = (item->second->imageHandler) |
| 208 | ? item->second->imageHandler->getSize() |
| 209 | : 0; |
| 210 | |
| 211 | meta->metadata.clear(); |
| 212 | |
Patrick Venture | 699750d | 2019-05-15 09:24:09 -0700 | [diff] [blame] | 213 | /* TODO: Implement this for the verification blob, which is what we expect. |
| 214 | * Calling stat() on the verify blob without an active session should not |
| 215 | * provide insight. |
| 216 | */ |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 217 | if (item->second->activePath == verifyBlobId) |
Patrick Venture | b3b4db7 | 2019-05-15 11:30:24 -0700 | [diff] [blame] | 218 | { |
Patrick Venture | 01a3327 | 2019-05-23 19:48:22 -0700 | [diff] [blame] | 219 | VerifyCheckResponses value; |
| 220 | |
| 221 | if (state == UpdateState::verificationPending) |
| 222 | { |
| 223 | value = VerifyCheckResponses::other; |
| 224 | } |
| 225 | else |
| 226 | { |
| 227 | value = verification->checkVerificationState(); |
| 228 | } |
Patrick Venture | 699750d | 2019-05-15 09:24:09 -0700 | [diff] [blame] | 229 | |
Patrick Venture | e955e07 | 2019-05-15 16:16:46 -0700 | [diff] [blame] | 230 | meta->metadata.push_back(static_cast<std::uint8_t>(value)); |
| 231 | |
| 232 | /* Change the firmware handler's state and the blob's stat value |
| 233 | * depending. |
| 234 | */ |
| 235 | if (value == VerifyCheckResponses::success || |
| 236 | value == VerifyCheckResponses::failed) |
| 237 | { |
| 238 | state = UpdateState::verificationCompleted; |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 239 | item->second->flags &= ~blobs::StateFlags::committing; |
Patrick Venture | e955e07 | 2019-05-15 16:16:46 -0700 | [diff] [blame] | 240 | |
| 241 | if (value == VerifyCheckResponses::success) |
| 242 | { |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 243 | item->second->flags |= blobs::StateFlags::committed; |
Patrick Venture | e955e07 | 2019-05-15 16:16:46 -0700 | [diff] [blame] | 244 | } |
| 245 | else |
| 246 | { |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 247 | item->second->flags |= blobs::StateFlags::commit_error; |
Patrick Venture | e955e07 | 2019-05-15 16:16:46 -0700 | [diff] [blame] | 248 | } |
| 249 | } |
Patrick Venture | b3b4db7 | 2019-05-15 11:30:24 -0700 | [diff] [blame] | 250 | } |
Patrick Venture | cc7d160 | 2018-11-15 13:58:33 -0800 | [diff] [blame] | 251 | |
Patrick Venture | e955e07 | 2019-05-15 16:16:46 -0700 | [diff] [blame] | 252 | /* The blobState here relates to an active sesion, so we should return the |
| 253 | * flags used to open this session. |
| 254 | */ |
| 255 | meta->blobState = item->second->flags; |
| 256 | |
Patrick Venture | cc7d160 | 2018-11-15 13:58:33 -0800 | [diff] [blame] | 257 | /* The metadata blob returned comes from the data handler... it's used for |
| 258 | * instance, in P2A bridging to get required information about the mapping, |
| 259 | * and is the "opposite" of the lpc writemeta requirement. |
| 260 | */ |
Patrick Venture | cc7d160 | 2018-11-15 13:58:33 -0800 | [diff] [blame] | 261 | if (item->second->dataHandler) |
| 262 | { |
Patrick Venture | 7430464 | 2019-01-17 09:31:04 -0800 | [diff] [blame] | 263 | auto bytes = item->second->dataHandler->readMeta(); |
Patrick Venture | cc7d160 | 2018-11-15 13:58:33 -0800 | [diff] [blame] | 264 | meta->metadata.insert(meta->metadata.begin(), bytes.begin(), |
| 265 | bytes.end()); |
| 266 | } |
| 267 | |
Patrick Venture | cc7d160 | 2018-11-15 13:58:33 -0800 | [diff] [blame] | 268 | return true; |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 269 | } |
| 270 | |
| 271 | /* |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 272 | * If you open /flash/image or /flash/tarball, or /flash/hash it will |
| 273 | * interpret the open flags and perform whatever actions are required for |
| 274 | * that update process. The session returned can be used immediately for |
| 275 | * sending data down, without requiring one to open the new active file. |
| 276 | * |
| 277 | * If you open the active flash image or active hash it will let you |
| 278 | * overwrite pieces, depending on the state. |
| 279 | * |
| 280 | * Once the verification process has started the active files cannot be |
| 281 | * opened. |
| 282 | * |
| 283 | * You can only have one open session at a time. Which means, you can only |
| 284 | * have one file open at a time. Trying to open the hash blob_id while you |
| 285 | * still have the flash image blob_id open will fail. Opening the flash |
| 286 | * blob_id when it is already open will fail. |
| 287 | */ |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 288 | bool FirmwareBlobHandler::open(uint16_t session, uint16_t flags, |
| 289 | const std::string& path) |
| 290 | { |
Patrick Venture | 6e307a7 | 2018-11-09 18:21:17 -0800 | [diff] [blame] | 291 | /* Check that they've opened for writing - read back not currently |
| 292 | * supported. |
| 293 | */ |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 294 | if ((flags & blobs::OpenFlags::write) == 0) |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 295 | { |
| 296 | return false; |
| 297 | } |
| 298 | |
Patrick Venture | b1b68fc | 2018-11-09 09:37:04 -0800 | [diff] [blame] | 299 | /* Is the verification process underway? */ |
| 300 | if (state == UpdateState::verificationStarted) |
| 301 | { |
| 302 | return false; |
| 303 | } |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 304 | |
| 305 | /* Is there an open session already? We only allow one at a time. |
Patrick Venture | 6e307a7 | 2018-11-09 18:21:17 -0800 | [diff] [blame] | 306 | * |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 307 | * TODO: Temporarily using a simple boolean flag until there's a full |
| 308 | * session object to check. |
Patrick Venture | 7c8b97e | 2018-11-08 09:14:30 -0800 | [diff] [blame] | 309 | * |
| 310 | * Further on this, if there's an active session to the hash we don't allow |
| 311 | * re-opening the image, and if we have the image open, we don't allow |
| 312 | * opening the hash. This design decision may be re-evaluated, and changed |
| 313 | * to only allow one session per object type (of the two types). But, |
| 314 | * consider if the hash is open, do we want to allow writing to the image? |
| 315 | * And why would we? But, really, the point of no-return is once the |
| 316 | * verification process has begun -- which is done via commit() on the hash |
| 317 | * blob_id, we no longer want to allow updating the contents. |
Patrick Venture | 5397796 | 2018-11-02 18:59:35 -0700 | [diff] [blame] | 318 | */ |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 319 | if (fileOpen) |
| 320 | { |
| 321 | return false; |
| 322 | } |
| 323 | |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 324 | /* Handle opening the verifyBlobId --> we know the image and hash aren't |
| 325 | * open because of the fileOpen check. |
| 326 | * |
| 327 | * The file must be opened for writing, but no transport mechanism specified |
| 328 | * since it's irrelevant. |
| 329 | */ |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 330 | if (path == verifyBlobId) |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 331 | { |
| 332 | /* In this case, there's no image handler to use, or data handler, |
| 333 | * simply set up a session. |
| 334 | */ |
| 335 | verifyImage.flags = flags; |
| 336 | verifyImage.state = Session::State::open; |
| 337 | |
| 338 | lookup[session] = &verifyImage; |
| 339 | |
| 340 | fileOpen = true; |
| 341 | |
| 342 | return true; |
| 343 | } |
| 344 | |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 345 | /* There are two abstractions at play, how you get the data and how you |
| 346 | * handle that data. such that, whether the data comes from the PCI bridge |
| 347 | * or LPC bridge is not connected to whether the data goes into a static |
| 348 | * layout flash update or a UBI tarball. |
| 349 | */ |
| 350 | |
| 351 | /* Check the flags for the transport mechanism: if none match we don't |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 352 | * support what they request. |
| 353 | */ |
Patrick Venture | 1cde5f9 | 2018-11-07 08:26:47 -0800 | [diff] [blame] | 354 | if ((flags & bitmask) == 0) |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 355 | { |
| 356 | return false; |
| 357 | } |
| 358 | |
| 359 | /* 2) there isn't, so what are they opening? */ |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 360 | if (path == activeImageBlobId) |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 361 | { |
| 362 | /* 2a) are they opening the active image? this can only happen if they |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 363 | * already started one (due to canHandleBlob's behavior). |
| 364 | */ |
Patrick Venture | 21c62c1 | 2018-11-09 17:46:58 -0800 | [diff] [blame] | 365 | return false; |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 366 | } |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 367 | else if (path == activeHashBlobId) |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 368 | { |
| 369 | /* 2b) are they opening the active hash? this can only happen if they |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 370 | * already started one (due to canHandleBlob's behavior). |
| 371 | */ |
Patrick Venture | 21c62c1 | 2018-11-09 17:46:58 -0800 | [diff] [blame] | 372 | return false; |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 373 | } |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 374 | |
| 375 | /* How are they expecting to copy this data? */ |
| 376 | auto d = std::find_if( |
| 377 | transports.begin(), transports.end(), |
| 378 | [&flags](const auto& iter) { return (iter.bitmask & flags); }); |
| 379 | if (d == transports.end()) |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 380 | { |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 381 | return false; |
| 382 | } |
| 383 | |
| 384 | /* We found the transport handler they requested, no surprise since |
| 385 | * above we verify they selected at least one we wanted. |
| 386 | */ |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 387 | |
Patrick Venture | 6e307a7 | 2018-11-09 18:21:17 -0800 | [diff] [blame] | 388 | /* Elsewhere I do this check by checking "if ::ipmi" because that's the |
| 389 | * only non-external data pathway -- but this is just a more generic |
| 390 | * approach to that. |
| 391 | */ |
| 392 | if (d->handler) |
| 393 | { |
| 394 | /* If the data handler open call fails, open fails. */ |
| 395 | if (!d->handler->open()) |
| 396 | { |
| 397 | return false; |
| 398 | } |
| 399 | } |
| 400 | |
Patrick Venture | 70e30bf | 2019-01-17 10:29:28 -0800 | [diff] [blame] | 401 | /* Do we have a file handler for the type of file they're opening. |
| 402 | * Note: This should only fail if something is somehow crazy wrong. |
| 403 | * Since the canHandle() said yes, and that's tied into the list of explicit |
| 404 | * firmware handers (and file handlers, like this'll know where to write the |
| 405 | * tarball, etc). |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 406 | */ |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 407 | auto h = std::find_if( |
| 408 | handlers.begin(), handlers.end(), |
| 409 | [&path](const auto& iter) { return (iter.blobName == path); }); |
| 410 | if (h == handlers.end()) |
| 411 | { |
| 412 | return false; |
| 413 | } |
| 414 | |
| 415 | /* Ok, so we found a handler that matched, so call open() */ |
| 416 | if (!h->handler->open(path)) |
| 417 | { |
| 418 | return false; |
| 419 | } |
| 420 | |
Patrick Venture | 70e30bf | 2019-01-17 10:29:28 -0800 | [diff] [blame] | 421 | Session* curr; |
| 422 | const std::string* active; |
| 423 | |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 424 | if (path == hashBlobId) |
Patrick Venture | 70e30bf | 2019-01-17 10:29:28 -0800 | [diff] [blame] | 425 | { |
| 426 | /* 2c) are they opening the /flash/hash ? (to start the process) */ |
| 427 | curr = &activeHash; |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 428 | active = &activeHashBlobId; |
Patrick Venture | 70e30bf | 2019-01-17 10:29:28 -0800 | [diff] [blame] | 429 | } |
| 430 | else |
| 431 | { |
| 432 | curr = &activeImage; |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 433 | active = &activeImageBlobId; |
Patrick Venture | 70e30bf | 2019-01-17 10:29:28 -0800 | [diff] [blame] | 434 | } |
| 435 | |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 436 | curr->flags = flags; |
| 437 | curr->dataHandler = d->handler; |
| 438 | curr->imageHandler = h->handler; |
Patrick Venture | cd31022 | 2018-11-09 18:47:13 -0800 | [diff] [blame] | 439 | curr->state = Session::State::open; |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 440 | |
| 441 | lookup[session] = curr; |
| 442 | |
Patrick Venture | efba42d | 2019-05-24 10:48:16 -0700 | [diff] [blame] | 443 | addBlobId(*active); |
Patrick Venture | 930c7b7 | 2019-05-24 11:11:08 -0700 | [diff] [blame] | 444 | removeBlobId(verifyBlobId); |
Patrick Venture | db253bf | 2018-11-09 19:36:03 -0800 | [diff] [blame] | 445 | |
Patrick Venture | 12233c5 | 2019-05-16 09:26:59 -0700 | [diff] [blame] | 446 | state = UpdateState::uploadInProgress; |
Patrick Venture | 991910a | 2018-11-09 19:43:48 -0800 | [diff] [blame] | 447 | fileOpen = true; |
| 448 | |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 449 | return true; |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 450 | } |
Patrick Venture | 5397796 | 2018-11-02 18:59:35 -0700 | [diff] [blame] | 451 | |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 452 | /** |
| 453 | * The write command really just grabs the data from wherever it is and sends it |
| 454 | * to the image handler. It's the image handler's responsibility to deal with |
| 455 | * the data provided. |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 456 | * |
| 457 | * This receives a session from the blob manager, therefore it is always called |
| 458 | * between open() and close(). |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 459 | */ |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 460 | bool FirmwareBlobHandler::write(uint16_t session, uint32_t offset, |
| 461 | const std::vector<uint8_t>& data) |
| 462 | { |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 463 | auto item = lookup.find(session); |
| 464 | if (item == lookup.end()) |
| 465 | { |
| 466 | return false; |
| 467 | } |
| 468 | |
Patrick Venture | b1b68fc | 2018-11-09 09:37:04 -0800 | [diff] [blame] | 469 | /* Prevent writing during verification. */ |
| 470 | if (state == UpdateState::verificationStarted) |
| 471 | { |
| 472 | return false; |
| 473 | } |
| 474 | |
Patrick Venture | 8af15eb | 2019-05-15 09:39:22 -0700 | [diff] [blame] | 475 | /* Prevent writing to the verification blob before they trigger |
Patrick Venture | 699750d | 2019-05-15 09:24:09 -0700 | [diff] [blame] | 476 | * verification. |
| 477 | */ |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 478 | if (item->second->activePath == verifyBlobId) |
Patrick Venture | 8af15eb | 2019-05-15 09:39:22 -0700 | [diff] [blame] | 479 | { |
| 480 | return false; |
| 481 | } |
Patrick Venture | 699750d | 2019-05-15 09:24:09 -0700 | [diff] [blame] | 482 | |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 483 | std::vector<std::uint8_t> bytes; |
| 484 | |
Patrick Venture | 05abf7e | 2018-11-09 11:02:56 -0800 | [diff] [blame] | 485 | if (item->second->flags & UpdateFlags::ipmi) |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 486 | { |
| 487 | bytes = data; |
| 488 | } |
| 489 | else |
| 490 | { |
| 491 | /* little endian required per design, and so on, but TODO: do endianness |
| 492 | * with boost. |
| 493 | */ |
| 494 | struct ExtChunkHdr header; |
| 495 | |
| 496 | if (data.size() != sizeof(header)) |
| 497 | { |
| 498 | return false; |
| 499 | } |
| 500 | |
| 501 | std::memcpy(&header, data.data(), data.size()); |
| 502 | bytes = item->second->dataHandler->copyFrom(header.length); |
| 503 | } |
| 504 | |
| 505 | return item->second->imageHandler->write(offset, bytes); |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 506 | } |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 507 | |
Patrick Venture | 8c53533 | 2018-11-08 15:58:00 -0800 | [diff] [blame] | 508 | /* |
| 509 | * If the active session (image or hash) is over LPC, this allows |
| 510 | * configuring it. This option is only available before you start |
| 511 | * writing data for the given item (image or hash). This will return |
| 512 | * false at any other part. -- the lpc handler portion will know to return |
| 513 | * false. |
| 514 | */ |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 515 | bool FirmwareBlobHandler::writeMeta(uint16_t session, uint32_t offset, |
| 516 | const std::vector<uint8_t>& data) |
| 517 | { |
Patrick Venture | 8c53533 | 2018-11-08 15:58:00 -0800 | [diff] [blame] | 518 | auto item = lookup.find(session); |
| 519 | if (item == lookup.end()) |
| 520 | { |
| 521 | return false; |
| 522 | } |
| 523 | |
Patrick Venture | 05abf7e | 2018-11-09 11:02:56 -0800 | [diff] [blame] | 524 | if (item->second->flags & UpdateFlags::ipmi) |
Patrick Venture | 8c53533 | 2018-11-08 15:58:00 -0800 | [diff] [blame] | 525 | { |
| 526 | return false; |
| 527 | } |
| 528 | |
Patrick Venture | d56097a | 2019-05-15 09:47:55 -0700 | [diff] [blame] | 529 | /* Prevent writing meta to the verification blob (it has no data handler). |
| 530 | */ |
| 531 | if (item->second->dataHandler) |
| 532 | { |
| 533 | return item->second->dataHandler->writeMeta(data); |
| 534 | } |
Patrick Venture | 699750d | 2019-05-15 09:24:09 -0700 | [diff] [blame] | 535 | |
Patrick Venture | d56097a | 2019-05-15 09:47:55 -0700 | [diff] [blame] | 536 | return false; |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 537 | } |
Patrick Venture | 8c53533 | 2018-11-08 15:58:00 -0800 | [diff] [blame] | 538 | |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 539 | /* |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 540 | * If this command is called on the session for the verifyBlobId, it'll |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 541 | * trigger a systemd service `verify_image.service` to attempt to verify |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 542 | * the image. |
| 543 | * |
| 544 | * For this file to have opened, the other two must be closed, which means any |
| 545 | * out-of-band transport mechanism involved is closed. |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 546 | */ |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 547 | bool FirmwareBlobHandler::commit(uint16_t session, |
| 548 | const std::vector<uint8_t>& data) |
| 549 | { |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 550 | auto item = lookup.find(session); |
| 551 | if (item == lookup.end()) |
| 552 | { |
| 553 | return false; |
| 554 | } |
| 555 | |
| 556 | /* You can only commit on the verifyBlodId */ |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 557 | if (item->second->activePath != verifyBlobId) |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 558 | { |
| 559 | return false; |
| 560 | } |
| 561 | |
Patrick Venture | be19870 | 2019-05-15 09:46:02 -0700 | [diff] [blame] | 562 | /* Calling repeatedly has no effect within an update process. */ |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 563 | if (state == UpdateState::verificationStarted) |
| 564 | { |
Patrick Venture | be19870 | 2019-05-15 09:46:02 -0700 | [diff] [blame] | 565 | return true; |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 566 | } |
| 567 | |
| 568 | /* Set state to committing. */ |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 569 | item->second->flags |= blobs::StateFlags::committing; |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 570 | |
| 571 | return triggerVerification(); |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 572 | } |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 573 | |
| 574 | /* |
| 575 | * Close must be called on the firmware image before triggering |
| 576 | * verification via commit. Once the verification is complete, you can |
| 577 | * then close the hash file. |
| 578 | * |
| 579 | * If the `verify_image.service` returned success, closing the hash file |
| 580 | * will have a specific behavior depending on the update. If it's UBI, |
| 581 | * it'll perform the install. If it's static layout, it'll do nothing. The |
| 582 | * verify_image service in the static layout case is responsible for placing |
| 583 | * the file in the correct staging position. |
| 584 | */ |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 585 | bool FirmwareBlobHandler::close(uint16_t session) |
| 586 | { |
Patrick Venture | 68bb143 | 2018-11-09 20:08:48 -0800 | [diff] [blame] | 587 | auto item = lookup.find(session); |
| 588 | if (item == lookup.end()) |
| 589 | { |
| 590 | return false; |
| 591 | } |
| 592 | |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 593 | /* Are you closing the verify blob? */ |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 594 | if (item->second->activePath == verifyBlobId) |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 595 | { |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 596 | if (state == UpdateState::verificationStarted) |
| 597 | { |
Patrick Venture | 12233c5 | 2019-05-16 09:26:59 -0700 | [diff] [blame] | 598 | /* TODO: If they close this blob before verification finishes, |
| 599 | * that's an abort. |
| 600 | */ |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 601 | return false; |
| 602 | } |
Patrick Venture | 12233c5 | 2019-05-16 09:26:59 -0700 | [diff] [blame] | 603 | else if (state == UpdateState::verificationCompleted) |
| 604 | { |
| 605 | /* TODO: Should this delete the verification artifact? */ |
| 606 | state = UpdateState::notYetStarted; |
| 607 | |
| 608 | /* A this point, delete the active blob IDs from the blob_list. */ |
Patrick Venture | 930c7b7 | 2019-05-24 11:11:08 -0700 | [diff] [blame] | 609 | removeBlobId(activeImageBlobId); |
| 610 | removeBlobId(activeHashBlobId); |
Patrick Venture | 12233c5 | 2019-05-16 09:26:59 -0700 | [diff] [blame] | 611 | } |
| 612 | /* Must be verificationPending... not yet started, they may re-open and |
| 613 | * trigger verification. |
| 614 | */ |
| 615 | } |
| 616 | else |
| 617 | { |
| 618 | /* They are closing a data pathway (image, tarball, hash). */ |
| 619 | state = UpdateState::verificationPending; |
Patrick Venture | 930c7b7 | 2019-05-24 11:11:08 -0700 | [diff] [blame] | 620 | |
| 621 | /* Add verify blob ID now that we can expect it. */ |
| 622 | addBlobId(verifyBlobId); |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 623 | } |
| 624 | |
Patrick Venture | 68bb143 | 2018-11-09 20:08:48 -0800 | [diff] [blame] | 625 | if (item->second->dataHandler) |
| 626 | { |
| 627 | item->second->dataHandler->close(); |
| 628 | } |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 629 | if (item->second->imageHandler) |
| 630 | { |
| 631 | item->second->imageHandler->close(); |
| 632 | } |
| 633 | |
Patrick Venture | 68bb143 | 2018-11-09 20:08:48 -0800 | [diff] [blame] | 634 | item->second->state = Session::State::closed; |
| 635 | /* Do not delete the active blob_id from the list of blob_ids, because that |
| 636 | * blob_id indicates there is data stored. Delete will destroy it. |
| 637 | */ |
| 638 | |
| 639 | lookup.erase(item); |
| 640 | |
Patrick Venture | 991910a | 2018-11-09 19:43:48 -0800 | [diff] [blame] | 641 | fileOpen = false; |
| 642 | |
Patrick Venture | 68bb143 | 2018-11-09 20:08:48 -0800 | [diff] [blame] | 643 | return true; |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 644 | } |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 645 | |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 646 | bool FirmwareBlobHandler::expire(uint16_t session) |
| 647 | { |
| 648 | return false; |
| 649 | } |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 650 | |
| 651 | /* |
| 652 | * Currently, the design does not provide this with a function, however, |
| 653 | * it will likely change to support reading data back. |
| 654 | */ |
| 655 | std::vector<uint8_t> FirmwareBlobHandler::read(uint16_t session, |
| 656 | uint32_t offset, |
| 657 | uint32_t requestedSize) |
| 658 | { |
| 659 | return {}; |
| 660 | } |
| 661 | |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 662 | bool FirmwareBlobHandler::triggerVerification() |
| 663 | { |
Patrick Venture | 3ecb350 | 2019-05-17 11:03:51 -0700 | [diff] [blame] | 664 | bool result = verification->triggerVerification(); |
| 665 | if (result) |
Patrick Venture | cabc117 | 2018-11-16 16:14:26 -0800 | [diff] [blame] | 666 | { |
Patrick Venture | 453f06a | 2019-01-17 10:02:12 -0800 | [diff] [blame] | 667 | state = UpdateState::verificationStarted; |
Patrick Venture | cabc117 | 2018-11-16 16:14:26 -0800 | [diff] [blame] | 668 | } |
Patrick Venture | cabc117 | 2018-11-16 16:14:26 -0800 | [diff] [blame] | 669 | |
Patrick Venture | 3ecb350 | 2019-05-17 11:03:51 -0700 | [diff] [blame] | 670 | return result; |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 671 | } |
| 672 | |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 673 | } // namespace ipmi_flash |