Patrick Venture | 21be45a | 2018-11-06 12:08:52 -0800 | [diff] [blame] | 1 | #include "firmware_handler.hpp" |
Patrick Venture | 84778b8 | 2019-06-26 20:11:09 -0700 | [diff] [blame] | 2 | #include "flags.hpp" |
Patrick Venture | a78e39f | 2018-11-06 18:37:06 -0800 | [diff] [blame] | 3 | #include "image_mock.hpp" |
Patrick Venture | 1d66fe6 | 2019-06-03 14:57:27 -0700 | [diff] [blame] | 4 | #include "triggerable_mock.hpp" |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 5 | #include "util.hpp" |
Patrick Venture | 21be45a | 2018-11-06 12:08:52 -0800 | [diff] [blame] | 6 | |
Patrick Venture | 5285462 | 2018-11-06 12:30:00 -0800 | [diff] [blame] | 7 | #include <algorithm> |
Patrick Venture | d4e20de | 2019-07-18 12:48:05 -0700 | [diff] [blame] | 8 | #include <memory> |
Patrick Venture | a78e39f | 2018-11-06 18:37:06 -0800 | [diff] [blame] | 9 | #include <vector> |
Patrick Venture | 21be45a | 2018-11-06 12:08:52 -0800 | [diff] [blame] | 10 | |
| 11 | #include <gtest/gtest.h> |
| 12 | |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 13 | namespace ipmi_flash |
Patrick Venture | 21be45a | 2018-11-06 12:08:52 -0800 | [diff] [blame] | 14 | { |
Patrick Venture | 930c7b7 | 2019-05-24 11:11:08 -0700 | [diff] [blame] | 15 | namespace |
| 16 | { |
| 17 | |
| 18 | using ::testing::UnorderedElementsAreArray; |
Patrick Venture | 5285462 | 2018-11-06 12:30:00 -0800 | [diff] [blame] | 19 | |
Patrick Venture | 1626538 | 2019-11-06 19:31:36 -0800 | [diff] [blame] | 20 | TEST(FirmwareHandlerTest, CreateEmptyHandlerListVerifyFails) |
Patrick Venture | 21be45a | 2018-11-06 12:08:52 -0800 | [diff] [blame] | 21 | { |
Patrick Venture | 4934daa | 2020-09-22 16:37:44 -0700 | [diff] [blame] | 22 | std::vector<DataHandlerPack> data; |
| 23 | data.emplace_back(FirmwareFlags::UpdateFlags::ipmi, nullptr); |
Patrick Venture | 1cde5f9 | 2018-11-07 08:26:47 -0800 | [diff] [blame] | 24 | |
Patrick Venture | 4eb5595 | 2018-11-16 15:36:24 -0800 | [diff] [blame] | 25 | auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler( |
Patrick Venture | 7b78343 | 2020-09-22 15:55:08 -0700 | [diff] [blame] | 26 | {}, std::move(data), std::move(CreateActionMap("abcd"))); |
Patrick Venture | 1cde5f9 | 2018-11-07 08:26:47 -0800 | [diff] [blame] | 27 | EXPECT_EQ(handler, nullptr); |
| 28 | } |
| 29 | TEST(FirmwareHandlerTest, CreateEmptyDataHandlerListFails) |
| 30 | { |
| 31 | ImageHandlerMock imageMock; |
| 32 | |
Patrick Venture | d4e20de | 2019-07-18 12:48:05 -0700 | [diff] [blame] | 33 | std::vector<HandlerPack> blobs; |
| 34 | blobs.push_back(std::move( |
| 35 | HandlerPack(hashBlobId, std::make_unique<ImageHandlerMock>()))); |
| 36 | blobs.push_back( |
| 37 | std::move(HandlerPack("asdf", std::make_unique<ImageHandlerMock>()))); |
Patrick Venture | 1cde5f9 | 2018-11-07 08:26:47 -0800 | [diff] [blame] | 38 | |
Patrick Venture | 4eb5595 | 2018-11-16 15:36:24 -0800 | [diff] [blame] | 39 | auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler( |
Patrick Venture | 7b78343 | 2020-09-22 15:55:08 -0700 | [diff] [blame] | 40 | std::move(blobs), std::move(std::vector<DataHandlerPack>()), |
| 41 | std::move(CreateActionMap("asdf"))); |
Patrick Venture | 5285462 | 2018-11-06 12:30:00 -0800 | [diff] [blame] | 42 | EXPECT_EQ(handler, nullptr); |
| 43 | } |
Patrick Venture | 1626538 | 2019-11-06 19:31:36 -0800 | [diff] [blame] | 44 | TEST(FirmwareHandlerTest, CreateEmptyActionPackVerifyFails) |
| 45 | { |
| 46 | /* The ActionPack map corresponds to the firmware list passed in, but |
| 47 | * they're not checked against each other yet. |
| 48 | */ |
Patrick Venture | 4934daa | 2020-09-22 16:37:44 -0700 | [diff] [blame] | 49 | std::vector<DataHandlerPack> data; |
| 50 | data.emplace_back(FirmwareFlags::UpdateFlags::ipmi, nullptr); |
Patrick Venture | 1626538 | 2019-11-06 19:31:36 -0800 | [diff] [blame] | 51 | |
| 52 | std::vector<HandlerPack> blobs; |
| 53 | blobs.push_back( |
| 54 | std::move(HandlerPack("asdf", std::make_unique<ImageHandlerMock>()))); |
| 55 | blobs.push_back(std::move( |
| 56 | HandlerPack(hashBlobId, std::make_unique<ImageHandlerMock>()))); |
| 57 | |
| 58 | ActionMap emptyMap; |
| 59 | |
| 60 | auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler( |
Patrick Venture | 7b78343 | 2020-09-22 15:55:08 -0700 | [diff] [blame] | 61 | std::move(blobs), std::move(data), std::move(emptyMap)); |
Patrick Venture | 1626538 | 2019-11-06 19:31:36 -0800 | [diff] [blame] | 62 | EXPECT_EQ(handler, nullptr); |
| 63 | } |
| 64 | TEST(FirmwareHandlerTest, FirmwareHandlerListRequiresAtLeastTwoEntries) |
| 65 | { |
| 66 | /* The hashblob handler must be one of the entries, but it cannot be the |
| 67 | * only entry. |
| 68 | */ |
Patrick Venture | 4934daa | 2020-09-22 16:37:44 -0700 | [diff] [blame] | 69 | std::vector<DataHandlerPack> data; |
| 70 | data.emplace_back(FirmwareFlags::UpdateFlags::ipmi, nullptr); |
Patrick Venture | 1626538 | 2019-11-06 19:31:36 -0800 | [diff] [blame] | 71 | |
| 72 | /* Provide a firmware list that has the hash blob, which is the required one |
| 73 | * -- tested in a different test. |
| 74 | */ |
| 75 | std::vector<HandlerPack> blobs; |
| 76 | blobs.push_back(std::move( |
| 77 | HandlerPack(hashBlobId, std::make_unique<ImageHandlerMock>()))); |
| 78 | |
| 79 | auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler( |
Patrick Venture | 7b78343 | 2020-09-22 15:55:08 -0700 | [diff] [blame] | 80 | std::move(blobs), std::move(data), std::move(CreateActionMap("asdf"))); |
Patrick Venture | 1626538 | 2019-11-06 19:31:36 -0800 | [diff] [blame] | 81 | EXPECT_EQ(handler, nullptr); |
| 82 | |
| 83 | /* Add second firmware and it'll now work. */ |
| 84 | std::vector<HandlerPack> blobs2; |
| 85 | blobs2.push_back(std::move( |
| 86 | HandlerPack(hashBlobId, std::make_unique<ImageHandlerMock>()))); |
| 87 | blobs2.push_back( |
| 88 | std::move(HandlerPack("asdf", std::make_unique<ImageHandlerMock>()))); |
| 89 | |
Patrick Venture | 4934daa | 2020-09-22 16:37:44 -0700 | [diff] [blame] | 90 | std::vector<DataHandlerPack> data2; |
| 91 | data2.emplace_back(FirmwareFlags::UpdateFlags::ipmi, nullptr); |
| 92 | |
Patrick Venture | 1626538 | 2019-11-06 19:31:36 -0800 | [diff] [blame] | 93 | handler = FirmwareBlobHandler::CreateFirmwareBlobHandler( |
Patrick Venture | 4934daa | 2020-09-22 16:37:44 -0700 | [diff] [blame] | 94 | std::move(blobs2), std::move(data2), |
| 95 | std::move(CreateActionMap("asdf"))); |
Patrick Venture | 1626538 | 2019-11-06 19:31:36 -0800 | [diff] [blame] | 96 | |
| 97 | auto result = handler->getBlobIds(); |
| 98 | std::vector<std::string> expectedBlobs = {"asdf", hashBlobId}; |
| 99 | EXPECT_THAT(result, UnorderedElementsAreArray(expectedBlobs)); |
| 100 | } |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 101 | TEST(FirmwareHandlerTest, VerifyHashRequiredForHappiness) |
Patrick Venture | 5285462 | 2018-11-06 12:30:00 -0800 | [diff] [blame] | 102 | { |
Patrick Venture | 4934daa | 2020-09-22 16:37:44 -0700 | [diff] [blame] | 103 | std::vector<DataHandlerPack> data; |
| 104 | data.emplace_back(FirmwareFlags::UpdateFlags::ipmi, nullptr); |
Patrick Venture | a78e39f | 2018-11-06 18:37:06 -0800 | [diff] [blame] | 105 | |
Patrick Venture | d4e20de | 2019-07-18 12:48:05 -0700 | [diff] [blame] | 106 | /* This works fine only if you also pass in the hash handler. */ |
| 107 | std::vector<HandlerPack> blobs; |
| 108 | blobs.push_back( |
| 109 | std::move(HandlerPack("asdf", std::make_unique<ImageHandlerMock>()))); |
| 110 | |
Patrick Venture | 4eb5595 | 2018-11-16 15:36:24 -0800 | [diff] [blame] | 111 | auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler( |
Patrick Venture | 7b78343 | 2020-09-22 15:55:08 -0700 | [diff] [blame] | 112 | std::move(blobs), std::move(data), std::move(CreateActionMap("asdf"))); |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 113 | EXPECT_EQ(handler, nullptr); |
| 114 | |
Patrick Venture | d4e20de | 2019-07-18 12:48:05 -0700 | [diff] [blame] | 115 | std::vector<HandlerPack> blobs2; |
| 116 | blobs2.push_back( |
| 117 | std::move(HandlerPack("asdf", std::make_unique<ImageHandlerMock>()))); |
| 118 | blobs2.push_back(std::move( |
| 119 | HandlerPack(hashBlobId, std::make_unique<ImageHandlerMock>()))); |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 120 | |
Patrick Venture | 4934daa | 2020-09-22 16:37:44 -0700 | [diff] [blame] | 121 | std::vector<DataHandlerPack> data2; |
| 122 | data2.emplace_back(FirmwareFlags::UpdateFlags::ipmi, nullptr); |
| 123 | |
Patrick Venture | 4eb5595 | 2018-11-16 15:36:24 -0800 | [diff] [blame] | 124 | handler = FirmwareBlobHandler::CreateFirmwareBlobHandler( |
Patrick Venture | 4934daa | 2020-09-22 16:37:44 -0700 | [diff] [blame] | 125 | std::move(blobs2), std::move(data2), |
| 126 | std::move(CreateActionMap("asdf"))); |
Patrick Venture | fa06a5f | 2019-07-01 09:22:38 -0700 | [diff] [blame] | 127 | |
Patrick Venture | 21be45a | 2018-11-06 12:08:52 -0800 | [diff] [blame] | 128 | auto result = handler->getBlobIds(); |
Patrick Venture | 930c7b7 | 2019-05-24 11:11:08 -0700 | [diff] [blame] | 129 | std::vector<std::string> expectedBlobs = {"asdf", hashBlobId}; |
| 130 | EXPECT_THAT(result, UnorderedElementsAreArray(expectedBlobs)); |
Patrick Venture | 21be45a | 2018-11-06 12:08:52 -0800 | [diff] [blame] | 131 | } |
Patrick Venture | 930c7b7 | 2019-05-24 11:11:08 -0700 | [diff] [blame] | 132 | |
| 133 | } // namespace |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 134 | } // namespace ipmi_flash |