Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-networkd / a3b14dcea243ec2480e88f6e8864dee010a0fcbc
commita3b14dcea243ec2480e88f6e8864dee010a0fcbc[log] [tgz]
authorLei YU <yulei.sh@bytedance.com>Tue Apr 06 11:42:10 2021 +0800
committerLei YU <yulei.sh@bytedance.com>Tue Apr 06 11:42:10 2021 +0800
tree8dbf28c9c869582abc689a3c27be2f131606c1ad
parent359623e2af84d63b4d37e15a14427f42781146ac [diff]
Fix __builtin_ctz related bug

The previous commit introduces an issue related to __builtin_ctz().

The GCC doc:

 Returns the number of trailing 0-bits in x, starting at the least
 significant bit position. If x is 0, the result is undefined.

The behavier of __builtin_ctz() differs on x86-64 and arm, where the
x86-64 toolchain returns 32 for __builtin_ctz(0), while arm toolchain
returns -1 in such case.

So the issue could not be found by the unit test running on x86-64
system, but is caught when it's running on the real BMC which is ARM.

Tested: Verify the IPv6 netmask settings are correctly parsed on BMC.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I1e803c94fe1adc9c37d4ce3e41108756963d100a
2 files changed
tree: 8dbf28c9c869582abc689a3c27be2f131606c1ad
  1. docs/
  2. test/
  3. xyz/
  4. .clang-format
  5. .gitignore
  6. argument.cpp
  7. argument.hpp
  8. bootstrap.sh
  9. config_parser.cpp
  10. config_parser.hpp
  11. configure.ac
  12. dhcp_configuration.cpp
  13. dhcp_configuration.hpp
  14. dns_updater.cpp
  15. dns_updater.hpp
  16. ethernet_interface.cpp
  17. ethernet_interface.hpp
  18. ipaddress.cpp
  19. ipaddress.hpp
  20. LICENSE
  21. MAINTAINERS
  22. Makefile.am
  23. ncsi_netlink_main.cpp
  24. ncsi_util.cpp
  25. ncsi_util.hpp
  26. neighbor.cpp
  27. neighbor.hpp
  28. netlink.cpp
  29. netlink.hpp
  30. network_config.cpp
  31. network_config.hpp
  32. network_manager.cpp
  33. network_manager.hpp
  34. network_manager_main.cpp
  35. README.md
  36. routing_table.cpp
  37. routing_table.hpp
  38. rtnetlink_server.cpp
  39. rtnetlink_server.hpp
  40. system_configuration.cpp
  41. system_configuration.hpp
  42. types.hpp
  43. util.cpp
  44. util.hpp
  45. vlan_interface.cpp
  46. vlan_interface.hpp
  47. watch.cpp
  48. watch.hpp
  49. xyz.openbmc_project.Network.conf.in
  50. xyz.openbmc_project.Network.service.in
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.