commit 75057c875743c4ad9989e124b0165e663894ebb3
author Brad Bishop <bradleyb@fuzziesquirrel.com> Tue Aug 03 15:22:02 2021 -0400
committer Brad Bishop <bradleyb@fuzziesquirrel.com> Tue Aug 03 16:03:42 2021 -0400
tree 8a3fabc3673b9d6915e2e6a717214ccb9670d26b
parent bdaa7f8bb4b34ec4d5f806135364e3ffcc427c0e

libmapper: hide symbols by default

Hide symbols unless explicitly un-hidden.  This facilitates putting unit
tests in different translation units by enabling non static declarations
yet still preventing their use by other applications.

Change-Id: Ia85babcae5ec705bf6227bdfc1da438ba9ad587d
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

Makefile.am

diff --git a/Makefile.am b/Makefile.am
index 48b9268..f9a608d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -27,7 +27,7 @@
 libmapper_LTLIBRARIES = libmapper.la
 libmapper_la_SOURCES = libmapper/mapper.c
 libmapper_la_LDFLAGS = $(SYSTEMD_LIBS) -version-info 1:0:0 -shared
-libmapper_la_CFLAGS = $(SYSTEMD_CFLAGS)
+libmapper_la_CFLAGS = $(SYSTEMD_CFLAGS) -fvisibility=hidden
 
 mapperx_SOURCES = src/main.cpp src/argument.cpp src/processing.cpp \
 	src/associations.cpp

libmapper/mapper.c

diff --git a/libmapper/mapper.c b/libmapper/mapper.c
index 4b69ac2..fb07940 100644
--- a/libmapper/mapper.c
+++ b/libmapper/mapper.c
@@ -27,6 +27,8 @@
 #include <systemd/sd-event.h>
 #include <unistd.h>
 
+#define _public_ __attribute__((__visibility__("default")))
+
 static const char* async_wait_introspection_match =
     "type='signal',"
     "sender='xyz.openbmc_project.ObjectMapper',"
@@ -300,16 +302,16 @@
     return 1;
 }
 
-void mapper_wait_async_free(mapper_async_wait* w)
+_public_ void mapper_wait_async_free(mapper_async_wait* w)
 {
     free(w->status);
     sarrayfree(w->objs);
     free(w);
 }
 
-int mapper_wait_async(sd_bus* conn, sd_event* loop, char* objs[],
-                      void (*callback)(int, void*), void* userdata,
-                      mapper_async_wait** w)
+_public_ int mapper_wait_async(sd_bus* conn, sd_event* loop, char* objs[],
+                               void (*callback)(int, void*), void* userdata,
+                               mapper_async_wait** w)
 {
     int r;
     mapper_async_wait* wait = NULL;
@@ -526,9 +528,10 @@
         t->callback(r, t->userdata);
 }
 
-int mapper_subtree_async(sd_bus* conn, sd_event* loop, char* namespace,
-                         char* interface, void (*callback)(int, void*),
-                         void* userdata, mapper_async_subtree** t, int op)
+_public_ int mapper_subtree_async(sd_bus* conn, sd_event* loop, char* namespace,
+                                  char* interface, void (*callback)(int, void*),
+                                  void* userdata, mapper_async_subtree** t,
+                                  int op)
 {
     int r = 0;
     mapper_async_subtree* subtree = NULL;
@@ -582,7 +585,8 @@
     return r;
 }
 
-int mapper_get_object(sd_bus* conn, const char* obj, sd_bus_message** reply)
+_public_ int mapper_get_object(sd_bus* conn, const char* obj,
+                               sd_bus_message** reply)
 {
     sd_bus_message* request = NULL;
     int r, retry = 0;
@@ -624,7 +628,7 @@
     return r;
 }
 
-int mapper_get_service(sd_bus* conn, const char* obj, char** service)
+_public_ int mapper_get_service(sd_bus* conn, const char* obj, char** service)
 {
     sd_bus_message* reply = NULL;
     const char* tmp;