commit 566a1518dab2cc17c180de23cc0d252fc1e87f95
author Patrick Venture <venture@google.com> Tue Jun 12 14:51:07 2018 -0700
committer Patrick Venture <venture@google.com> Fri Jun 22 08:24:49 2018 -0700
tree b634b91920df71792249f60cbe5dca41f9e61a46
parent 3349ef20ba710e6c971c3e067cca9a0bd276a88d

test: pid: fancontroller

Adds unit-tests for the fancontroller.
Bugfix: set point not initialized to 0, although bug has no impact.
Tested: Ran on quanta-q71l board and it behaved as expected.

Change-Id: I516833d8c9ed806b765ff9333801f3d57932a17b
Signed-off-by: Patrick Venture <venture@google.com>

pid/fancontroller.cpp

diff --git a/pid/fancontroller.cpp b/pid/fancontroller.cpp
index c2dee74..9407689 100644
--- a/pid/fancontroller.cpp
+++ b/pid/fancontroller.cpp
@@ -27,6 +27,10 @@
     std::vector<std::string>& inputs,
     ec::pidinfo initial)
 {
+    if (inputs.size() == 0)
+    {
+        return nullptr;
+    }
     auto fan = std::make_unique<FanController>(id, inputs, owner);
     ec::pid_info_t* info = fan->get_pid_info();
 
@@ -68,6 +72,8 @@
         throw;
     }
 
+    /* Reset the value from the above loop. */
+    value = 0;
     if (values.size() > 0)
     {
         /* When this is a configuration option in a later update, this code