phosphor-power-supply/test/power_supply_tests.cpp - openbmc/phosphor-power - Gitiles

 #include "../power_supply.hpp"
 #include "mock.hpp"

 #include <xyz/openbmc_project/Common/Device/error.hpp>
 #include <xyz/openbmc_project/Common/error.hpp>

 #include <gmock/gmock.h>
 #include <gtest/gtest.h>

 using namespace phosphor::power::psu;
 using namespace phosphor::pmbus;

 using ::testing::_;
 using ::testing::Args;
 using ::testing::Assign;
 using ::testing::DoAll;
 using ::testing::ElementsAre;
 using ::testing::NotNull;
 using ::testing::Return;
 using ::testing::StrEq;

 static auto PSUInventoryPath = "/xyz/bmc/inv/sys/chassis/board/powersupply0";
 static auto PSUGPIOLineName = "presence-ps0";

 class PowerSupplyTests : public ::testing::Test
 {
   public:
     PowerSupplyTests() :
         mockedUtil(reinterpret_cast<const MockedUtil&>(getUtils()))
     {
         ON_CALL(mockedUtil, getPresence(_, _)).WillByDefault(Return(false));
     }

     ~PowerSupplyTests() override
     {
         freeUtils();
     }

     const MockedUtil& mockedUtil;
 };

 TEST_F(PowerSupplyTests, Constructor)
 {
     /**
      * @param[in] invpath - String for inventory path to use
      * @param[in] i2cbus - The bus number this power supply is on
      * @param[in] i2caddr - The 16-bit I2C address of the power supply
      * @param[in] gpioLineName - The string for the gpio-line-name to read for
      * presence.
      * @param[in] bindDelay - Time in milliseconds to delay binding the device
      * driver after seeing the presence line go active.
      */
     auto bus = sdbusplus::bus::new_default();

     // Try where inventory path is empty, constructor should fail.
     try
     {
         auto psu =
             std::make_unique<PowerSupply>(bus, "", 3, 0x68, PSUGPIOLineName);
         ADD_FAILURE() << "Should not have reached this line.";
     }
     catch (const std::invalid_argument& e)
     {
         EXPECT_STREQ(e.what(), "Invalid empty inventoryPath");
     }
     catch (...)
     {
         ADD_FAILURE() << "Should not have caught exception.";
     }

     // TODO: Try invalid i2c address?

     // Try where gpioLineName is empty.
     try
     {
         auto psu =
             std::make_unique<PowerSupply>(bus, PSUInventoryPath, 3, 0x68, "");
         ADD_FAILURE()
             << "Should not have reached this line. Invalid gpioLineName.";
     }
     catch (const std::invalid_argument& e)
     {
         EXPECT_STREQ(e.what(), "Invalid empty gpioLineName");
     }
     catch (...)
     {
         ADD_FAILURE() << "Should not have caught exception.";
     }

     // Test with valid arguments
     // NOT using D-Bus inventory path for presence.
     try
     {
         auto psu = std::make_unique<PowerSupply>(bus, PSUInventoryPath, 3, 0x68,
                                                  PSUGPIOLineName);

         EXPECT_EQ(psu->isPresent(), false);
         EXPECT_EQ(psu->isFaulted(), false);
         EXPECT_EQ(psu->hasInputFault(), false);
         EXPECT_EQ(psu->hasMFRFault(), false);
         EXPECT_EQ(psu->hasVINUVFault(), false);
     }
     catch (...)
     {
         ADD_FAILURE() << "Should not have caught exception.";
     }

     // Test with valid arguments
     // TODO: Using D-Bus inventory path for presence.
     try
     {
         // FIXME: How do I get that presenceGPIO.read() in the startup to throw
         // an exception?

         // EXPECT_CALL(mockedUtil, getPresence(_,
         // StrEq(PSUInventoryPath)))
         //    .Times(1);
     }
     catch (...)
     {
         ADD_FAILURE() << "Should not have caught exception.";
     }
 }

 TEST_F(PowerSupplyTests, Analyze)
 {
     auto bus = sdbusplus::bus::new_default();

     // If I default to reading the GPIO, I will NOT expect a call to
     // getPresence().

     PowerSupply psu{bus, PSUInventoryPath, 4, 0x69, PSUGPIOLineName};
     MockedGPIOReader* mockPresenceGPIO =
         static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
     EXPECT_CALL(*mockPresenceGPIO, read()).Times(1).WillOnce(Return(0));

     psu.analyze();
     // By default, nothing should change.
     EXPECT_EQ(psu.isPresent(), false);
     EXPECT_EQ(psu.isFaulted(), false);
     EXPECT_EQ(psu.hasInputFault(), false);
     EXPECT_EQ(psu.hasMFRFault(), false);
     EXPECT_EQ(psu.hasVINUVFault(), false);

     PowerSupply psu2{bus, PSUInventoryPath, 5, 0x6a, PSUGPIOLineName};
     // In order to get the various faults tested, the power supply needs to
     // be present in order to read from the PMBus device(s).
     MockedGPIOReader* mockPresenceGPIO2 =
         static_cast<MockedGPIOReader*>(psu2.getPresenceGPIO());
     ON_CALL(*mockPresenceGPIO2, read()).WillByDefault(Return(1));

     EXPECT_EQ(psu2.isPresent(), false);

     // STATUS_WORD 0x0000 is powered on, no faults.
     // It will read STATUS_MFR at the same time, so there are 2 reads.
     MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu2.getPMBus());
     EXPECT_CALL(mockPMBus, read(_, _)).Times(2).WillRepeatedly(Return(0x0000));
     psu2.analyze();
     EXPECT_EQ(psu2.isPresent(), true);
     EXPECT_EQ(psu2.isFaulted(), false);
     EXPECT_EQ(psu2.hasInputFault(), false);
     EXPECT_EQ(psu2.hasMFRFault(), false);
     EXPECT_EQ(psu2.hasVINUVFault(), false);

     // STATUS_WORD input fault/warn
     EXPECT_CALL(mockPMBus, read(_, _))
         .Times(2)
         .WillOnce(Return(status_word::INPUT_FAULT_WARN))
         .WillOnce(Return(0x0000));
     psu2.analyze();
     EXPECT_EQ(psu2.isPresent(), true);
     EXPECT_EQ(psu2.isFaulted(), true);
     EXPECT_EQ(psu2.hasInputFault(), true);
     EXPECT_EQ(psu2.hasMFRFault(), false);
     EXPECT_EQ(psu2.hasVINUVFault(), false);

     // STATUS_WORD INPUT/UV fault.
     // First need it to return good status, then the fault
     EXPECT_CALL(mockPMBus, read(_, _))
         .WillOnce(Return(0x0000))
         .WillOnce(Return(status_word::VIN_UV_FAULT))
         .WillOnce(Return(0x0000));
     psu2.analyze();
     psu2.analyze();
     EXPECT_EQ(psu2.isPresent(), true);
     EXPECT_EQ(psu2.isFaulted(), true);
     EXPECT_EQ(psu2.hasInputFault(), false);
     EXPECT_EQ(psu2.hasMFRFault(), false);
     EXPECT_EQ(psu2.hasVINUVFault(), true);

     // STATUS_WORD MFR fault.
     EXPECT_CALL(mockPMBus, read(_, _))
         .WillOnce(Return(0x0000))
         .WillOnce(Return(status_word::MFR_SPECIFIC_FAULT))
         .WillOnce(Return(1)); // mock return for read(STATUS_MFR... )
     psu2.analyze();
     psu2.analyze();
     EXPECT_EQ(psu2.isPresent(), true);
     EXPECT_EQ(psu2.isFaulted(), true);
     EXPECT_EQ(psu2.hasInputFault(), false);
     EXPECT_EQ(psu2.hasMFRFault(), true);
     EXPECT_EQ(psu2.hasVINUVFault(), false);

     // Ignore Temperature fault.
     EXPECT_CALL(mockPMBus, read(_, _))
         .WillOnce(Return(0x0000))
         .WillOnce(Return(status_word::TEMPERATURE_FAULT_WARN))
         .WillOnce(Return(0x0000));
     psu2.analyze();
     psu2.analyze();
     EXPECT_EQ(psu2.isPresent(), true);
     EXPECT_EQ(psu2.isFaulted(), false);
     EXPECT_EQ(psu2.hasInputFault(), false);
     EXPECT_EQ(psu2.hasMFRFault(), false);
     EXPECT_EQ(psu2.hasVINUVFault(), false);

     // Ignore fan fault
     EXPECT_CALL(mockPMBus, read(_, _))
         .WillOnce(Return(0x0000))
         .WillOnce(Return(status_word::FAN_FAULT))
         .WillOnce(Return(0x0000));
     psu2.analyze();
     psu2.analyze();
     EXPECT_EQ(psu2.isPresent(), true);
     EXPECT_EQ(psu2.isFaulted(), false);
     EXPECT_EQ(psu2.hasInputFault(), false);
     EXPECT_EQ(psu2.hasMFRFault(), false);
     EXPECT_EQ(psu2.hasVINUVFault(), false);

     // TODO: ReadFailure
 }

 TEST_F(PowerSupplyTests, OnOffConfig)
 {
     auto bus = sdbusplus::bus::new_default();
     uint8_t data = 0x15;

     // Test where PSU is NOT present
     try
     {
         // Assume GPIO presence, not inventory presence?
         PowerSupply psu{bus, PSUInventoryPath, 4, 0x69, PSUGPIOLineName};

         MockedGPIOReader* mockPresenceGPIO =
             static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
         ON_CALL(*mockPresenceGPIO, read()).WillByDefault(Return(0));
         MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
         // Constructor should set initial presence, default read returns 0.
         // If it is not present, I should not be trying to write to it.
         EXPECT_CALL(mockPMBus, writeBinary(_, _, _)).Times(0);
         psu.onOffConfig(data);
     }
     catch (...)
     {}

     // Test where PSU is present
     try
     {
         // Assume GPIO presence, not inventory presence?
         PowerSupply psu{bus, PSUInventoryPath, 5, 0x6a, PSUGPIOLineName};
         MockedGPIOReader* mockPresenceGPIO =
             static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
         ON_CALL(*mockPresenceGPIO, read()).WillByDefault(Return(1));
         MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
         // TODO: expect setPresence call?
         // updatePresence() private function reads gpio, called by analyze().
         psu.analyze();
         // TODO: ???should I check the filename?
         EXPECT_CALL(mockPMBus,
                     writeBinary(_, ElementsAre(0x15), Type::HwmonDeviceDebug))
             .Times(1);
         psu.onOffConfig(data);
     }
     catch (...)
     {}
 }

 TEST_F(PowerSupplyTests, ClearFaults)
 {
     auto bus = sdbusplus::bus::new_default();
     PowerSupply psu{bus, PSUInventoryPath, 13, 0x68, PSUGPIOLineName};
     MockedGPIOReader* mockPresenceGPIO =
         static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
     // GPIO read return 1 to indicate present.
     ON_CALL(*mockPresenceGPIO, read()).WillByDefault(Return(1));
     MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
     ON_CALL(mockPMBus, read(_, _)).WillByDefault(Return(0));
     psu.analyze();
     EXPECT_EQ(psu.isPresent(), true);
     EXPECT_EQ(psu.isFaulted(), false);
     EXPECT_EQ(psu.hasInputFault(), false);
     EXPECT_EQ(psu.hasMFRFault(), false);
     EXPECT_EQ(psu.hasVINUVFault(), false);
     EXPECT_CALL(mockPMBus, read(_, _))
         .Times(2)
         .WillOnce(Return(0xFFFF))
         .WillOnce(Return(1)); // mock return for read(STATUS_MFR... )
     psu.analyze();
     EXPECT_EQ(psu.isPresent(), true);
     EXPECT_EQ(psu.isFaulted(), true);
     EXPECT_EQ(psu.hasInputFault(), true);
     EXPECT_EQ(psu.hasMFRFault(), true);
     EXPECT_EQ(psu.hasVINUVFault(), true);
     EXPECT_CALL(mockPMBus, read("in1_input", _))
         .Times(1)
         .WillOnce(Return(209000));
     psu.clearFaults();
     EXPECT_EQ(psu.isPresent(), true);
     EXPECT_EQ(psu.isFaulted(), false);
     EXPECT_EQ(psu.hasInputFault(), false);
     EXPECT_EQ(psu.hasMFRFault(), false);
     EXPECT_EQ(psu.hasVINUVFault(), false);

     // TODO: Faults clear on missing/present?
 }

 TEST_F(PowerSupplyTests, UpdateInventory)
 {
     auto bus = sdbusplus::bus::new_default();

     try
     {
         PowerSupply psu{bus, PSUInventoryPath, 3, 0x68, PSUGPIOLineName};
         MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
         // If it is not present, I should not be trying to read a string
         EXPECT_CALL(mockPMBus, readString(_, _)).Times(0);
         psu.updateInventory();
     }
     catch (...)
     {
         ADD_FAILURE() << "Should not have caught exception.";
     }

     try
     {
         PowerSupply psu{bus, PSUInventoryPath, 13, 0x69, PSUGPIOLineName};
         MockedGPIOReader* mockPresenceGPIO =
             static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
         // GPIO read return 1 to indicate present.
         EXPECT_CALL(*mockPresenceGPIO, read()).Times(1).WillOnce(Return(1));
         psu.analyze();
         MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
         EXPECT_CALL(mockPMBus, readString(_, _)).WillRepeatedly(Return(""));
         psu.updateInventory();

 #if IBM_VPD
         EXPECT_CALL(mockPMBus, readString(_, _))
             .WillOnce(Return("CCIN"))
             .WillOnce(Return("PN3456"))
             .WillOnce(Return("FN3456"))
             .WillOnce(Return("HEADER"))
             .WillOnce(Return("SN3456"))
             .WillOnce(Return("FW3456"));
 #endif
         psu.updateInventory();
         // TODO: D-Bus mocking to verify values stored on D-Bus (???)
     }
     catch (...)
     {
         ADD_FAILURE() << "Should not have caught exception.";
     }
 }

 TEST_F(PowerSupplyTests, IsPresent)
 {
     auto bus = sdbusplus::bus::new_default();

     PowerSupply psu{bus, PSUInventoryPath, 3, 0x68, PSUGPIOLineName};
     MockedGPIOReader* mockPresenceGPIO =
         static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
     EXPECT_EQ(psu.isPresent(), false);

     // Change GPIO read to return 1 to indicate present.
     EXPECT_CALL(*mockPresenceGPIO, read()).Times(1).WillOnce(Return(1));
     psu.analyze();
     EXPECT_EQ(psu.isPresent(), true);
 }

 TEST_F(PowerSupplyTests, IsFaulted)
 {
     auto bus = sdbusplus::bus::new_default();

     PowerSupply psu{bus, PSUInventoryPath, 11, 0x6f, PSUGPIOLineName};
     MockedGPIOReader* mockPresenceGPIO =
         static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
     // Always return 1 to indicate present.
     EXPECT_CALL(*mockPresenceGPIO, read()).WillRepeatedly(Return(1));
     psu.analyze();
     EXPECT_EQ(psu.isFaulted(), false);
     MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
     EXPECT_CALL(mockPMBus, read(_, _))
         .Times(2)
         .WillOnce(Return(0xFFFF))
         .WillOnce(Return(1)); // mock return for read(STATUS_MFR... )
     psu.analyze();
     EXPECT_EQ(psu.isFaulted(), true);
 }

 TEST_F(PowerSupplyTests, HasInputFault)
 {
     auto bus = sdbusplus::bus::new_default();

     PowerSupply psu{bus, PSUInventoryPath, 3, 0x68, PSUGPIOLineName};
     MockedGPIOReader* mockPresenceGPIO =
         static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
     // Always return 1 to indicate present.
     EXPECT_CALL(*mockPresenceGPIO, read()).WillRepeatedly(Return(1));
     psu.analyze();
     MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
     EXPECT_EQ(psu.hasInputFault(), false);
     EXPECT_CALL(mockPMBus, read(_, _)).Times(1).WillOnce(Return(0x0000));
     psu.analyze();
     EXPECT_EQ(psu.hasInputFault(), false);
     EXPECT_CALL(mockPMBus, read(_, _))
         .Times(2)
         .WillOnce(Return(status_word::INPUT_FAULT_WARN))
         .WillOnce(Return(0));
     psu.analyze();
     EXPECT_EQ(psu.hasInputFault(), true);
     EXPECT_CALL(mockPMBus, read(_, _)).Times(1).WillOnce(Return(0x0000));
     psu.analyze();
     EXPECT_EQ(psu.hasInputFault(), false);
 }

 TEST_F(PowerSupplyTests, HasMFRFault)
 {
     auto bus = sdbusplus::bus::new_default();

     PowerSupply psu{bus, PSUInventoryPath, 3, 0x68, PSUGPIOLineName};
     MockedGPIOReader* mockPresenceGPIO =
         static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
     // Always return 1 to indicate present.
     EXPECT_CALL(*mockPresenceGPIO, read()).WillRepeatedly(Return(1));
     psu.analyze();
     MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
     EXPECT_EQ(psu.hasMFRFault(), false);
     EXPECT_CALL(mockPMBus, read(_, _)).Times(1).WillOnce(Return(0x0000));
     psu.analyze();
     EXPECT_EQ(psu.hasMFRFault(), false);
     EXPECT_CALL(mockPMBus, read(_, _))
         .Times(2)
         .WillOnce(Return(status_word::MFR_SPECIFIC_FAULT))
         .WillOnce(Return(1)); // mock return for read(STATUS_MFR... )
     psu.analyze();
     EXPECT_EQ(psu.hasMFRFault(), true);
     EXPECT_CALL(mockPMBus, read(_, _)).Times(1).WillOnce(Return(0x0000));
     psu.analyze();
     EXPECT_EQ(psu.hasMFRFault(), false);
 }

 TEST_F(PowerSupplyTests, HasVINUVFault)
 {
     auto bus = sdbusplus::bus::new_default();

     PowerSupply psu{bus, PSUInventoryPath, 3, 0x68, PSUGPIOLineName};
     MockedGPIOReader* mockPresenceGPIO =
         static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
     // Always return 1 to indicate present.
     EXPECT_CALL(*mockPresenceGPIO, read()).WillRepeatedly(Return(1));
     psu.analyze();
     MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
     EXPECT_EQ(psu.hasVINUVFault(), false);
     EXPECT_CALL(mockPMBus, read(_, _)).Times(1).WillOnce(Return(0x0000));
     psu.analyze();
     EXPECT_EQ(psu.hasVINUVFault(), false);
     EXPECT_CALL(mockPMBus, read(_, _))
         .Times(2)
         .WillOnce(Return(status_word::VIN_UV_FAULT))
         .WillOnce(Return(0));
     psu.analyze();
     EXPECT_EQ(psu.hasVINUVFault(), true);
     EXPECT_CALL(mockPMBus, read(_, _)).Times(1).WillOnce(Return(0x0000));
     psu.analyze();
     EXPECT_EQ(psu.hasVINUVFault(), false);
 }
	#include "../power_supply.hpp"
	#include "mock.hpp"

	#include <xyz/openbmc_project/Common/Device/error.hpp>
	#include <xyz/openbmc_project/Common/error.hpp>

	#include <gmock/gmock.h>
	#include <gtest/gtest.h>

	using namespace phosphor::power::psu;
	using namespace phosphor::pmbus;

	using ::testing::_;
	using ::testing::Args;
	using ::testing::Assign;
	using ::testing::DoAll;
	using ::testing::ElementsAre;
	using ::testing::NotNull;
	using ::testing::Return;
	using ::testing::StrEq;

	static auto PSUInventoryPath = "/xyz/bmc/inv/sys/chassis/board/powersupply0";
	static auto PSUGPIOLineName = "presence-ps0";

	class PowerSupplyTests : public ::testing::Test
	{
	public:
	PowerSupplyTests() :
	mockedUtil(reinterpret_cast<const MockedUtil&>(getUtils()))
	{
	ON_CALL(mockedUtil, getPresence(_, _)).WillByDefault(Return(false));
	}

	~PowerSupplyTests() override
	{
	freeUtils();
	}

	const MockedUtil& mockedUtil;
	};

	TEST_F(PowerSupplyTests, Constructor)
	{
	/**
	* @param[in] invpath - String for inventory path to use
	* @param[in] i2cbus - The bus number this power supply is on
	* @param[in] i2caddr - The 16-bit I2C address of the power supply
	* @param[in] gpioLineName - The string for the gpio-line-name to read for
	* presence.
	* @param[in] bindDelay - Time in milliseconds to delay binding the device
	* driver after seeing the presence line go active.
	*/
	auto bus = sdbusplus::bus::new_default();

	// Try where inventory path is empty, constructor should fail.
	try
	{
	auto psu =
	std::make_unique<PowerSupply>(bus, "", 3, 0x68, PSUGPIOLineName);
	ADD_FAILURE() << "Should not have reached this line.";
	}
	catch (const std::invalid_argument& e)
	{
	EXPECT_STREQ(e.what(), "Invalid empty inventoryPath");
	}
	catch (...)
	{
	ADD_FAILURE() << "Should not have caught exception.";
	}

	// TODO: Try invalid i2c address?

	// Try where gpioLineName is empty.
	try
	{
	auto psu =
	std::make_unique<PowerSupply>(bus, PSUInventoryPath, 3, 0x68, "");
	ADD_FAILURE()
	<< "Should not have reached this line. Invalid gpioLineName.";
	}
	catch (const std::invalid_argument& e)
	{
	EXPECT_STREQ(e.what(), "Invalid empty gpioLineName");
	}
	catch (...)
	{
	ADD_FAILURE() << "Should not have caught exception.";
	}

	// Test with valid arguments
	// NOT using D-Bus inventory path for presence.
	try
	{
	auto psu = std::make_unique<PowerSupply>(bus, PSUInventoryPath, 3, 0x68,
	PSUGPIOLineName);

	EXPECT_EQ(psu->isPresent(), false);
	EXPECT_EQ(psu->isFaulted(), false);
	EXPECT_EQ(psu->hasInputFault(), false);
	EXPECT_EQ(psu->hasMFRFault(), false);
	EXPECT_EQ(psu->hasVINUVFault(), false);
	}
	catch (...)
	{
	ADD_FAILURE() << "Should not have caught exception.";
	}

	// Test with valid arguments
	// TODO: Using D-Bus inventory path for presence.
	try
	{
	// FIXME: How do I get that presenceGPIO.read() in the startup to throw
	// an exception?

	// EXPECT_CALL(mockedUtil, getPresence(_,
	// StrEq(PSUInventoryPath)))
	// .Times(1);
	}
	catch (...)
	{
	ADD_FAILURE() << "Should not have caught exception.";
	}
	}

	TEST_F(PowerSupplyTests, Analyze)
	{
	auto bus = sdbusplus::bus::new_default();

	// If I default to reading the GPIO, I will NOT expect a call to
	// getPresence().

	PowerSupply psu{bus, PSUInventoryPath, 4, 0x69, PSUGPIOLineName};
	MockedGPIOReader* mockPresenceGPIO =
	static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
	EXPECT_CALL(*mockPresenceGPIO, read()).Times(1).WillOnce(Return(0));

	psu.analyze();
	// By default, nothing should change.
	EXPECT_EQ(psu.isPresent(), false);
	EXPECT_EQ(psu.isFaulted(), false);
	EXPECT_EQ(psu.hasInputFault(), false);
	EXPECT_EQ(psu.hasMFRFault(), false);
	EXPECT_EQ(psu.hasVINUVFault(), false);

	PowerSupply psu2{bus, PSUInventoryPath, 5, 0x6a, PSUGPIOLineName};
	// In order to get the various faults tested, the power supply needs to
	// be present in order to read from the PMBus device(s).
	MockedGPIOReader* mockPresenceGPIO2 =
	static_cast<MockedGPIOReader*>(psu2.getPresenceGPIO());
	ON_CALL(*mockPresenceGPIO2, read()).WillByDefault(Return(1));

	EXPECT_EQ(psu2.isPresent(), false);

	// STATUS_WORD 0x0000 is powered on, no faults.
	// It will read STATUS_MFR at the same time, so there are 2 reads.
	MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu2.getPMBus());
	EXPECT_CALL(mockPMBus, read(_, _)).Times(2).WillRepeatedly(Return(0x0000));
	psu2.analyze();
	EXPECT_EQ(psu2.isPresent(), true);
	EXPECT_EQ(psu2.isFaulted(), false);
	EXPECT_EQ(psu2.hasInputFault(), false);
	EXPECT_EQ(psu2.hasMFRFault(), false);
	EXPECT_EQ(psu2.hasVINUVFault(), false);

	// STATUS_WORD input fault/warn
	EXPECT_CALL(mockPMBus, read(_, _))
	.Times(2)
	.WillOnce(Return(status_word::INPUT_FAULT_WARN))
	.WillOnce(Return(0x0000));
	psu2.analyze();
	EXPECT_EQ(psu2.isPresent(), true);
	EXPECT_EQ(psu2.isFaulted(), true);
	EXPECT_EQ(psu2.hasInputFault(), true);
	EXPECT_EQ(psu2.hasMFRFault(), false);
	EXPECT_EQ(psu2.hasVINUVFault(), false);

	// STATUS_WORD INPUT/UV fault.
	// First need it to return good status, then the fault
	EXPECT_CALL(mockPMBus, read(_, _))
	.WillOnce(Return(0x0000))
	.WillOnce(Return(status_word::VIN_UV_FAULT))
	.WillOnce(Return(0x0000));
	psu2.analyze();
	psu2.analyze();
	EXPECT_EQ(psu2.isPresent(), true);
	EXPECT_EQ(psu2.isFaulted(), true);
	EXPECT_EQ(psu2.hasInputFault(), false);
	EXPECT_EQ(psu2.hasMFRFault(), false);
	EXPECT_EQ(psu2.hasVINUVFault(), true);

	// STATUS_WORD MFR fault.
	EXPECT_CALL(mockPMBus, read(_, _))
	.WillOnce(Return(0x0000))
	.WillOnce(Return(status_word::MFR_SPECIFIC_FAULT))
	.WillOnce(Return(1)); // mock return for read(STATUS_MFR... )
	psu2.analyze();
	psu2.analyze();
	EXPECT_EQ(psu2.isPresent(), true);
	EXPECT_EQ(psu2.isFaulted(), true);
	EXPECT_EQ(psu2.hasInputFault(), false);
	EXPECT_EQ(psu2.hasMFRFault(), true);
	EXPECT_EQ(psu2.hasVINUVFault(), false);

	// Ignore Temperature fault.
	EXPECT_CALL(mockPMBus, read(_, _))
	.WillOnce(Return(0x0000))
	.WillOnce(Return(status_word::TEMPERATURE_FAULT_WARN))
	.WillOnce(Return(0x0000));
	psu2.analyze();
	psu2.analyze();
	EXPECT_EQ(psu2.isPresent(), true);
	EXPECT_EQ(psu2.isFaulted(), false);
	EXPECT_EQ(psu2.hasInputFault(), false);
	EXPECT_EQ(psu2.hasMFRFault(), false);
	EXPECT_EQ(psu2.hasVINUVFault(), false);

	// Ignore fan fault
	EXPECT_CALL(mockPMBus, read(_, _))
	.WillOnce(Return(0x0000))
	.WillOnce(Return(status_word::FAN_FAULT))
	.WillOnce(Return(0x0000));
	psu2.analyze();
	psu2.analyze();
	EXPECT_EQ(psu2.isPresent(), true);
	EXPECT_EQ(psu2.isFaulted(), false);
	EXPECT_EQ(psu2.hasInputFault(), false);
	EXPECT_EQ(psu2.hasMFRFault(), false);
	EXPECT_EQ(psu2.hasVINUVFault(), false);

	// TODO: ReadFailure
	}

	TEST_F(PowerSupplyTests, OnOffConfig)
	{
	auto bus = sdbusplus::bus::new_default();
	uint8_t data = 0x15;

	// Test where PSU is NOT present
	try
	{
	// Assume GPIO presence, not inventory presence?
	PowerSupply psu{bus, PSUInventoryPath, 4, 0x69, PSUGPIOLineName};

	MockedGPIOReader* mockPresenceGPIO =
	static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
	ON_CALL(*mockPresenceGPIO, read()).WillByDefault(Return(0));
	MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
	// Constructor should set initial presence, default read returns 0.
	// If it is not present, I should not be trying to write to it.
	EXPECT_CALL(mockPMBus, writeBinary(_, _, _)).Times(0);
	psu.onOffConfig(data);
	}
	catch (...)
	{}

	// Test where PSU is present
	try
	{
	// Assume GPIO presence, not inventory presence?
	PowerSupply psu{bus, PSUInventoryPath, 5, 0x6a, PSUGPIOLineName};
	MockedGPIOReader* mockPresenceGPIO =
	static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
	ON_CALL(*mockPresenceGPIO, read()).WillByDefault(Return(1));
	MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
	// TODO: expect setPresence call?
	// updatePresence() private function reads gpio, called by analyze().
	psu.analyze();
	// TODO: ???should I check the filename?
	EXPECT_CALL(mockPMBus,
	writeBinary(_, ElementsAre(0x15), Type::HwmonDeviceDebug))
	.Times(1);
	psu.onOffConfig(data);
	}
	catch (...)
	{}
	}

	TEST_F(PowerSupplyTests, ClearFaults)
	{
	auto bus = sdbusplus::bus::new_default();
	PowerSupply psu{bus, PSUInventoryPath, 13, 0x68, PSUGPIOLineName};
	MockedGPIOReader* mockPresenceGPIO =
	static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
	// GPIO read return 1 to indicate present.
	ON_CALL(*mockPresenceGPIO, read()).WillByDefault(Return(1));
	MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
	ON_CALL(mockPMBus, read(_, _)).WillByDefault(Return(0));
	psu.analyze();
	EXPECT_EQ(psu.isPresent(), true);
	EXPECT_EQ(psu.isFaulted(), false);
	EXPECT_EQ(psu.hasInputFault(), false);
	EXPECT_EQ(psu.hasMFRFault(), false);
	EXPECT_EQ(psu.hasVINUVFault(), false);
	EXPECT_CALL(mockPMBus, read(_, _))
	.Times(2)
	.WillOnce(Return(0xFFFF))
	.WillOnce(Return(1)); // mock return for read(STATUS_MFR... )
	psu.analyze();
	EXPECT_EQ(psu.isPresent(), true);
	EXPECT_EQ(psu.isFaulted(), true);
	EXPECT_EQ(psu.hasInputFault(), true);
	EXPECT_EQ(psu.hasMFRFault(), true);
	EXPECT_EQ(psu.hasVINUVFault(), true);
	EXPECT_CALL(mockPMBus, read("in1_input", _))
	.Times(1)
	.WillOnce(Return(209000));
	psu.clearFaults();
	EXPECT_EQ(psu.isPresent(), true);
	EXPECT_EQ(psu.isFaulted(), false);
	EXPECT_EQ(psu.hasInputFault(), false);
	EXPECT_EQ(psu.hasMFRFault(), false);
	EXPECT_EQ(psu.hasVINUVFault(), false);

	// TODO: Faults clear on missing/present?
	}

	TEST_F(PowerSupplyTests, UpdateInventory)
	{
	auto bus = sdbusplus::bus::new_default();

	try
	{
	PowerSupply psu{bus, PSUInventoryPath, 3, 0x68, PSUGPIOLineName};
	MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
	// If it is not present, I should not be trying to read a string
	EXPECT_CALL(mockPMBus, readString(_, _)).Times(0);
	psu.updateInventory();
	}
	catch (...)
	{
	ADD_FAILURE() << "Should not have caught exception.";
	}

	try
	{
	PowerSupply psu{bus, PSUInventoryPath, 13, 0x69, PSUGPIOLineName};
	MockedGPIOReader* mockPresenceGPIO =
	static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
	// GPIO read return 1 to indicate present.
	EXPECT_CALL(*mockPresenceGPIO, read()).Times(1).WillOnce(Return(1));
	psu.analyze();
	MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
	EXPECT_CALL(mockPMBus, readString(_, _)).WillRepeatedly(Return(""));
	psu.updateInventory();

	#if IBM_VPD
	EXPECT_CALL(mockPMBus, readString(_, _))
	.WillOnce(Return("CCIN"))
	.WillOnce(Return("PN3456"))
	.WillOnce(Return("FN3456"))
	.WillOnce(Return("HEADER"))
	.WillOnce(Return("SN3456"))
	.WillOnce(Return("FW3456"));
	#endif
	psu.updateInventory();
	// TODO: D-Bus mocking to verify values stored on D-Bus (???)
	}
	catch (...)
	{
	ADD_FAILURE() << "Should not have caught exception.";
	}
	}

	TEST_F(PowerSupplyTests, IsPresent)
	{
	auto bus = sdbusplus::bus::new_default();

	PowerSupply psu{bus, PSUInventoryPath, 3, 0x68, PSUGPIOLineName};
	MockedGPIOReader* mockPresenceGPIO =
	static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
	EXPECT_EQ(psu.isPresent(), false);

	// Change GPIO read to return 1 to indicate present.
	EXPECT_CALL(*mockPresenceGPIO, read()).Times(1).WillOnce(Return(1));
	psu.analyze();
	EXPECT_EQ(psu.isPresent(), true);
	}

	TEST_F(PowerSupplyTests, IsFaulted)
	{
	auto bus = sdbusplus::bus::new_default();

	PowerSupply psu{bus, PSUInventoryPath, 11, 0x6f, PSUGPIOLineName};
	MockedGPIOReader* mockPresenceGPIO =
	static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
	// Always return 1 to indicate present.
	EXPECT_CALL(*mockPresenceGPIO, read()).WillRepeatedly(Return(1));
	psu.analyze();
	EXPECT_EQ(psu.isFaulted(), false);
	MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
	EXPECT_CALL(mockPMBus, read(_, _))
	.Times(2)
	.WillOnce(Return(0xFFFF))
	.WillOnce(Return(1)); // mock return for read(STATUS_MFR... )
	psu.analyze();
	EXPECT_EQ(psu.isFaulted(), true);
	}

	TEST_F(PowerSupplyTests, HasInputFault)
	{
	auto bus = sdbusplus::bus::new_default();

	PowerSupply psu{bus, PSUInventoryPath, 3, 0x68, PSUGPIOLineName};
	MockedGPIOReader* mockPresenceGPIO =
	static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
	// Always return 1 to indicate present.
	EXPECT_CALL(*mockPresenceGPIO, read()).WillRepeatedly(Return(1));
	psu.analyze();
	MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
	EXPECT_EQ(psu.hasInputFault(), false);
	EXPECT_CALL(mockPMBus, read(_, _)).Times(1).WillOnce(Return(0x0000));
	psu.analyze();
	EXPECT_EQ(psu.hasInputFault(), false);
	EXPECT_CALL(mockPMBus, read(_, _))
	.Times(2)
	.WillOnce(Return(status_word::INPUT_FAULT_WARN))
	.WillOnce(Return(0));
	psu.analyze();
	EXPECT_EQ(psu.hasInputFault(), true);
	EXPECT_CALL(mockPMBus, read(_, _)).Times(1).WillOnce(Return(0x0000));
	psu.analyze();
	EXPECT_EQ(psu.hasInputFault(), false);
	}

	TEST_F(PowerSupplyTests, HasMFRFault)
	{
	auto bus = sdbusplus::bus::new_default();

	PowerSupply psu{bus, PSUInventoryPath, 3, 0x68, PSUGPIOLineName};
	MockedGPIOReader* mockPresenceGPIO =
	static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
	// Always return 1 to indicate present.
	EXPECT_CALL(*mockPresenceGPIO, read()).WillRepeatedly(Return(1));
	psu.analyze();
	MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
	EXPECT_EQ(psu.hasMFRFault(), false);
	EXPECT_CALL(mockPMBus, read(_, _)).Times(1).WillOnce(Return(0x0000));
	psu.analyze();
	EXPECT_EQ(psu.hasMFRFault(), false);
	EXPECT_CALL(mockPMBus, read(_, _))
	.Times(2)
	.WillOnce(Return(status_word::MFR_SPECIFIC_FAULT))
	.WillOnce(Return(1)); // mock return for read(STATUS_MFR... )
	psu.analyze();
	EXPECT_EQ(psu.hasMFRFault(), true);
	EXPECT_CALL(mockPMBus, read(_, _)).Times(1).WillOnce(Return(0x0000));
	psu.analyze();
	EXPECT_EQ(psu.hasMFRFault(), false);
	}

	TEST_F(PowerSupplyTests, HasVINUVFault)
	{
	auto bus = sdbusplus::bus::new_default();

	PowerSupply psu{bus, PSUInventoryPath, 3, 0x68, PSUGPIOLineName};
	MockedGPIOReader* mockPresenceGPIO =
	static_cast<MockedGPIOReader*>(psu.getPresenceGPIO());
	// Always return 1 to indicate present.
	EXPECT_CALL(*mockPresenceGPIO, read()).WillRepeatedly(Return(1));
	psu.analyze();
	MockedPMBus& mockPMBus = static_cast<MockedPMBus&>(psu.getPMBus());
	EXPECT_EQ(psu.hasVINUVFault(), false);
	EXPECT_CALL(mockPMBus, read(_, _)).Times(1).WillOnce(Return(0x0000));
	psu.analyze();
	EXPECT_EQ(psu.hasVINUVFault(), false);
	EXPECT_CALL(mockPMBus, read(_, _))
	.Times(2)
	.WillOnce(Return(status_word::VIN_UV_FAULT))
	.WillOnce(Return(0));
	psu.analyze();
	EXPECT_EQ(psu.hasVINUVFault(), true);
	EXPECT_CALL(mockPMBus, read(_, _)).Times(1).WillOnce(Return(0x0000));
	psu.analyze();
	EXPECT_EQ(psu.hasVINUVFault(), false);
	}