commit 3fa31a7ca1868cb1ee9bae75f592d45764b5af43
author Patrick Williams <patrick@stwcx.xyz> Tue Apr 05 21:22:58 2022 -0500
committer Shawn McCarney <shawnmm@us.ibm.com> Wed Apr 06 15:49:34 2022 +0000
tree 6a82d106e475e714c2858fb655dab7e4ecb7b5d2
parent b23e44332eb9e661c61adae11d2382ac50a0deb2

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications.  Map all `true` occurrences to
`action::defer_emit`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ied6d1b6116b07a8f73b398a098298f4990b24818

phosphor-power-sequencer/src/power_control.cpp

diff --git a/phosphor-power-sequencer/src/power_control.cpp b/phosphor-power-sequencer/src/power_control.cpp
index 9ed3878..78a1d74 100644
--- a/phosphor-power-sequencer/src/power_control.cpp
+++ b/phosphor-power-sequencer/src/power_control.cpp
@@ -42,7 +42,7 @@
 
 PowerControl::PowerControl(sdbusplus::bus::bus& bus,
                            const sdeventplus::Event& event) :
-    PowerObject{bus, POWER_OBJ_PATH, true},
+    PowerObject{bus, POWER_OBJ_PATH, PowerObject::action::defer_emit},
     bus{bus}, device{std::make_unique<PowerSequencerMonitor>(bus)},
     match{bus,
           sdbusplus::bus::match::rules::interfacesAdded() +

phosphor-regulators/src/dbus_sensor.cpp

diff --git a/phosphor-regulators/src/dbus_sensor.cpp b/phosphor-regulators/src/dbus_sensor.cpp
index 9717a12..1dfd172 100644
--- a/phosphor-regulators/src/dbus_sensor.cpp
+++ b/phosphor-regulators/src/dbus_sensor.cpp
@@ -85,11 +85,11 @@
 
     // Create the sdbusplus object that implements the D-Bus sensor interfaces.
     // Skip emitting D-Bus signals until the object has been fully created.
-    bool skipSignal{true};
-    dbusObject =
-        std::make_unique<DBusSensorObject>(bus, objectPath.c_str(), skipSignal);
+    dbusObject = std::make_unique<DBusSensorObject>(
+        bus, objectPath.c_str(), DBusSensorObject::action::defer_emit);
 
     // Set properties of the Value interface
+    constexpr auto skipSignal = true;
     dbusObject->value(value, skipSignal);
     dbusObject->maxValue(maxValue, skipSignal);
     dbusObject->minValue(minValue, skipSignal);

phosphor-regulators/src/manager.cpp

diff --git a/phosphor-regulators/src/manager.cpp b/phosphor-regulators/src/manager.cpp
index 71b3369..5eeccc9 100644
--- a/phosphor-regulators/src/manager.cpp
+++ b/phosphor-regulators/src/manager.cpp
@@ -72,10 +72,9 @@
 const fs::path testConfigFileDir{"/etc/phosphor-regulators"};
 
 Manager::Manager(sdbusplus::bus::bus& bus, const sdeventplus::Event& event) :
-    ManagerObject{bus, managerObjPath, true}, bus{bus}, eventLoop{event},
-    services{bus}, phaseFaultTimer{event,
-                                   std::bind(&Manager::phaseFaultTimerExpired,
-                                             this)},
+    ManagerObject{bus, managerObjPath, ManagerObject::action::defer_emit},
+    bus{bus}, eventLoop{event}, services{bus},
+    phaseFaultTimer{event, std::bind(&Manager::phaseFaultTimerExpired, this)},
     sensorTimer{event, std::bind(&Manager::sensorTimerExpired, this)}
 {
     // Subscribe to D-Bus interfacesAdded signal from Entity Manager.  This