sdbusplus: object: don't use 'bool' argument constructor
`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ied6d1b6116b07a8f73b398a098298f4990b24818
diff --git a/phosphor-regulators/src/dbus_sensor.cpp b/phosphor-regulators/src/dbus_sensor.cpp
index 9717a12..1dfd172 100644
--- a/phosphor-regulators/src/dbus_sensor.cpp
+++ b/phosphor-regulators/src/dbus_sensor.cpp
@@ -85,11 +85,11 @@
// Create the sdbusplus object that implements the D-Bus sensor interfaces.
// Skip emitting D-Bus signals until the object has been fully created.
- bool skipSignal{true};
- dbusObject =
- std::make_unique<DBusSensorObject>(bus, objectPath.c_str(), skipSignal);
+ dbusObject = std::make_unique<DBusSensorObject>(
+ bus, objectPath.c_str(), DBusSensorObject::action::defer_emit);
// Set properties of the Value interface
+ constexpr auto skipSignal = true;
dbusObject->value(value, skipSignal);
dbusObject->maxValue(maxValue, skipSignal);
dbusObject->minValue(minValue, skipSignal);
diff --git a/phosphor-regulators/src/manager.cpp b/phosphor-regulators/src/manager.cpp
index 71b3369..5eeccc9 100644
--- a/phosphor-regulators/src/manager.cpp
+++ b/phosphor-regulators/src/manager.cpp
@@ -72,10 +72,9 @@
const fs::path testConfigFileDir{"/etc/phosphor-regulators"};
Manager::Manager(sdbusplus::bus::bus& bus, const sdeventplus::Event& event) :
- ManagerObject{bus, managerObjPath, true}, bus{bus}, eventLoop{event},
- services{bus}, phaseFaultTimer{event,
- std::bind(&Manager::phaseFaultTimerExpired,
- this)},
+ ManagerObject{bus, managerObjPath, ManagerObject::action::defer_emit},
+ bus{bus}, eventLoop{event}, services{bus},
+ phaseFaultTimer{event, std::bind(&Manager::phaseFaultTimerExpired, this)},
sensorTimer{event, std::bind(&Manager::sensorTimerExpired, this)}
{
// Subscribe to D-Bus interfacesAdded signal from Entity Manager. This