Lei YU | 415b964 | 2017-02-09 11:37:26 +0800 | [diff] [blame] | 1 | #include "manager.hpp" |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 2 | #include "mocked_property_change_listener.hpp" |
Gunnar Mills | ab4cc6a | 2018-09-14 14:42:39 -0500 | [diff] [blame] | 3 | #include "types.hpp" |
| 4 | |
| 5 | #include <sdbusplus/bus.hpp> |
| 6 | |
| 7 | #include <gtest/gtest.h> |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 8 | |
| 9 | using ::testing::_; |
Lei YU | 415b964 | 2017-02-09 11:37:26 +0800 | [diff] [blame] | 10 | |
| 11 | namespace phosphor |
| 12 | { |
| 13 | namespace time |
| 14 | { |
| 15 | |
| 16 | class TestManager : public testing::Test |
| 17 | { |
Gunnar Mills | ab4cc6a | 2018-09-14 14:42:39 -0500 | [diff] [blame] | 18 | public: |
| 19 | sdbusplus::bus::bus bus; |
| 20 | Manager manager; |
| 21 | MockPropertyChangeListner listener1; |
| 22 | MockPropertyChangeListner listener2; |
Lei YU | 415b964 | 2017-02-09 11:37:26 +0800 | [diff] [blame] | 23 | |
Gunnar Mills | ab4cc6a | 2018-09-14 14:42:39 -0500 | [diff] [blame] | 24 | TestManager() : bus(sdbusplus::bus::new_default()), manager(bus) |
| 25 | { |
| 26 | // Add two mocked listeners so that we can test |
| 27 | // the behavior related to listeners |
| 28 | manager.addListener(&listener1); |
| 29 | manager.addListener(&listener2); |
| 30 | } |
Lei YU | 415b964 | 2017-02-09 11:37:26 +0800 | [diff] [blame] | 31 | |
Gunnar Mills | ab4cc6a | 2018-09-14 14:42:39 -0500 | [diff] [blame] | 32 | // Proxies for Manager's private members and functions |
| 33 | Mode getTimeMode() |
| 34 | { |
| 35 | return manager.timeMode; |
| 36 | } |
| 37 | Owner getTimeOwner() |
| 38 | { |
| 39 | return manager.timeOwner; |
| 40 | } |
| 41 | bool hostOn() |
| 42 | { |
| 43 | return manager.hostOn; |
| 44 | } |
| 45 | std::string getRequestedMode() |
| 46 | { |
| 47 | return manager.requestedMode; |
| 48 | } |
| 49 | std::string getRequestedOwner() |
| 50 | { |
| 51 | return manager.requestedOwner; |
| 52 | } |
| 53 | void notifyPropertyChanged(const std::string& key, const std::string& value) |
| 54 | { |
| 55 | manager.onPropertyChanged(key, value); |
| 56 | } |
| 57 | void notifyOnHostState(bool hostOn) |
| 58 | { |
| 59 | manager.onHostState(hostOn); |
| 60 | } |
Lei YU | 415b964 | 2017-02-09 11:37:26 +0800 | [diff] [blame] | 61 | }; |
| 62 | |
Lei YU | ddd5442 | 2017-04-18 16:38:44 +0800 | [diff] [blame] | 63 | TEST_F(TestManager, DISABLED_empty) |
Lei YU | 415b964 | 2017-02-09 11:37:26 +0800 | [diff] [blame] | 64 | { |
Lei YU | 7f4fca5 | 2017-02-23 15:15:51 +0800 | [diff] [blame] | 65 | EXPECT_FALSE(hostOn()); |
| 66 | EXPECT_EQ("", getRequestedMode()); |
| 67 | EXPECT_EQ("", getRequestedOwner()); |
Lei YU | 57eab12 | 2017-06-16 10:27:30 +0800 | [diff] [blame] | 68 | |
| 69 | // Default mode/owner is MANUAL/BOTH |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 70 | EXPECT_EQ(Mode::Manual, getTimeMode()); |
| 71 | EXPECT_EQ(Owner::Both, getTimeOwner()); |
Lei YU | 415b964 | 2017-02-09 11:37:26 +0800 | [diff] [blame] | 72 | } |
| 73 | |
Lei YU | debe1d8 | 2017-10-13 13:21:37 +0800 | [diff] [blame] | 74 | TEST_F(TestManager, DISABLED_hostStateChange) |
Lei YU | 7f4fca5 | 2017-02-23 15:15:51 +0800 | [diff] [blame] | 75 | { |
Lei YU | debe1d8 | 2017-10-13 13:21:37 +0800 | [diff] [blame] | 76 | notifyOnHostState(true); |
Lei YU | 7f4fca5 | 2017-02-23 15:15:51 +0800 | [diff] [blame] | 77 | EXPECT_TRUE(hostOn()); |
Lei YU | debe1d8 | 2017-10-13 13:21:37 +0800 | [diff] [blame] | 78 | notifyOnHostState(false); |
Lei YU | 7f4fca5 | 2017-02-23 15:15:51 +0800 | [diff] [blame] | 79 | EXPECT_FALSE(hostOn()); |
| 80 | } |
| 81 | |
Lei YU | ddd5442 | 2017-04-18 16:38:44 +0800 | [diff] [blame] | 82 | TEST_F(TestManager, DISABLED_propertyChanged) |
Lei YU | 7f4fca5 | 2017-02-23 15:15:51 +0800 | [diff] [blame] | 83 | { |
Gunnar Mills | 7f25c53 | 2017-10-25 20:45:28 -0500 | [diff] [blame] | 84 | // When host is off, property change will be notified to listeners |
Lei YU | 7f4fca5 | 2017-02-23 15:15:51 +0800 | [diff] [blame] | 85 | EXPECT_FALSE(hostOn()); |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 86 | |
| 87 | // Check mocked listeners shall receive notifications on property changed |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 88 | EXPECT_CALL(listener1, onModeChanged(Mode::Manual)).Times(1); |
| 89 | EXPECT_CALL(listener1, onOwnerChanged(Owner::Host)).Times(1); |
| 90 | EXPECT_CALL(listener2, onModeChanged(Mode::Manual)).Times(1); |
| 91 | EXPECT_CALL(listener2, onOwnerChanged(Owner::Host)).Times(1); |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 92 | |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 93 | notifyPropertyChanged( |
Lei YU | 710d49b | 2017-08-01 17:10:17 +0800 | [diff] [blame] | 94 | "TimeSyncMethod", |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 95 | "xyz.openbmc_project.Time.Synchronization.Method.Manual"); |
Gunnar Mills | ab4cc6a | 2018-09-14 14:42:39 -0500 | [diff] [blame] | 96 | notifyPropertyChanged("TimeOwner", |
| 97 | "xyz.openbmc_project.Time.Owner.Owners.Host"); |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 98 | |
Lei YU | 7f4fca5 | 2017-02-23 15:15:51 +0800 | [diff] [blame] | 99 | EXPECT_EQ("", getRequestedMode()); |
| 100 | EXPECT_EQ("", getRequestedOwner()); |
Lei YU | 7f4fca5 | 2017-02-23 15:15:51 +0800 | [diff] [blame] | 101 | |
Lei YU | 7f4fca5 | 2017-02-23 15:15:51 +0800 | [diff] [blame] | 102 | // When host is on, property changes are saved as requested ones |
Lei YU | debe1d8 | 2017-10-13 13:21:37 +0800 | [diff] [blame] | 103 | notifyOnHostState(true); |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 104 | |
| 105 | // Check mocked listeners shall not receive notifications |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 106 | EXPECT_CALL(listener1, onModeChanged(Mode::Manual)).Times(0); |
| 107 | EXPECT_CALL(listener1, onOwnerChanged(Owner::Host)).Times(0); |
| 108 | EXPECT_CALL(listener2, onModeChanged(Mode::Manual)).Times(0); |
| 109 | EXPECT_CALL(listener2, onOwnerChanged(Owner::Host)).Times(0); |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 110 | |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 111 | notifyPropertyChanged( |
Lei YU | 710d49b | 2017-08-01 17:10:17 +0800 | [diff] [blame] | 112 | "TimeSyncMethod", |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 113 | "xyz.openbmc_project.Time.Synchronization.Method.NTP"); |
Gunnar Mills | ab4cc6a | 2018-09-14 14:42:39 -0500 | [diff] [blame] | 114 | notifyPropertyChanged("TimeOwner", |
| 115 | "xyz.openbmc_project.Time.Owner.Owners.Split"); |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 116 | |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 117 | EXPECT_EQ("xyz.openbmc_project.Time.Synchronization.Method.NTP", |
| 118 | getRequestedMode()); |
| 119 | EXPECT_EQ("xyz.openbmc_project.Time.Owner.Owners.Split", |
| 120 | getRequestedOwner()); |
Lei YU | 7f4fca5 | 2017-02-23 15:15:51 +0800 | [diff] [blame] | 121 | |
Lei YU | 7f4fca5 | 2017-02-23 15:15:51 +0800 | [diff] [blame] | 122 | // When host becomes off, the requested mode/owner shall be notified |
Gunnar Mills | 7f25c53 | 2017-10-25 20:45:28 -0500 | [diff] [blame] | 123 | // to listeners, and be cleared |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 124 | EXPECT_CALL(listener1, onModeChanged(Mode::NTP)).Times(1); |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 125 | EXPECT_CALL(listener1, onOwnerChanged(Owner::Split)).Times(1); |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 126 | EXPECT_CALL(listener2, onModeChanged(Mode::NTP)).Times(1); |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 127 | EXPECT_CALL(listener2, onOwnerChanged(Owner::Split)).Times(1); |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 128 | |
Lei YU | debe1d8 | 2017-10-13 13:21:37 +0800 | [diff] [blame] | 129 | notifyOnHostState(false); |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 130 | |
Lei YU | 7f4fca5 | 2017-02-23 15:15:51 +0800 | [diff] [blame] | 131 | EXPECT_EQ("", getRequestedMode()); |
| 132 | EXPECT_EQ("", getRequestedOwner()); |
| 133 | |
| 134 | // When host is on, and invalid property is changed, |
| 135 | // verify the code asserts because it shall never occur |
Lei YU | debe1d8 | 2017-10-13 13:21:37 +0800 | [diff] [blame] | 136 | notifyOnHostState(true); |
Lei YU | 7f4fca5 | 2017-02-23 15:15:51 +0800 | [diff] [blame] | 137 | ASSERT_DEATH(notifyPropertyChanged("invalid property", "whatever"), ""); |
| 138 | } |
| 139 | |
Lei YU | ddd5442 | 2017-04-18 16:38:44 +0800 | [diff] [blame] | 140 | TEST_F(TestManager, DISABLED_propertyChangedAndChangedbackWhenHostOn) |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 141 | { |
| 142 | // Property is now MANUAL/HOST |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 143 | notifyPropertyChanged( |
Lei YU | 710d49b | 2017-08-01 17:10:17 +0800 | [diff] [blame] | 144 | "TimeSyncMethod", |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 145 | "xyz.openbmc_project.Time.Synchronization.Method.Manual"); |
Gunnar Mills | ab4cc6a | 2018-09-14 14:42:39 -0500 | [diff] [blame] | 146 | notifyPropertyChanged("TimeOwner", |
| 147 | "xyz.openbmc_project.Time.Owner.Owners.Host"); |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 148 | |
| 149 | // Set host on |
Lei YU | debe1d8 | 2017-10-13 13:21:37 +0800 | [diff] [blame] | 150 | notifyOnHostState(true); |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 151 | |
| 152 | // Check mocked listeners shall not receive notifications |
| 153 | EXPECT_CALL(listener1, onModeChanged(_)).Times(0); |
| 154 | EXPECT_CALL(listener1, onOwnerChanged(_)).Times(0); |
| 155 | EXPECT_CALL(listener2, onModeChanged(_)).Times(0); |
| 156 | EXPECT_CALL(listener2, onOwnerChanged(_)).Times(0); |
| 157 | |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 158 | notifyPropertyChanged( |
Lei YU | 710d49b | 2017-08-01 17:10:17 +0800 | [diff] [blame] | 159 | "TimeSyncMethod", |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 160 | "xyz.openbmc_project.Time.Synchronization.Method.NTP"); |
Gunnar Mills | ab4cc6a | 2018-09-14 14:42:39 -0500 | [diff] [blame] | 161 | notifyPropertyChanged("TimeOwner", |
| 162 | "xyz.openbmc_project.Time.Owner.Owners.Split"); |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 163 | |
| 164 | // Saved as requested mode/owner |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 165 | EXPECT_EQ("xyz.openbmc_project.Time.Synchronization.Method.NTP", |
| 166 | getRequestedMode()); |
| 167 | EXPECT_EQ("xyz.openbmc_project.Time.Owner.Owners.Split", |
| 168 | getRequestedOwner()); |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 169 | |
| 170 | // Property changed back to MANUAL/HOST |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 171 | notifyPropertyChanged( |
Lei YU | 710d49b | 2017-08-01 17:10:17 +0800 | [diff] [blame] | 172 | "TimeSyncMethod", |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 173 | "xyz.openbmc_project.Time.Synchronization.Method.Manual"); |
Gunnar Mills | ab4cc6a | 2018-09-14 14:42:39 -0500 | [diff] [blame] | 174 | notifyPropertyChanged("TimeOwner", |
| 175 | "xyz.openbmc_project.Time.Owner.Owners.Host"); |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 176 | |
| 177 | // Requested mode/owner shall be updated |
Lei YU | ad14354 | 2017-07-25 14:27:07 +0800 | [diff] [blame] | 178 | EXPECT_EQ("xyz.openbmc_project.Time.Synchronization.Method.Manual", |
| 179 | getRequestedMode()); |
| 180 | EXPECT_EQ("xyz.openbmc_project.Time.Owner.Owners.Host", |
| 181 | getRequestedOwner()); |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 182 | |
| 183 | // Because the latest mode/owner is the same as when host is off, |
| 184 | // The listeners shall not be notified, and requested mode/owner |
| 185 | // shall be cleared |
| 186 | EXPECT_CALL(listener1, onModeChanged(_)).Times(0); |
| 187 | EXPECT_CALL(listener1, onOwnerChanged(_)).Times(0); |
| 188 | EXPECT_CALL(listener2, onModeChanged(_)).Times(0); |
| 189 | EXPECT_CALL(listener2, onOwnerChanged(_)).Times(0); |
| 190 | |
Lei YU | debe1d8 | 2017-10-13 13:21:37 +0800 | [diff] [blame] | 191 | notifyOnHostState(false); |
Lei YU | a5003ce | 2017-02-24 15:35:25 +0800 | [diff] [blame] | 192 | |
| 193 | EXPECT_EQ("", getRequestedMode()); |
| 194 | EXPECT_EQ("", getRequestedOwner()); |
| 195 | } |
| 196 | |
Lei YU | a741713 | 2017-02-23 15:24:05 +0800 | [diff] [blame] | 197 | // TODO: if gmock is ready, add case to test |
| 198 | // updateNtpSetting() and updateNetworkSetting() |
| 199 | |
Gunnar Mills | ab4cc6a | 2018-09-14 14:42:39 -0500 | [diff] [blame] | 200 | } // namespace time |
| 201 | } // namespace phosphor |