libpldm/firmware_update.c - openbmc/pldm - Gitiles

 #include "firmware_update.h"
 #include <endian.h>
 #include <string.h>

 /** @brief Check whether string type value is valid
  *
  *  @return true if string type value is valid, false if not
  */
 static bool is_string_type_valid(uint8_t string_type)
 {
 	switch (string_type) {
 	case PLDM_STR_TYPE_UNKNOWN:
 	case PLDM_STR_TYPE_ASCII:
 	case PLDM_STR_TYPE_UTF_8:
 	case PLDM_STR_TYPE_UTF_16:
 	case PLDM_STR_TYPE_UTF_16LE:
 	case PLDM_STR_TYPE_UTF_16BE:
 		return true;
 	default:
 		return false;
 	}
 }

 /** @brief Return the length of the descriptor type described in firmware update
  *         specification
  *
  *  @return length of the descriptor type if descriptor type is valid else
  *          return 0
  */
 static uint16_t get_descriptor_type_length(uint16_t descriptor_type)
 {
 	switch (descriptor_type) {

 	case PLDM_FWUP_PCI_VENDOR_ID:
 		return PLDM_FWUP_PCI_VENDOR_ID_LENGTH;
 	case PLDM_FWUP_IANA_ENTERPRISE_ID:
 		return PLDM_FWUP_IANA_ENTERPRISE_ID_LENGTH;
 	case PLDM_FWUP_UUID:
 		return PLDM_FWUP_UUID_LENGTH;
 	case PLDM_FWUP_PNP_VENDOR_ID:
 		return PLDM_FWUP_PNP_VENDOR_ID_LENGTH;
 	case PLDM_FWUP_ACPI_VENDOR_ID:
 		return PLDM_FWUP_ACPI_VENDOR_ID_LENGTH;
 	case PLDM_FWUP_IEEE_ASSIGNED_COMPANY_ID:
 		return PLDM_FWUP_IEEE_ASSIGNED_COMPANY_ID_LENGTH;
 	case PLDM_FWUP_SCSI_VENDOR_ID:
 		return PLDM_FWUP_SCSI_VENDOR_ID_LENGTH;
 	case PLDM_FWUP_PCI_DEVICE_ID:
 		return PLDM_FWUP_PCI_DEVICE_ID_LENGTH;
 	case PLDM_FWUP_PCI_SUBSYSTEM_VENDOR_ID:
 		return PLDM_FWUP_PCI_SUBSYSTEM_VENDOR_ID_LENGTH;
 	case PLDM_FWUP_PCI_SUBSYSTEM_ID:
 		return PLDM_FWUP_PCI_SUBSYSTEM_ID_LENGTH;
 	case PLDM_FWUP_PCI_REVISION_ID:
 		return PLDM_FWUP_PCI_REVISION_ID_LENGTH;
 	case PLDM_FWUP_PNP_PRODUCT_IDENTIFIER:
 		return PLDM_FWUP_PNP_PRODUCT_IDENTIFIER_LENGTH;
 	case PLDM_FWUP_ACPI_PRODUCT_IDENTIFIER:
 		return PLDM_FWUP_ACPI_PRODUCT_IDENTIFIER_LENGTH;
 	case PLDM_FWUP_ASCII_MODEL_NUMBER_LONG_STRING:
 		return PLDM_FWUP_ASCII_MODEL_NUMBER_LONG_STRING_LENGTH;
 	case PLDM_FWUP_ASCII_MODEL_NUMBER_SHORT_STRING:
 		return PLDM_FWUP_ASCII_MODEL_NUMBER_SHORT_STRING_LENGTH;
 	case PLDM_FWUP_SCSI_PRODUCT_ID:
 		return PLDM_FWUP_SCSI_PRODUCT_ID_LENGTH;
 	case PLDM_FWUP_UBM_CONTROLLER_DEVICE_CODE:
 		return PLDM_FWUP_UBM_CONTROLLER_DEVICE_CODE_LENGTH;
 	default:
 		return 0;
 	}
 }

 int decode_descriptor_type_length_value(const uint8_t *data, size_t length,
 					uint16_t *descriptor_type,
 					struct variable_field *descriptor_data)
 {
 	uint16_t descriptor_length = 0;

 	if (data == NULL || descriptor_type == NULL ||
 	    descriptor_data == NULL) {
 		return PLDM_ERROR_INVALID_DATA;
 	}

 	if (length < PLDM_FWUP_DEVICE_DESCRIPTOR_MIN_LEN) {
 		return PLDM_ERROR_INVALID_LENGTH;
 	}

 	struct pldm_descriptor_tlv *entry =
 	    (struct pldm_descriptor_tlv *)(data);

 	*descriptor_type = le16toh(entry->descriptor_type);
 	descriptor_length = le16toh(entry->descriptor_length);
 	if (*descriptor_type != PLDM_FWUP_VENDOR_DEFINED) {
 		if (descriptor_length !=
 		    get_descriptor_type_length(*descriptor_type)) {
 			return PLDM_ERROR_INVALID_LENGTH;
 		}
 	}

 	if (length < (sizeof(*descriptor_type) + sizeof(descriptor_length) +
 		      descriptor_length)) {
 		return PLDM_ERROR_INVALID_LENGTH;
 	}

 	descriptor_data->ptr = entry->descriptor_data;
 	descriptor_data->length = descriptor_length;

 	return PLDM_SUCCESS;
 }

 int decode_vendor_defined_descriptor_value(
     const uint8_t *data, size_t length, uint8_t *descriptor_title_str_type,
     struct variable_field *descriptor_title_str,
     struct variable_field *descriptor_data)
 {
 	if (data == NULL || descriptor_title_str_type == NULL ||
 	    descriptor_title_str == NULL || descriptor_data == NULL) {
 		return PLDM_ERROR_INVALID_DATA;
 	}

 	if (length < sizeof(struct pldm_vendor_defined_descriptor_title_data)) {
 		return PLDM_ERROR_INVALID_LENGTH;
 	}

 	struct pldm_vendor_defined_descriptor_title_data *entry =
 	    (struct pldm_vendor_defined_descriptor_title_data *)(data);
 	if (!is_string_type_valid(
 		entry->vendor_defined_descriptor_title_str_type) ||
 	    (entry->vendor_defined_descriptor_title_str_len == 0)) {
 		return PLDM_ERROR_INVALID_DATA;
 	}

 	// Assuming atleast 1 byte of VendorDefinedDescriptorData
 	if (length < (sizeof(struct pldm_vendor_defined_descriptor_title_data) +
 		      entry->vendor_defined_descriptor_title_str_len)) {
 		return PLDM_ERROR_INVALID_LENGTH;
 	}

 	*descriptor_title_str_type =
 	    entry->vendor_defined_descriptor_title_str_type;
 	descriptor_title_str->ptr = entry->vendor_defined_descriptor_title_str;
 	descriptor_title_str->length =
 	    entry->vendor_defined_descriptor_title_str_len;

 	descriptor_data->ptr =
 	    descriptor_title_str->ptr + descriptor_title_str->length;
 	descriptor_data->length =
 	    length - sizeof(entry->vendor_defined_descriptor_title_str_type) -
 	    sizeof(entry->vendor_defined_descriptor_title_str_len) -
 	    descriptor_title_str->length;

 	return PLDM_SUCCESS;
 }

 int encode_query_device_identifiers_req(uint8_t instance_id,
 					size_t payload_length,
 					struct pldm_msg *msg)
 {
 	if (msg == NULL) {
 		return PLDM_ERROR_INVALID_DATA;
 	}

 	if (payload_length != PLDM_QUERY_DEVICE_IDENTIFIERS_REQ_BYTES) {
 		return PLDM_ERROR_INVALID_LENGTH;
 	}

 	return encode_pldm_header_only(PLDM_REQUEST, instance_id, PLDM_FWUP,
 				       PLDM_QUERY_DEVICE_IDENTIFIERS, msg);
 }

 int decode_query_device_identifiers_resp(const struct pldm_msg *msg,
 					 size_t payload_length,
 					 uint8_t *completion_code,
 					 uint32_t *device_identifiers_len,
 					 uint8_t *descriptor_count,
 					 uint8_t **descriptor_data)
 {
 	if (msg == NULL || completion_code == NULL ||
 	    device_identifiers_len == NULL || descriptor_count == NULL ||
 	    descriptor_data == NULL) {
 		return PLDM_ERROR_INVALID_DATA;
 	}

 	*completion_code = msg->payload[0];
 	if (PLDM_SUCCESS != *completion_code) {
 		return PLDM_SUCCESS;
 	}

 	if (payload_length <
 	    sizeof(struct pldm_query_device_identifiers_resp)) {
 		return PLDM_ERROR_INVALID_LENGTH;
 	}

 	struct pldm_query_device_identifiers_resp *response =
 	    (struct pldm_query_device_identifiers_resp *)msg->payload;
 	*device_identifiers_len = le32toh(response->device_identifiers_len);

 	if (*device_identifiers_len < PLDM_FWUP_DEVICE_DESCRIPTOR_MIN_LEN) {
 		return PLDM_ERROR_INVALID_LENGTH;
 	}

 	if (payload_length !=
 	    sizeof(struct pldm_query_device_identifiers_resp) +
 		*device_identifiers_len) {
 		return PLDM_ERROR_INVALID_LENGTH;
 	}
 	*descriptor_count = response->descriptor_count;

 	if (*descriptor_count == 0) {
 		return PLDM_ERROR_INVALID_DATA;
 	}
 	*descriptor_data =
 	    (uint8_t *)(msg->payload +
 			sizeof(struct pldm_query_device_identifiers_resp));
 	return PLDM_SUCCESS;
 }

 int encode_get_firmware_parameters_req(uint8_t instance_id,
 				       size_t payload_length,
 				       struct pldm_msg *msg)
 {
 	if (msg == NULL) {
 		return PLDM_ERROR_INVALID_DATA;
 	}

 	if (payload_length != PLDM_GET_FIRMWARE_PARAMETERS_REQ_BYTES) {
 		return PLDM_ERROR_INVALID_LENGTH;
 	}

 	return encode_pldm_header_only(PLDM_REQUEST, instance_id, PLDM_FWUP,
 				       PLDM_GET_FIRMWARE_PARAMETERS, msg);
 }

 int decode_get_firmware_parameters_resp(
     const struct pldm_msg *msg, size_t payload_length,
     struct pldm_get_firmware_parameters_resp *resp_data,
     struct variable_field *active_comp_image_set_ver_str,
     struct variable_field *pending_comp_image_set_ver_str,
     struct variable_field *comp_parameter_table)
 {
 	if (msg == NULL || resp_data == NULL ||
 	    active_comp_image_set_ver_str == NULL ||
 	    pending_comp_image_set_ver_str == NULL ||
 	    comp_parameter_table == NULL) {
 		return PLDM_ERROR_INVALID_DATA;
 	}

 	if (payload_length < sizeof(struct pldm_get_firmware_parameters_resp)) {
 		return PLDM_ERROR_INVALID_LENGTH;
 	}

 	struct pldm_get_firmware_parameters_resp *response =
 	    (struct pldm_get_firmware_parameters_resp *)msg->payload;

 	resp_data->completion_code = response->completion_code;

 	if (PLDM_SUCCESS != resp_data->completion_code) {
 		return PLDM_SUCCESS;
 	}

 	if (!is_string_type_valid(
 		response->active_comp_image_set_ver_str_type) ||
 	    (response->active_comp_image_set_ver_str_len == 0)) {
 		return PLDM_ERROR_INVALID_DATA;
 	}

 	if (response->pending_comp_image_set_ver_str_len == 0) {
 		if (response->pending_comp_image_set_ver_str_type !=
 		    PLDM_STR_TYPE_UNKNOWN) {
 			return PLDM_ERROR_INVALID_DATA;
 		}
 	} else {
 		if (!is_string_type_valid(
 			response->pending_comp_image_set_ver_str_type)) {
 			return PLDM_ERROR_INVALID_DATA;
 		}
 	}

 	size_t partial_response_length =
 	    sizeof(struct pldm_get_firmware_parameters_resp) +
 	    response->active_comp_image_set_ver_str_len +
 	    response->pending_comp_image_set_ver_str_len;

 	if (payload_length < partial_response_length) {
 		return PLDM_ERROR_INVALID_LENGTH;
 	}

 	resp_data->capabilities_during_update.value =
 	    le32toh(response->capabilities_during_update.value);
 	resp_data->comp_count = le16toh(response->comp_count);
 	resp_data->active_comp_image_set_ver_str_type =
 	    response->active_comp_image_set_ver_str_type;
 	resp_data->active_comp_image_set_ver_str_len =
 	    response->active_comp_image_set_ver_str_len;
 	resp_data->pending_comp_image_set_ver_str_type =
 	    response->pending_comp_image_set_ver_str_type;
 	resp_data->pending_comp_image_set_ver_str_len =
 	    response->pending_comp_image_set_ver_str_len;

 	active_comp_image_set_ver_str->ptr =
 	    msg->payload + sizeof(struct pldm_get_firmware_parameters_resp);
 	active_comp_image_set_ver_str->length =
 	    resp_data->active_comp_image_set_ver_str_len;

 	if (resp_data->pending_comp_image_set_ver_str_len != 0) {
 		pending_comp_image_set_ver_str->ptr =
 		    msg->payload +
 		    sizeof(struct pldm_get_firmware_parameters_resp) +
 		    resp_data->active_comp_image_set_ver_str_len;
 		pending_comp_image_set_ver_str->length =
 		    resp_data->pending_comp_image_set_ver_str_len;
 	} else {
 		pending_comp_image_set_ver_str->ptr = NULL;
 		pending_comp_image_set_ver_str->length = 0;
 	}

 	if (payload_length > partial_response_length && resp_data->comp_count) {
 		comp_parameter_table->ptr =
 		    msg->payload +
 		    sizeof(struct pldm_get_firmware_parameters_resp) +
 		    resp_data->active_comp_image_set_ver_str_len +
 		    resp_data->pending_comp_image_set_ver_str_len;
 		comp_parameter_table->length =
 		    payload_length - partial_response_length;
 	} else {
 		comp_parameter_table->ptr = NULL;
 		comp_parameter_table->length = 0;
 	}

 	return PLDM_SUCCESS;
 }

 int decode_get_firmware_parameters_resp_comp_entry(
     const uint8_t *data, size_t length,
     struct pldm_component_parameter_entry *component_data,
     struct variable_field *active_comp_ver_str,
     struct variable_field *pending_comp_ver_str)
 {
 	if (data == NULL || component_data == NULL ||
 	    active_comp_ver_str == NULL || pending_comp_ver_str == NULL) {
 		return PLDM_ERROR_INVALID_DATA;
 	}

 	if (length < sizeof(struct pldm_component_parameter_entry)) {
 		return PLDM_ERROR_INVALID_LENGTH;
 	}

 	struct pldm_component_parameter_entry *entry =
 	    (struct pldm_component_parameter_entry *)(data);
 	if (entry->active_comp_ver_str_len == 0) {
 		return PLDM_ERROR_INVALID_LENGTH;
 	}

 	size_t entry_length = sizeof(struct pldm_component_parameter_entry) +
 			      entry->active_comp_ver_str_len +
 			      entry->pending_comp_ver_str_len;

 	if (length != entry_length) {
 		return PLDM_ERROR_INVALID_LENGTH;
 	}

 	component_data->comp_classification =
 	    le16toh(entry->comp_classification);
 	component_data->comp_identifier = le16toh(entry->comp_identifier);
 	component_data->comp_classification_index =
 	    entry->comp_classification_index;
 	component_data->active_comp_comparison_stamp =
 	    le32toh(entry->active_comp_comparison_stamp);
 	component_data->active_comp_ver_str_type =
 	    entry->active_comp_ver_str_type;
 	component_data->active_comp_ver_str_len =
 	    entry->active_comp_ver_str_len;
 	memcpy(component_data->active_comp_release_date,
 	       entry->active_comp_release_date,
 	       sizeof(entry->active_comp_release_date));
 	component_data->pending_comp_comparison_stamp =
 	    le32toh(entry->pending_comp_comparison_stamp);
 	component_data->pending_comp_ver_str_type =
 	    entry->pending_comp_ver_str_type;
 	component_data->pending_comp_ver_str_len =
 	    entry->pending_comp_ver_str_len;
 	memcpy(component_data->pending_comp_release_date,
 	       entry->pending_comp_release_date,
 	       sizeof(entry->pending_comp_release_date));
 	component_data->comp_activation_methods.value =
 	    le16toh(entry->comp_activation_methods.value);
 	component_data->capabilities_during_update.value =
 	    le32toh(entry->capabilities_during_update.value);

 	active_comp_ver_str->ptr =
 	    data + sizeof(struct pldm_component_parameter_entry);
 	active_comp_ver_str->length = entry->active_comp_ver_str_len;

 	if (entry->pending_comp_ver_str_len != 0) {

 		pending_comp_ver_str->ptr =
 		    data + sizeof(struct pldm_component_parameter_entry) +
 		    entry->active_comp_ver_str_len;
 		pending_comp_ver_str->length = entry->pending_comp_ver_str_len;
 	} else {
 		pending_comp_ver_str->ptr = NULL;
 		pending_comp_ver_str->length = 0;
 	}
 	return PLDM_SUCCESS;
 }
	#include "firmware_update.h"
	#include <endian.h>
	#include <string.h>

	/** @brief Check whether string type value is valid
	*
	* @return true if string type value is valid, false if not
	*/
	static bool is_string_type_valid(uint8_t string_type)
	{
	switch (string_type) {
	case PLDM_STR_TYPE_UNKNOWN:
	case PLDM_STR_TYPE_ASCII:
	case PLDM_STR_TYPE_UTF_8:
	case PLDM_STR_TYPE_UTF_16:
	case PLDM_STR_TYPE_UTF_16LE:
	case PLDM_STR_TYPE_UTF_16BE:
	return true;
	default:
	return false;
	}
	}

	/** @brief Return the length of the descriptor type described in firmware update
	* specification
	*
	* @return length of the descriptor type if descriptor type is valid else
	* return 0
	*/
	static uint16_t get_descriptor_type_length(uint16_t descriptor_type)
	{
	switch (descriptor_type) {

	case PLDM_FWUP_PCI_VENDOR_ID:
	return PLDM_FWUP_PCI_VENDOR_ID_LENGTH;
	case PLDM_FWUP_IANA_ENTERPRISE_ID:
	return PLDM_FWUP_IANA_ENTERPRISE_ID_LENGTH;
	case PLDM_FWUP_UUID:
	return PLDM_FWUP_UUID_LENGTH;
	case PLDM_FWUP_PNP_VENDOR_ID:
	return PLDM_FWUP_PNP_VENDOR_ID_LENGTH;
	case PLDM_FWUP_ACPI_VENDOR_ID:
	return PLDM_FWUP_ACPI_VENDOR_ID_LENGTH;
	case PLDM_FWUP_IEEE_ASSIGNED_COMPANY_ID:
	return PLDM_FWUP_IEEE_ASSIGNED_COMPANY_ID_LENGTH;
	case PLDM_FWUP_SCSI_VENDOR_ID:
	return PLDM_FWUP_SCSI_VENDOR_ID_LENGTH;
	case PLDM_FWUP_PCI_DEVICE_ID:
	return PLDM_FWUP_PCI_DEVICE_ID_LENGTH;
	case PLDM_FWUP_PCI_SUBSYSTEM_VENDOR_ID:
	return PLDM_FWUP_PCI_SUBSYSTEM_VENDOR_ID_LENGTH;
	case PLDM_FWUP_PCI_SUBSYSTEM_ID:
	return PLDM_FWUP_PCI_SUBSYSTEM_ID_LENGTH;
	case PLDM_FWUP_PCI_REVISION_ID:
	return PLDM_FWUP_PCI_REVISION_ID_LENGTH;
	case PLDM_FWUP_PNP_PRODUCT_IDENTIFIER:
	return PLDM_FWUP_PNP_PRODUCT_IDENTIFIER_LENGTH;
	case PLDM_FWUP_ACPI_PRODUCT_IDENTIFIER:
	return PLDM_FWUP_ACPI_PRODUCT_IDENTIFIER_LENGTH;
	case PLDM_FWUP_ASCII_MODEL_NUMBER_LONG_STRING:
	return PLDM_FWUP_ASCII_MODEL_NUMBER_LONG_STRING_LENGTH;
	case PLDM_FWUP_ASCII_MODEL_NUMBER_SHORT_STRING:
	return PLDM_FWUP_ASCII_MODEL_NUMBER_SHORT_STRING_LENGTH;
	case PLDM_FWUP_SCSI_PRODUCT_ID:
	return PLDM_FWUP_SCSI_PRODUCT_ID_LENGTH;
	case PLDM_FWUP_UBM_CONTROLLER_DEVICE_CODE:
	return PLDM_FWUP_UBM_CONTROLLER_DEVICE_CODE_LENGTH;
	default:
	return 0;
	}
	}

	int decode_descriptor_type_length_value(const uint8_t *data, size_t length,
	uint16_t *descriptor_type,
	struct variable_field *descriptor_data)
	{
	uint16_t descriptor_length = 0;

	if (data == NULL \|\| descriptor_type == NULL \|\|
	descriptor_data == NULL) {
	return PLDM_ERROR_INVALID_DATA;
	}

	if (length < PLDM_FWUP_DEVICE_DESCRIPTOR_MIN_LEN) {
	return PLDM_ERROR_INVALID_LENGTH;
	}

	struct pldm_descriptor_tlv *entry =
	(struct pldm_descriptor_tlv *)(data);

	*descriptor_type = le16toh(entry->descriptor_type);
	descriptor_length = le16toh(entry->descriptor_length);
	if (*descriptor_type != PLDM_FWUP_VENDOR_DEFINED) {
	if (descriptor_length !=
	get_descriptor_type_length(*descriptor_type)) {
	return PLDM_ERROR_INVALID_LENGTH;
	}
	}

	if (length < (sizeof(*descriptor_type) + sizeof(descriptor_length) +
	descriptor_length)) {
	return PLDM_ERROR_INVALID_LENGTH;
	}

	descriptor_data->ptr = entry->descriptor_data;
	descriptor_data->length = descriptor_length;

	return PLDM_SUCCESS;
	}

	int decode_vendor_defined_descriptor_value(
	const uint8_t data, size_t length, uint8_t descriptor_title_str_type,
	struct variable_field *descriptor_title_str,
	struct variable_field *descriptor_data)
	{
	if (data == NULL \|\| descriptor_title_str_type == NULL \|\|
	descriptor_title_str == NULL \|\| descriptor_data == NULL) {
	return PLDM_ERROR_INVALID_DATA;
	}

	if (length < sizeof(struct pldm_vendor_defined_descriptor_title_data)) {
	return PLDM_ERROR_INVALID_LENGTH;
	}

	struct pldm_vendor_defined_descriptor_title_data *entry =
	(struct pldm_vendor_defined_descriptor_title_data *)(data);
	if (!is_string_type_valid(
	entry->vendor_defined_descriptor_title_str_type) \|\|
	(entry->vendor_defined_descriptor_title_str_len == 0)) {
	return PLDM_ERROR_INVALID_DATA;
	}

	// Assuming atleast 1 byte of VendorDefinedDescriptorData
	if (length < (sizeof(struct pldm_vendor_defined_descriptor_title_data) +
	entry->vendor_defined_descriptor_title_str_len)) {
	return PLDM_ERROR_INVALID_LENGTH;
	}

	*descriptor_title_str_type =
	entry->vendor_defined_descriptor_title_str_type;
	descriptor_title_str->ptr = entry->vendor_defined_descriptor_title_str;
	descriptor_title_str->length =
	entry->vendor_defined_descriptor_title_str_len;

	descriptor_data->ptr =
	descriptor_title_str->ptr + descriptor_title_str->length;
	descriptor_data->length =
	length - sizeof(entry->vendor_defined_descriptor_title_str_type) -
	sizeof(entry->vendor_defined_descriptor_title_str_len) -
	descriptor_title_str->length;

	return PLDM_SUCCESS;
	}

	int encode_query_device_identifiers_req(uint8_t instance_id,
	size_t payload_length,
	struct pldm_msg *msg)
	{
	if (msg == NULL) {
	return PLDM_ERROR_INVALID_DATA;
	}

	if (payload_length != PLDM_QUERY_DEVICE_IDENTIFIERS_REQ_BYTES) {
	return PLDM_ERROR_INVALID_LENGTH;
	}

	return encode_pldm_header_only(PLDM_REQUEST, instance_id, PLDM_FWUP,
	PLDM_QUERY_DEVICE_IDENTIFIERS, msg);
	}

	int decode_query_device_identifiers_resp(const struct pldm_msg *msg,
	size_t payload_length,
	uint8_t *completion_code,
	uint32_t *device_identifiers_len,
	uint8_t *descriptor_count,
	uint8_t **descriptor_data)
	{
	if (msg == NULL \|\| completion_code == NULL \|\|
	device_identifiers_len == NULL \|\| descriptor_count == NULL \|\|
	descriptor_data == NULL) {
	return PLDM_ERROR_INVALID_DATA;
	}

	*completion_code = msg->payload[0];
	if (PLDM_SUCCESS != *completion_code) {
	return PLDM_SUCCESS;
	}

	if (payload_length <
	sizeof(struct pldm_query_device_identifiers_resp)) {
	return PLDM_ERROR_INVALID_LENGTH;
	}

	struct pldm_query_device_identifiers_resp *response =
	(struct pldm_query_device_identifiers_resp *)msg->payload;
	*device_identifiers_len = le32toh(response->device_identifiers_len);

	if (*device_identifiers_len < PLDM_FWUP_DEVICE_DESCRIPTOR_MIN_LEN) {
	return PLDM_ERROR_INVALID_LENGTH;
	}

	if (payload_length !=
	sizeof(struct pldm_query_device_identifiers_resp) +
	*device_identifiers_len) {
	return PLDM_ERROR_INVALID_LENGTH;
	}
	*descriptor_count = response->descriptor_count;

	if (*descriptor_count == 0) {
	return PLDM_ERROR_INVALID_DATA;
	}
	*descriptor_data =
	(uint8_t *)(msg->payload +
	sizeof(struct pldm_query_device_identifiers_resp));
	return PLDM_SUCCESS;
	}

	int encode_get_firmware_parameters_req(uint8_t instance_id,
	size_t payload_length,
	struct pldm_msg *msg)
	{
	if (msg == NULL) {
	return PLDM_ERROR_INVALID_DATA;
	}

	if (payload_length != PLDM_GET_FIRMWARE_PARAMETERS_REQ_BYTES) {
	return PLDM_ERROR_INVALID_LENGTH;
	}

	return encode_pldm_header_only(PLDM_REQUEST, instance_id, PLDM_FWUP,
	PLDM_GET_FIRMWARE_PARAMETERS, msg);
	}

	int decode_get_firmware_parameters_resp(
	const struct pldm_msg *msg, size_t payload_length,
	struct pldm_get_firmware_parameters_resp *resp_data,
	struct variable_field *active_comp_image_set_ver_str,
	struct variable_field *pending_comp_image_set_ver_str,
	struct variable_field *comp_parameter_table)
	{
	if (msg == NULL \|\| resp_data == NULL \|\|
	active_comp_image_set_ver_str == NULL \|\|
	pending_comp_image_set_ver_str == NULL \|\|
	comp_parameter_table == NULL) {
	return PLDM_ERROR_INVALID_DATA;
	}

	if (payload_length < sizeof(struct pldm_get_firmware_parameters_resp)) {
	return PLDM_ERROR_INVALID_LENGTH;
	}

	struct pldm_get_firmware_parameters_resp *response =
	(struct pldm_get_firmware_parameters_resp *)msg->payload;

	resp_data->completion_code = response->completion_code;

	if (PLDM_SUCCESS != resp_data->completion_code) {
	return PLDM_SUCCESS;
	}

	if (!is_string_type_valid(
	response->active_comp_image_set_ver_str_type) \|\|
	(response->active_comp_image_set_ver_str_len == 0)) {
	return PLDM_ERROR_INVALID_DATA;
	}

	if (response->pending_comp_image_set_ver_str_len == 0) {
	if (response->pending_comp_image_set_ver_str_type !=
	PLDM_STR_TYPE_UNKNOWN) {
	return PLDM_ERROR_INVALID_DATA;
	}
	} else {
	if (!is_string_type_valid(
	response->pending_comp_image_set_ver_str_type)) {
	return PLDM_ERROR_INVALID_DATA;
	}
	}

	size_t partial_response_length =
	sizeof(struct pldm_get_firmware_parameters_resp) +
	response->active_comp_image_set_ver_str_len +
	response->pending_comp_image_set_ver_str_len;

	if (payload_length < partial_response_length) {
	return PLDM_ERROR_INVALID_LENGTH;
	}

	resp_data->capabilities_during_update.value =
	le32toh(response->capabilities_during_update.value);
	resp_data->comp_count = le16toh(response->comp_count);
	resp_data->active_comp_image_set_ver_str_type =
	response->active_comp_image_set_ver_str_type;
	resp_data->active_comp_image_set_ver_str_len =
	response->active_comp_image_set_ver_str_len;
	resp_data->pending_comp_image_set_ver_str_type =
	response->pending_comp_image_set_ver_str_type;
	resp_data->pending_comp_image_set_ver_str_len =
	response->pending_comp_image_set_ver_str_len;

	active_comp_image_set_ver_str->ptr =
	msg->payload + sizeof(struct pldm_get_firmware_parameters_resp);
	active_comp_image_set_ver_str->length =
	resp_data->active_comp_image_set_ver_str_len;

	if (resp_data->pending_comp_image_set_ver_str_len != 0) {
	pending_comp_image_set_ver_str->ptr =
	msg->payload +
	sizeof(struct pldm_get_firmware_parameters_resp) +
	resp_data->active_comp_image_set_ver_str_len;
	pending_comp_image_set_ver_str->length =
	resp_data->pending_comp_image_set_ver_str_len;
	} else {
	pending_comp_image_set_ver_str->ptr = NULL;
	pending_comp_image_set_ver_str->length = 0;
	}

	if (payload_length > partial_response_length && resp_data->comp_count) {
	comp_parameter_table->ptr =
	msg->payload +
	sizeof(struct pldm_get_firmware_parameters_resp) +
	resp_data->active_comp_image_set_ver_str_len +
	resp_data->pending_comp_image_set_ver_str_len;
	comp_parameter_table->length =
	payload_length - partial_response_length;
	} else {
	comp_parameter_table->ptr = NULL;
	comp_parameter_table->length = 0;
	}

	return PLDM_SUCCESS;
	}

	int decode_get_firmware_parameters_resp_comp_entry(
	const uint8_t *data, size_t length,
	struct pldm_component_parameter_entry *component_data,
	struct variable_field *active_comp_ver_str,
	struct variable_field *pending_comp_ver_str)
	{
	if (data == NULL \|\| component_data == NULL \|\|
	active_comp_ver_str == NULL \|\| pending_comp_ver_str == NULL) {
	return PLDM_ERROR_INVALID_DATA;
	}

	if (length < sizeof(struct pldm_component_parameter_entry)) {
	return PLDM_ERROR_INVALID_LENGTH;
	}

	struct pldm_component_parameter_entry *entry =
	(struct pldm_component_parameter_entry *)(data);
	if (entry->active_comp_ver_str_len == 0) {
	return PLDM_ERROR_INVALID_LENGTH;
	}

	size_t entry_length = sizeof(struct pldm_component_parameter_entry) +
	entry->active_comp_ver_str_len +
	entry->pending_comp_ver_str_len;

	if (length != entry_length) {
	return PLDM_ERROR_INVALID_LENGTH;
	}

	component_data->comp_classification =
	le16toh(entry->comp_classification);
	component_data->comp_identifier = le16toh(entry->comp_identifier);
	component_data->comp_classification_index =
	entry->comp_classification_index;
	component_data->active_comp_comparison_stamp =
	le32toh(entry->active_comp_comparison_stamp);
	component_data->active_comp_ver_str_type =
	entry->active_comp_ver_str_type;
	component_data->active_comp_ver_str_len =
	entry->active_comp_ver_str_len;
	memcpy(component_data->active_comp_release_date,
	entry->active_comp_release_date,
	sizeof(entry->active_comp_release_date));
	component_data->pending_comp_comparison_stamp =
	le32toh(entry->pending_comp_comparison_stamp);
	component_data->pending_comp_ver_str_type =
	entry->pending_comp_ver_str_type;
	component_data->pending_comp_ver_str_len =
	entry->pending_comp_ver_str_len;
	memcpy(component_data->pending_comp_release_date,
	entry->pending_comp_release_date,
	sizeof(entry->pending_comp_release_date));
	component_data->comp_activation_methods.value =
	le16toh(entry->comp_activation_methods.value);
	component_data->capabilities_during_update.value =
	le32toh(entry->capabilities_during_update.value);

	active_comp_ver_str->ptr =
	data + sizeof(struct pldm_component_parameter_entry);
	active_comp_ver_str->length = entry->active_comp_ver_str_len;

	if (entry->pending_comp_ver_str_len != 0) {

	pending_comp_ver_str->ptr =
	data + sizeof(struct pldm_component_parameter_entry) +
	entry->active_comp_ver_str_len;
	pending_comp_ver_str->length = entry->pending_comp_ver_str_len;
	} else {
	pending_comp_ver_str->ptr = NULL;
	pending_comp_ver_str->length = 0;
	}
	return PLDM_SUCCESS;
	}