blob: 4a6c18d84aa30eace34f869a1391ec0b299f4807 [file] [log] [blame]
Deepak Kodihalli9dfe89e2019-02-09 09:33:28 -06001List of maintainers for pldm
2===============================
3
4How to use this list:
5 Find the most specific section entry (described below) that matches where
6 your change lives and add the reviewers (R) and maintainers (M) as
7 reviewers. You can use the same method to track down who knows a particular
8 code base best.
9
10 Your change/query may span multiple entries; that is okay.
11
12 If you do not find an entry that describes your request at all, someone
13 forgot to update this list; please at least file an issue or send an email
14 to a maintainer, but preferably you should just update this document.
15
16Description of section entries:
17
18 Section entries are structured according to the following scheme:
19
Deepak Kodihalli17837ab2020-11-26 10:25:33 +053020 X: NAME <EMAIL_USERNAME@DOMAIN> <DISCORD_USERNAME!>
Deepak Kodihalli9dfe89e2019-02-09 09:33:28 -060021 X: ...
22 .
23 .
24 .
25
26 Where REPO_NAME is the name of the repository within the OpenBMC GitHub
27 organization; FILE_PATH is a file path within the repository, possibly with
28 wildcards; X is a tag of one of the following types:
29
Deepak Kodihalli17837ab2020-11-26 10:25:33 +053030 M: Denotes maintainer; has fields NAME <EMAIL_USERNAME@DOMAIN> <DISCORD_USERNAME!>;
Deepak Kodihalli9dfe89e2019-02-09 09:33:28 -060031 if omitted from an entry, assume one of the maintainers from the
32 MAINTAINERS entry.
Deepak Kodihalli17837ab2020-11-26 10:25:33 +053033 R: Denotes reviewer; has fields NAME <EMAIL_USERNAME@DOMAIN> <DISCORD_USERNAME!>;
Deepak Kodihalli9dfe89e2019-02-09 09:33:28 -060034 these people are to be added as reviewers for a change matching the repo
35 path.
36 F: Denotes forked from an external repository; has fields URL.
37
38 Line comments are to be denoted "# SOME COMMENT" (typical shell style
39 comment); it is important to follow the correct syntax and semantics as we
40 may want to use automated tools with this file in the future.
41
42 A change cannot be added to an OpenBMC repository without a MAINTAINER's
43 approval; thus, a MAINTAINER should always be listed as a reviewer.
44
45Change approval rules:
46
47 - Patches must be be approved (+1) by at least 1 maintainer.
48 - Patches must not have an unresolved -1 vote by any maintainer.
49 - Patches should have all maintainers added for visibility.
50 - Patches should include unit tests where possible.
Deepak Kodihalli17837ab2020-11-26 10:25:33 +053051 - Feel free to ping on DISCORD about patches that look good but have not
Deepak Kodihalli9dfe89e2019-02-09 09:33:28 -060052 received +2
John Wang4b11edd2020-02-21 15:30:13 +080053 - Wait 24 hours before doing the final submit after doing a +2 on a
54 commit and any maintainer can do the final submit
Deepak Kodihalli9dfe89e2019-02-09 09:33:28 -060055
56Design approval rules:
57
58 - Design discussions should be carried out via email with, at minimum,
59 all maintainers on the thread. It's encouraged to include the
60 OpenBMC mailing list in the thread as well.
61
62START OF MAINTAINERS LIST
63-------------------------
64
Deepak Kodihallia41853a2020-11-26 10:08:24 +053065M: Deepak Kodihalli <deepak.kodihalli.83@gmail.com> <dkodihal!>
Tom Josepha66f2e92021-04-26 03:22:05 -070066M: Tom Joseph <rushtotom@gmail.com> <tomjose!>
Patrick Williams89d29fa2021-04-16 21:42:34 -050067M: Sampa Misra <sampmisr@in.ibm.com> <sampmisr!>
George Liud38763b2021-05-17 09:27:08 +080068R: George Liu <liuxiwei@inspur.com> <George Liu!>