commit 2adcefa68e0ebad9d7900683268e8e7b1de9c088
author Patrick Williams <patrick@stwcx.xyz> Wed Nov 16 08:23:12 2016 -0600
committer Patrick Williams <patrick@stwcx.xyz> Fri Nov 18 14:26:34 2016 +0000
tree 361cc39edc2526dae2b68b4d39e611961a9fd3e9
parent 0aa0dded234b88bdcfe94ed1439709fb42053987

sdbus++: fix enumeration property default values

Current generation emits for enumerations:
    Enum property = EnumValue
Fix this to be:
    Enum property = Enum::EnumValue

Change-Id: Iae1e8e4ad73bf8623ed9f3b2d3ec57803c7f18bd
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

tools/sdbusplus/property.py

diff --git a/tools/sdbusplus/property.py b/tools/sdbusplus/property.py
index bcb50d9..0297e79 100644
--- a/tools/sdbusplus/property.py
+++ b/tools/sdbusplus/property.py
@@ -11,11 +11,18 @@
 
         super(Property, self).__init__(**kwargs)
 
+    def is_enum(self):
+        if not self.cppTypeName:
+            return False
+        if self.cppTypeName.startswith("enum<"):
+            return True
+        return False
+
     """ Return a conversion of the cppTypeName valid as a function parameter.
         Currently only 'enum' requires conversion.
     """
     def cppTypeParam(self, interface, server=True):
-        if self.cppTypeName.startswith("enum<"):
+        if self.is_enum():
             # strip off 'enum<' and '>'
             r = self.cppTypeName.split('>')[0].split('<')[1]
 
@@ -33,7 +40,7 @@
         message.  Currently only 'enum' requires conversion.
     """
     def cppTypeMessage(self, interface):
-        if self.cppTypeName.startswith("enum<"):
+        if self.is_enum():
             return "std::string"
         return self.cppTypeName
 

tools/sdbusplus/templates/interface.mako.server.hpp

diff --git a/tools/sdbusplus/templates/interface.mako.server.hpp b/tools/sdbusplus/templates/interface.mako.server.hpp
index 5a67a43..1fab15b 100644
--- a/tools/sdbusplus/templates/interface.mako.server.hpp
+++ b/tools/sdbusplus/templates/interface.mako.server.hpp
@@ -88,7 +88,11 @@
 
     % for p in interface.properties:
         % if p.defaultValue:
-        ${p.cppTypeParam(interface.name)} _${p.camelCase} = ${p.defaultValue};
+        ${p.cppTypeParam(interface.name)} _${p.camelCase} = \
+            % if p.is_enum():
+${p.cppTypeParam(interface.name)}::\
+            % endif
+${p.defaultValue};
         % else:
         ${p.cppTypeParam(interface.name)} _${p.camelCase}{};
         % endif