commit 651e87ad362e55ed4e34e6565fd0674390941a58
author William A. Kennington III <wak@google.com> Tue Dec 11 16:45:37 2018 -0800
committer William A. Kennington III <wak@google.com> Thu Dec 13 15:22:36 2018 -0800
tree 38903c0c1552b65629fad3a5839a5615b1e3d787
parent d4b33e95f6b9bf9a2e1ad41f371fa602a49989a5

clang-tidy: Basic configuration

This also cleans up some outstanding issues detected by the
configuration.

Tested:
    Ran through unit test scripts.

Change-Id: I3357a2280a681a87532d6d72315260db2ab73e87
Signed-off-by: William A. Kennington III <wak@google.com>

.clang-tidy

diff --git a/.clang-tidy b/.clang-tidy
new file mode 100644
index 0000000..f6ee139
--- /dev/null
+++ b/.clang-tidy
@@ -0,0 +1 @@
+Checks: 'clang-analyzer-*'

test/internal/sdref.cpp

diff --git a/test/internal/sdref.cpp b/test/internal/sdref.cpp
index 3b261d5..e8effa9 100644
--- a/test/internal/sdref.cpp
+++ b/test/internal/sdref.cpp
@@ -216,7 +216,14 @@
     EXPECT_TRUE(event);
     EXPECT_EQ(expected_event, event.get());
 
+#if defined(__clang__)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wself-move"
+#endif
     event = std::move(event);
+#if defined(__clang__)
+#pragma clang diagnostic pop
+#endif
     EXPECT_TRUE(event);
     EXPECT_EQ(expected_event, event.get());
     EXPECT_CALL(mock, sd_event_unref(expected_event))

test/source/base.cpp

diff --git a/test/source/base.cpp b/test/source/base.cpp
index df855c1..75a6dde 100644
--- a/test/source/base.cpp
+++ b/test/source/base.cpp
@@ -327,7 +327,7 @@
 {
     EXPECT_CALL(mock, sd_event_source_set_prepare(expected_source, testing::_))
         .WillOnce(Return(0));
-    base->set_prepare(std::move([](Base&) {}));
+    base->set_prepare([](Base&) {});
     EXPECT_TRUE(base->get_prepare());
 
     Base::Callback callback = [](Base&) {};
@@ -342,7 +342,7 @@
 {
     EXPECT_CALL(mock, sd_event_source_set_prepare(expected_source, testing::_))
         .WillOnce(Return(0));
-    base->set_prepare(std::move([](Base&) {}));
+    base->set_prepare([](Base&) {});
     EXPECT_TRUE(base->get_prepare());
 
     EXPECT_CALL(mock, sd_event_source_set_prepare(expected_source, nullptr))