Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 1 | #include "dbus_environment.hpp" |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 2 | #include "helpers.hpp" |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 3 | #include "mocks/sensor_listener_mock.hpp" |
| 4 | #include "sensor.hpp" |
| 5 | #include "sensor_cache.hpp" |
| 6 | #include "stubs/dbus_sensor_object.hpp" |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 7 | #include "utils/clock.hpp" |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 8 | |
| 9 | #include <sdbusplus/asio/property.hpp> |
| 10 | |
| 11 | #include <thread> |
| 12 | |
| 13 | #include <gmock/gmock.h> |
| 14 | |
| 15 | using namespace testing; |
| 16 | using namespace std::chrono_literals; |
| 17 | |
| 18 | class TestSensor : public Test |
| 19 | { |
| 20 | public: |
| 21 | void SetUp() override |
| 22 | { |
Wludzik, Jozef | 5ade2b1 | 2020-11-16 14:00:23 +0100 | [diff] [blame] | 23 | sensorObject->setValue(42.7); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 24 | } |
| 25 | |
| 26 | void TearDown() override |
| 27 | { |
| 28 | DbusEnvironment::synchronizeIoc(); |
| 29 | } |
| 30 | |
| 31 | void |
| 32 | registerForUpdates(std::shared_ptr<interfaces::SensorListener> listener) |
| 33 | { |
Wludzik, Jozef | 5ade2b1 | 2020-11-16 14:00:23 +0100 | [diff] [blame] | 34 | sut->registerForUpdates(listener); |
| 35 | DbusEnvironment::synchronizeIoc(); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 36 | } |
| 37 | |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 38 | void unregisterFromUpdates( |
| 39 | std::shared_ptr<interfaces::SensorListener> listener) |
| 40 | { |
| 41 | sut->unregisterFromUpdates(listener); |
| 42 | DbusEnvironment::synchronizeIoc(); |
| 43 | } |
| 44 | |
Wludzik, Jozef | 5ade2b1 | 2020-11-16 14:00:23 +0100 | [diff] [blame] | 45 | static std::unique_ptr<stubs::DbusSensorObject> makeSensorObject() |
| 46 | { |
| 47 | return std::make_unique<stubs::DbusSensorObject>( |
| 48 | DbusEnvironment::getIoc(), DbusEnvironment::getBus(), |
| 49 | DbusEnvironment::getObjServer()); |
| 50 | } |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 51 | |
Wludzik, Jozef | 5ade2b1 | 2020-11-16 14:00:23 +0100 | [diff] [blame] | 52 | std::unique_ptr<stubs::DbusSensorObject> sensorObject = makeSensorObject(); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 53 | |
| 54 | SensorCache sensorCache; |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame^] | 55 | Milliseconds timestamp = Clock().steadyTimestamp(); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 56 | std::shared_ptr<Sensor> sut = sensorCache.makeSensor<Sensor>( |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 57 | DbusEnvironment::serviceName(), sensorObject->path(), "metadata", |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 58 | DbusEnvironment::getIoc(), DbusEnvironment::getBus()); |
| 59 | std::shared_ptr<SensorListenerMock> listenerMock = |
| 60 | std::make_shared<StrictMock<SensorListenerMock>>(); |
| 61 | std::shared_ptr<SensorListenerMock> listenerMock2 = |
| 62 | std::make_shared<StrictMock<SensorListenerMock>>(); |
Wludzik, Jozef | 5ade2b1 | 2020-11-16 14:00:23 +0100 | [diff] [blame] | 63 | MockFunction<void()> checkPoint; |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 64 | }; |
| 65 | |
| 66 | TEST_F(TestSensor, createsCorretlyViaSensorCache) |
| 67 | { |
| 68 | ASSERT_THAT(sut->id(), |
Krzysztof Grobelny | 6ccfcbf | 2020-11-04 09:31:36 +0100 | [diff] [blame] | 69 | Eq(Sensor::Id("Sensor", DbusEnvironment::serviceName(), |
Wludzik, Jozef | 5ade2b1 | 2020-11-16 14:00:23 +0100 | [diff] [blame] | 70 | sensorObject->path()))); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 71 | } |
| 72 | |
| 73 | TEST_F(TestSensor, notifiesWithValueAfterRegister) |
| 74 | { |
| 75 | EXPECT_CALL(*listenerMock, sensorUpdated(Ref(*sut), Ge(timestamp), 42.7)) |
Wludzik, Jozef | 0e29f43 | 2020-11-17 08:22:33 +0100 | [diff] [blame] | 76 | .WillOnce(InvokeWithoutArgs(DbusEnvironment::setPromise("async_read"))); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 77 | |
| 78 | registerForUpdates(listenerMock); |
| 79 | |
| 80 | ASSERT_TRUE(DbusEnvironment::waitForFuture("async_read")); |
| 81 | } |
| 82 | |
| 83 | TEST_F(TestSensor, notifiesOnceWithValueAfterRegister) |
| 84 | { |
| 85 | EXPECT_CALL(*listenerMock, sensorUpdated(Ref(*sut), Ge(timestamp), 42.7)) |
Wludzik, Jozef | 0e29f43 | 2020-11-17 08:22:33 +0100 | [diff] [blame] | 86 | .WillOnce(InvokeWithoutArgs(DbusEnvironment::setPromise("async_read"))); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 87 | EXPECT_CALL(*listenerMock2, sensorUpdated(Ref(*sut), Ge(timestamp), 42.7)) |
Wludzik, Jozef | 0e29f43 | 2020-11-17 08:22:33 +0100 | [diff] [blame] | 88 | .WillOnce( |
| 89 | InvokeWithoutArgs(DbusEnvironment::setPromise("async_read2"))); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 90 | |
| 91 | DbusEnvironment::synchronizedPost([this] { |
| 92 | sut->registerForUpdates(listenerMock); |
| 93 | sut->registerForUpdates(listenerMock2); |
| 94 | }); |
| 95 | |
| 96 | ASSERT_TRUE(DbusEnvironment::waitForFuture("async_read")); |
| 97 | ASSERT_TRUE(DbusEnvironment::waitForFuture("async_read2")); |
| 98 | } |
| 99 | |
| 100 | class TestSensorNotification : public TestSensor |
| 101 | { |
| 102 | public: |
| 103 | void SetUp() override |
| 104 | { |
| 105 | EXPECT_CALL(*listenerMock, sensorUpdated(Ref(*sut), Ge(timestamp), 0.)) |
Wludzik, Jozef | 0e29f43 | 2020-11-17 08:22:33 +0100 | [diff] [blame] | 106 | .WillOnce( |
| 107 | InvokeWithoutArgs(DbusEnvironment::setPromise("async_read"))); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 108 | |
| 109 | registerForUpdates(listenerMock); |
| 110 | |
| 111 | ASSERT_TRUE(DbusEnvironment::waitForFuture("async_read")); |
| 112 | } |
| 113 | |
| 114 | std::shared_ptr<SensorListenerMock> listenerMock2 = |
| 115 | std::make_shared<StrictMock<SensorListenerMock>>(); |
| 116 | }; |
| 117 | |
| 118 | TEST_F(TestSensorNotification, notifiesListenerWithValueWhenChangeOccurs) |
| 119 | { |
| 120 | EXPECT_CALL(*listenerMock, sensorUpdated(Ref(*sut), Ge(timestamp), 42.7)) |
Wludzik, Jozef | 0e29f43 | 2020-11-17 08:22:33 +0100 | [diff] [blame] | 121 | .WillOnce(InvokeWithoutArgs(DbusEnvironment::setPromise("notify"))); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 122 | |
Wludzik, Jozef | 5ade2b1 | 2020-11-16 14:00:23 +0100 | [diff] [blame] | 123 | sensorObject->setValue(42.7); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 124 | |
| 125 | ASSERT_TRUE(DbusEnvironment::waitForFuture("notify")); |
| 126 | } |
| 127 | |
| 128 | TEST_F(TestSensorNotification, notifiesListenerWithValueWhenNoChangeOccurs) |
| 129 | { |
Wludzik, Jozef | 5ade2b1 | 2020-11-16 14:00:23 +0100 | [diff] [blame] | 130 | InSequence seq; |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 131 | |
Wludzik, Jozef | 5ade2b1 | 2020-11-16 14:00:23 +0100 | [diff] [blame] | 132 | EXPECT_CALL(*listenerMock, sensorUpdated(Ref(*sut), Ge(timestamp), 42.7)); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 133 | EXPECT_CALL(*listenerMock, sensorUpdated(Ref(*sut), Ge(timestamp))) |
Wludzik, Jozef | 0e29f43 | 2020-11-17 08:22:33 +0100 | [diff] [blame] | 134 | .WillOnce(InvokeWithoutArgs(DbusEnvironment::setPromise("notify"))); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 135 | |
Wludzik, Jozef | 5ade2b1 | 2020-11-16 14:00:23 +0100 | [diff] [blame] | 136 | sensorObject->setValue(42.7); |
| 137 | sensorObject->setValue(42.7); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 138 | |
| 139 | ASSERT_TRUE(DbusEnvironment::waitForFuture("notify")); |
| 140 | } |
| 141 | |
| 142 | TEST_F(TestSensorNotification, doesntNotifyExpiredListener) |
| 143 | { |
Wludzik, Jozef | 5ade2b1 | 2020-11-16 14:00:23 +0100 | [diff] [blame] | 144 | InSequence seq; |
| 145 | EXPECT_CALL(*listenerMock2, sensorUpdated(Ref(*sut), Ge(timestamp), 0.)); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 146 | EXPECT_CALL(*listenerMock2, sensorUpdated(Ref(*sut), Ge(timestamp), 42.7)) |
Wludzik, Jozef | 0e29f43 | 2020-11-17 08:22:33 +0100 | [diff] [blame] | 147 | .WillOnce(InvokeWithoutArgs(DbusEnvironment::setPromise("notify"))); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 148 | |
| 149 | registerForUpdates(listenerMock2); |
| 150 | listenerMock = nullptr; |
| 151 | |
Wludzik, Jozef | 5ade2b1 | 2020-11-16 14:00:23 +0100 | [diff] [blame] | 152 | sensorObject->setValue(42.7); |
Krzysztof Grobelny | b564594 | 2020-09-29 11:52:45 +0200 | [diff] [blame] | 153 | |
| 154 | ASSERT_TRUE(DbusEnvironment::waitForFuture("notify")); |
| 155 | } |
| 156 | |
| 157 | TEST_F(TestSensorNotification, notifiesWithValueDuringRegister) |
| 158 | { |
| 159 | EXPECT_CALL(*listenerMock2, sensorUpdated(Ref(*sut), Ge(timestamp), 0.)); |
| 160 | |
| 161 | registerForUpdates(listenerMock2); |
| 162 | } |
Wludzik, Jozef | 5ade2b1 | 2020-11-16 14:00:23 +0100 | [diff] [blame] | 163 | |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 164 | TEST_F(TestSensorNotification, notNotifiesWithValueWhenUnregistered) |
| 165 | { |
| 166 | EXPECT_CALL(*listenerMock2, sensorUpdated(Ref(*sut), Ge(timestamp), 0.)); |
| 167 | EXPECT_CALL(*listenerMock, sensorUpdated(Ref(*sut), Ge(timestamp), 42.7)) |
| 168 | .Times(0); |
| 169 | EXPECT_CALL(*listenerMock2, sensorUpdated(Ref(*sut), Ge(timestamp), 42.7)) |
| 170 | .WillOnce(InvokeWithoutArgs(DbusEnvironment::setPromise("notify"))); |
| 171 | |
| 172 | registerForUpdates(listenerMock2); |
| 173 | unregisterFromUpdates(listenerMock); |
| 174 | |
| 175 | sensorObject->setValue(42.7); |
| 176 | |
| 177 | ASSERT_TRUE(DbusEnvironment::waitForFuture("notify")); |
| 178 | } |
| 179 | |
Wludzik, Jozef | 5ade2b1 | 2020-11-16 14:00:23 +0100 | [diff] [blame] | 180 | TEST_F(TestSensorNotification, |
| 181 | dbusSensorIsAddedToSystemAfterSensorIsCreatedThenValueIsUpdated) |
| 182 | { |
| 183 | InSequence seq; |
| 184 | |
| 185 | EXPECT_CALL(*listenerMock, |
| 186 | sensorUpdated(Ref(*sut), Ge(timestamp), DoubleEq(42.7))) |
| 187 | .WillOnce( |
| 188 | InvokeWithoutArgs(DbusEnvironment::setPromise("notify-change"))); |
| 189 | EXPECT_CALL(checkPoint, Call()); |
| 190 | EXPECT_CALL(*listenerMock, |
| 191 | sensorUpdated(Ref(*sut), Ge(timestamp), DoubleEq(0.))) |
| 192 | .WillOnce( |
| 193 | InvokeWithoutArgs(DbusEnvironment::setPromise("notify-create"))); |
| 194 | |
| 195 | sensorObject->setValue(42.7); |
| 196 | DbusEnvironment::waitForFuture("notify-change"); |
| 197 | |
| 198 | checkPoint.Call(); |
| 199 | |
| 200 | sensorObject = nullptr; |
| 201 | sensorObject = makeSensorObject(); |
| 202 | DbusEnvironment::waitForFuture("notify-create"); |
| 203 | } |