Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 1 | #include "dbus_environment.hpp" |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 2 | #include "helpers.hpp" |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 3 | #include "interfaces/trigger_manager.hpp" |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 4 | #include "mocks/json_storage_mock.hpp" |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 5 | #include "mocks/report_factory_mock.hpp" |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 6 | #include "mocks/trigger_manager_mock.hpp" |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 7 | #include "params/report_params.hpp" |
| 8 | #include "report.hpp" |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 9 | #include "report_manager.hpp" |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 10 | #include "utils/conversion.hpp" |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 11 | #include "utils/transform.hpp" |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 12 | |
| 13 | using namespace testing; |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 14 | using namespace std::string_literals; |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 15 | using namespace std::chrono_literals; |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 16 | |
| 17 | class TestReportManager : public Test |
| 18 | { |
| 19 | public: |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 20 | ReportParams reportParams; |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 21 | |
| 22 | std::unique_ptr<ReportFactoryMock> reportFactoryMockPtr = |
| 23 | std::make_unique<StrictMock<ReportFactoryMock>>(); |
| 24 | ReportFactoryMock& reportFactoryMock = *reportFactoryMockPtr; |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 25 | |
| 26 | std::unique_ptr<StorageMock> storageMockPtr = |
| 27 | std::make_unique<NiceMock<StorageMock>>(); |
| 28 | StorageMock& storageMock = *storageMockPtr; |
| 29 | |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 30 | std::unique_ptr<ReportMock> reportMockPtr = |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 31 | std::make_unique<NiceMock<ReportMock>>(reportParams.reportId()); |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 32 | ReportMock& reportMock = *reportMockPtr; |
| 33 | |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 34 | std::unique_ptr<interfaces::TriggerManager> triggerManagerMockPtr = |
| 35 | std::make_unique<NiceMock<TriggerManagerMock>>(); |
| 36 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 37 | std::unique_ptr<ReportManager> sut; |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 38 | |
| 39 | MockFunction<void(std::string)> checkPoint; |
| 40 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 41 | void SetUp() override |
| 42 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 43 | EXPECT_CALL(reportFactoryMock, convertMetricParams(_, _)) |
| 44 | .Times(AnyNumber()); |
| 45 | |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 46 | sut = std::make_unique<ReportManager>( |
| 47 | std::move(reportFactoryMockPtr), std::move(storageMockPtr), |
| 48 | DbusEnvironment::getObjServer(), triggerManagerMockPtr); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 49 | } |
| 50 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 51 | void TearDown() override |
| 52 | { |
| 53 | DbusEnvironment::synchronizeIoc(); |
| 54 | } |
| 55 | |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 56 | template <class... Args> |
| 57 | requires(sizeof...(Args) > 1) |
| 58 | std::pair<boost::system::error_code, std::string> addReport( |
| 59 | Args&&... args) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 60 | { |
| 61 | std::promise<std::pair<boost::system::error_code, std::string>> |
| 62 | addReportPromise; |
| 63 | DbusEnvironment::getBus()->async_method_call( |
| 64 | [&addReportPromise](boost::system::error_code ec, |
| 65 | const std::string& path) { |
| 66 | addReportPromise.set_value({ec, path}); |
| 67 | }, |
| 68 | DbusEnvironment::serviceName(), ReportManager::reportManagerPath, |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 69 | ReportManager::reportManagerIfaceName, "AddReportFutureVersion", |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 70 | std::forward<Args>(args)...); |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 71 | return DbusEnvironment::waitForFuture(addReportPromise.get_future()); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 72 | } |
| 73 | |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 74 | auto addReport(const ReportParams& params) |
| 75 | { |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 76 | return addReport(params.reportId(), params.reportName(), |
| 77 | utils::enumToString(params.reportingType()), |
| 78 | utils::enumToString(params.reportUpdates()), |
| 79 | params.appendLimit(), |
| 80 | utils::transform(params.reportActions(), |
| 81 | [](const auto v) { |
| 82 | return utils::enumToString(v); |
| 83 | }), |
| 84 | params.interval().count(), |
| 85 | toReadingParameters(params.metricParameters())); |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 86 | } |
| 87 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 88 | template <class T> |
Szymon Dompke | e28aa53 | 2021-10-27 12:33:12 +0200 | [diff] [blame] | 89 | static T getProperty(const std::string& property) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 90 | { |
Szymon Dompke | e28aa53 | 2021-10-27 12:33:12 +0200 | [diff] [blame] | 91 | return DbusEnvironment::getProperty<T>( |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 92 | ReportManager::reportManagerPath, |
Szymon Dompke | e28aa53 | 2021-10-27 12:33:12 +0200 | [diff] [blame] | 93 | ReportManager::reportManagerIfaceName, property); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 94 | } |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 95 | }; |
| 96 | |
| 97 | TEST_F(TestReportManager, minInterval) |
| 98 | { |
| 99 | EXPECT_THAT(getProperty<uint64_t>("MinInterval"), |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 100 | Eq(ReportManager::minInterval.count())); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 101 | } |
| 102 | |
| 103 | TEST_F(TestReportManager, maxReports) |
| 104 | { |
Wludzik, Jozef | 503c158 | 2020-12-11 14:48:01 +0100 | [diff] [blame] | 105 | EXPECT_THAT(getProperty<size_t>("MaxReports"), |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 106 | Eq(ReportManager::maxReports)); |
| 107 | } |
| 108 | |
| 109 | TEST_F(TestReportManager, addReport) |
| 110 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 111 | EXPECT_CALL(reportFactoryMock, convertMetricParams(_, _)); |
| 112 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 113 | .WillOnce(Return(ByMove(std::move(reportMockPtr)))); |
| 114 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 115 | auto [ec, path] = addReport(reportParams); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 116 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::success)); |
| 117 | EXPECT_THAT(path, Eq(reportMock.getPath())); |
| 118 | } |
| 119 | |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 120 | TEST_F(TestReportManager, nameIsUsedToGenerateIdWhenIdIsEmptyInAddReport) |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 121 | { |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 122 | reportParams.reportId("ReportName"); |
| 123 | reportParams.reportName("ReportName"); |
| 124 | |
| 125 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)); |
| 126 | |
| 127 | auto [ec, path] = addReport(reportParams.reportId("")); |
| 128 | |
| 129 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::success)); |
| 130 | EXPECT_THAT(path, Eq("/ReportName")); |
| 131 | } |
| 132 | |
| 133 | TEST_F(TestReportManager, nameIsUsedToGenerateIdWhenIdIsNamespace) |
| 134 | { |
| 135 | reportParams.reportId("Prefix/ReportName"); |
| 136 | reportParams.reportName("ReportName"); |
| 137 | |
| 138 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)); |
| 139 | |
| 140 | auto [ec, path] = addReport(reportParams.reportId("Prefix/")); |
| 141 | |
| 142 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::success)); |
| 143 | EXPECT_THAT(path, Eq("/Prefix/ReportName")); |
| 144 | } |
| 145 | |
| 146 | TEST_F(TestReportManager, addReportWithMaxLengthId) |
| 147 | { |
| 148 | std::string reportId(ReportManager::maxReportIdLength, 'z'); |
| 149 | reportParams.reportId(reportId); |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 150 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 151 | |
| 152 | auto [ec, path] = addReport(reportParams); |
| 153 | |
| 154 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::success)); |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 155 | EXPECT_THAT(path, Eq("/"s + reportId)); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 156 | } |
| 157 | |
| 158 | TEST_F(TestReportManager, DISABLED_failToAddReportWithTooLongName) |
| 159 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 160 | reportFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock)) |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 161 | .Times(0); |
| 162 | |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 163 | reportParams.reportId( |
| 164 | std::string(ReportManager::maxReportIdLength + 1, 'z')); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 165 | |
| 166 | auto [ec, path] = addReport(reportParams); |
| 167 | |
| 168 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::invalid_argument)); |
| 169 | EXPECT_THAT(path, Eq(std::string())); |
| 170 | } |
| 171 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 172 | TEST_F(TestReportManager, DISABLED_failToAddReportTwice) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 173 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 174 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)) |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 175 | .WillOnce(Return(ByMove(std::move(reportMockPtr)))); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 176 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 177 | addReport(reportParams); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 178 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 179 | auto [ec, path] = addReport(reportParams); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 180 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 181 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::file_exists)); |
| 182 | EXPECT_THAT(path, Eq(std::string())); |
| 183 | } |
| 184 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 185 | TEST_F(TestReportManager, DISABLED_failToAddReportWithInvalidInterval) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 186 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 187 | reportFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock)) |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 188 | .Times(0); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 189 | |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 190 | reportParams.reportingType(ReportingType::periodic); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 191 | reportParams.interval(reportParams.interval() - 1ms); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 192 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 193 | auto [ec, path] = addReport(reportParams); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 194 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 195 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::invalid_argument)); |
| 196 | EXPECT_THAT(path, Eq(std::string())); |
| 197 | } |
| 198 | |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 199 | TEST_F(TestReportManager, DISABLED_failToAddReportWithInvalidReportingType) |
| 200 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 201 | reportFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock)) |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 202 | .Times(0); |
| 203 | |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 204 | auto [ec, path] = addReport( |
| 205 | reportParams.reportName(), "InvalidReportingType", |
| 206 | utils::transform(reportParams.reportActions(), |
| 207 | [](const auto v) { return utils::enumToString(v); }), |
| 208 | reportParams.interval().count(), |
| 209 | toReadingParameters(reportParams.metricParameters())); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 210 | |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 211 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::invalid_argument)); |
| 212 | EXPECT_THAT(path, Eq(std::string())); |
| 213 | } |
| 214 | |
Ankita Vilas Gawade | cd5b0b7 | 2022-01-20 20:55:04 +0000 | [diff] [blame] | 215 | TEST_F(TestReportManager, |
| 216 | DISABLED_failToAddReportWithMoreMetricPropertiesThanExpected) |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 217 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 218 | reportFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock)) |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 219 | .Times(0); |
| 220 | |
Ankita Vilas Gawade | cd5b0b7 | 2022-01-20 20:55:04 +0000 | [diff] [blame] | 221 | reportParams.metricParameters( |
| 222 | std::vector<LabeledMetricParameters>{{LabeledMetricParameters{ |
Szymon Dompke | 94f71c5 | 2021-12-10 07:16:33 +0100 | [diff] [blame] | 223 | {LabeledSensorInfo{"Service", |
| 224 | "/xyz/openbmc_project/sensors/power/p1", |
| 225 | "Metadata1"}}, |
Ankita Vilas Gawade | cd5b0b7 | 2022-01-20 20:55:04 +0000 | [diff] [blame] | 226 | OperationType::single, |
| 227 | "MetricId1", |
| 228 | CollectionTimeScope::point, |
| 229 | CollectionDuration(Milliseconds(0u))}}}); |
| 230 | |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 231 | auto metricParams = reportParams.metricParameters(); |
Ankita Vilas Gawade | cd5b0b7 | 2022-01-20 20:55:04 +0000 | [diff] [blame] | 232 | auto& metricParamsVec = |
| 233 | metricParams[0].at_label<utils::tstring::SensorPath>(); |
| 234 | |
| 235 | for (size_t i = 0; i < ReportManager::maxNumberMetrics; i++) |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 236 | { |
Szymon Dompke | 94f71c5 | 2021-12-10 07:16:33 +0100 | [diff] [blame] | 237 | metricParamsVec.emplace_back(LabeledSensorInfo{ |
Ankita Vilas Gawade | cd5b0b7 | 2022-01-20 20:55:04 +0000 | [diff] [blame] | 238 | "Service", "/xyz/openbmc_project/sensors/power/p1", "Metadata1"}); |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 239 | } |
Ankita Vilas Gawade | cd5b0b7 | 2022-01-20 20:55:04 +0000 | [diff] [blame] | 240 | |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 241 | reportParams.metricParameters(std::move(metricParams)); |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 242 | |
| 243 | auto [ec, path] = addReport(reportParams); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 244 | |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 245 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::argument_list_too_long)); |
| 246 | EXPECT_THAT(path, Eq(std::string())); |
| 247 | } |
| 248 | |
Ankita Vilas Gawade | cd5b0b7 | 2022-01-20 20:55:04 +0000 | [diff] [blame] | 249 | TEST_F(TestReportManager, DISABLED_failToAddReportWithMoreMetricsThanExpected) |
| 250 | { |
| 251 | reportFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock)) |
| 252 | .Times(0); |
| 253 | |
| 254 | auto metricParams = std::vector<LabeledMetricParameters>{}; |
| 255 | |
| 256 | for (size_t i = 0; i < ReportManager::maxNumberMetrics + 1; i++) |
| 257 | { |
| 258 | metricParams.emplace_back( |
| 259 | LabeledMetricParameters{{}, |
| 260 | OperationType::single, |
| 261 | "MetricId1", |
| 262 | CollectionTimeScope::point, |
| 263 | CollectionDuration(Milliseconds(0u))}); |
| 264 | } |
| 265 | |
| 266 | reportParams.metricParameters(std::move(metricParams)); |
| 267 | |
| 268 | auto [ec, path] = addReport(reportParams); |
| 269 | |
| 270 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::argument_list_too_long)); |
| 271 | EXPECT_THAT(path, Eq(std::string())); |
| 272 | } |
| 273 | |
| 274 | TEST_F(TestReportManager, DISABLED_failToAddReportWithAppendLimitGreaterThanMax) |
| 275 | { |
| 276 | reportFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock)) |
| 277 | .Times(0); |
| 278 | |
| 279 | reportParams.appendLimit(ReportManager::maxAppendLimit + 1); |
| 280 | |
| 281 | auto [ec, path] = addReport(reportParams); |
| 282 | |
| 283 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::invalid_argument)); |
| 284 | EXPECT_THAT(path, Eq(std::string())); |
| 285 | } |
| 286 | |
Krzysztof Grobelny | e6c417c | 2022-02-02 17:25:53 +0100 | [diff] [blame] | 287 | TEST_F(TestReportManager, addReportWithAppendLimitEqualToUint64MaxIsAllowed) |
| 288 | { |
| 289 | reportParams.appendLimit(std::numeric_limits<uint64_t>::max()); |
| 290 | |
| 291 | EXPECT_CALL(reportFactoryMock, convertMetricParams(_, _)); |
| 292 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)) |
| 293 | .WillOnce(Return(ByMove(std::move(reportMockPtr)))); |
| 294 | |
| 295 | auto [ec, path] = addReport(reportParams); |
| 296 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::success)); |
| 297 | EXPECT_THAT(path, Eq(reportMock.getPath())); |
| 298 | } |
| 299 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 300 | TEST_F(TestReportManager, DISABLED_failToAddReportWhenMaxReportIsReached) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 301 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 302 | reportFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock)) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 303 | .Times(ReportManager::maxReports); |
| 304 | |
| 305 | for (size_t i = 0; i < ReportManager::maxReports; i++) |
| 306 | { |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 307 | reportParams.reportId(reportParams.reportName() + std::to_string(i)); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 308 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 309 | auto [ec, path] = addReport(reportParams); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 310 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::success)); |
| 311 | } |
| 312 | |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 313 | reportParams.reportId(reportParams.reportName() + |
| 314 | std::to_string(ReportManager::maxReports)); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 315 | auto [ec, path] = addReport(reportParams); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 316 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 317 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::too_many_files_open)); |
| 318 | EXPECT_THAT(path, Eq(std::string())); |
| 319 | } |
| 320 | |
| 321 | TEST_F(TestReportManager, removeReport) |
| 322 | { |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 323 | { |
| 324 | InSequence seq; |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 325 | EXPECT_CALL(reportFactoryMock, convertMetricParams(_, _)); |
| 326 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 327 | .WillOnce(Return(ByMove(std::move(reportMockPtr)))); |
| 328 | EXPECT_CALL(reportMock, Die()); |
| 329 | EXPECT_CALL(checkPoint, Call("end")); |
| 330 | } |
| 331 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 332 | addReport(reportParams); |
| 333 | sut->removeReport(&reportMock); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 334 | checkPoint.Call("end"); |
| 335 | } |
| 336 | |
| 337 | TEST_F(TestReportManager, removingReportThatIsNotInContainerHasNoEffect) |
| 338 | { |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 339 | { |
| 340 | InSequence seq; |
| 341 | EXPECT_CALL(checkPoint, Call("end")); |
| 342 | EXPECT_CALL(reportMock, Die()); |
| 343 | } |
| 344 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 345 | sut->removeReport(&reportMock); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 346 | checkPoint.Call("end"); |
| 347 | } |
| 348 | |
| 349 | TEST_F(TestReportManager, removingSameReportTwiceHasNoSideEffect) |
| 350 | { |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 351 | { |
| 352 | InSequence seq; |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 353 | EXPECT_CALL(reportFactoryMock, convertMetricParams(_, _)); |
| 354 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 355 | .WillOnce(Return(ByMove(std::move(reportMockPtr)))); |
| 356 | EXPECT_CALL(reportMock, Die()); |
| 357 | EXPECT_CALL(checkPoint, Call("end")); |
| 358 | } |
| 359 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 360 | addReport(reportParams); |
| 361 | sut->removeReport(&reportMock); |
| 362 | sut->removeReport(&reportMock); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 363 | checkPoint.Call("end"); |
| 364 | } |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 365 | |
Wludzik, Jozef | d960e1f | 2021-01-08 09:25:59 +0100 | [diff] [blame] | 366 | TEST_F(TestReportManager, updateReportCallsUpdateReadingsForExistReport) |
| 367 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 368 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)) |
Wludzik, Jozef | d960e1f | 2021-01-08 09:25:59 +0100 | [diff] [blame] | 369 | .WillOnce(Return(ByMove(std::move(reportMockPtr)))); |
| 370 | EXPECT_CALL(reportMock, updateReadings()); |
| 371 | |
| 372 | addReport(reportParams); |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 373 | sut->updateReport(reportParams.reportId()); |
Wludzik, Jozef | d960e1f | 2021-01-08 09:25:59 +0100 | [diff] [blame] | 374 | } |
| 375 | |
| 376 | TEST_F(TestReportManager, updateReportDoNothingIfReportDoesNotExist) |
| 377 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 378 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)) |
Wludzik, Jozef | d960e1f | 2021-01-08 09:25:59 +0100 | [diff] [blame] | 379 | .WillOnce(Return(ByMove(std::move(reportMockPtr)))); |
| 380 | EXPECT_CALL(reportMock, updateReadings()).Times(0); |
| 381 | |
| 382 | addReport(reportParams); |
| 383 | sut->updateReport("NotAReport"); |
| 384 | } |
| 385 | |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 386 | TEST_F(TestReportManager, updateTriggerIdsUpdatesThemForExistReport) |
| 387 | { |
| 388 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)) |
| 389 | .WillOnce(Return(ByMove(std::move(reportMockPtr)))); |
| 390 | EXPECT_CALL(reportMock, updateTriggerIds("Trigger1", TriggerIdUpdate::Add)); |
| 391 | EXPECT_CALL(reportMock, |
| 392 | updateTriggerIds("Trigger2", TriggerIdUpdate::Remove)); |
| 393 | |
| 394 | addReport(reportParams); |
| 395 | sut->updateTriggerIds(reportParams.reportId(), "Trigger1", |
| 396 | TriggerIdUpdate::Add); |
| 397 | |
| 398 | sut->updateTriggerIds(reportParams.reportId(), "Trigger2", |
| 399 | TriggerIdUpdate::Remove); |
| 400 | } |
| 401 | |
| 402 | TEST_F(TestReportManager, updateTriggerIdsDoNothingIfReportDoesNotExist) |
| 403 | { |
| 404 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)) |
| 405 | .WillOnce(Return(ByMove(std::move(reportMockPtr)))); |
| 406 | EXPECT_CALL(reportMock, updateTriggerIds(_, _)).Times(0); |
| 407 | |
| 408 | addReport(reportParams); |
| 409 | sut->updateTriggerIds("NotAReport", "Trigger1", TriggerIdUpdate::Add); |
| 410 | } |
| 411 | |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 412 | class TestReportManagerWithAggregationOperationType : |
| 413 | public TestReportManager, |
| 414 | public WithParamInterface<OperationType> |
| 415 | { |
| 416 | public: |
| 417 | OperationType operationType = GetParam(); |
| 418 | }; |
| 419 | |
| 420 | INSTANTIATE_TEST_SUITE_P(_, TestReportManagerWithAggregationOperationType, |
| 421 | Values(OperationType::single, OperationType::max, |
| 422 | OperationType::min, OperationType::avg, |
| 423 | OperationType::sum)); |
| 424 | |
| 425 | TEST_P(TestReportManagerWithAggregationOperationType, |
| 426 | addReportWithDifferentOperationTypes) |
| 427 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 428 | reportParams.metricParameters( |
| 429 | std::vector<LabeledMetricParameters>{{LabeledMetricParameters{ |
Szymon Dompke | 94f71c5 | 2021-12-10 07:16:33 +0100 | [diff] [blame] | 430 | {LabeledSensorInfo{"Service", |
| 431 | "/xyz/openbmc_project/sensors/power/p1", |
| 432 | "Metadata1"}}, |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 433 | operationType, |
| 434 | "MetricId1", |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 435 | CollectionTimeScope::point, |
| 436 | CollectionDuration(Milliseconds(0u))}}}); |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 437 | |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 438 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)) |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 439 | .WillOnce(Return(ByMove(std::move(reportMockPtr)))); |
| 440 | |
| 441 | auto [ec, path] = addReport(reportParams); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 442 | |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 443 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::success)); |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 444 | EXPECT_THAT(path, Eq("/"s + reportParams.reportId())); |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 445 | } |
| 446 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 447 | class TestReportManagerStorage : public TestReportManager |
| 448 | { |
| 449 | public: |
| 450 | using FilePath = interfaces::JsonStorage::FilePath; |
| 451 | using DirectoryPath = interfaces::JsonStorage::DirectoryPath; |
| 452 | |
| 453 | void SetUp() override |
| 454 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 455 | EXPECT_CALL(reportFactoryMock, convertMetricParams(_, _)).Times(0); |
| 456 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 457 | ON_CALL(storageMock, list()) |
| 458 | .WillByDefault(Return(std::vector<FilePath>{FilePath("report1")})); |
| 459 | ON_CALL(storageMock, load(FilePath("report1"))) |
Krzysztof Grobelny | 6ccfcbf | 2020-11-04 09:31:36 +0100 | [diff] [blame] | 460 | .WillByDefault(InvokeWithoutArgs([this] { return data; })); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 461 | } |
| 462 | |
| 463 | void makeReportManager() |
| 464 | { |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 465 | sut = std::make_unique<ReportManager>( |
| 466 | std::move(reportFactoryMockPtr), std::move(storageMockPtr), |
| 467 | DbusEnvironment::getObjServer(), triggerManagerMockPtr); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 468 | } |
| 469 | |
| 470 | nlohmann::json data = nlohmann::json{ |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 471 | {"Enabled", reportParams.enabled()}, |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 472 | {"Version", Report::reportVersion}, |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 473 | {"Id", reportParams.reportId()}, |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 474 | {"Name", reportParams.reportName()}, |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 475 | {"ReportingType", utils::toUnderlying(reportParams.reportingType())}, |
| 476 | {"ReportActions", reportParams.reportActions()}, |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 477 | {"Interval", reportParams.interval().count()}, |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 478 | {"ReportUpdates", utils::toUnderlying(reportParams.reportUpdates())}, |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 479 | {"AppendLimit", reportParams.appendLimit()}, |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 480 | {"ReadingParameters", reportParams.metricParameters()}}; |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 481 | }; |
| 482 | |
| 483 | TEST_F(TestReportManagerStorage, reportManagerCtorAddReportFromStorage) |
| 484 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 485 | reportFactoryMock.expectMake(reportParams, _, Ref(storageMock)); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 486 | |
| 487 | makeReportManager(); |
| 488 | } |
| 489 | |
| 490 | TEST_F(TestReportManagerStorage, |
| 491 | reportManagerCtorRemoveFileIfVersionDoesNotMatch) |
| 492 | { |
| 493 | data["Version"] = Report::reportVersion - 1; |
| 494 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 495 | EXPECT_CALL(storageMock, remove(FilePath("report1"))); |
| 496 | |
| 497 | makeReportManager(); |
| 498 | } |
| 499 | |
| 500 | TEST_F(TestReportManagerStorage, |
| 501 | reportManagerCtorRemoveFileIfIntervalHasWrongType) |
| 502 | { |
| 503 | data["Interval"] = "1000"; |
| 504 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 505 | EXPECT_CALL(storageMock, remove(FilePath("report1"))); |
| 506 | |
| 507 | makeReportManager(); |
| 508 | } |