Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 1 | #include "dbus_environment.hpp" |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 2 | #include "helpers.hpp" |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 3 | #include "interfaces/trigger_manager.hpp" |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 4 | #include "mocks/json_storage_mock.hpp" |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 5 | #include "mocks/report_factory_mock.hpp" |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 6 | #include "mocks/trigger_manager_mock.hpp" |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 7 | #include "params/report_params.hpp" |
| 8 | #include "report.hpp" |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 9 | #include "report_manager.hpp" |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 10 | #include "utils/conversion.hpp" |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 11 | #include "utils/transform.hpp" |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 12 | |
| 13 | using namespace testing; |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 14 | using namespace std::string_literals; |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 15 | using namespace std::chrono_literals; |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 16 | |
| 17 | class TestReportManager : public Test |
| 18 | { |
| 19 | public: |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 20 | ReportParams reportParams; |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 21 | |
| 22 | std::unique_ptr<ReportFactoryMock> reportFactoryMockPtr = |
| 23 | std::make_unique<StrictMock<ReportFactoryMock>>(); |
| 24 | ReportFactoryMock& reportFactoryMock = *reportFactoryMockPtr; |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 25 | |
| 26 | std::unique_ptr<StorageMock> storageMockPtr = |
| 27 | std::make_unique<NiceMock<StorageMock>>(); |
| 28 | StorageMock& storageMock = *storageMockPtr; |
| 29 | |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 30 | std::unique_ptr<ReportMock> reportMockPtr = |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 31 | std::make_unique<NiceMock<ReportMock>>(reportParams.reportId()); |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 32 | ReportMock& reportMock = *reportMockPtr; |
| 33 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 34 | std::unique_ptr<ReportManager> sut; |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 35 | |
| 36 | MockFunction<void(std::string)> checkPoint; |
| 37 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 38 | void SetUp() override |
| 39 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 40 | EXPECT_CALL(reportFactoryMock, convertMetricParams(_, _)) |
| 41 | .Times(AnyNumber()); |
| 42 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame^] | 43 | sut = std::make_unique<ReportManager>(std::move(reportFactoryMockPtr), |
| 44 | std::move(storageMockPtr), |
| 45 | DbusEnvironment::getObjServer()); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 46 | } |
| 47 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 48 | void TearDown() override |
| 49 | { |
| 50 | DbusEnvironment::synchronizeIoc(); |
| 51 | } |
| 52 | |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 53 | template <class... Args> |
| 54 | requires(sizeof...(Args) > 1) |
| 55 | std::pair<boost::system::error_code, std::string> addReport( |
| 56 | Args&&... args) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 57 | { |
| 58 | std::promise<std::pair<boost::system::error_code, std::string>> |
| 59 | addReportPromise; |
| 60 | DbusEnvironment::getBus()->async_method_call( |
| 61 | [&addReportPromise](boost::system::error_code ec, |
| 62 | const std::string& path) { |
| 63 | addReportPromise.set_value({ec, path}); |
| 64 | }, |
| 65 | DbusEnvironment::serviceName(), ReportManager::reportManagerPath, |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 66 | ReportManager::reportManagerIfaceName, "AddReportFutureVersion", |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 67 | std::forward<Args>(args)...); |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 68 | return DbusEnvironment::waitForFuture(addReportPromise.get_future()); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 69 | } |
| 70 | |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 71 | auto addReport(const ReportParams& params) |
| 72 | { |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 73 | return addReport(params.reportId(), params.reportName(), |
| 74 | utils::enumToString(params.reportingType()), |
| 75 | utils::enumToString(params.reportUpdates()), |
| 76 | params.appendLimit(), |
| 77 | utils::transform(params.reportActions(), |
| 78 | [](const auto v) { |
| 79 | return utils::enumToString(v); |
| 80 | }), |
| 81 | params.interval().count(), |
| 82 | toReadingParameters(params.metricParameters())); |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 83 | } |
| 84 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 85 | template <class T> |
Szymon Dompke | e28aa53 | 2021-10-27 12:33:12 +0200 | [diff] [blame] | 86 | static T getProperty(const std::string& property) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 87 | { |
Szymon Dompke | e28aa53 | 2021-10-27 12:33:12 +0200 | [diff] [blame] | 88 | return DbusEnvironment::getProperty<T>( |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 89 | ReportManager::reportManagerPath, |
Szymon Dompke | e28aa53 | 2021-10-27 12:33:12 +0200 | [diff] [blame] | 90 | ReportManager::reportManagerIfaceName, property); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 91 | } |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 92 | }; |
| 93 | |
| 94 | TEST_F(TestReportManager, minInterval) |
| 95 | { |
| 96 | EXPECT_THAT(getProperty<uint64_t>("MinInterval"), |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 97 | Eq(ReportManager::minInterval.count())); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 98 | } |
| 99 | |
| 100 | TEST_F(TestReportManager, maxReports) |
| 101 | { |
Wludzik, Jozef | 503c158 | 2020-12-11 14:48:01 +0100 | [diff] [blame] | 102 | EXPECT_THAT(getProperty<size_t>("MaxReports"), |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 103 | Eq(ReportManager::maxReports)); |
| 104 | } |
| 105 | |
| 106 | TEST_F(TestReportManager, addReport) |
| 107 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 108 | EXPECT_CALL(reportFactoryMock, convertMetricParams(_, _)); |
| 109 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 110 | .WillOnce(Return(ByMove(std::move(reportMockPtr)))); |
| 111 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 112 | auto [ec, path] = addReport(reportParams); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 113 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::success)); |
| 114 | EXPECT_THAT(path, Eq(reportMock.getPath())); |
| 115 | } |
| 116 | |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 117 | TEST_F(TestReportManager, nameIsUsedToGenerateIdWhenIdIsEmptyInAddReport) |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 118 | { |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 119 | reportParams.reportId("ReportName"); |
| 120 | reportParams.reportName("ReportName"); |
| 121 | |
| 122 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)); |
| 123 | |
| 124 | auto [ec, path] = addReport(reportParams.reportId("")); |
| 125 | |
| 126 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::success)); |
| 127 | EXPECT_THAT(path, Eq("/ReportName")); |
| 128 | } |
| 129 | |
| 130 | TEST_F(TestReportManager, nameIsUsedToGenerateIdWhenIdIsNamespace) |
| 131 | { |
| 132 | reportParams.reportId("Prefix/ReportName"); |
| 133 | reportParams.reportName("ReportName"); |
| 134 | |
| 135 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)); |
| 136 | |
| 137 | auto [ec, path] = addReport(reportParams.reportId("Prefix/")); |
| 138 | |
| 139 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::success)); |
| 140 | EXPECT_THAT(path, Eq("/Prefix/ReportName")); |
| 141 | } |
| 142 | |
| 143 | TEST_F(TestReportManager, addReportWithMaxLengthId) |
| 144 | { |
| 145 | std::string reportId(ReportManager::maxReportIdLength, 'z'); |
| 146 | reportParams.reportId(reportId); |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 147 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 148 | |
| 149 | auto [ec, path] = addReport(reportParams); |
| 150 | |
| 151 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::success)); |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 152 | EXPECT_THAT(path, Eq("/"s + reportId)); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 153 | } |
| 154 | |
| 155 | TEST_F(TestReportManager, DISABLED_failToAddReportWithTooLongName) |
| 156 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 157 | reportFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock)) |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 158 | .Times(0); |
| 159 | |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 160 | reportParams.reportId( |
| 161 | std::string(ReportManager::maxReportIdLength + 1, 'z')); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 162 | |
| 163 | auto [ec, path] = addReport(reportParams); |
| 164 | |
| 165 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::invalid_argument)); |
| 166 | EXPECT_THAT(path, Eq(std::string())); |
| 167 | } |
| 168 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 169 | TEST_F(TestReportManager, DISABLED_failToAddReportTwice) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 170 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 171 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)) |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 172 | .WillOnce(Return(ByMove(std::move(reportMockPtr)))); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 173 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 174 | addReport(reportParams); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 175 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 176 | auto [ec, path] = addReport(reportParams); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 177 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 178 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::file_exists)); |
| 179 | EXPECT_THAT(path, Eq(std::string())); |
| 180 | } |
| 181 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 182 | TEST_F(TestReportManager, DISABLED_failToAddReportWithInvalidInterval) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 183 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 184 | reportFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock)) |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 185 | .Times(0); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 186 | |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 187 | reportParams.reportingType(ReportingType::periodic); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 188 | reportParams.interval(reportParams.interval() - 1ms); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 189 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 190 | auto [ec, path] = addReport(reportParams); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 191 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 192 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::invalid_argument)); |
| 193 | EXPECT_THAT(path, Eq(std::string())); |
| 194 | } |
| 195 | |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 196 | TEST_F(TestReportManager, DISABLED_failToAddReportWithInvalidReportingType) |
| 197 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 198 | reportFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock)) |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 199 | .Times(0); |
| 200 | |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 201 | auto [ec, path] = addReport( |
| 202 | reportParams.reportName(), "InvalidReportingType", |
| 203 | utils::transform(reportParams.reportActions(), |
| 204 | [](const auto v) { return utils::enumToString(v); }), |
| 205 | reportParams.interval().count(), |
| 206 | toReadingParameters(reportParams.metricParameters())); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 207 | |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 208 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::invalid_argument)); |
| 209 | EXPECT_THAT(path, Eq(std::string())); |
| 210 | } |
| 211 | |
Ankita Vilas Gawade | cd5b0b7 | 2022-01-20 20:55:04 +0000 | [diff] [blame] | 212 | TEST_F(TestReportManager, |
| 213 | DISABLED_failToAddReportWithMoreMetricPropertiesThanExpected) |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 214 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 215 | reportFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock)) |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 216 | .Times(0); |
| 217 | |
Ankita Vilas Gawade | cd5b0b7 | 2022-01-20 20:55:04 +0000 | [diff] [blame] | 218 | reportParams.metricParameters( |
| 219 | std::vector<LabeledMetricParameters>{{LabeledMetricParameters{ |
Szymon Dompke | 94f71c5 | 2021-12-10 07:16:33 +0100 | [diff] [blame] | 220 | {LabeledSensorInfo{"Service", |
| 221 | "/xyz/openbmc_project/sensors/power/p1", |
| 222 | "Metadata1"}}, |
Ankita Vilas Gawade | cd5b0b7 | 2022-01-20 20:55:04 +0000 | [diff] [blame] | 223 | OperationType::single, |
| 224 | "MetricId1", |
| 225 | CollectionTimeScope::point, |
| 226 | CollectionDuration(Milliseconds(0u))}}}); |
| 227 | |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 228 | auto metricParams = reportParams.metricParameters(); |
Ankita Vilas Gawade | cd5b0b7 | 2022-01-20 20:55:04 +0000 | [diff] [blame] | 229 | auto& metricParamsVec = |
| 230 | metricParams[0].at_label<utils::tstring::SensorPath>(); |
| 231 | |
| 232 | for (size_t i = 0; i < ReportManager::maxNumberMetrics; i++) |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 233 | { |
Szymon Dompke | 94f71c5 | 2021-12-10 07:16:33 +0100 | [diff] [blame] | 234 | metricParamsVec.emplace_back(LabeledSensorInfo{ |
Ankita Vilas Gawade | cd5b0b7 | 2022-01-20 20:55:04 +0000 | [diff] [blame] | 235 | "Service", "/xyz/openbmc_project/sensors/power/p1", "Metadata1"}); |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 236 | } |
Ankita Vilas Gawade | cd5b0b7 | 2022-01-20 20:55:04 +0000 | [diff] [blame] | 237 | |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 238 | reportParams.metricParameters(std::move(metricParams)); |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 239 | |
| 240 | auto [ec, path] = addReport(reportParams); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 241 | |
Wludzik, Jozef | bc766b4 | 2020-12-08 16:06:22 +0100 | [diff] [blame] | 242 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::argument_list_too_long)); |
| 243 | EXPECT_THAT(path, Eq(std::string())); |
| 244 | } |
| 245 | |
Ankita Vilas Gawade | cd5b0b7 | 2022-01-20 20:55:04 +0000 | [diff] [blame] | 246 | TEST_F(TestReportManager, DISABLED_failToAddReportWithMoreMetricsThanExpected) |
| 247 | { |
| 248 | reportFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock)) |
| 249 | .Times(0); |
| 250 | |
| 251 | auto metricParams = std::vector<LabeledMetricParameters>{}; |
| 252 | |
| 253 | for (size_t i = 0; i < ReportManager::maxNumberMetrics + 1; i++) |
| 254 | { |
| 255 | metricParams.emplace_back( |
| 256 | LabeledMetricParameters{{}, |
| 257 | OperationType::single, |
| 258 | "MetricId1", |
| 259 | CollectionTimeScope::point, |
| 260 | CollectionDuration(Milliseconds(0u))}); |
| 261 | } |
| 262 | |
| 263 | reportParams.metricParameters(std::move(metricParams)); |
| 264 | |
| 265 | auto [ec, path] = addReport(reportParams); |
| 266 | |
| 267 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::argument_list_too_long)); |
| 268 | EXPECT_THAT(path, Eq(std::string())); |
| 269 | } |
| 270 | |
| 271 | TEST_F(TestReportManager, DISABLED_failToAddReportWithAppendLimitGreaterThanMax) |
| 272 | { |
| 273 | reportFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock)) |
| 274 | .Times(0); |
| 275 | |
| 276 | reportParams.appendLimit(ReportManager::maxAppendLimit + 1); |
| 277 | |
| 278 | auto [ec, path] = addReport(reportParams); |
| 279 | |
| 280 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::invalid_argument)); |
| 281 | EXPECT_THAT(path, Eq(std::string())); |
| 282 | } |
| 283 | |
Krzysztof Grobelny | e6c417c | 2022-02-02 17:25:53 +0100 | [diff] [blame] | 284 | TEST_F(TestReportManager, addReportWithAppendLimitEqualToUint64MaxIsAllowed) |
| 285 | { |
| 286 | reportParams.appendLimit(std::numeric_limits<uint64_t>::max()); |
| 287 | |
| 288 | EXPECT_CALL(reportFactoryMock, convertMetricParams(_, _)); |
| 289 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)) |
| 290 | .WillOnce(Return(ByMove(std::move(reportMockPtr)))); |
| 291 | |
| 292 | auto [ec, path] = addReport(reportParams); |
| 293 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::success)); |
| 294 | EXPECT_THAT(path, Eq(reportMock.getPath())); |
| 295 | } |
| 296 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 297 | TEST_F(TestReportManager, DISABLED_failToAddReportWhenMaxReportIsReached) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 298 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 299 | reportFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock)) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 300 | .Times(ReportManager::maxReports); |
| 301 | |
| 302 | for (size_t i = 0; i < ReportManager::maxReports; i++) |
| 303 | { |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 304 | reportParams.reportId(reportParams.reportName() + std::to_string(i)); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 305 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 306 | auto [ec, path] = addReport(reportParams); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 307 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::success)); |
| 308 | } |
| 309 | |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 310 | reportParams.reportId(reportParams.reportName() + |
| 311 | std::to_string(ReportManager::maxReports)); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 312 | auto [ec, path] = addReport(reportParams); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 313 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 314 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::too_many_files_open)); |
| 315 | EXPECT_THAT(path, Eq(std::string())); |
| 316 | } |
| 317 | |
| 318 | TEST_F(TestReportManager, removeReport) |
| 319 | { |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 320 | { |
| 321 | InSequence seq; |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 322 | EXPECT_CALL(reportFactoryMock, convertMetricParams(_, _)); |
| 323 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 324 | .WillOnce(Return(ByMove(std::move(reportMockPtr)))); |
| 325 | EXPECT_CALL(reportMock, Die()); |
| 326 | EXPECT_CALL(checkPoint, Call("end")); |
| 327 | } |
| 328 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 329 | addReport(reportParams); |
| 330 | sut->removeReport(&reportMock); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 331 | checkPoint.Call("end"); |
| 332 | } |
| 333 | |
| 334 | TEST_F(TestReportManager, removingReportThatIsNotInContainerHasNoEffect) |
| 335 | { |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 336 | { |
| 337 | InSequence seq; |
| 338 | EXPECT_CALL(checkPoint, Call("end")); |
| 339 | EXPECT_CALL(reportMock, Die()); |
| 340 | } |
| 341 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 342 | sut->removeReport(&reportMock); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 343 | checkPoint.Call("end"); |
| 344 | } |
| 345 | |
| 346 | TEST_F(TestReportManager, removingSameReportTwiceHasNoSideEffect) |
| 347 | { |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 348 | { |
| 349 | InSequence seq; |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 350 | EXPECT_CALL(reportFactoryMock, convertMetricParams(_, _)); |
| 351 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 352 | .WillOnce(Return(ByMove(std::move(reportMockPtr)))); |
| 353 | EXPECT_CALL(reportMock, Die()); |
| 354 | EXPECT_CALL(checkPoint, Call("end")); |
| 355 | } |
| 356 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 357 | addReport(reportParams); |
| 358 | sut->removeReport(&reportMock); |
| 359 | sut->removeReport(&reportMock); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 360 | checkPoint.Call("end"); |
| 361 | } |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 362 | |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 363 | class TestReportManagerWithAggregationOperationType : |
| 364 | public TestReportManager, |
| 365 | public WithParamInterface<OperationType> |
| 366 | { |
| 367 | public: |
| 368 | OperationType operationType = GetParam(); |
| 369 | }; |
| 370 | |
| 371 | INSTANTIATE_TEST_SUITE_P(_, TestReportManagerWithAggregationOperationType, |
| 372 | Values(OperationType::single, OperationType::max, |
| 373 | OperationType::min, OperationType::avg, |
| 374 | OperationType::sum)); |
| 375 | |
| 376 | TEST_P(TestReportManagerWithAggregationOperationType, |
| 377 | addReportWithDifferentOperationTypes) |
| 378 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 379 | reportParams.metricParameters( |
| 380 | std::vector<LabeledMetricParameters>{{LabeledMetricParameters{ |
Szymon Dompke | 94f71c5 | 2021-12-10 07:16:33 +0100 | [diff] [blame] | 381 | {LabeledSensorInfo{"Service", |
| 382 | "/xyz/openbmc_project/sensors/power/p1", |
| 383 | "Metadata1"}}, |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 384 | operationType, |
| 385 | "MetricId1", |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 386 | CollectionTimeScope::point, |
| 387 | CollectionDuration(Milliseconds(0u))}}}); |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 388 | |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 389 | reportFactoryMock.expectMake(reportParams, Ref(*sut), Ref(storageMock)) |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 390 | .WillOnce(Return(ByMove(std::move(reportMockPtr)))); |
| 391 | |
| 392 | auto [ec, path] = addReport(reportParams); |
Karol Niczyj | 32859b6 | 2021-05-19 10:20:46 +0200 | [diff] [blame] | 393 | |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 394 | EXPECT_THAT(ec.value(), Eq(boost::system::errc::success)); |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 395 | EXPECT_THAT(path, Eq("/"s + reportParams.reportId())); |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 396 | } |
| 397 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 398 | class TestReportManagerStorage : public TestReportManager |
| 399 | { |
| 400 | public: |
| 401 | using FilePath = interfaces::JsonStorage::FilePath; |
| 402 | using DirectoryPath = interfaces::JsonStorage::DirectoryPath; |
| 403 | |
| 404 | void SetUp() override |
| 405 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 406 | EXPECT_CALL(reportFactoryMock, convertMetricParams(_, _)).Times(0); |
| 407 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 408 | ON_CALL(storageMock, list()) |
| 409 | .WillByDefault(Return(std::vector<FilePath>{FilePath("report1")})); |
| 410 | ON_CALL(storageMock, load(FilePath("report1"))) |
Krzysztof Grobelny | 6ccfcbf | 2020-11-04 09:31:36 +0100 | [diff] [blame] | 411 | .WillByDefault(InvokeWithoutArgs([this] { return data; })); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 412 | } |
| 413 | |
| 414 | void makeReportManager() |
| 415 | { |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame^] | 416 | sut = std::make_unique<ReportManager>(std::move(reportFactoryMockPtr), |
| 417 | std::move(storageMockPtr), |
| 418 | DbusEnvironment::getObjServer()); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 419 | } |
| 420 | |
| 421 | nlohmann::json data = nlohmann::json{ |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 422 | {"Enabled", reportParams.enabled()}, |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 423 | {"Version", Report::reportVersion}, |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 424 | {"Id", reportParams.reportId()}, |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 425 | {"Name", reportParams.reportName()}, |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 426 | {"ReportingType", utils::toUnderlying(reportParams.reportingType())}, |
| 427 | {"ReportActions", reportParams.reportActions()}, |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 428 | {"Interval", reportParams.interval().count()}, |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 429 | {"ReportUpdates", utils::toUnderlying(reportParams.reportUpdates())}, |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 430 | {"AppendLimit", reportParams.appendLimit()}, |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 431 | {"ReadingParameters", reportParams.metricParameters()}}; |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 432 | }; |
| 433 | |
| 434 | TEST_F(TestReportManagerStorage, reportManagerCtorAddReportFromStorage) |
| 435 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 436 | reportFactoryMock.expectMake(reportParams, _, Ref(storageMock)); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 437 | |
| 438 | makeReportManager(); |
| 439 | } |
| 440 | |
| 441 | TEST_F(TestReportManagerStorage, |
| 442 | reportManagerCtorRemoveFileIfVersionDoesNotMatch) |
| 443 | { |
| 444 | data["Version"] = Report::reportVersion - 1; |
| 445 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 446 | EXPECT_CALL(storageMock, remove(FilePath("report1"))); |
| 447 | |
| 448 | makeReportManager(); |
| 449 | } |
| 450 | |
| 451 | TEST_F(TestReportManagerStorage, |
| 452 | reportManagerCtorRemoveFileIfIntervalHasWrongType) |
| 453 | { |
| 454 | data["Interval"] = "1000"; |
| 455 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 456 | EXPECT_CALL(storageMock, remove(FilePath("report1"))); |
| 457 | |
| 458 | makeReportManager(); |
| 459 | } |