Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 1 | #include "dbus_environment.hpp" |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 2 | #include "fakes/clock_fake.hpp" |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 3 | #include "helpers.hpp" |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 4 | #include "messages/collect_trigger_id.hpp" |
| 5 | #include "messages/trigger_presence_changed_ind.hpp" |
| 6 | #include "messages/update_report_ind.hpp" |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 7 | #include "mocks/json_storage_mock.hpp" |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 8 | #include "mocks/metric_mock.hpp" |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 9 | #include "mocks/report_factory_mock.hpp" |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 10 | #include "mocks/report_manager_mock.hpp" |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 11 | #include "params/report_params.hpp" |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 12 | #include "report.hpp" |
| 13 | #include "report_manager.hpp" |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 14 | #include "utils/clock.hpp" |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 15 | #include "utils/contains.hpp" |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 16 | #include "utils/conv_container.hpp" |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 17 | #include "utils/messanger.hpp" |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 18 | #include "utils/transform.hpp" |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 19 | #include "utils/tstring.hpp" |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 20 | |
| 21 | #include <sdbusplus/exception.hpp> |
| 22 | |
| 23 | using namespace testing; |
| 24 | using namespace std::literals::string_literals; |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 25 | using namespace std::chrono_literals; |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 26 | namespace tstring = utils::tstring; |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 27 | |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 28 | constexpr Milliseconds systemTimestamp = 55ms; |
| 29 | |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 30 | namespace |
| 31 | { |
| 32 | |
| 33 | ReportParams defaultParams() |
| 34 | { |
| 35 | return ReportParams(); |
| 36 | } |
| 37 | |
| 38 | ReportParams defaultOnChangeParams() |
| 39 | { |
| 40 | return defaultParams().reportingType(ReportingType::onChange); |
| 41 | } |
| 42 | |
| 43 | } // namespace |
| 44 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 45 | class TestReport : public Test |
| 46 | { |
| 47 | public: |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 48 | std::unique_ptr<ReportManagerMock> reportManagerMock = |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 49 | std::make_unique<NiceMock<ReportManagerMock>>(); |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 50 | std::unique_ptr<ReportFactoryMock> reportFactoryMock = |
| 51 | std::make_unique<NiceMock<ReportFactoryMock>>(); |
Krzysztof Grobelny | 493e62e | 2022-02-14 10:55:50 +0100 | [diff] [blame] | 52 | nlohmann::json storedConfiguration; |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 53 | NiceMock<StorageMock> storageMock; |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 54 | std::vector<std::shared_ptr<MetricMock>> metricMocks; |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 55 | std::unique_ptr<ClockFake> clockFakePtr = std::make_unique<ClockFake>(); |
| 56 | ClockFake& clockFake = *clockFakePtr; |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 57 | std::unique_ptr<Report> sut; |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 58 | utils::Messanger messanger; |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 59 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 60 | MockFunction<void()> checkPoint; |
| 61 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 62 | TestReport() : messanger(DbusEnvironment::getIoc()) |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 63 | { |
| 64 | clockFake.system.set(systemTimestamp); |
Krzysztof Grobelny | 493e62e | 2022-02-14 10:55:50 +0100 | [diff] [blame] | 65 | ON_CALL(storageMock, store(to_file_path(ReportParams().reportId()), _)) |
| 66 | .WillByDefault(SaveArg<1>(&storedConfiguration)); |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 67 | } |
| 68 | |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 69 | void initMetricMocks( |
| 70 | const std::vector<LabeledMetricParameters>& metricParameters) |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 71 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 72 | for (auto i = metricMocks.size(); i < metricParameters.size(); ++i) |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 73 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 74 | metricMocks.emplace_back(std::make_shared<NiceMock<MetricMock>>()); |
| 75 | } |
| 76 | metricMocks.resize(metricParameters.size()); |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 77 | |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 78 | std::vector<MetricValue> readings{{MetricValue{"a", "b", 17.1, 114}, |
| 79 | MetricValue{"aa", "bb", 42.0, 74}}}; |
| 80 | readings.resize(metricParameters.size()); |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 81 | |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 82 | for (size_t i = 0; i < metricParameters.size(); ++i) |
| 83 | { |
Krzysztof Grobelny | 9e8da54 | 2022-02-17 10:40:16 +0100 | [diff] [blame] | 84 | ON_CALL(*metricMocks[i], getUpdatedReadings()) |
| 85 | .WillByDefault(ReturnRefOfCopy(std::vector({readings[i]}))); |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 86 | ON_CALL(*metricMocks[i], dumpConfiguration()) |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 87 | .WillByDefault(Return(metricParameters[i])); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 88 | } |
| 89 | } |
| 90 | |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 91 | std::vector<std::shared_ptr<interfaces::Metric>> |
| 92 | getMetricsFromReadingParams(const ReadingParameters& params) |
| 93 | { |
| 94 | const auto metricParameters = |
| 95 | reportFactoryMock->convertMetricParams(params); |
| 96 | std::vector<std::shared_ptr<MetricMock>> metricMocks; |
| 97 | |
| 98 | for (size_t i = 0; i < metricParameters.size(); ++i) |
| 99 | { |
| 100 | metricMocks.emplace_back(std::make_shared<NiceMock<MetricMock>>()); |
| 101 | ON_CALL(*metricMocks[i], dumpConfiguration()) |
| 102 | .WillByDefault(Return(metricParameters[i])); |
| 103 | } |
| 104 | |
| 105 | return utils::convContainer<std::shared_ptr<interfaces::Metric>>( |
| 106 | metricMocks); |
| 107 | } |
| 108 | |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 109 | void SetUp() override |
| 110 | { |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 111 | sut = makeReport(defaultParams()); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 112 | } |
| 113 | |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 114 | static interfaces::JsonStorage::FilePath to_file_path(std::string id) |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 115 | { |
| 116 | return interfaces::JsonStorage::FilePath( |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 117 | std::to_string(std::hash<std::string>{}(id))); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 118 | } |
| 119 | |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 120 | std::unique_ptr<Report> makeReport(const ReportParams& params) |
| 121 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 122 | initMetricMocks(params.metricParameters()); |
| 123 | |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 124 | return std::make_unique<Report>( |
| 125 | DbusEnvironment::getIoc(), DbusEnvironment::getObjServer(), |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 126 | params.reportId(), params.reportName(), params.reportingType(), |
| 127 | params.reportActions(), params.interval(), params.appendLimit(), |
| 128 | params.reportUpdates(), *reportManagerMock, storageMock, |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 129 | utils::convContainer<std::shared_ptr<interfaces::Metric>>( |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 130 | metricMocks), |
Krzysztof Grobelny | 493e62e | 2022-02-14 10:55:50 +0100 | [diff] [blame] | 131 | *reportFactoryMock, params.enabled(), std::move(clockFakePtr), |
| 132 | params.readings()); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 133 | } |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 134 | |
| 135 | template <class T> |
| 136 | static T getProperty(const std::string& path, const std::string& property) |
| 137 | { |
Szymon Dompke | e28aa53 | 2021-10-27 12:33:12 +0200 | [diff] [blame] | 138 | return DbusEnvironment::getProperty<T>(path, Report::reportIfaceName, |
| 139 | property); |
| 140 | } |
| 141 | |
| 142 | template <class T> |
| 143 | static boost::system::error_code setProperty(const std::string& path, |
| 144 | const std::string& property, |
| 145 | const T& newValue) |
| 146 | { |
| 147 | return DbusEnvironment::setProperty<T>(path, Report::reportIfaceName, |
| 148 | property, newValue); |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 149 | } |
| 150 | |
| 151 | boost::system::error_code call(const std::string& path, |
| 152 | const std::string& interface, |
| 153 | const std::string& method) |
| 154 | { |
| 155 | std::promise<boost::system::error_code> methodPromise; |
| 156 | DbusEnvironment::getBus()->async_method_call( |
| 157 | [&methodPromise](boost::system::error_code ec) { |
| 158 | methodPromise.set_value(ec); |
| 159 | }, |
| 160 | DbusEnvironment::serviceName(), path, interface, method); |
| 161 | return DbusEnvironment::waitForFuture(methodPromise.get_future()); |
| 162 | } |
| 163 | |
| 164 | boost::system::error_code update(const std::string& path) |
| 165 | { |
| 166 | return call(path, Report::reportIfaceName, "Update"); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 167 | } |
| 168 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 169 | boost::system::error_code deleteReport(const std::string& path) |
| 170 | { |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 171 | return call(path, Report::deleteIfaceName, "Delete"); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 172 | } |
| 173 | }; |
| 174 | |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 175 | TEST_F(TestReport, returnsId) |
| 176 | { |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 177 | EXPECT_THAT(sut->getId(), Eq(defaultParams().reportId())); |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 178 | } |
| 179 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 180 | TEST_F(TestReport, verifyIfPropertiesHaveValidValue) |
| 181 | { |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 182 | EXPECT_THAT(getProperty<bool>(sut->getPath(), "Enabled"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 183 | Eq(defaultParams().enabled())); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 184 | EXPECT_THAT(getProperty<uint64_t>(sut->getPath(), "Interval"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 185 | Eq(defaultParams().interval().count())); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 186 | EXPECT_THAT(getProperty<bool>(sut->getPath(), "Persistency"), Eq(true)); |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 187 | EXPECT_THAT( |
| 188 | getProperty<std::vector<std::string>>(sut->getPath(), "ReportActions"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 189 | Eq(utils::transform(defaultParams().reportActions(), [](const auto v) { |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 190 | return utils::enumToString(v); |
| 191 | }))); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 192 | EXPECT_THAT(getProperty<bool>(sut->getPath(), "EmitsReadingsUpdate"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 193 | Eq(utils::contains(defaultParams().reportActions(), |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 194 | ReportAction::emitsReadingsUpdate))); |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 195 | EXPECT_THAT(getProperty<uint64_t>(sut->getPath(), "AppendLimit"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 196 | Eq(defaultParams().appendLimit())); |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 197 | EXPECT_THAT(getProperty<std::string>(sut->getPath(), "ReportingType"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 198 | Eq(utils::enumToString(defaultParams().reportingType()))); |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 199 | EXPECT_THAT(getProperty<std::string>(sut->getPath(), "ReportUpdates"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 200 | Eq(utils::enumToString(defaultParams().reportUpdates()))); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 201 | EXPECT_THAT( |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 202 | getProperty<bool>(sut->getPath(), "LogToMetricReportsCollection"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 203 | Eq(utils::contains(defaultParams().reportActions(), |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 204 | ReportAction::logToMetricReportsCollection))); |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 205 | EXPECT_THAT(getProperty<ReadingParameters>( |
| 206 | sut->getPath(), "ReadingParametersFutureVersion"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 207 | Eq(toReadingParameters(defaultParams().metricParameters()))); |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 208 | EXPECT_THAT(getProperty<std::string>(sut->getPath(), "Name"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 209 | Eq(defaultParams().reportName())); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 210 | EXPECT_THAT( |
| 211 | getProperty<std::vector<std::string>>(sut->getPath(), "TriggerIds"), |
| 212 | Eq(std::vector<std::string>())); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 213 | } |
| 214 | |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 215 | TEST_F(TestReport, readingsAreInitialyEmpty) |
| 216 | { |
| 217 | EXPECT_THAT(getProperty<Readings>(sut->getPath(), "Readings"), |
| 218 | Eq(Readings{})); |
| 219 | } |
| 220 | |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 221 | TEST_F(TestReport, setReadingParametersWithNewParams) |
| 222 | { |
| 223 | ReadingParameters newParams = toReadingParameters( |
| 224 | std::vector<LabeledMetricParameters>{{LabeledMetricParameters{ |
| 225 | {LabeledSensorInfo{"Service", |
| 226 | "/xyz/openbmc_project/sensors/power/psu", |
| 227 | "NewMetadata123"}}, |
| 228 | OperationType::avg, |
| 229 | "NewMetricId123", |
| 230 | CollectionTimeScope::startup, |
| 231 | CollectionDuration(250ms)}}}); |
| 232 | auto metrics = getMetricsFromReadingParams(newParams); |
| 233 | |
| 234 | EXPECT_CALL(*reportFactoryMock, updateMetrics(_, _, _)) |
| 235 | .WillOnce(SetArgReferee<0>(metrics)); |
| 236 | EXPECT_THAT( |
| 237 | setProperty(sut->getPath(), "ReadingParametersFutureVersion", newParams) |
| 238 | .value(), |
| 239 | Eq(boost::system::errc::success)); |
| 240 | EXPECT_THAT(getProperty<ReadingParameters>( |
| 241 | sut->getPath(), "ReadingParametersFutureVersion"), |
| 242 | Eq(newParams)); |
| 243 | } |
| 244 | |
| 245 | TEST_F(TestReport, setReportingTypeWithValidNewType) |
| 246 | { |
| 247 | std::string newType = "Periodic"; |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 248 | std::string currType = utils::enumToString(defaultParams().reportingType()); |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 249 | |
| 250 | EXPECT_THAT(newType, Ne(currType)); |
| 251 | EXPECT_THAT(setProperty(sut->getPath(), "ReportingType", newType).value(), |
| 252 | Eq(boost::system::errc::success)); |
| 253 | EXPECT_THAT(getProperty<std::string>(sut->getPath(), "ReportingType"), |
| 254 | Eq(newType)); |
| 255 | } |
| 256 | |
| 257 | TEST_F(TestReport, setReportingTypeWithInvalidType) |
| 258 | { |
| 259 | std::string newType = "Periodic_ABC"; |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 260 | std::string prevType = utils::enumToString(defaultParams().reportingType()); |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 261 | |
| 262 | EXPECT_THAT(setProperty(sut->getPath(), "ReportingType", newType).value(), |
| 263 | Eq(boost::system::errc::invalid_argument)); |
| 264 | EXPECT_THAT(getProperty<std::string>(sut->getPath(), "ReportingType"), |
| 265 | Eq(prevType)); |
| 266 | } |
| 267 | |
| 268 | TEST_F(TestReport, setReportActionsWithValidNewActions) |
| 269 | { |
| 270 | std::vector<std::string> newActions = {"EmitsReadingsUpdate"}; |
| 271 | std::vector<std::string> currActions = |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 272 | utils::transform(defaultParams().reportActions(), |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 273 | [](const auto v) { return utils::enumToString(v); }); |
| 274 | |
| 275 | EXPECT_THAT(newActions, Ne(currActions)); |
| 276 | EXPECT_THAT( |
| 277 | setProperty(sut->getPath(), "ReportActions", newActions).value(), |
| 278 | Eq(boost::system::errc::success)); |
| 279 | EXPECT_THAT( |
| 280 | getProperty<std::vector<std::string>>(sut->getPath(), "ReportActions"), |
| 281 | UnorderedElementsAre("EmitsReadingsUpdate", |
| 282 | "LogToMetricReportsCollection")); |
| 283 | } |
| 284 | |
| 285 | TEST_F(TestReport, setReportActionsWithValidUnsortedActions) |
| 286 | { |
| 287 | std::vector<std::string> newActions = {"LogToMetricReportsCollection", |
| 288 | "EmitsReadingsUpdate"}; |
| 289 | std::vector<std::string> expectedActions = {"EmitsReadingsUpdate", |
| 290 | "LogToMetricReportsCollection"}; |
| 291 | std::vector<std::string> currActions = |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 292 | utils::transform(defaultParams().reportActions(), |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 293 | [](const auto v) { return utils::enumToString(v); }); |
| 294 | |
| 295 | EXPECT_THAT(newActions, Ne(currActions)); |
| 296 | EXPECT_THAT( |
| 297 | setProperty(sut->getPath(), "ReportActions", newActions).value(), |
| 298 | Eq(boost::system::errc::success)); |
| 299 | EXPECT_THAT( |
| 300 | getProperty<std::vector<std::string>>(sut->getPath(), "ReportActions"), |
| 301 | Eq(expectedActions)); |
| 302 | } |
| 303 | |
| 304 | TEST_F(TestReport, setReportActionsWithEmptyActions) |
| 305 | { |
| 306 | std::vector<std::string> newActions = {}; |
| 307 | std::vector<std::string> expectedActions = {"LogToMetricReportsCollection"}; |
| 308 | std::vector<std::string> currActions = |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 309 | utils::transform(defaultParams().reportActions(), |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 310 | [](const auto v) { return utils::enumToString(v); }); |
| 311 | |
| 312 | EXPECT_THAT(newActions, Ne(currActions)); |
| 313 | EXPECT_THAT( |
| 314 | setProperty(sut->getPath(), "ReportActions", newActions).value(), |
| 315 | Eq(boost::system::errc::success)); |
| 316 | EXPECT_THAT( |
| 317 | getProperty<std::vector<std::string>>(sut->getPath(), "ReportActions"), |
| 318 | Eq(expectedActions)); |
| 319 | } |
| 320 | |
| 321 | TEST_F(TestReport, setReportActionsWithInvalidActions) |
| 322 | { |
| 323 | std::vector<std::string> invalidActions = {"EmitsReadingsUpdate_1"}; |
| 324 | EXPECT_THAT( |
| 325 | setProperty(sut->getPath(), "ReportActions", invalidActions).value(), |
| 326 | Eq(boost::system::errc::invalid_argument)); |
| 327 | EXPECT_THAT( |
| 328 | getProperty<std::vector<std::string>>(sut->getPath(), "ReportActions"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 329 | Eq(utils::transform(defaultParams().reportActions(), [](const auto v) { |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 330 | return utils::enumToString(v); |
| 331 | }))); |
| 332 | } |
| 333 | |
| 334 | TEST_F(TestReport, createReportWithEmptyActions) |
| 335 | { |
| 336 | std::vector<std::string> expectedActions = {"LogToMetricReportsCollection"}; |
| 337 | |
| 338 | sut = makeReport(ReportParams().reportId("TestId_1").reportActions({})); |
| 339 | EXPECT_THAT( |
| 340 | getProperty<std::vector<std::string>>(sut->getPath(), "ReportActions"), |
| 341 | Eq(expectedActions)); |
| 342 | } |
| 343 | |
| 344 | TEST_F(TestReport, createReportWithValidUnsortedActions) |
| 345 | { |
| 346 | std::vector<std::string> newActions = {"LogToMetricReportsCollection", |
| 347 | "EmitsReadingsUpdate"}; |
| 348 | std::vector<std::string> expectedActions = {"EmitsReadingsUpdate", |
| 349 | "LogToMetricReportsCollection"}; |
| 350 | |
| 351 | sut = makeReport( |
| 352 | ReportParams() |
| 353 | .reportId("TestId_1") |
| 354 | .reportActions(utils::transform(newActions, [](const auto& action) { |
| 355 | return utils::toReportAction(action); |
| 356 | }))); |
| 357 | EXPECT_THAT( |
| 358 | getProperty<std::vector<std::string>>(sut->getPath(), "ReportActions"), |
| 359 | Eq(expectedActions)); |
| 360 | } |
| 361 | |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 362 | TEST_F(TestReport, setEnabledWithNewValue) |
| 363 | { |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 364 | bool newValue = !defaultParams().enabled(); |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 365 | EXPECT_THAT(setProperty(sut->getPath(), "Enabled", newValue).value(), |
| 366 | Eq(boost::system::errc::success)); |
| 367 | EXPECT_THAT(getProperty<bool>(sut->getPath(), "Enabled"), Eq(newValue)); |
| 368 | } |
| 369 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 370 | TEST_F(TestReport, setIntervalWithValidValue) |
| 371 | { |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 372 | uint64_t newValue = defaultParams().interval().count() + 1; |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 373 | EXPECT_THAT(setProperty(sut->getPath(), "Interval", newValue).value(), |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 374 | Eq(boost::system::errc::success)); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 375 | EXPECT_THAT(getProperty<uint64_t>(sut->getPath(), "Interval"), |
| 376 | Eq(newValue)); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 377 | } |
| 378 | |
Szymon Dompke | 3e2cc9d | 2021-12-14 12:00:52 +0100 | [diff] [blame] | 379 | TEST_F( |
| 380 | TestReport, |
| 381 | settingIntervalWithInvalidValueDoesNotChangePropertyAndReturnsInvalidArgument) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 382 | { |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 383 | uint64_t newValue = defaultParams().interval().count() - 1; |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 384 | EXPECT_THAT(setProperty(sut->getPath(), "Interval", newValue).value(), |
Szymon Dompke | 3e2cc9d | 2021-12-14 12:00:52 +0100 | [diff] [blame] | 385 | Eq(boost::system::errc::invalid_argument)); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 386 | EXPECT_THAT(getProperty<uint64_t>(sut->getPath(), "Interval"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 387 | Eq(defaultParams().interval().count())); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 388 | } |
| 389 | |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 390 | TEST_F(TestReport, settingEmitsReadingsUpdateHaveNoEffect) |
| 391 | { |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 392 | EXPECT_THAT( |
| 393 | setProperty(sut->getPath(), "EmitsReadingsUpdate", true).value(), |
| 394 | Eq(boost::system::errc::read_only_file_system)); |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 395 | EXPECT_THAT(getProperty<bool>(sut->getPath(), "EmitsReadingsUpdate"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 396 | Eq(utils::contains(defaultParams().reportActions(), |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 397 | ReportAction::emitsReadingsUpdate))); |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 398 | } |
| 399 | |
| 400 | TEST_F(TestReport, settingLogToMetricReportCollectionHaveNoEffect) |
| 401 | { |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 402 | EXPECT_THAT( |
| 403 | setProperty(sut->getPath(), "LogToMetricReportsCollection", true) |
| 404 | .value(), |
| 405 | Eq(boost::system::errc::read_only_file_system)); |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 406 | EXPECT_THAT( |
| 407 | getProperty<bool>(sut->getPath(), "LogToMetricReportsCollection"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 408 | Eq(utils::contains(defaultParams().reportActions(), |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 409 | ReportAction::logToMetricReportsCollection))); |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 410 | } |
| 411 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 412 | TEST_F(TestReport, settingPersistencyToFalseRemovesReportFromStorage) |
| 413 | { |
Krzysztof Grobelny | 493e62e | 2022-02-14 10:55:50 +0100 | [diff] [blame] | 414 | EXPECT_CALL(storageMock, store(_, _)).Times(0); |
| 415 | EXPECT_CALL(storageMock, remove(to_file_path(sut->getId()))) |
| 416 | .Times(AtLeast(1)); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 417 | |
| 418 | bool persistency = false; |
| 419 | EXPECT_THAT(setProperty(sut->getPath(), "Persistency", persistency).value(), |
| 420 | Eq(boost::system::errc::success)); |
| 421 | EXPECT_THAT(getProperty<bool>(sut->getPath(), "Persistency"), |
| 422 | Eq(persistency)); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 423 | } |
| 424 | |
| 425 | TEST_F(TestReport, deleteReport) |
| 426 | { |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 427 | EXPECT_CALL(*reportManagerMock, removeReport(sut.get())); |
| 428 | auto ec = deleteReport(sut->getPath()); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 429 | EXPECT_THAT(ec, Eq(boost::system::errc::success)); |
| 430 | } |
| 431 | |
| 432 | TEST_F(TestReport, deletingNonExistingReportReturnInvalidRequestDescriptor) |
| 433 | { |
| 434 | auto ec = deleteReport(Report::reportDir + "NonExisting"s); |
| 435 | EXPECT_THAT(ec.value(), Eq(EBADR)); |
| 436 | } |
| 437 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 438 | TEST_F(TestReport, deleteReportExpectThatFileIsRemoveFromStorage) |
| 439 | { |
Krzysztof Grobelny | 493e62e | 2022-02-14 10:55:50 +0100 | [diff] [blame] | 440 | EXPECT_CALL(storageMock, store(_, _)).Times(0); |
| 441 | EXPECT_CALL(storageMock, remove(to_file_path(sut->getId()))) |
| 442 | .Times(AtLeast(1)); |
| 443 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 444 | auto ec = deleteReport(sut->getPath()); |
| 445 | EXPECT_THAT(ec, Eq(boost::system::errc::success)); |
| 446 | } |
| 447 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 448 | TEST_F(TestReport, updatesTriggerIdWhenTriggerIsAdded) |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 449 | { |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 450 | utils::Messanger messanger(DbusEnvironment::getIoc()); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 451 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 452 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 453 | messages::Presence::Exist, "trigger1", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 454 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 455 | messages::Presence::Exist, "trigger1", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 456 | messanger.send(messages::TriggerPresenceChangedInd{ |
| 457 | messages::Presence::Exist, "trigger2", {"someOtherReport"}}); |
| 458 | messanger.send(messages::TriggerPresenceChangedInd{ |
| 459 | messages::Presence::Exist, |
| 460 | "trigger3", |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 461 | {"someOtherReport", defaultParams().reportId()}}); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 462 | |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 463 | EXPECT_THAT( |
| 464 | getProperty<std::vector<std::string>>(sut->getPath(), "TriggerIds"), |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 465 | UnorderedElementsAre("trigger1", "trigger3")); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 466 | } |
| 467 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 468 | TEST_F(TestReport, updatesTriggerIdWhenTriggerIsRemoved) |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 469 | { |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 470 | utils::Messanger messanger(DbusEnvironment::getIoc()); |
| 471 | |
| 472 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 473 | messages::Presence::Exist, "trigger1", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 474 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 475 | messages::Presence::Exist, "trigger2", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 476 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 477 | messages::Presence::Exist, "trigger3", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 478 | |
| 479 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 480 | messages::Presence::Removed, "trigger1", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 481 | messanger.send(messages::TriggerPresenceChangedInd{ |
| 482 | messages::Presence::Removed, "trigger2", {}}); |
| 483 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 484 | messages::Presence::Removed, "trigger1", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 485 | |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 486 | EXPECT_THAT( |
| 487 | getProperty<std::vector<std::string>>(sut->getPath(), "TriggerIds"), |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 488 | UnorderedElementsAre("trigger3")); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 489 | } |
| 490 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 491 | TEST_F(TestReport, updatesTriggerIdWhenTriggerIsModified) |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 492 | { |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 493 | utils::Messanger messanger(DbusEnvironment::getIoc()); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 494 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 495 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 496 | messages::Presence::Exist, "trigger1", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 497 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 498 | messages::Presence::Exist, "trigger2", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 499 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 500 | messages::Presence::Exist, "trigger3", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 501 | |
| 502 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 503 | messages::Presence::Exist, "trigger1", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 504 | messanger.send(messages::TriggerPresenceChangedInd{ |
| 505 | messages::Presence::Exist, "trigger2", {}}); |
| 506 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 507 | messages::Presence::Exist, "trigger3", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 508 | |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 509 | EXPECT_THAT( |
| 510 | getProperty<std::vector<std::string>>(sut->getPath(), "TriggerIds"), |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 511 | UnorderedElementsAre("trigger1", "trigger3")); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 512 | } |
| 513 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 514 | class TestReportStore : |
| 515 | public TestReport, |
| 516 | public WithParamInterface<std::pair<std::string, nlohmann::json>> |
| 517 | { |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 518 | void SetUp() override |
| 519 | {} |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 520 | }; |
| 521 | |
| 522 | INSTANTIATE_TEST_SUITE_P( |
| 523 | _, TestReportStore, |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 524 | Values( |
| 525 | std::make_pair("Enabled"s, nlohmann::json(defaultParams().enabled())), |
| 526 | std::make_pair("Version"s, nlohmann::json(6)), |
| 527 | std::make_pair("Id"s, nlohmann::json(defaultParams().reportId())), |
| 528 | std::make_pair("Name"s, nlohmann::json(defaultParams().reportName())), |
| 529 | std::make_pair("ReportingType", |
| 530 | nlohmann::json(defaultParams().reportingType())), |
| 531 | std::make_pair("ReportActions", nlohmann::json(utils::transform( |
| 532 | defaultParams().reportActions(), |
| 533 | [](const auto v) { |
| 534 | return utils::toUnderlying(v); |
| 535 | }))), |
| 536 | std::make_pair("Interval", |
| 537 | nlohmann::json(defaultParams().interval().count())), |
| 538 | std::make_pair("AppendLimit", |
| 539 | nlohmann::json(ReportParams().appendLimit())), |
| 540 | std::make_pair( |
| 541 | "ReadingParameters", |
| 542 | nlohmann::json( |
| 543 | {{{tstring::SensorPath::str(), |
| 544 | {{{tstring::Service::str(), "Service"}, |
| 545 | {tstring::Path::str(), |
| 546 | "/xyz/openbmc_project/sensors/power/p1"}, |
| 547 | {tstring::Metadata::str(), "metadata1"}}}}, |
| 548 | {tstring::OperationType::str(), OperationType::avg}, |
| 549 | {tstring::Id::str(), "MetricId1"}, |
| 550 | {tstring::CollectionTimeScope::str(), |
| 551 | CollectionTimeScope::point}, |
| 552 | {tstring::CollectionDuration::str(), 0}}, |
| 553 | {{tstring::SensorPath::str(), |
| 554 | {{{tstring::Service::str(), "Service"}, |
| 555 | {tstring::Path::str(), |
| 556 | "/xyz/openbmc_project/sensors/power/p2"}, |
| 557 | {tstring::Metadata::str(), "metadata2"}}}}, |
| 558 | {tstring::OperationType::str(), OperationType::avg}, |
| 559 | {tstring::Id::str(), "MetricId2"}, |
| 560 | {tstring::CollectionTimeScope::str(), |
| 561 | CollectionTimeScope::point}, |
| 562 | {tstring::CollectionDuration::str(), 0}}})))); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 563 | |
| 564 | TEST_P(TestReportStore, settingPersistencyToTrueStoresReport) |
| 565 | { |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 566 | sut = makeReport(defaultParams()); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 567 | |
| 568 | { |
| 569 | InSequence seq; |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 570 | EXPECT_CALL(storageMock, remove(to_file_path(sut->getId()))); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 571 | EXPECT_CALL(checkPoint, Call()); |
Krzysztof Grobelny | 493e62e | 2022-02-14 10:55:50 +0100 | [diff] [blame] | 572 | EXPECT_CALL(storageMock, store(to_file_path(sut->getId()), _)); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 573 | } |
| 574 | |
| 575 | setProperty(sut->getPath(), "Persistency", false); |
| 576 | checkPoint.Call(); |
| 577 | setProperty(sut->getPath(), "Persistency", true); |
| 578 | |
| 579 | const auto& [key, value] = GetParam(); |
| 580 | |
| 581 | ASSERT_THAT(storedConfiguration.at(key), Eq(value)); |
| 582 | } |
| 583 | |
| 584 | TEST_P(TestReportStore, reportIsSavedToStorageAfterCreated) |
| 585 | { |
Krzysztof Grobelny | 493e62e | 2022-02-14 10:55:50 +0100 | [diff] [blame] | 586 | EXPECT_CALL(storageMock, |
| 587 | store(to_file_path(defaultParams().reportId()), _)); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 588 | |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 589 | sut = makeReport(defaultParams()); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 590 | |
| 591 | const auto& [key, value] = GetParam(); |
| 592 | |
| 593 | ASSERT_THAT(storedConfiguration.at(key), Eq(value)); |
| 594 | } |
| 595 | |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 596 | class TestReportValidNames : |
| 597 | public TestReport, |
| 598 | public WithParamInterface<ReportParams> |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 599 | { |
| 600 | public: |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 601 | void SetUp() override |
| 602 | {} |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 603 | }; |
| 604 | |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 605 | INSTANTIATE_TEST_SUITE_P( |
| 606 | ValidNames, TestReportValidNames, |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 607 | Values(defaultParams().reportName("Valid_1"), |
| 608 | defaultParams().reportName("Valid_1/Valid_2"), |
| 609 | defaultParams().reportName("Valid_1/Valid_2/Valid_3"))); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 610 | |
| 611 | TEST_P(TestReportValidNames, reportCtorDoesNotThrowOnValidName) |
| 612 | { |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 613 | EXPECT_NO_THROW(makeReport(GetParam())); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 614 | } |
| 615 | |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 616 | class TestReportInvalidIds : |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 617 | public TestReport, |
| 618 | public WithParamInterface<ReportParams> |
| 619 | { |
| 620 | public: |
| 621 | void SetUp() override |
| 622 | {} |
| 623 | }; |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 624 | |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 625 | INSTANTIATE_TEST_SUITE_P(InvalidNames, TestReportInvalidIds, |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 626 | Values(defaultParams().reportId("/"), |
| 627 | defaultParams().reportId("/Invalid"), |
| 628 | defaultParams().reportId("Invalid/"), |
| 629 | defaultParams().reportId("Invalid/Invalid/"), |
| 630 | defaultParams().reportId("Invalid?"))); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 631 | |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 632 | TEST_P(TestReportInvalidIds, failsToCreateReportWithInvalidName) |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 633 | { |
| 634 | EXPECT_CALL(storageMock, store).Times(0); |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 635 | |
| 636 | EXPECT_THROW(makeReport(GetParam()), sdbusplus::exception::SdBusError); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 637 | } |
| 638 | |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 639 | class TestReportAllReportTypes : |
| 640 | public TestReport, |
| 641 | public WithParamInterface<ReportParams> |
| 642 | { |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 643 | public: |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 644 | void SetUp() override |
| 645 | { |
| 646 | sut = makeReport(GetParam()); |
| 647 | } |
| 648 | }; |
| 649 | |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 650 | INSTANTIATE_TEST_SUITE_P( |
| 651 | _, TestReportAllReportTypes, |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 652 | Values(defaultParams().reportingType(ReportingType::onRequest), |
| 653 | defaultParams().reportingType(ReportingType::onChange), |
| 654 | defaultParams().reportingType(ReportingType::periodic))); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 655 | |
| 656 | TEST_P(TestReportAllReportTypes, returnPropertValueOfReportType) |
| 657 | { |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 658 | EXPECT_THAT(utils::toReportingType( |
| 659 | getProperty<std::string>(sut->getPath(), "ReportingType")), |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 660 | Eq(GetParam().reportingType())); |
| 661 | } |
| 662 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 663 | TEST_P(TestReportAllReportTypes, readingsAreUpdated) |
| 664 | { |
| 665 | clockFake.system.advance(10ms); |
| 666 | |
| 667 | messanger.send(messages::UpdateReportInd{{sut->getId()}}); |
| 668 | const auto [timestamp, readings] = |
| 669 | getProperty<Readings>(sut->getPath(), "Readings"); |
| 670 | |
| 671 | EXPECT_THAT(Milliseconds{timestamp}, Eq(systemTimestamp + 10ms)); |
| 672 | } |
| 673 | |
| 674 | TEST_P(TestReportAllReportTypes, readingsAreNotUpdatedWhenReportIsDisabled) |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 675 | { |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 676 | clockFake.system.advance(10ms); |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 677 | |
| 678 | setProperty(sut->getPath(), "Enabled", false); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 679 | messanger.send(messages::UpdateReportInd{{sut->getId()}}); |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 680 | const auto [timestamp, readings] = |
| 681 | getProperty<Readings>(sut->getPath(), "Readings"); |
| 682 | |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 683 | EXPECT_THAT(Milliseconds{timestamp}, Eq(0ms)); |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 684 | } |
| 685 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 686 | TEST_P(TestReportAllReportTypes, readingsAreNotUpdatedWhenReportIdDiffers) |
Wludzik, Jozef | d960e1f | 2021-01-08 09:25:59 +0100 | [diff] [blame] | 687 | { |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 688 | clockFake.system.advance(10ms); |
Wludzik, Jozef | d960e1f | 2021-01-08 09:25:59 +0100 | [diff] [blame] | 689 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 690 | messanger.send(messages::UpdateReportInd{{sut->getId() + "x"s}}); |
Wludzik, Jozef | d960e1f | 2021-01-08 09:25:59 +0100 | [diff] [blame] | 691 | const auto [timestamp, readings] = |
| 692 | getProperty<Readings>(sut->getPath(), "Readings"); |
| 693 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 694 | EXPECT_THAT(Milliseconds{timestamp}, Eq(0ms)); |
Wludzik, Jozef | d960e1f | 2021-01-08 09:25:59 +0100 | [diff] [blame] | 695 | } |
| 696 | |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 697 | class TestReportOnRequestType : public TestReport |
| 698 | { |
| 699 | void SetUp() override |
| 700 | { |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 701 | sut = |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 702 | makeReport(defaultParams().reportingType(ReportingType::onRequest)); |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 703 | } |
| 704 | }; |
| 705 | |
| 706 | TEST_F(TestReportOnRequestType, updatesReadingTimestamp) |
| 707 | { |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 708 | clockFake.system.advance(10ms); |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 709 | |
| 710 | ASSERT_THAT(update(sut->getPath()), Eq(boost::system::errc::success)); |
| 711 | |
| 712 | const auto [timestamp, readings] = |
| 713 | getProperty<Readings>(sut->getPath(), "Readings"); |
| 714 | |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 715 | EXPECT_THAT(Milliseconds{timestamp}, Eq(systemTimestamp + 10ms)); |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 716 | } |
| 717 | |
| 718 | TEST_F(TestReportOnRequestType, updatesReadingWhenUpdateIsCalled) |
| 719 | { |
| 720 | ASSERT_THAT(update(sut->getPath()), Eq(boost::system::errc::success)); |
| 721 | |
| 722 | const auto [timestamp, readings] = |
| 723 | getProperty<Readings>(sut->getPath(), "Readings"); |
| 724 | |
| 725 | EXPECT_THAT(readings, |
| 726 | ElementsAre(std::make_tuple("a"s, "b"s, 17.1, 114u), |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 727 | std::make_tuple("aa"s, "bb"s, 42.0, 74u))); |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 728 | } |
| 729 | |
| 730 | class TestReportNonOnRequestType : |
| 731 | public TestReport, |
| 732 | public WithParamInterface<ReportParams> |
| 733 | { |
| 734 | void SetUp() override |
| 735 | { |
| 736 | sut = makeReport(GetParam()); |
| 737 | } |
| 738 | }; |
| 739 | |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 740 | INSTANTIATE_TEST_SUITE_P( |
| 741 | _, TestReportNonOnRequestType, |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 742 | Values(defaultParams().reportingType(ReportingType::periodic), |
| 743 | defaultParams().reportingType(ReportingType::onChange))); |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 744 | |
| 745 | TEST_P(TestReportNonOnRequestType, readingsAreNotUpdateOnUpdateCall) |
| 746 | { |
| 747 | ASSERT_THAT(update(sut->getPath()), Eq(boost::system::errc::success)); |
| 748 | |
| 749 | EXPECT_THAT(getProperty<Readings>(sut->getPath(), "Readings"), |
| 750 | Eq(Readings{})); |
| 751 | } |
| 752 | |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 753 | class TestReportNonPeriodicReport : |
| 754 | public TestReport, |
| 755 | public WithParamInterface<ReportParams> |
| 756 | { |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 757 | public: |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 758 | void SetUp() override |
| 759 | { |
| 760 | sut = makeReport(GetParam()); |
| 761 | } |
| 762 | }; |
| 763 | |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 764 | INSTANTIATE_TEST_SUITE_P( |
| 765 | _, TestReportNonPeriodicReport, |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 766 | Values(defaultParams().reportingType(ReportingType::onRequest), |
| 767 | defaultParams().reportingType(ReportingType::onChange))); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 768 | |
| 769 | TEST_P(TestReportNonPeriodicReport, readingsAreNotUpdatedAfterIntervalExpires) |
| 770 | { |
| 771 | DbusEnvironment::sleepFor(ReportManager::minInterval + 1ms); |
| 772 | |
| 773 | EXPECT_THAT(getProperty<Readings>(sut->getPath(), "Readings"), |
| 774 | Eq(Readings{})); |
| 775 | } |
| 776 | |
| 777 | class TestReportPeriodicReport : public TestReport |
| 778 | { |
| 779 | void SetUp() override |
| 780 | { |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 781 | sut = |
| 782 | makeReport(defaultParams().reportingType(ReportingType::periodic)); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 783 | } |
| 784 | }; |
| 785 | |
| 786 | TEST_F(TestReportPeriodicReport, readingTimestampIsUpdatedAfterIntervalExpires) |
| 787 | { |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 788 | clockFake.system.advance(10ms); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 789 | DbusEnvironment::sleepFor(ReportManager::minInterval + 1ms); |
| 790 | |
| 791 | const auto [timestamp, readings] = |
| 792 | getProperty<Readings>(sut->getPath(), "Readings"); |
| 793 | |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 794 | EXPECT_THAT(Milliseconds{timestamp}, Eq(systemTimestamp + 10ms)); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 795 | } |
| 796 | |
| 797 | TEST_F(TestReportPeriodicReport, readingsAreUpdatedAfterIntervalExpires) |
| 798 | { |
| 799 | DbusEnvironment::sleepFor(ReportManager::minInterval + 1ms); |
| 800 | |
| 801 | const auto [timestamp, readings] = |
| 802 | getProperty<Readings>(sut->getPath(), "Readings"); |
| 803 | |
| 804 | EXPECT_THAT(readings, |
| 805 | ElementsAre(std::make_tuple("a"s, "b"s, 17.1, 114u), |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 806 | std::make_tuple("aa"s, "bb"s, 42.0, 74u))); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 807 | } |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 808 | |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 809 | struct ReportUpdatesReportParams |
| 810 | { |
| 811 | ReportParams reportParams; |
| 812 | std::vector<ReadingData> expectedReadings; |
| 813 | bool expectedEnabled; |
| 814 | }; |
| 815 | |
| 816 | class TestReportWithReportUpdatesAndLimit : |
| 817 | public TestReport, |
| 818 | public WithParamInterface<ReportUpdatesReportParams> |
| 819 | { |
| 820 | void SetUp() override |
| 821 | { |
| 822 | sut = makeReport(ReportParams(GetParam().reportParams) |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 823 | .reportingType(ReportingType::periodic) |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 824 | .interval(std::chrono::hours(1000))); |
| 825 | } |
| 826 | }; |
| 827 | |
| 828 | INSTANTIATE_TEST_SUITE_P( |
| 829 | _, TestReportWithReportUpdatesAndLimit, |
| 830 | Values( |
| 831 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 832 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 833 | .reportUpdates(ReportUpdates::appendWrapsWhenFull) |
| 834 | .appendLimit(5), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 835 | std::vector<ReadingData>{{std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 836 | std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 837 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 838 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 839 | std::make_tuple("a"s, "b"s, 17.1, 114u)}}, |
| 840 | true}, |
| 841 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 842 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 843 | .reportUpdates(ReportUpdates::appendWrapsWhenFull) |
| 844 | .appendLimit(4), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 845 | std::vector<ReadingData>{ |
| 846 | {std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 847 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 848 | std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 849 | std::make_tuple("aa"s, "bb"s, 42.0, 74u)}}, |
| 850 | true}, |
| 851 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 852 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 853 | .reportUpdates(ReportUpdates::appendWrapsWhenFull) |
| 854 | .appendLimit(0), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 855 | std::vector<ReadingData>{}, true}, |
| 856 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 857 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 858 | .reportUpdates(ReportUpdates::appendStopsWhenFull) |
| 859 | .appendLimit(10), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 860 | std::vector<ReadingData>{ |
| 861 | {std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 862 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 863 | std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 864 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 865 | std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 866 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 867 | std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 868 | std::make_tuple("aa"s, "bb"s, 42.0, 74u)}}, |
| 869 | true}, |
| 870 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 871 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 872 | .reportUpdates(ReportUpdates::appendStopsWhenFull) |
| 873 | .appendLimit(5), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 874 | std::vector<ReadingData>{{std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 875 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 876 | std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 877 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 878 | std::make_tuple("a"s, "b"s, 17.1, 114u)}}, |
| 879 | false}, |
| 880 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 881 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 882 | .reportUpdates(ReportUpdates::appendStopsWhenFull) |
| 883 | .appendLimit(4), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 884 | std::vector<ReadingData>{ |
| 885 | {std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 886 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 887 | std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 888 | std::make_tuple("aa"s, "bb"s, 42.0, 74u)}}, |
| 889 | false}, |
| 890 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 891 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 892 | .reportUpdates(ReportUpdates::appendStopsWhenFull) |
| 893 | .appendLimit(0), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 894 | std::vector<ReadingData>{}, false}, |
| 895 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 896 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 897 | .reportUpdates(ReportUpdates::overwrite) |
| 898 | .appendLimit(500), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 899 | std::vector<ReadingData>{ |
| 900 | {std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 901 | std::make_tuple("aa"s, "bb"s, 42.0, 74u)}}, |
| 902 | true}, |
| 903 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 904 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 905 | .reportUpdates(ReportUpdates::overwrite) |
| 906 | .appendLimit(1), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 907 | std::vector<ReadingData>{ |
| 908 | {std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 909 | std::make_tuple("aa"s, "bb"s, 42.0, 74u)}}, |
| 910 | true}, |
| 911 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 912 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 913 | .reportUpdates(ReportUpdates::overwrite) |
| 914 | .appendLimit(0), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 915 | std::vector<ReadingData>{ |
| 916 | {std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 917 | std::make_tuple("aa"s, "bb"s, 42.0, 74u)}}, |
| 918 | true})); |
| 919 | |
| 920 | TEST_P(TestReportWithReportUpdatesAndLimit, |
| 921 | readingsAreUpdatedAfterIntervalExpires) |
| 922 | { |
| 923 | for (int i = 0; i < 4; i++) |
| 924 | { |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 925 | messanger.send(messages::UpdateReportInd{{sut->getId()}}); |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 926 | } |
| 927 | |
| 928 | const auto [timestamp, readings] = |
| 929 | getProperty<Readings>(sut->getPath(), "Readings"); |
| 930 | const auto enabled = getProperty<bool>(sut->getPath(), "Enabled"); |
| 931 | |
| 932 | EXPECT_THAT(readings, ElementsAreArray(GetParam().expectedReadings)); |
| 933 | EXPECT_EQ(enabled, GetParam().expectedEnabled); |
| 934 | } |
| 935 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 936 | class TestReportInitialization : public TestReport |
| 937 | { |
| 938 | public: |
| 939 | void SetUp() override |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 940 | { |
| 941 | initMetricMocks(defaultParams().metricParameters()); |
| 942 | } |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 943 | |
| 944 | void monitorProc(sdbusplus::message::message& msg) |
| 945 | { |
| 946 | std::string iface; |
| 947 | std::vector<std::pair<std::string, std::variant<Readings>>> |
| 948 | changed_properties; |
| 949 | std::vector<std::string> invalidated_properties; |
| 950 | |
| 951 | msg.read(iface, changed_properties, invalidated_properties); |
| 952 | |
| 953 | if (iface == Report::reportIfaceName) |
| 954 | { |
| 955 | for (const auto& [name, value] : changed_properties) |
| 956 | { |
| 957 | if (name == "Readings") |
| 958 | { |
| 959 | readingsUpdated.Call(); |
| 960 | } |
| 961 | } |
| 962 | } |
| 963 | } |
| 964 | |
| 965 | void makeMonitor() |
| 966 | { |
Patrick Williams | 3a62ee1 | 2021-12-03 10:13:25 -0600 | [diff] [blame] | 967 | monitor = std::make_unique<sdbusplus::bus::match_t>( |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 968 | *DbusEnvironment::getBus(), |
| 969 | sdbusplus::bus::match::rules::propertiesChanged( |
| 970 | sut->getPath(), Report::reportIfaceName), |
| 971 | [this](auto& msg) { monitorProc(msg); }); |
| 972 | } |
| 973 | |
Patrick Williams | 3a62ee1 | 2021-12-03 10:13:25 -0600 | [diff] [blame] | 974 | std::unique_ptr<sdbusplus::bus::match_t> monitor; |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 975 | MockFunction<void()> readingsUpdated; |
| 976 | }; |
| 977 | |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 978 | TEST_F(TestReportInitialization, |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 979 | registersForMetricUpdatesWhenOnChangeReportCreated) |
Krzysztof Grobelny | 6ccfcbf | 2020-11-04 09:31:36 +0100 | [diff] [blame] | 980 | { |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 981 | std::vector<const interfaces::MetricListener*> args; |
Krzysztof Grobelny | 6ccfcbf | 2020-11-04 09:31:36 +0100 | [diff] [blame] | 982 | for (auto& metric : metricMocks) |
| 983 | { |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 984 | EXPECT_CALL(*metric, registerForUpdates(_)) |
| 985 | .WillOnce(Invoke([&args](const interfaces::MetricListener& report) { |
| 986 | args.emplace_back(&report); |
| 987 | })); |
| 988 | ; |
Krzysztof Grobelny | 6ccfcbf | 2020-11-04 09:31:36 +0100 | [diff] [blame] | 989 | } |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 990 | |
| 991 | sut = makeReport(defaultParams().reportingType(ReportingType::onChange)); |
| 992 | |
| 993 | EXPECT_THAT(args, SizeIs(metricMocks.size())); |
| 994 | for (const auto* reportPtr : args) |
| 995 | { |
| 996 | EXPECT_THAT(reportPtr, Eq(sut.get())); |
| 997 | } |
| 998 | } |
| 999 | |
| 1000 | TEST_F(TestReportInitialization, |
| 1001 | deregistersForMetricUpdatesWhenOnChangeReportDestroyed) |
| 1002 | { |
| 1003 | sut = makeReport(defaultParams().reportingType(ReportingType::onChange)); |
| 1004 | |
| 1005 | for (auto& metric : metricMocks) |
| 1006 | { |
| 1007 | EXPECT_CALL(*metric, |
| 1008 | unregisterFromUpdates(Ref( |
| 1009 | static_cast<interfaces::MetricListener&>(*sut.get())))); |
| 1010 | } |
| 1011 | |
| 1012 | sut = nullptr; |
| 1013 | } |
| 1014 | |
| 1015 | TEST_F(TestReportInitialization, |
| 1016 | metricsAreInitializedWhenEnabledReportConstructed) |
| 1017 | { |
| 1018 | for (auto& metric : metricMocks) |
| 1019 | { |
| 1020 | EXPECT_CALL(*metric, initialize()); |
| 1021 | } |
| 1022 | sut = makeReport(defaultParams().enabled(true)); |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 1023 | } |
Krzysztof Grobelny | 6ccfcbf | 2020-11-04 09:31:36 +0100 | [diff] [blame] | 1024 | |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 1025 | TEST_F(TestReportInitialization, |
| 1026 | metricsAreNotInitializedWhenDisabledReportConstructed) |
| 1027 | { |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 1028 | for (auto& metric : metricMocks) |
| 1029 | { |
| 1030 | EXPECT_CALL(*metric, initialize()).Times(0); |
| 1031 | } |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1032 | sut = makeReport(defaultParams().enabled(false)); |
Krzysztof Grobelny | 6ccfcbf | 2020-11-04 09:31:36 +0100 | [diff] [blame] | 1033 | } |
| 1034 | |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 1035 | TEST_F(TestReportInitialization, |
| 1036 | emitReadingsUpdateIsTrueReadingsPropertiesChangedSingalEmits) |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 1037 | { |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 1038 | EXPECT_CALL(readingsUpdated, Call()) |
| 1039 | .WillOnce( |
| 1040 | InvokeWithoutArgs(DbusEnvironment::setPromise("readingsUpdated"))); |
| 1041 | |
| 1042 | const auto elapsed = DbusEnvironment::measureTime([this] { |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 1043 | sut = |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1044 | makeReport(defaultParams() |
| 1045 | .reportingType(ReportingType::periodic) |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 1046 | .reportActions({ReportAction::emitsReadingsUpdate})); |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 1047 | makeMonitor(); |
| 1048 | EXPECT_TRUE(DbusEnvironment::waitForFuture("readingsUpdated")); |
| 1049 | }); |
| 1050 | |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1051 | EXPECT_THAT(elapsed, AllOf(Ge(defaultParams().interval()), |
| 1052 | Lt(defaultParams().interval() * 2))); |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 1053 | } |
| 1054 | |
| 1055 | TEST_F(TestReportInitialization, |
| 1056 | emitReadingsUpdateIsFalseReadingsPropertiesChangesSigalDoesNotEmits) |
| 1057 | { |
| 1058 | EXPECT_CALL(readingsUpdated, Call()).Times(0); |
| 1059 | |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1060 | sut = makeReport(defaultParams() |
| 1061 | .reportingType(ReportingType::periodic) |
| 1062 | .reportActions({})); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 1063 | makeMonitor(); |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1064 | DbusEnvironment::sleepFor(defaultParams().interval() * 2); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 1065 | } |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1066 | |
| 1067 | TEST_F(TestReportInitialization, appendLimitDeducedProperly) |
| 1068 | { |
| 1069 | sut = makeReport( |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1070 | defaultParams().appendLimit(std::numeric_limits<uint64_t>::max())); |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1071 | auto appendLimit = getProperty<uint64_t>(sut->getPath(), "AppendLimit"); |
| 1072 | EXPECT_EQ(appendLimit, 2ull); |
| 1073 | } |
Krzysztof Grobelny | e6c417c | 2022-02-02 17:25:53 +0100 | [diff] [blame] | 1074 | |
| 1075 | TEST_F(TestReportInitialization, appendLimitSetToUintMaxIsStoredCorrectly) |
| 1076 | { |
Krzysztof Grobelny | e6c417c | 2022-02-02 17:25:53 +0100 | [diff] [blame] | 1077 | sut = makeReport( |
| 1078 | ReportParams().appendLimit(std::numeric_limits<uint64_t>::max())); |
| 1079 | |
| 1080 | ASSERT_THAT(storedConfiguration.at("AppendLimit"), |
| 1081 | Eq(std::numeric_limits<uint64_t>::max())); |
| 1082 | } |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 1083 | |
| 1084 | TEST_F(TestReportInitialization, triggerIdsPropertyIsInitialzed) |
| 1085 | { |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 1086 | for (const auto& triggerId : {"trigger1", "trigger2"}) |
| 1087 | { |
| 1088 | messanger.on_receive<messages::CollectTriggerIdReq>( |
| 1089 | [&](const auto& msg) { |
| 1090 | messanger.send(messages::CollectTriggerIdResp{triggerId}); |
| 1091 | }); |
| 1092 | } |
| 1093 | |
| 1094 | sut = makeReport(ReportParams()); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 1095 | |
| 1096 | EXPECT_THAT( |
| 1097 | getProperty<std::vector<std::string>>(sut->getPath(), "TriggerIds"), |
| 1098 | UnorderedElementsAre("trigger1", "trigger2")); |
| 1099 | } |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1100 | |
Krzysztof Grobelny | 493e62e | 2022-02-14 10:55:50 +0100 | [diff] [blame] | 1101 | TEST_F(TestReportInitialization, |
| 1102 | metricValuesAreNotStoredForReportUpdatesDifferentThanAppendStopsWhenFull) |
| 1103 | { |
| 1104 | sut = makeReport(ReportParams() |
| 1105 | .reportingType(ReportingType::periodic) |
| 1106 | .interval(1h) |
| 1107 | .reportUpdates(ReportUpdates::appendWrapsWhenFull) |
| 1108 | .readings(Readings{{}, {{}}})); |
| 1109 | |
| 1110 | ASSERT_THAT(storedConfiguration.find("MetricValues"), |
| 1111 | Eq(storedConfiguration.end())); |
| 1112 | } |
| 1113 | |
| 1114 | TEST_F(TestReportInitialization, metricValuesAreNotStoredForOnRequestReport) |
| 1115 | { |
| 1116 | sut = makeReport(ReportParams() |
| 1117 | .reportingType(ReportingType::onRequest) |
| 1118 | .reportUpdates(ReportUpdates::appendStopsWhenFull) |
| 1119 | .readings(Readings{{}, {{}}})); |
| 1120 | |
| 1121 | ASSERT_THAT(storedConfiguration.find("MetricValues"), |
| 1122 | Eq(storedConfiguration.end())); |
| 1123 | } |
| 1124 | |
| 1125 | TEST_F(TestReportInitialization, |
| 1126 | metricValuesAreStoredForNonOnRequestReportWithAppendStopsWhenFull) |
| 1127 | { |
| 1128 | const auto readings = Readings{{}, {{}}}; |
| 1129 | |
| 1130 | sut = makeReport(ReportParams() |
| 1131 | .reportingType(ReportingType::periodic) |
| 1132 | .interval(1h) |
| 1133 | .reportUpdates(ReportUpdates::appendStopsWhenFull) |
| 1134 | .readings(readings)); |
| 1135 | |
| 1136 | ASSERT_THAT(storedConfiguration.at("MetricValues").get<LabeledReadings>(), |
| 1137 | Eq(utils::toLabeledReadings(readings))); |
| 1138 | } |
| 1139 | |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1140 | class TestReportInitializationOnChangeReport : public TestReportInitialization |
| 1141 | { |
| 1142 | public: |
| 1143 | void SetUp() override |
| 1144 | { |
| 1145 | initMetricMocks(params.metricParameters()); |
| 1146 | } |
| 1147 | |
| 1148 | ReportParams params = defaultOnChangeParams(); |
| 1149 | }; |
| 1150 | |
| 1151 | TEST_F(TestReportInitializationOnChangeReport, |
| 1152 | doesntUpdateReadingsWhenNotRequired) |
| 1153 | { |
| 1154 | EXPECT_CALL(*metricMocks[0], updateReadings(_)).Times(0); |
| 1155 | |
| 1156 | ON_CALL(*metricMocks[0], isTimerRequired()).WillByDefault(Return(false)); |
| 1157 | |
| 1158 | sut = makeReport(params); |
| 1159 | |
| 1160 | DbusEnvironment::sleepFor(500ms); |
| 1161 | } |
| 1162 | |
| 1163 | TEST_F(TestReportInitializationOnChangeReport, updatesReadingsWhenRequired) |
| 1164 | { |
| 1165 | EXPECT_CALL(*metricMocks[0], updateReadings(_)) |
| 1166 | .WillOnce(Return()) |
| 1167 | .WillOnce( |
| 1168 | InvokeWithoutArgs(DbusEnvironment::setPromise("readingsUpdated"))) |
| 1169 | .WillRepeatedly(Return()); |
| 1170 | |
| 1171 | ON_CALL(*metricMocks[0], isTimerRequired()).WillByDefault(Return(true)); |
| 1172 | |
| 1173 | sut = makeReport(params); |
| 1174 | |
| 1175 | DbusEnvironment::waitForFuture("readingsUpdated"); |
| 1176 | } |