commit d7ea283b7ec6c7718ac70b0d38c654b9a5bac3db
author Olivier FAURAX <olivier.faurax@eu.equinix.com> Fri Apr 14 14:08:02 2023 +0000
committer Olivier FAURAX <olivier.faurax@eu.equinix.com> Tue May 16 06:42:46 2023 +0000
tree 7e1e592876d5e484e38de735980b9b5b9cb76791
parent 48aa1f05d51c2f2cc86e9592a3569e022f9171c8

Add option to only log nmiButtonPress when host is running

While NMI button presses are of little interest when the host is off,
some systems (e.g. romed8hm3) generates spurious events on shutdown,
probably due to some lack of electronic stability.
This patch adds an option to disable handling these events when host is off.

Change-Id: Idc74b2dcb7131ddf6d99d1b8c49d947be98de78e
Signed-off-by: Olivier FAURAX <olivier.faurax@eu.equinix.com>

config/power-config-host0.json

diff --git a/config/power-config-host0.json b/config/power-config-host0.json
index 83e1059..f575b15 100644
--- a/config/power-config-host0.json
+++ b/config/power-config-host0.json
@@ -83,5 +83,8 @@
         "GracefulPowerOffS": 300,
         "WarmResetCheckMs": 500,
         "PowerOffSaveMs": 7000
+    },
+    "event_configs": {
+        "NMIWhenPoweredOff": true
     }
 }

src/power_control.cpp

diff --git a/src/power_control.cpp b/src/power_control.cpp
index 0dafd60..07fc14f 100644
--- a/src/power_control.cpp
+++ b/src/power_control.cpp
@@ -145,6 +145,7 @@
     {"SlotPowerCycleMs", 200}};
 
 static bool nmiEnabled = true;
+static bool nmiWhenPoweredOff = true;
 static bool sioEnabled = true;
 
 // Timers
@@ -2191,6 +2192,13 @@
 
 static void nmiButtonHandler(bool state)
 {
+    // Don't handle event if host not running and config doesn't force it
+    if (!nmiWhenPoweredOff &&
+        getHostState(powerState) !=
+            "xyz.openbmc_project.State.Host.HostState.Running")
+    {
+        return;
+    }
     nmiButtonIface->set_property("ButtonPressed", !state);
     if (!state)
     {
@@ -2415,6 +2423,14 @@
         }
     }
 
+    // If "events_configs" key is not in json config, fallback to {}
+    auto events = jsonData.value(
+        "event_configs", nlohmann::json(nlohmann::json::value_t::object));
+    if (events)
+    {
+        nmiWhenPoweredOff = events.value("NMIWhenPoweredOff", true);
+    }
+
     return 0;
 }