| Brad Bishop | 286d45c | 2018-10-02 15:21:57 -0400 | [diff] [blame] | 1 | From 22c63d4d79ac488403340470c14c73bad4984fa3 Mon Sep 17 00:00:00 2001 |
| 2 | From: David Holsgrove <david.holsgrove@xilinx.com> |
| 3 | Date: Wed, 27 Feb 2013 13:56:11 +1000 |
| 4 | Subject: [PATCH 15/16] [LOCAL]: upstream change to garbage collection sweep |
| 5 | causes mb regression |
| 6 | |
| 7 | Upstream change for PR13177 now clears the def_regular during gc_sweep of a |
| 8 | section. (All other archs in binutils/bfd/elf32-*.c received an update |
| 9 | to a warning about unresolvable relocations - this warning is not present |
| 10 | in binutils/bfd/elf32-microblaze.c, but this warning check would not |
| 11 | prevent the error being seen) |
| 12 | |
| 13 | The visible issue with this change is when running a c++ application |
| 14 | in Petalinux which links libstdc++.so for exception handling it segfaults |
| 15 | on execution. |
| 16 | |
| 17 | This does not occur if static linking libstdc++.a, so its during the |
| 18 | relocations for a shared lib with garbage collection this occurs |
| 19 | |
| 20 | Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com> |
| 21 | Upstream-Status: Pending |
| 22 | --- |
| 23 | bfd/elflink.c | 1 - |
| 24 | 1 file changed, 1 deletion(-) |
| 25 | |
| 26 | diff --git a/bfd/elflink.c b/bfd/elflink.c |
| 27 | index 6756fb1..f21dc06 100644 |
| 28 | --- a/bfd/elflink.c |
| 29 | +++ b/bfd/elflink.c |
| 30 | @@ -11932,7 +11932,6 @@ elf_gc_sweep_symbol (struct elf_link_hash_entry *h, void *data) |
| 31 | |
| 32 | inf = (struct elf_gc_sweep_symbol_info *) data; |
| 33 | (*inf->hide_symbol) (inf->info, h, TRUE); |
| 34 | - h->def_regular = 0; |
| 35 | h->ref_regular = 0; |
| 36 | h->ref_regular_nonweak = 0; |
| 37 | } |
| 38 | -- |
| 39 | 1.9.0 |
| 40 | |