blob: 9fc1421fdd6909c2863c2f6e8be250532745cbf2 [file] [log] [blame]
Brad Bishop6e60e8b2018-02-01 10:27:11 -05001From ef832a115b40861c08df333339b1366da49e5393 Mon Sep 17 00:00:00 2001
2From: Khem Raj <raj.khem@gmail.com>
3Date: Sun, 17 Apr 2016 12:35:41 -0700
4Subject: [PATCH 9/9] WebKitMacros: Append to -I and not to -isystem
5
6gcc-6 has now introduced stdlib.h in libstdc++ for better
7compliance and its including the C library stdlib.h using
8include_next which is sensitive to order of system header
9include paths. Its infact better to not tinker with the
10system header include paths at all. Since adding /usr/include
11to -system is redundant and compiler knows about it moreover
12now with gcc6 it interferes with compiler's functioning
13and ends up with compile errors e.g.
14
15/usr/include/c++/6.0.0/cstdlib:75:25: fatal error: stdlib.h: No such file or directory
16
17Signed-off-by: Khem Raj <raj.khem@gmail.com>
18
Brad Bishop316dfdd2018-06-25 12:45:53 -040019Upstream-Status: Pending
Brad Bishop6e60e8b2018-02-01 10:27:11 -050020---
21 Source/JavaScriptCore/shell/CMakeLists.txt | 2 +-
22 Source/WebCore/PlatformGTK.cmake | 6 +++---
23 Source/WebKit/PlatformGTK.cmake | 2 +-
24 Source/cmake/WebKitMacros.cmake | 2 +-
25 Tools/MiniBrowser/gtk/CMakeLists.txt | 2 +-
26 Tools/TestWebKitAPI/PlatformGTK.cmake | 2 +-
27 6 files changed, 8 insertions(+), 8 deletions(-)
28
29diff --git a/Source/JavaScriptCore/shell/CMakeLists.txt b/Source/JavaScriptCore/shell/CMakeLists.txt
30index bc37dd31..4e49871f 100644
31--- a/Source/JavaScriptCore/shell/CMakeLists.txt
32+++ b/Source/JavaScriptCore/shell/CMakeLists.txt
33@@ -35,7 +35,7 @@ WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()
34 WEBKIT_WRAP_SOURCELIST(${JSC_SOURCES})
35 WEBKIT_WRAP_SOURCELIST(${TESTAPI_SOURCES})
36 include_directories(./ ${JavaScriptCore_INCLUDE_DIRECTORIES})
37-include_directories(SYSTEM ${JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES})
38+include_directories(${JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES})
39 add_executable(jsc ${JSC_SOURCES})
40 target_link_libraries(jsc ${JSC_LIBRARIES})
41
42diff --git a/Source/WebCore/PlatformGTK.cmake b/Source/WebCore/PlatformGTK.cmake
43index 73506c74..8eb8b415 100644
44--- a/Source/WebCore/PlatformGTK.cmake
45+++ b/Source/WebCore/PlatformGTK.cmake
46@@ -281,7 +281,7 @@ if (ENABLE_PLUGIN_PROCESS_GTK2)
47 ${GTK2_INCLUDE_DIRS}
48 ${GDK2_INCLUDE_DIRS}
49 )
50- target_include_directories(WebCorePlatformGTK2 SYSTEM PRIVATE
51+ target_include_directories(WebCorePlatformGTK2 PRIVATE
52 ${WebCore_SYSTEM_INCLUDE_DIRECTORIES}
53 )
54 target_link_libraries(WebCorePlatformGTK2
55@@ -305,7 +305,7 @@ add_dependencies(WebCorePlatformGTK WebCore)
56 target_include_directories(WebCorePlatformGTK PRIVATE
57 ${WebCore_INCLUDE_DIRECTORIES}
58 )
59-target_include_directories(WebCorePlatformGTK SYSTEM PRIVATE
60+target_include_directories(WebCorePlatformGTK PRIVATE
61 ${WebCore_SYSTEM_INCLUDE_DIRECTORIES}
62 ${GTK_INCLUDE_DIRS}
63 ${GDK_INCLUDE_DIRS}
64@@ -321,7 +321,7 @@ include_directories(
65 "${WEBCORE_DIR}/bindings/gobject/"
66 )
67
68-include_directories(SYSTEM
69+include_directories(
70 ${WebCore_SYSTEM_INCLUDE_DIRECTORIES}
71 )
72
73diff --git a/Source/WebKit/PlatformGTK.cmake b/Source/WebKit/PlatformGTK.cmake
74index d83a2e77..401246f4 100644
75--- a/Source/WebKit/PlatformGTK.cmake
76+++ b/Source/WebKit/PlatformGTK.cmake
77@@ -1050,7 +1050,7 @@ if (ENABLE_PLUGIN_PROCESS_GTK2)
78 target_include_directories(WebKitPluginProcess2 PRIVATE
79 ${WebKit2CommonIncludeDirectories}
80 )
81- target_include_directories(WebKitPluginProcess2 SYSTEM PRIVATE
82+ target_include_directories(WebKitPluginProcess2 PRIVATE
83 ${WebKit2CommonSystemIncludeDirectories}
84 ${GTK2_INCLUDE_DIRS}
85 ${GDK2_INCLUDE_DIRS}
86diff --git a/Source/cmake/WebKitMacros.cmake b/Source/cmake/WebKitMacros.cmake
87index 7bc89543..d9818fa4 100644
88--- a/Source/cmake/WebKitMacros.cmake
89+++ b/Source/cmake/WebKitMacros.cmake
90@@ -78,7 +78,7 @@ macro(WEBKIT_FRAMEWORK_DECLARE _target)
91 endmacro()
92
93 macro(WEBKIT_FRAMEWORK _target)
94- include_directories(SYSTEM ${${_target}_SYSTEM_INCLUDE_DIRECTORIES})
95+ include_directories(${${_target}_SYSTEM_INCLUDE_DIRECTORIES})
96 target_sources(${_target} PRIVATE
97 ${${_target}_HEADERS}
98 ${${_target}_SOURCES}
99diff --git a/Tools/MiniBrowser/gtk/CMakeLists.txt b/Tools/MiniBrowser/gtk/CMakeLists.txt
100index e832a86d..ce92c864 100644
101--- a/Tools/MiniBrowser/gtk/CMakeLists.txt
102+++ b/Tools/MiniBrowser/gtk/CMakeLists.txt
103@@ -57,7 +57,7 @@ endif ()
104 add_definitions(-DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_6)
105
106 include_directories(${MiniBrowser_INCLUDE_DIRECTORIES})
107-include_directories(SYSTEM ${MiniBrowser_SYSTEM_INCLUDE_DIRECTORIES})
108+include_directories(${MiniBrowser_SYSTEM_INCLUDE_DIRECTORIES})
109 add_executable(MiniBrowser ${MiniBrowser_SOURCES})
110 target_link_libraries(MiniBrowser ${MiniBrowser_LIBRARIES})
111
112diff --git a/Tools/TestWebKitAPI/PlatformGTK.cmake b/Tools/TestWebKitAPI/PlatformGTK.cmake
113index 1be3dd52..7bdddf37 100644
114--- a/Tools/TestWebKitAPI/PlatformGTK.cmake
115+++ b/Tools/TestWebKitAPI/PlatformGTK.cmake
116@@ -20,7 +20,7 @@ include_directories(
117 ${WEBKIT2_DIR}/UIProcess/API/gtk
118 )
119
120-include_directories(SYSTEM
121+include_directories(
122 ${GDK3_INCLUDE_DIRS}
123 ${GLIB_INCLUDE_DIRS}
124 ${GTK3_INCLUDE_DIRS}
125--
1262.14.1
127