Andrew Geissler | 97771a3 | 2021-03-05 15:23:11 -0600 | [diff] [blame] | 1 | From de10fbc2386dcac3ab810c49b6977b2ee01bf426 Mon Sep 17 00:00:00 2001 |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 2 | From: Khem Raj <raj.khem@gmail.com> |
Andrew Geissler | 97771a3 | 2021-03-05 15:23:11 -0600 | [diff] [blame] | 3 | Date: Wed, 17 Feb 2021 13:30:23 -0800 |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 4 | Subject: [PATCH] setup.py: Do not mix C and C++ compiler options |
| 5 | |
| 6 | EXTRA_ENV_COMPILE_ARGS is used both with CC and CXX |
| 7 | so using -std=c++11 or -std=gnu99 together will cause |
| 8 | build time errors espcially with clang |
| 9 | |
Andrew Geissler | 97771a3 | 2021-03-05 15:23:11 -0600 | [diff] [blame] | 10 | Keep '-std=c++11' to fix native build error |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 11 | with old gcc (such as gcc 5.4.0 on ubuntu 16.04), for clang |
| 12 | we will remove them through GRPC_PYTHON_CFLAGS at do_compile |
| 13 | in bb recipe. |
| 14 | |
Andrew Geissler | 97771a3 | 2021-03-05 15:23:11 -0600 | [diff] [blame] | 15 | While export CC="gcc ", cc_args is None, it will |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 16 | cause subprocess.Popen always return 1. On centos 8, if you don't |
| 17 | install package libatomic, there will be a native build error |
| 18 | `cannot find /usr/lib64/libatomic.so.1.2.0'. |
| 19 | |
| 20 | Add no harm '-g' to cc_args if cc_args is empty. |
| 21 | |
| 22 | Upstream-Status: Inappropriate [oe specific] |
Andrew Geissler | 97771a3 | 2021-03-05 15:23:11 -0600 | [diff] [blame] | 23 | |
| 24 | Signed-off-by: Khem Raj <raj.khem@gmail.com> |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 25 | Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> |
| 26 | --- |
Andrew Geissler | 97771a3 | 2021-03-05 15:23:11 -0600 | [diff] [blame] | 27 | setup.py | 9 ++++++--- |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 28 | src/python/grpcio/commands.py | 5 ++++- |
Andrew Geissler | 97771a3 | 2021-03-05 15:23:11 -0600 | [diff] [blame] | 29 | 2 files changed, 10 insertions(+), 4 deletions(-) |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 30 | |
| 31 | diff --git a/setup.py b/setup.py |
Andrew Geissler | 97771a3 | 2021-03-05 15:23:11 -0600 | [diff] [blame] | 32 | index 4b8c9d4..271b7b1 100644 |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 33 | --- a/setup.py |
| 34 | +++ b/setup.py |
Andrew Geissler | 97771a3 | 2021-03-05 15:23:11 -0600 | [diff] [blame] | 35 | @@ -172,8 +172,11 @@ def check_linker_need_libatomic(): |
| 36 | """Test if linker on system needs libatomic.""" |
| 37 | code_test = (b'#include <atomic>\n' + |
| 38 | b'int main() { return std::atomic<int64_t>{}; }') |
| 39 | - cxx = os.environ.get('CXX', 'c++') |
| 40 | - cpp_test = subprocess.Popen([cxx, '-x', 'c++', '-std=c++11', '-'], |
| 41 | + cxx, cxx_args = os.environ.get('CXX').split(' ', 1) or 'c++' |
| 42 | + if not cxx_args: |
| 43 | + cxx_args = "-g" |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 44 | + |
Andrew Geissler | 97771a3 | 2021-03-05 15:23:11 -0600 | [diff] [blame] | 45 | + cpp_test = subprocess.Popen([cxx, cxx_args, '-x', 'c++', '-std=c++11', '-'], |
| 46 | stdin=PIPE, |
| 47 | stdout=PIPE, |
| 48 | stderr=PIPE) |
| 49 | @@ -183,7 +186,7 @@ def check_linker_need_libatomic(): |
| 50 | # Double-check to see if -latomic actually can solve the problem. |
| 51 | # https://github.com/grpc/grpc/issues/22491 |
| 52 | cpp_test = subprocess.Popen( |
| 53 | - [cxx, '-x', 'c++', '-std=c++11', '-latomic', '-'], |
| 54 | + [cxx, cxx_args, '-x', 'c++', '-std=c++11', '-latomic', '-'], |
| 55 | stdin=PIPE, |
| 56 | stdout=PIPE, |
| 57 | stderr=PIPE) |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 58 | diff --git a/src/python/grpcio/commands.py b/src/python/grpcio/commands.py |
Andrew Geissler | 97771a3 | 2021-03-05 15:23:11 -0600 | [diff] [blame] | 59 | index a8b2ff5..b928201 100644 |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 60 | --- a/src/python/grpcio/commands.py |
| 61 | +++ b/src/python/grpcio/commands.py |
Andrew Geissler | 97771a3 | 2021-03-05 15:23:11 -0600 | [diff] [blame] | 62 | @@ -219,7 +219,10 @@ class BuildExt(build_ext.build_ext): |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 63 | """ |
Andrew Geissler | 97771a3 | 2021-03-05 15:23:11 -0600 | [diff] [blame] | 64 | try: |
| 65 | # TODO(lidiz) Remove the generated a.out for success tests. |
| 66 | - cc_test = subprocess.Popen(['cc', '-x', 'c', '-std=c++11', '-'], |
| 67 | + cc_test, cc_args = os.environ.get('CC').split(' ', 1) or 'gcc' |
| 68 | + if not cc_args: |
| 69 | + cc_args = "-g" |
| 70 | + cc_test = subprocess.Popen([cc_test, cc_args, '-x', 'c', '-std=c++11', '-'], |
| 71 | stdin=subprocess.PIPE, |
| 72 | stdout=subprocess.PIPE, |
| 73 | stderr=subprocess.PIPE) |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 74 | -- |
Andrew Geissler | 97771a3 | 2021-03-05 15:23:11 -0600 | [diff] [blame] | 75 | 2.30.1 |
Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 76 | |