Brad Bishop | 34ae600 | 2019-04-08 15:21:03 -0400 | [diff] [blame] | 1 | From 87b94e54fefa1f83b41030444fc87b421c97b2c5 Mon Sep 17 00:00:00 2001 |
| 2 | From: Alistair Francis <alistair.francis@wdc.com> |
| 3 | Date: Tue, 19 Mar 2019 13:38:44 -0700 |
| 4 | Subject: [PATCH 3/5] Use python3 and pip3 instead of python and pip |
| 5 | |
| 6 | Signed-off-by: Alistair Francis <alistair.francis@wdc.com> |
| 7 | Upstream-Status: Inappropriate [embedded specific] |
| 8 | --- |
| 9 | bin/mycroft-cli-client | 2 +- |
| 10 | bin/mycroft-pip | 2 +- |
| 11 | bin/mycroft-say-to | 2 +- |
| 12 | bin/mycroft-skill-testrunner | 4 ++-- |
| 13 | bin/mycroft-speak | 2 +- |
| 14 | dev_setup.sh | 10 +++++----- |
| 15 | scripts/install-pocketsphinx.sh | 2 +- |
| 16 | 7 files changed, 12 insertions(+), 12 deletions(-) |
| 17 | |
| 18 | diff --git a/bin/mycroft-cli-client b/bin/mycroft-cli-client |
| 19 | index f40a316e3f6..de2040d9e67 100755 |
| 20 | --- a/bin/mycroft-cli-client |
| 21 | +++ b/bin/mycroft-cli-client |
| 22 | @@ -21,4 +21,4 @@ DIR="$( dirname "$SOURCE" )" |
| 23 | source "$DIR/../venv-activate.sh" -q |
| 24 | |
| 25 | # Invoke the Command Line Interface |
| 26 | -python -m mycroft.client.text $@ |
| 27 | +python3 -m mycroft.client.text $@ |
| 28 | diff --git a/bin/mycroft-pip b/bin/mycroft-pip |
| 29 | index a42b16b847a..81bd5bfb3cf 100755 |
| 30 | --- a/bin/mycroft-pip |
| 31 | +++ b/bin/mycroft-pip |
| 32 | @@ -21,4 +21,4 @@ DIR="$( dirname "$SOURCE" )" |
| 33 | source "$DIR/../venv-activate.sh" -q |
| 34 | |
| 35 | # Install pip packages within the Mycroft venv |
| 36 | -pip $@ |
| 37 | \ No newline at end of file |
| 38 | +pip3 $@ |
| 39 | \ No newline at end of file |
| 40 | diff --git a/bin/mycroft-say-to b/bin/mycroft-say-to |
| 41 | index 964e16eb0c5..5575969715c 100755 |
| 42 | --- a/bin/mycroft-say-to |
| 43 | +++ b/bin/mycroft-say-to |
| 44 | @@ -22,4 +22,4 @@ DIR="$( pwd )" |
| 45 | source "$DIR/../venv-activate.sh" -q |
| 46 | |
| 47 | # Send a message to be spoken |
| 48 | -output=$(python -m mycroft.messagebus.send "recognizer_loop:utterance" "{\"utterances\": [\"$@\"], \"lang\": \"en-us\"}") |
| 49 | +output=$(python3 -m mycroft.messagebus.send "recognizer_loop:utterance" "{\"utterances\": [\"$@\"], \"lang\": \"en-us\"}") |
| 50 | diff --git a/bin/mycroft-skill-testrunner b/bin/mycroft-skill-testrunner |
| 51 | index 9699a4d138f..282f5ca65b0 100755 |
| 52 | --- a/bin/mycroft-skill-testrunner |
| 53 | +++ b/bin/mycroft-skill-testrunner |
| 54 | @@ -22,7 +22,7 @@ source "$DIR/../venv-activate.sh" -q |
| 55 | |
| 56 | # Invoke the individual skill tester |
| 57 | if [ "$#" -eq 0 ] ; then |
| 58 | - python -m test.integrationtests.skills.runner . |
| 59 | + python3 -m test.integrationtests.skills.runner . |
| 60 | else |
| 61 | - python -m test.integrationtests.skills.runner $@ |
| 62 | + python3 -m test.integrationtests.skills.runner $@ |
| 63 | fi |
| 64 | \ No newline at end of file |
| 65 | diff --git a/bin/mycroft-speak b/bin/mycroft-speak |
| 66 | index 51facf29189..c65556f1173 100755 |
| 67 | --- a/bin/mycroft-speak |
| 68 | +++ b/bin/mycroft-speak |
| 69 | @@ -22,4 +22,4 @@ DIR="$( pwd )" |
| 70 | source "$DIR/../venv-activate.sh" -q |
| 71 | |
| 72 | # Send a message to be spoken |
| 73 | -output=$(python -m mycroft.messagebus.send "speak" "{\"utterance\": \"$@\"}") |
| 74 | \ No newline at end of file |
| 75 | +output=$(python3 -m mycroft.messagebus.send "speak" "{\"utterance\": \"$@\"}") |
| 76 | \ No newline at end of file |
| 77 | diff --git a/dev_setup.sh b/dev_setup.sh |
| 78 | index aed54b2167a..dd391181f19 100755 |
| 79 | --- a/dev_setup.sh |
| 80 | +++ b/dev_setup.sh |
| 81 | @@ -48,7 +48,7 @@ param="" |
| 82 | |
| 83 | for var in "$@" ; do |
| 84 | # Check if parameter should be read |
| 85 | - if [[ ${param} == "python" ]] ; then |
| 86 | + if [[ ${param} == "python3" ]] ; then |
| 87 | opt_python=${var} |
| 88 | param="" |
| 89 | continue |
| 90 | @@ -351,17 +351,17 @@ if [ -z ${INSTALL_PRECOMMIT_HOOK} ] ; then |
| 91 | HOOK_FILE="./.git/hooks/pre-commit" |
| 92 | if [ ! -f ${HOOK_FILE} ] || grep -q "MYCROFT DEV SETUP" ${HOOK_FILE} ; then |
| 93 | echo "Installing PEP8 check as precommit-hook" |
| 94 | - echo "#! $( which python )" > ${HOOK_FILE} |
| 95 | + echo "#! $( which python3 )" > ${HOOK_FILE} |
| 96 | echo "# MYCROFT DEV SETUP" >> ${HOOK_FILE} |
| 97 | cat ./scripts/pre-commit >> ${HOOK_FILE} |
| 98 | chmod +x ${HOOK_FILE} |
| 99 | fi |
| 100 | fi |
| 101 | |
| 102 | -PYTHON=$( python -c "import sys;print('python{}.{}'.format(sys.version_info[0], sys.version_info[1]))" ) |
| 103 | +PYTHON=$( python3 -c "import sys;print('python{}.{}'.format(sys.version_info[0], sys.version_info[1]))" ) |
| 104 | |
| 105 | # install required python modules |
| 106 | -if ! pip install -r requirements.txt ; then |
| 107 | +if ! pip3 install -r requirements.txt ; then |
| 108 | echo "Warning: Failed to install all requirements. Continue? y/N" |
| 109 | read -n1 continue |
| 110 | if [[ "$continue" != "y" ]] ; then |
| 111 | @@ -369,7 +369,7 @@ if ! pip install -r requirements.txt ; then |
| 112 | fi |
| 113 | fi |
| 114 | |
| 115 | -if ! pip install -r test-requirements.txt ; then |
| 116 | +if ! pip3 install -r test-requirements.txt ; then |
| 117 | echo "Warning test requirements wasn't installed, Note: normal operation should still work fine..." |
| 118 | fi |
| 119 | |
| 120 | diff --git a/scripts/install-pocketsphinx.sh b/scripts/install-pocketsphinx.sh |
| 121 | index 44d329b7985..d45f5c22747 100755 |
| 122 | --- a/scripts/install-pocketsphinx.sh |
| 123 | +++ b/scripts/install-pocketsphinx.sh |
| 124 | @@ -47,7 +47,7 @@ function install_pocketsphinx() { |
| 125 | |
| 126 | # build and install pocketsphinx python bindings |
| 127 | cd ${TOP}/pocketsphinx-python |
| 128 | - python setup.py install |
| 129 | + python3 setup.py install |
| 130 | } |
| 131 | |
| 132 | if [ "$1" = "-q" ] ; then |
| 133 | -- |
| 134 | 2.21.0 |
| 135 | |