| Brad Bishop | 15ae250 | 2019-06-18 21:44:24 -0400 | [diff] [blame] | 1 | Test script to reproduce the problem: |
| 2 | |
| 3 | #!/usr/bin/env perl |
| 4 | $) = "2 2"; |
| 5 | print $!; |
| 6 | |
| 7 | Result from perl 5.28 under strace: |
| 8 | |
| 9 | setgroups(1, [2]) = 0 |
| 10 | setresgid(-1, 2, -1) = 0 |
| 11 | |
| 12 | Result from perl 5.30 under strace: |
| 13 | |
| 14 | setgroups(1, [-1]) = -1 EINVAL (Invalid argument) |
| 15 | setresgid(-1, 2, -1) = 0 |
| 16 | |
| 17 | Patch which broke this upstream: |
| 18 | https://perl5.git.perl.org/perl.git/commitdiff/5d4a52b5c68a11bfc97c2e24806993b84a61eade |
| 19 | |
| 20 | Issue is that the new function changes the endptr to the end of the |
| 21 | scanned number and needs to be reset to the end of the string for |
| 22 | each iteration of the loop. |
| 23 | |
| 24 | [YOCTO #13391] |
| 25 | |
| 26 | RP |
| 27 | 2019/6/14 |
| 28 | Upstream-Status: Pending |
| 29 | |
| 30 | Index: perl-5.30.0/mg.c |
| 31 | =================================================================== |
| 32 | --- perl-5.30.0.orig/mg.c |
| 33 | +++ perl-5.30.0/mg.c |
| 34 | @@ -3179,6 +3256,7 @@ Perl_magic_set(pTHX_ SV *sv, MAGIC *mg) |
| 35 | const char *p = SvPV_const(sv, len); |
| 36 | Groups_t *gary = NULL; |
| 37 | const char* endptr = p + len; |
| 38 | + const char* realend = p + len; |
| 39 | UV uv; |
| 40 | #ifdef _SC_NGROUPS_MAX |
| 41 | int maxgrp = sysconf(_SC_NGROUPS_MAX); |
| 42 | @@ -3209,6 +3287,7 @@ Perl_magic_set(pTHX_ SV *sv, MAGIC *mg) |
| 43 | Newx(gary, i + 1, Groups_t); |
| 44 | else |
| 45 | Renew(gary, i + 1, Groups_t); |
| 46 | + endptr = realend; |
| 47 | if (grok_atoUV(p, &uv, &endptr)) |
| 48 | gary[i] = (Groups_t)uv; |
| 49 | else { |