Brad Bishop | 1a4b7ee | 2018-12-16 17:11:34 -0800 | [diff] [blame] | 1 | From 0c28cf7bfa90f8947833722cddf23d513490c6c3 Mon Sep 17 00:00:00 2001 |
| 2 | From: Anuj Mittal <anuj.mittal@intel.com> |
| 3 | Date: Wed, 28 Nov 2018 15:08:48 +0800 |
| 4 | Subject: [PATCH] vaapsink: downgrade to marginal |
| 5 | |
| 6 | Using vaapisink with default poky configuration results in an |
| 7 | unresponsive display as of today because DRI2 rendering is currently broken |
| 8 | in non composited environments [1] and libva doesn't support DRI3 [2]. |
| 9 | |
| 10 | Downgrade vaapisink to marginal for now so playbin (and in turn gst-play |
| 11 | and gtk-play examples) use xvimagesink or others out of box. |
| 12 | |
| 13 | [1] https://gitlab.freedesktop.org/xorg/xserver/issues/13 |
| 14 | [2] https://github.com/intel/libva/issues/122 |
| 15 | |
| 16 | Upstream-Status: Pending |
| 17 | |
| 18 | Signed-off-by: Anuj Mittal <anuj.mittal@intel.com> |
| 19 | --- |
| 20 | gst/vaapi/gstvaapi.c | 6 +----- |
| 21 | 1 file changed, 1 insertion(+), 5 deletions(-) |
| 22 | |
| 23 | diff --git a/gst/vaapi/gstvaapi.c b/gst/vaapi/gstvaapi.c |
| 24 | index 9a82454..4d94f2b 100644 |
| 25 | --- a/gst/vaapi/gstvaapi.c |
| 26 | +++ b/gst/vaapi/gstvaapi.c |
Brad Bishop | 15ae250 | 2019-06-18 21:44:24 -0400 | [diff] [blame] | 27 | @@ -195,7 +195,6 @@ plugin_init (GstPlugin * plugin) |
Brad Bishop | 1a4b7ee | 2018-12-16 17:11:34 -0800 | [diff] [blame] | 28 | { |
| 29 | GstVaapiDisplay *display; |
| 30 | GArray *decoders; |
| 31 | - guint rank; |
| 32 | |
| 33 | plugin_add_dependencies (plugin); |
| 34 | |
Brad Bishop | 15ae250 | 2019-06-18 21:44:24 -0400 | [diff] [blame] | 35 | @@ -220,10 +219,7 @@ plugin_init (GstPlugin * plugin) |
Brad Bishop | 1a4b7ee | 2018-12-16 17:11:34 -0800 | [diff] [blame] | 36 | gst_element_register (plugin, "vaapidecodebin", |
| 37 | GST_RANK_PRIMARY + 2, GST_TYPE_VAAPI_DECODE_BIN); |
| 38 | |
| 39 | - rank = GST_RANK_PRIMARY; |
| 40 | - if (g_getenv ("WAYLAND_DISPLAY")) |
| 41 | - rank = GST_RANK_MARGINAL; |
| 42 | - gst_element_register (plugin, "vaapisink", rank, GST_TYPE_VAAPISINK); |
| 43 | + gst_element_register (plugin, "vaapisink", GST_RANK_MARGINAL, GST_TYPE_VAAPISINK); |
| 44 | |
| 45 | #if USE_ENCODERS |
| 46 | gst_vaapiencode_register (plugin, display); |