blob: 7945a923c9c802bc20898855a76655ee40625ed0 [file] [log] [blame]
Brad Bishop1a4b7ee2018-12-16 17:11:34 -08001From 0c28cf7bfa90f8947833722cddf23d513490c6c3 Mon Sep 17 00:00:00 2001
2From: Anuj Mittal <anuj.mittal@intel.com>
3Date: Wed, 28 Nov 2018 15:08:48 +0800
4Subject: [PATCH] vaapsink: downgrade to marginal
5
6Using vaapisink with default poky configuration results in an
7unresponsive display as of today because DRI2 rendering is currently broken
8in non composited environments [1] and libva doesn't support DRI3 [2].
9
10Downgrade vaapisink to marginal for now so playbin (and in turn gst-play
11and gtk-play examples) use xvimagesink or others out of box.
12
13[1] https://gitlab.freedesktop.org/xorg/xserver/issues/13
14[2] https://github.com/intel/libva/issues/122
15
16Upstream-Status: Pending
17
18Signed-off-by: Anuj Mittal <anuj.mittal@intel.com>
19---
20 gst/vaapi/gstvaapi.c | 6 +-----
21 1 file changed, 1 insertion(+), 5 deletions(-)
22
23diff --git a/gst/vaapi/gstvaapi.c b/gst/vaapi/gstvaapi.c
24index 9a82454..4d94f2b 100644
25--- a/gst/vaapi/gstvaapi.c
26+++ b/gst/vaapi/gstvaapi.c
Brad Bishop15ae2502019-06-18 21:44:24 -040027@@ -195,7 +195,6 @@ plugin_init (GstPlugin * plugin)
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080028 {
29 GstVaapiDisplay *display;
30 GArray *decoders;
31- guint rank;
32
33 plugin_add_dependencies (plugin);
34
Brad Bishop15ae2502019-06-18 21:44:24 -040035@@ -220,10 +219,7 @@ plugin_init (GstPlugin * plugin)
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080036 gst_element_register (plugin, "vaapidecodebin",
37 GST_RANK_PRIMARY + 2, GST_TYPE_VAAPI_DECODE_BIN);
38
39- rank = GST_RANK_PRIMARY;
40- if (g_getenv ("WAYLAND_DISPLAY"))
41- rank = GST_RANK_MARGINAL;
42- gst_element_register (plugin, "vaapisink", rank, GST_TYPE_VAAPISINK);
43+ gst_element_register (plugin, "vaapisink", GST_RANK_MARGINAL, GST_TYPE_VAAPISINK);
44
45 #if USE_ENCODERS
46 gst_vaapiencode_register (plugin, display);