| Andrew Geissler | 95ac1b8 | 2021-03-31 14:34:31 -0500 | [diff] [blame] | 1 | From ec1949dffd931d0ec7e4f67108a08ab1e2af0cfe Mon Sep 17 00:00:00 2001 |
| 2 | From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com> |
| 3 | Date: Tue, 16 Mar 2021 19:25:36 +0200 |
| 4 | Subject: [PATCH] rtpjitterbuffer: Fix parsing of the mediaclk:direct= field |
| 5 | |
| 6 | Due to an off-by-one when parsing the string, the most significant digit |
| 7 | or the clock offset was skipped when parsing the offset. |
| 8 | |
| 9 | Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/910> |
| 10 | |
| 11 | Upstream-Status: Backport [b5bb4ede3a42273fafc1054f9cf106ca527e3c26] |
| 12 | |
| 13 | Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com> |
| 14 | --- |
| 15 | gst/rtpmanager/gstrtpjitterbuffer.c | 2 +- |
| 16 | 1 file changed, 1 insertion(+), 1 deletion(-) |
| 17 | |
| 18 | diff --git a/gst/rtpmanager/gstrtpjitterbuffer.c b/gst/rtpmanager/gstrtpjitterbuffer.c |
| 19 | index 60d8ad875..02fe15adc 100644 |
| 20 | --- a/gst/rtpmanager/gstrtpjitterbuffer.c |
| 21 | +++ b/gst/rtpmanager/gstrtpjitterbuffer.c |
| 22 | @@ -1534,7 +1534,7 @@ gst_jitter_buffer_sink_parse_caps (GstRtpJitterBuffer * jitterbuffer, |
| 23 | GST_DEBUG_OBJECT (jitterbuffer, "Got media clock %s", mediaclk); |
| 24 | |
| 25 | if (!g_str_has_prefix (mediaclk, "direct=") || |
| 26 | - !g_ascii_string_to_unsigned (&mediaclk[8], 10, 0, G_MAXUINT64, |
| 27 | + !g_ascii_string_to_unsigned (&mediaclk[7], 10, 0, G_MAXUINT64, |
| 28 | &clock_offset, NULL)) |
| 29 | GST_FIXME_OBJECT (jitterbuffer, "Unsupported media clock"); |
| 30 | if (strstr (mediaclk, "rate=") != NULL) { |
| 31 | -- |
| 32 | 2.31.0 |
| 33 | |