blob: febe6c4c87ad979c2537d9f7969f7ebbd996e3f8 [file] [log] [blame]
Andrew Geissler97771a32021-03-05 15:23:11 -06001From de10fbc2386dcac3ab810c49b6977b2ee01bf426 Mon Sep 17 00:00:00 2001
Andrew Geissler82c905d2020-04-13 13:39:40 -05002From: Khem Raj <raj.khem@gmail.com>
Andrew Geissler97771a32021-03-05 15:23:11 -06003Date: Wed, 17 Feb 2021 13:30:23 -0800
Andrew Geissler82c905d2020-04-13 13:39:40 -05004Subject: [PATCH] setup.py: Do not mix C and C++ compiler options
5
6EXTRA_ENV_COMPILE_ARGS is used both with CC and CXX
7so using -std=c++11 or -std=gnu99 together will cause
8build time errors espcially with clang
9
Andrew Geissler97771a32021-03-05 15:23:11 -060010Keep '-std=c++11' to fix native build error
Andrew Geissler82c905d2020-04-13 13:39:40 -050011with old gcc (such as gcc 5.4.0 on ubuntu 16.04), for clang
12we will remove them through GRPC_PYTHON_CFLAGS at do_compile
13in bb recipe.
14
Andrew Geissler97771a32021-03-05 15:23:11 -060015While export CC="gcc ", cc_args is None, it will
Andrew Geissler82c905d2020-04-13 13:39:40 -050016cause subprocess.Popen always return 1. On centos 8, if you don't
17install package libatomic, there will be a native build error
18`cannot find /usr/lib64/libatomic.so.1.2.0'.
19
20Add no harm '-g' to cc_args if cc_args is empty.
21
22Upstream-Status: Inappropriate [oe specific]
Andrew Geissler97771a32021-03-05 15:23:11 -060023
24Signed-off-by: Khem Raj <raj.khem@gmail.com>
Andrew Geissler82c905d2020-04-13 13:39:40 -050025Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
26---
Andrew Geissler97771a32021-03-05 15:23:11 -060027 setup.py | 9 ++++++---
Andrew Geissler82c905d2020-04-13 13:39:40 -050028 src/python/grpcio/commands.py | 5 ++++-
Andrew Geissler97771a32021-03-05 15:23:11 -060029 2 files changed, 10 insertions(+), 4 deletions(-)
Andrew Geissler82c905d2020-04-13 13:39:40 -050030
Andrew Geissler82c905d2020-04-13 13:39:40 -050031--- a/setup.py
32+++ b/setup.py
Andrew Geissler9aee5002022-03-30 16:27:02 +000033@@ -199,8 +199,11 @@ def check_linker_need_libatomic():
Andrew Geissler97771a32021-03-05 15:23:11 -060034 """Test if linker on system needs libatomic."""
35 code_test = (b'#include <atomic>\n' +
36 b'int main() { return std::atomic<int64_t>{}; }')
37- cxx = os.environ.get('CXX', 'c++')
38- cpp_test = subprocess.Popen([cxx, '-x', 'c++', '-std=c++11', '-'],
39+ cxx, cxx_args = os.environ.get('CXX').split(' ', 1) or 'c++'
40+ if not cxx_args:
41+ cxx_args = "-g"
Andrew Geissler82c905d2020-04-13 13:39:40 -050042+
Andrew Geissler97771a32021-03-05 15:23:11 -060043+ cpp_test = subprocess.Popen([cxx, cxx_args, '-x', 'c++', '-std=c++11', '-'],
44 stdin=PIPE,
45 stdout=PIPE,
46 stderr=PIPE)
Andrew Geissler9aee5002022-03-30 16:27:02 +000047@@ -210,7 +213,7 @@ def check_linker_need_libatomic():
Andrew Geissler97771a32021-03-05 15:23:11 -060048 # Double-check to see if -latomic actually can solve the problem.
49 # https://github.com/grpc/grpc/issues/22491
50 cpp_test = subprocess.Popen(
Andrew Geissler9aee5002022-03-30 16:27:02 +000051- [cxx, '-x', 'c++', '-std=c++11', '-', '-latomic'],
52+ [cxx, cxx_args, '-x', 'c++', '-std=c++11', '-', '-latomic'],
Andrew Geissler97771a32021-03-05 15:23:11 -060053 stdin=PIPE,
54 stdout=PIPE,
55 stderr=PIPE)
Andrew Geissler82c905d2020-04-13 13:39:40 -050056--- a/src/python/grpcio/commands.py
57+++ b/src/python/grpcio/commands.py
Andrew Geissler9aee5002022-03-30 16:27:02 +000058@@ -228,7 +228,10 @@ class BuildExt(build_ext.build_ext):
Andrew Geissler82c905d2020-04-13 13:39:40 -050059 """
Andrew Geissler97771a32021-03-05 15:23:11 -060060 try:
61 # TODO(lidiz) Remove the generated a.out for success tests.
62- cc_test = subprocess.Popen(['cc', '-x', 'c', '-std=c++11', '-'],
63+ cc_test, cc_args = os.environ.get('CC').split(' ', 1) or 'gcc'
64+ if not cc_args:
65+ cc_args = "-g"
66+ cc_test = subprocess.Popen([cc_test, cc_args, '-x', 'c', '-std=c++11', '-'],
67 stdin=subprocess.PIPE,
68 stdout=subprocess.PIPE,
69 stderr=subprocess.PIPE)