| Brad Bishop | 6e60e8b | 2018-02-01 10:27:11 -0500 | [diff] [blame] | 1 | From d82457ce5ca7455e336da5e244d95f90e52aaef8 Mon Sep 17 00:00:00 2001 |
| 2 | From: Robert Yang <liezhi.yang@windriver.com> |
| 3 | Date: Tue, 18 Apr 2017 01:17:26 -0700 |
| 4 | Subject: [PATCH] Makefile: libacl should depend on include |
| 5 | |
| 6 | Fixed race issue: |
| 7 | In file included from acl_copy_entry.c:22:0: |
| 8 | libacl.h:19:21: fatal error: sys/acl.h: No such file or directory |
| 9 | #include <sys/acl.h> |
| 10 | |
| 11 | [snip] |
| 12 | |
| 13 | compilation terminated. |
| 14 | acl_get_file.c:27:24: fatal error: acl/libacl.h: No such file or directory |
| 15 | #include <acl/libacl.h> |
| 16 | ^ |
| 17 | |
| 18 | The acl.h is in "include" directory, and include/Makefile creates |
| 19 | symlink "sys" and "acl" poinst to current dirctory: |
| 20 | $ ls include/ -l |
| 21 | acl -> . |
| 22 | sys -> . |
| 23 | |
| 24 | So if "libacl" target runs before "include", the error would happen |
| 25 | since no "acl" or "sys" directory. |
| 26 | |
| 27 | Let libacl depend on include can fix the problem. |
| 28 | |
| 29 | Upstream-Status: Pending |
| 30 | |
| 31 | Signed-off-by: Robert Yang <liezhi.yang@windriver.com> |
| 32 | --- |
| 33 | Makefile | 2 +- |
| 34 | 1 file changed, 1 insertion(+), 1 deletion(-) |
| 35 | |
| 36 | diff --git a/Makefile b/Makefile |
| 37 | index dce32d3..8a79379 100644 |
| 38 | --- a/Makefile |
| 39 | +++ b/Makefile |
| 40 | @@ -48,7 +48,7 @@ else |
| 41 | endif |
| 42 | |
| 43 | # tool/lib dependencies |
| 44 | -libacl: libmisc |
| 45 | +libacl: include libmisc |
| 46 | getfacl setfacl chacl: libacl |
| 47 | |
| 48 | ifeq ($(HAVE_BUILDDEFS), yes) |
| 49 | -- |
| 50 | 2.10.2 |
| 51 | |