Patrick Williams | 2390b1b | 2022-11-03 13:47:49 -0500 | [diff] [blame] | 1 | From fb22e586871cc6be0b7041e86d2daceee06ea568 Mon Sep 17 00:00:00 2001 |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 2 | From: Khem Raj <raj.khem@gmail.com> |
| 3 | Date: Mon, 28 Mar 2022 10:59:03 -0700 |
| 4 | Subject: [PATCH] cmd/go: make content-based hash generation less pedantic |
| 5 | |
| 6 | Go 1.10's build tool now uses content-based hashes to |
| 7 | determine when something should be built or re-built. |
| 8 | This same mechanism is used to maintain a built-artifact |
| 9 | cache for speeding up builds. |
| 10 | |
| 11 | However, the hashes it generates include information that |
| 12 | doesn't work well with OE, nor with using a shared runtime |
| 13 | library. |
| 14 | |
| 15 | First, it embeds path names to source files, unless |
| 16 | building within GOROOT. This prevents the building |
| 17 | of a package in GOPATH for later staging into GOROOT. |
| 18 | |
| 19 | This patch adds support for the environment variable |
| 20 | GOPATH_OMIT_IN_ACTIONID. If present, path name |
| 21 | embedding is disabled. |
| 22 | |
| 23 | Upstream-Status: Inappropriate [OE specific] |
| 24 | |
| 25 | Signed-off-by: Alex Kube <alexander.j.kube@gmail.com> |
| 26 | Signed-off-by: Matt Madison <matt@madison.systems> |
| 27 | Signed-off-by: Khem Raj <raj.khem@gmail.com> |
Patrick Williams | 92b42cb | 2022-09-03 06:53:57 -0500 | [diff] [blame] | 28 | |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 29 | --- |
| 30 | src/cmd/go/internal/envcmd/env.go | 2 +- |
Patrick Williams | 92b42cb | 2022-09-03 06:53:57 -0500 | [diff] [blame] | 31 | src/cmd/go/internal/work/exec.go | 42 ++++++++++++++++++++++++------- |
| 32 | 2 files changed, 34 insertions(+), 10 deletions(-) |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 33 | |
Patrick Williams | 92b42cb | 2022-09-03 06:53:57 -0500 | [diff] [blame] | 34 | diff --git a/src/cmd/go/internal/envcmd/env.go b/src/cmd/go/internal/envcmd/env.go |
Patrick Williams | 2390b1b | 2022-11-03 13:47:49 -0500 | [diff] [blame] | 35 | index 81ee859..2db3898 100644 |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 36 | --- a/src/cmd/go/internal/envcmd/env.go |
| 37 | +++ b/src/cmd/go/internal/envcmd/env.go |
Patrick Williams | 92b42cb | 2022-09-03 06:53:57 -0500 | [diff] [blame] | 38 | @@ -176,7 +176,7 @@ func ExtraEnvVars() []cfg.EnvVar { |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 39 | func ExtraEnvVarsCostly() []cfg.EnvVar { |
Patrick Williams | 2390b1b | 2022-11-03 13:47:49 -0500 | [diff] [blame] | 40 | b := work.NewBuilder("") |
| 41 | |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 42 | - cppflags, cflags, cxxflags, fflags, ldflags, err := b.CFlags(&load.Package{}) |
| 43 | + cppflags, cflags, cxxflags, fflags, ldflags, err := b.CFlags(&load.Package{}, false) |
| 44 | if err != nil { |
| 45 | // Should not happen - b.CFlags was given an empty package. |
| 46 | fmt.Fprintf(os.Stderr, "go: invalid cflags: %v\n", err) |
Patrick Williams | 92b42cb | 2022-09-03 06:53:57 -0500 | [diff] [blame] | 47 | diff --git a/src/cmd/go/internal/work/exec.go b/src/cmd/go/internal/work/exec.go |
| 48 | index c88b315..a06455c 100644 |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 49 | --- a/src/cmd/go/internal/work/exec.go |
| 50 | +++ b/src/cmd/go/internal/work/exec.go |
Patrick Williams | 92b42cb | 2022-09-03 06:53:57 -0500 | [diff] [blame] | 51 | @@ -213,6 +213,8 @@ func (b *Builder) Do(ctx context.Context, root *Action) { |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 52 | writeActionGraph() |
| 53 | } |
| 54 | |
| 55 | +var omitGopath = os.Getenv("GOPATH_OMIT_IN_ACTIONID") != "" |
| 56 | + |
| 57 | // buildActionID computes the action ID for a build action. |
| 58 | func (b *Builder) buildActionID(a *Action) cache.ActionID { |
| 59 | p := a.Package |
Patrick Williams | 92b42cb | 2022-09-03 06:53:57 -0500 | [diff] [blame] | 60 | @@ -234,7 +236,7 @@ func (b *Builder) buildActionID(a *Action) cache.ActionID { |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 61 | if p.Module != nil { |
| 62 | fmt.Fprintf(h, "module %s@%s\n", p.Module.Path, p.Module.Version) |
| 63 | } |
| 64 | - } else if p.Goroot { |
| 65 | + } else if p.Goroot || omitGopath { |
| 66 | // The Go compiler always hides the exact value of $GOROOT |
| 67 | // when building things in GOROOT. |
| 68 | // |
Patrick Williams | 92b42cb | 2022-09-03 06:53:57 -0500 | [diff] [blame] | 69 | @@ -266,9 +268,9 @@ func (b *Builder) buildActionID(a *Action) cache.ActionID { |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 70 | } |
| 71 | if len(p.CgoFiles)+len(p.SwigFiles)+len(p.SwigCXXFiles) > 0 { |
| 72 | fmt.Fprintf(h, "cgo %q\n", b.toolID("cgo")) |
| 73 | - cppflags, cflags, cxxflags, fflags, ldflags, _ := b.CFlags(p) |
| 74 | + cppflags, cflags, cxxflags, fflags, ldflags, _ := b.CFlags(p, true) |
| 75 | |
| 76 | - ccExe := b.ccExe() |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame^] | 77 | + ccExe := filterCompilerFlags(b.ccExe(), true) |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 78 | fmt.Fprintf(h, "CC=%q %q %q %q\n", ccExe, cppflags, cflags, ldflags) |
| 79 | // Include the C compiler tool ID so that if the C |
| 80 | // compiler changes we rebuild the package. |
Patrick Williams | 92b42cb | 2022-09-03 06:53:57 -0500 | [diff] [blame] | 81 | @@ -281,14 +283,14 @@ func (b *Builder) buildActionID(a *Action) cache.ActionID { |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 82 | } |
| 83 | } |
| 84 | if len(p.CXXFiles)+len(p.SwigCXXFiles) > 0 { |
| 85 | - cxxExe := b.cxxExe() |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame^] | 86 | + cxxExe := filterCompilerFlags(b.cxxExe(), true) |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 87 | fmt.Fprintf(h, "CXX=%q %q\n", cxxExe, cxxflags) |
| 88 | if cxxID, err := b.gccToolID(cxxExe[0], "c++"); err == nil { |
| 89 | fmt.Fprintf(h, "CXX ID=%q\n", cxxID) |
| 90 | } |
| 91 | } |
| 92 | if len(p.FFiles) > 0 { |
| 93 | - fcExe := b.fcExe() |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame^] | 94 | + fcExe := filterCompilerFlags(b.fcExe(), true) |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 95 | fmt.Fprintf(h, "FC=%q %q\n", fcExe, fflags) |
| 96 | if fcID, err := b.gccToolID(fcExe[0], "f95"); err == nil { |
| 97 | fmt.Fprintf(h, "FC ID=%q\n", fcID) |
Patrick Williams | 92b42cb | 2022-09-03 06:53:57 -0500 | [diff] [blame] | 98 | @@ -305,7 +307,7 @@ func (b *Builder) buildActionID(a *Action) cache.ActionID { |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 99 | } |
| 100 | } |
Patrick Williams | 92b42cb | 2022-09-03 06:53:57 -0500 | [diff] [blame] | 101 | if p.Internal.BuildInfo != "" { |
| 102 | - fmt.Fprintf(h, "modinfo %q\n", p.Internal.BuildInfo) |
| 103 | + //fmt.Fprintf(h, "modinfo %q\n", p.Internal.BuildInfo) |
| 104 | } |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 105 | |
| 106 | // Configuration specific to compiler toolchain. |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame^] | 107 | @@ -2705,8 +2707,25 @@ func envList(key, def string) []string { |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 108 | return args |
| 109 | } |
| 110 | |
| 111 | +var filterFlags = os.Getenv("CGO_PEDANTIC") == "" |
| 112 | + |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame^] | 113 | +func filterCompilerFlags(flags []string, keepfirst bool) []string { |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 114 | + var newflags []string |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame^] | 115 | + var realkeepfirst bool = keepfirst |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 116 | + if !filterFlags { |
| 117 | + return flags |
| 118 | + } |
| 119 | + for _, flag := range flags { |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame^] | 120 | + if strings.HasPrefix(flag, "-m") || realkeepfirst { |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 121 | + newflags = append(newflags, flag) |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame^] | 122 | + realkeepfirst = false |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 123 | + } |
| 124 | + } |
| 125 | + return newflags |
| 126 | +} |
| 127 | + |
| 128 | // CFlags returns the flags to use when invoking the C, C++ or Fortran compilers, or cgo. |
| 129 | -func (b *Builder) CFlags(p *load.Package) (cppflags, cflags, cxxflags, fflags, ldflags []string, err error) { |
| 130 | +func (b *Builder) CFlags(p *load.Package, filtered bool) (cppflags, cflags, cxxflags, fflags, ldflags []string, err error) { |
| 131 | defaults := "-g -O2" |
| 132 | |
| 133 | if cppflags, err = buildFlags("CPPFLAGS", "", p.CgoCPPFLAGS, checkCompilerFlags); err != nil { |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame^] | 134 | @@ -2724,6 +2743,13 @@ func (b *Builder) CFlags(p *load.Package) (cppflags, cflags, cxxflags, fflags, l |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 135 | if ldflags, err = buildFlags("LDFLAGS", defaults, p.CgoLDFLAGS, checkLinkerFlags); err != nil { |
| 136 | return |
| 137 | } |
| 138 | + if filtered { |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame^] | 139 | + cppflags = filterCompilerFlags(cppflags, false) |
| 140 | + cflags = filterCompilerFlags(cflags, false) |
| 141 | + cxxflags = filterCompilerFlags(cxxflags, false) |
| 142 | + fflags = filterCompilerFlags(fflags, false) |
| 143 | + ldflags = filterCompilerFlags(ldflags, false) |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 144 | + } |
| 145 | |
| 146 | return |
| 147 | } |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame^] | 148 | @@ -2739,7 +2765,7 @@ var cgoRe = lazyregexp.New(`[/\\:]`) |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 149 | |
| 150 | func (b *Builder) cgo(a *Action, cgoExe, objdir string, pcCFLAGS, pcLDFLAGS, cgofiles, gccfiles, gxxfiles, mfiles, ffiles []string) (outGo, outObj []string, err error) { |
| 151 | p := a.Package |
| 152 | - cgoCPPFLAGS, cgoCFLAGS, cgoCXXFLAGS, cgoFFLAGS, cgoLDFLAGS, err := b.CFlags(p) |
| 153 | + cgoCPPFLAGS, cgoCFLAGS, cgoCXXFLAGS, cgoFFLAGS, cgoLDFLAGS, err := b.CFlags(p, false) |
| 154 | if err != nil { |
| 155 | return nil, nil, err |
| 156 | } |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame^] | 157 | @@ -3246,7 +3272,7 @@ func (b *Builder) swigIntSize(objdir string) (intsize string, err error) { |
Patrick Williams | 03907ee | 2022-05-01 06:28:52 -0500 | [diff] [blame] | 158 | |
| 159 | // Run SWIG on one SWIG input file. |
| 160 | func (b *Builder) swigOne(a *Action, p *load.Package, file, objdir string, pcCFLAGS []string, cxx bool, intgosize string) (outGo, outC string, err error) { |
| 161 | - cgoCPPFLAGS, cgoCFLAGS, cgoCXXFLAGS, _, _, err := b.CFlags(p) |
| 162 | + cgoCPPFLAGS, cgoCFLAGS, cgoCXXFLAGS, _, _, err := b.CFlags(p, false) |
| 163 | if err != nil { |
| 164 | return "", "", err |
| 165 | } |