blob: 56fd346ae60e68af753f3df4d94698dfbbd01c9f [file] [log] [blame]
Patrick Williamsf1e5d692016-03-30 15:21:19 -05001From 4ab0359a8ae182a7ac5c99609667273167703fab Mon Sep 17 00:00:00 2001
2From: Prasad J Pandit <pjp@fedoraproject.org>
3Date: Mon, 11 Jan 2016 14:10:42 -0500
4Subject: [PATCH] ide: ahci: reset ncq object to unused on error
5
6When processing NCQ commands, AHCI device emulation prepares a
7NCQ transfer object; To which an aio control block(aiocb) object
8is assigned in 'execute_ncq_command'. In case, when the NCQ
9command is invalid, the 'aiocb' object is not assigned, and NCQ
10transfer object is left as 'used'. This leads to a use after
11free kind of error in 'bdrv_aio_cancel_async' via 'ahci_reset_port'.
12Reset NCQ transfer object to 'unused' to avoid it.
13
14[Maintainer edit: s/ACHI/AHCI/ in the commit message. --js]
15
16Reported-by: Qinghao Tang <luodalongde@gmail.com>
17Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
18Reviewed-by: John Snow <jsnow@redhat.com>
19Message-id: 1452282511-4116-1-git-send-email-ppandit@redhat.com
20Signed-off-by: John Snow <jsnow@redhat.com>
21
22Upstream-Status: Backport
23
24http://git.qemu.org/?p=qemu.git;a=commit;h=4ab0359a8ae182a7ac5c99609667273167703fab
25
26CVE: CVE-2016-1568
27[Yocto # 9013]
28
29Signed-off-by: Armin Kuster <akuster@mvista.com>
30
31---
32 hw/ide/ahci.c | 1 +
33 1 file changed, 1 insertion(+)
34
Patrick Williamsd8c66bc2016-06-20 12:57:21 -050035Index: qemu-2.5.0/hw/ide/ahci.c
Patrick Williamsf1e5d692016-03-30 15:21:19 -050036===================================================================
Patrick Williamsd8c66bc2016-06-20 12:57:21 -050037--- qemu-2.5.0.orig/hw/ide/ahci.c
38+++ qemu-2.5.0/hw/ide/ahci.c
39@@ -910,6 +910,7 @@ static void ncq_err(NCQTransferState *nc
Patrick Williamsf1e5d692016-03-30 15:21:19 -050040 ide_state->error = ABRT_ERR;
41 ide_state->status = READY_STAT | ERR_STAT;
42 ncq_tfs->drive->port_regs.scr_err |= (1 << ncq_tfs->tag);
43+ ncq_tfs->used = 0;
44 }
45
46 static void ncq_finish(NCQTransferState *ncq_tfs)