blob: a13c2b7dae41921e1992a3de5f20c4378232b226 [file] [log] [blame]
Ed Tanousd5cea142021-09-09 11:42:05 -07001#!/bin/bash -e
2#
3
Ed Tanous7f8954e2021-09-09 11:46:43 -07004script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
5obmc_dir=${script_dir}/../../
6
Patrick Williams12a27b22021-10-26 16:07:31 -05007cd "$obmc_dir"
8
Ed Tanous7f8954e2021-09-09 11:46:43 -07009# openbmc doesn't control what upstream poky, or any of the other layers do,
10# which do use patches as part of their upstreaming process.
11# meta-phosphor is also included such that patches that the community agrees to
12# hold onto will be allowed in that layer.
13
14patch_files_tmp=$(mktemp)
15allowed_patches_tmp=$(mktemp)
Patrick Williams693d3db2021-10-26 16:10:20 -050016trap 'rm $patch_files_tmp $allowed_patches_tmp' exit
Ed Tanous7f8954e2021-09-09 11:46:43 -070017
Patrick Williams12a27b22021-10-26 16:07:31 -050018git ls-files -- \
Ed Tanous7f8954e2021-09-09 11:46:43 -070019 '*.patch' \
20 ':!:poky/**' \
Brad Bishopbec4ebc2022-08-03 09:55:16 -040021 ':!:meta-arm/**' \
Ed Tanous7f8954e2021-09-09 11:46:43 -070022 ':!:meta-security/**' \
Ed Tanous7f8954e2021-09-09 11:46:43 -070023 ':!:meta-raspberrypi/**' \
24 ':!:meta-openembedded/**' \
25 ':!:meta-phosphor/**' \
Patrick Williams693d3db2021-10-26 16:10:20 -050026 | sort > "$patch_files_tmp"
Ed Tanous7f8954e2021-09-09 11:46:43 -070027
28
29# The following patches were present on master at the time this test was
30# written. Their presence in this list should not be acknowlegement that they
31# are now allowed, but ignoring them is required in the intermediate time
32# between when this test was created, and when the maintainers of these repos
33# clean them up.
34#
35# https://github.com/openbmc/docs/blob/master/meta-layer-guidelines.md
36echo "\
Ed Tanous7f8954e2021-09-09 11:46:43 -070037meta-aspeed/recipes-bsp/u-boot/files/default-gcc.patch
Ed Tanous7f8954e2021-09-09 11:46:43 -070038meta-bytedance/meta-g220a/recipes-kernel/linux/linux-aspeed/0005-ARM-dts-aspeed-Enable-g220a-uart-route.patch
Logananth Sundararaj971257a2022-03-23 17:34:12 +053039meta-facebook/meta-yosemitev2/recipes-bsp/u-boot/u-boot-aspeed-sdk/0001-board-aspeed-Add-Mux-for-yosemitev2.patch
40meta-facebook/meta-yosemitev2/recipes-bsp/u-boot/u-boot-aspeed-sdk/0002-spl-host-console-handle.patch
Ed Tanous7f8954e2021-09-09 11:46:43 -070041meta-google/dynamic-layers/nuvoton-layer/recipes-bsp/images/npcm7xx-igps/0001-Set-FIU0_DRD_CFG-and-FIU_Clk_divider-for-gbmc-hoth.patch
42meta-google/recipes-extended/libconfig/files/0001-conf2struct-Use-the-right-perl.patch
43meta-google/recipes-extended/libconfig/files/0001-makefile-Add-missing-LDFLAGS.patch
44meta-google/recipes-phosphor/initrdscripts/obmc-phosphor-initfs/rwfs-clean-dev.patch
45meta-ingrasys/meta-zaius/recipes-bsp/u-boot/u-boot-aspeed/0001-board-aspeed-Add-reset_phy-for-Zaius.patch
46meta-nuvoton/recipes-bsp/images/npcm7xx-igps/0001-Adjust-paths-for-use-with-Bitbake.patch
47meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0001-Add-system-reset-status-support.patch
48meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0002-config-ast-common-set-fieldmode-to-true.patch
49meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0003-aspeed-add-gpio-support.patch
50meta-yadro/meta-nicole/recipes-bsp/u-boot/files/0004-aspeed-add-bmc-position-support.patch
51meta-yadro/meta-nicole/recipes-kernel/linux/linux-aspeed/0001-Add-NCSI-channel-selector.patch
52meta-yadro/meta-nicole/recipes-phosphor/host/op-proc-control/0001-Stop-and-send-SRESET-for-one-thread-only.patch
53meta-yadro/recipes-phosphor/dbus/phosphor-dbus-interfaces/0001-Add-boot-initiator-mailbox-interface.patch
54meta-yadro/recipes-phosphor/ipmi/phosphor-ipmi-host/0001-Add-support-for-persistent-only-settings.patch
55meta-yadro/recipes-phosphor/ipmi/phosphor-ipmi-host/0002-Add-support-for-boot-initiator-mailbox.patch
56meta-yadro/recipes-phosphor/ipmi/phosphor-ipmi-host/0003-Fix-version-parsing-update-AUX-revision-info.patch
Patrick Williams693d3db2021-10-26 16:10:20 -050057" | sort > "$allowed_patches_tmp"
Ed Tanous7f8954e2021-09-09 11:46:43 -070058
Patrick Williams693d3db2021-10-26 16:10:20 -050059files_diff=$(comm -23 "$patch_files_tmp" "$allowed_patches_tmp")
Ed Tanous7f8954e2021-09-09 11:46:43 -070060
Ed Tanous4734c222021-09-20 11:11:34 -070061files_count=$(echo -n "$files_diff" | grep -c '^' || true)
Ed Tanous7f8954e2021-09-09 11:46:43 -070062if [[ $files_count -ne 0 ]]; then
63 echo "Patch files found not in allow list"
64 echo "$files_diff"
65 echo "Patches are not allowed on OpenBMC in these layers. Please upstream your changes and see \
66 https://github.com/openbmc/docs/blob/master/meta-layer-guidelines.md"
67 exit 1
68fi
69
Andrew Geisslerfc328172022-01-21 09:37:06 -060070# Now verify there are no kernel dts files being added in a patch
71# All dts files should be sent upstream and can be carried in the openbmc/linux
72# tree until they are accepted upstream
73dts_files_tmp=$(mktemp)
74allowed_dts_tmp=$(mktemp)
75trap 'rm $dts_files_tmp $allowed_dts_tmp' exit
76
77git ls-files -- \
78 '*.dts' \
79 ':!:poky/**' \
Brad Bishopbec4ebc2022-08-03 09:55:16 -040080 ':!:meta-arm/**' \
Andrew Geisslerfc328172022-01-21 09:37:06 -060081 ':!:meta-security/**' \
82 ':!:meta-raspberrypi/**' \
83 ':!:meta-openembedded/**' \
84 | sort > "$dts_files_tmp"
85
86# There is a single dts currently in the tree that we will exempt for now
87echo "\
88meta-hpe/meta-dl360poc/recipes-kernel/linux/linux-obmc/gxp.dts
89" | sort > "$allowed_dts_tmp"
90
91files_diff=$(comm -23 "$dts_files_tmp" "$allowed_dts_tmp")
92
93files_count=$(echo -n "$files_diff" | grep -c '^' || true)
94if [[ $files_count -ne 0 ]]; then
95echo "Dts files found not in allow list"
96echo "$files_diff"
97echo "Dts files are not allowed on OpenBMC in these layers. Please upstream your changes and see \
98 https://github.com/openbmc/docs/blob/master/kernel-development.md"
99exit 1
100fi
101
Patrick Williams12a27b22021-10-26 16:07:31 -0500102lint_exempt="\
103meta-amd/recipes-amd/amd-fpga/files/ethanolx/fpgardu.sh
Patrick Williams12a27b22021-10-26 16:07:31 -0500104meta-bytedance/meta-g220a/recipes-network/network/static-mac-addr/mac-check
105meta-bytedance/meta-g220a/recipes-phosphor/datetime/me-time-sync/me-time-sync.sh
Patrick Williams12a27b22021-10-26 16:07:31 -0500106meta-google/recipes-google/gpio/gpio-ctrl/lib.sh
107meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/host_isoff.sh
108meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/host_powercycle.sh
109meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/host_poweroff.sh
110meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/host_poweron.sh
111meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/host_reset.sh
112meta-google/recipes-google/host-power-ctrl/gpio-host-pwr/lib.sh
113meta-google/recipes-google/ipmi/ipmi-fru-sh/lib.sh
114meta-google/recipes-google/ncsi/files/gbmc-ncsi-ip-from-ra.sh.in
115meta-google/recipes-google/networking/files/gbmc-ip-monitor-test.sh
116meta-google/recipes-google/networking/files/gbmc-ip-monitor.sh
117meta-google/recipes-google/networking/files/gbmc-mac-config.sh.in
Patrick Williams521d8f62021-10-27 09:30:41 -0500118meta-google/recipes-google/networking/gbmc-bridge/gbmc-br-from-ra.sh
119meta-google/recipes-google/networking/gbmc-bridge/gbmc-br-gw-src.sh
120meta-google/recipes-google/networking/gbmc-bridge/gbmc-br-nft.sh
121meta-google/recipes-google/networking/gbmc-bridge/gbmc-br-ula.sh
Patrick Williams12a27b22021-10-26 16:07:31 -0500122meta-google/recipes-google/networking/google-usb-network/usb_network.sh
123meta-google/recipes-google/networking/google-usb-network/usb_network_test.sh
124meta-google/recipes-google/networking/network-sh/lib.sh
125meta-google/recipes-google/networking/network-sh/test.sh
126meta-google/recipes-google/nftables/files/nft-configure.sh
127meta-google/recipes-google/ssh/authorized-keys-comp/authorized-keys-comp.sh
128meta-google/recipes-google/test/test-sh/test.sh
129meta-google/recipes-phosphor/flash/google-key/verify-bmc-image.sh
130meta-google/recipes-phosphor/flash/inplace-gbmc-update/inplace-gbmc-verify.sh
131meta-hpe/meta-common/recipes-hpe/host/host-boot-enable/host-boot-enable.sh
132meta-hpe/meta-common/recipes-phosphor/initrdscripts/files/gxp-obmc-init.sh
133meta-hpe/meta-dl360poc/recipes-hpe/host/host-boot-enable/host-boot-enable.sh
134meta-ibm/meta-romulus/recipes-phosphor/chassis/vrm-control/vrm-control.sh
135meta-ibm/meta-romulus/recipes-phosphor/gpio/id-button/toggle_identify_led.sh
136meta-ibm/recipes-phosphor/chassis/power-workarounds/witherspoon/power-workarounds.sh
137meta-ibm/recipes-phosphor/chassis/vrm-control/ibm-ac-server/ir35221-unbind-bind.sh
Patrick Williams12a27b22021-10-26 16:07:31 -0500138meta-ibm/recipes-phosphor/chassis/vrm-control/vrm-control.sh
139meta-ibm/recipes-phosphor/dump/phosphor-debug-collector/plugins.d/ibm_elogall
140meta-ibm/recipes-phosphor/dump/phosphor-debug-collector/plugins.d/pels
141meta-ibm/recipes-phosphor/gpio/id-button/toggle_identify_led.sh
142meta-ibm/recipes-phosphor/mboxd/mboxd/check_pnor_format.sh
143meta-ingrasys/meta-zaius/recipes-phosphor/chassis/avsbus-control/zaius_avsbus.sh
144meta-ingrasys/meta-zaius/recipes-phosphor/chassis/vcs-control/zaius_vcs.sh
145meta-inventec/meta-transformers/recipes-phosphor/init/transformers-init/transformers-init.sh
Patrick Williams521d8f62021-10-27 09:30:41 -0500146meta-openpower/recipes-bsp/pdata/files/power-target.sh
Patrick Williams12a27b22021-10-26 16:07:31 -0500147meta-openpower/recipes-phosphor/dump/phosphor-debug-collector/plugins.d/guard
148meta-openpower/recipes-phosphor/network/first-boot-set-hostname/first-boot-set-hostname.sh
149meta-openpower/recipes-phosphor/network/first-boot-set-mac/first-boot-set-mac.sh
150meta-openpower/recipes-phosphor/occ/openpower-occ-control/occ-active.sh
151meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-init.sh
152meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-shutdown.sh
153meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-update.sh
154meta-phosphor/recipes-phosphor/initrdscripts/phosphor-mmc-init/mmc-init.sh
155meta-phosphor/recipes-phosphor/interfaces/bmcweb/run-ptest
Patrick Williams12a27b22021-10-26 16:07:31 -0500156meta-phosphor/recipes-support/nss-pam-ldapd/files/nslcd.init
Patrick Williams12a27b22021-10-26 16:07:31 -0500157meta-quanta/meta-common/recipes-quanta/network/usb-network/usb-network.sh
158meta-quanta/meta-gbs/recipes-gbs/gbs-bios-update/files/bios-update.sh
159meta-quanta/meta-gbs/recipes-gbs/gbs-bios-update/files/bios-verify.sh
160meta-quanta/meta-gbs/recipes-gbs/gbs-bmc-update/files/bmc-verify.sh
161meta-quanta/meta-gbs/recipes-gbs/gbs-detect-gpio-present/files/detect-gpio-present.sh
162meta-quanta/meta-gbs/recipes-gbs/gbs-sysinit/files/gbs-sysinit.sh
163meta-quanta/meta-gbs/recipes-gbs/hotswap-power-cycle/files/tray_powercycle.sh
164meta-quanta/meta-gbs/recipes-google/acpi-power-state/acpi-power-state-daemon/gbs-check-host-state.sh
165meta-quanta/meta-gbs/recipes-google/acpi-power-state/acpi-power-state-daemon/gbs-set-failsafe.sh
166meta-quanta/meta-gbs/recipes-phosphor/fans/phosphor-pid-control/fan-table-init.sh
167meta-quanta/meta-gbs/recipes-phosphor/sensors/phosphor-nvme/nvme_json_rewrite.sh
168meta-quanta/meta-gsj/recipes-gsj/detect-fan-fail/files/detect-fan-fail.sh
169meta-quanta/meta-gsj/recipes-gsj/gsj-hotswap-change-setting/files/gsj-hotswap-change-setting.sh
170meta-quanta/meta-gsj/recipes-gsj/quanta-nvme-powerctrl/files/init_once.sh
171meta-quanta/meta-gsj/recipes-gsj/quanta-nvme-powerctrl/files/nvme_powerctrl_library.sh
172meta-quanta/meta-gsj/recipes-gsj/quanta-nvme-powerctrl/files/nvme_powermanager.sh
173meta-quanta/meta-gsj/recipes-gsj/usb-network/files/usb_network.sh
174meta-quanta/meta-gsj/recipes-phosphor/fans/phosphor-pid-control/fan-control.sh
Patrick Williams521d8f62021-10-27 09:30:41 -0500175meta-quanta/meta-gsj/recipes-phosphor/fans/phosphor-pid-control/fan-default-speed.sh
Patrick Williams12a27b22021-10-26 16:07:31 -0500176meta-quanta/meta-olympus-nuvoton/recipes-olympus-nuvoton/power/first-boot-set-psu/first-boot-set-psu.sh
Patrick Williams521d8f62021-10-27 09:30:41 -0500177meta-quanta/meta-olympus-nuvoton/recipes-phosphor/fans/phosphor-pid-control/fan-full-speed.sh
Patrick Williams12a27b22021-10-26 16:07:31 -0500178meta-quanta/meta-q71l/recipes-phosphor/quanta-powerctrl/files/init_once.sh
179meta-quanta/meta-q71l/recipes-phosphor/quanta-powerctrl/files/poweroff.sh
180meta-quanta/meta-q71l/recipes-phosphor/quanta-powerctrl/files/poweron.sh
181meta-yadro/meta-nicole/recipes-phosphor/chassis/avsbus-control/avsbus-control.sh
Patrick Williams12a27b22021-10-26 16:07:31 -0500182"
183
Patrick Williams2ed00d82021-10-27 09:33:53 -0500184types=(json shell)
185# shellcheck disable=SC2034
186check_json="eslint --resolve-plugins-relative-to /usr/local/lib/node_modules"
Patrick Williams521d8f62021-10-27 09:30:41 -0500187# shellcheck disable=SC2034
188check_shell="shellcheck -x"
189
190for t in "${types[@]}"; do
191 check_cmd="check_${t}"
192 if ! which "${!check_cmd%% *}" > /dev/null 2>&1; then
193 eval "${check_cmd}=\"echo WARNING: Skipping $t due to missing command:\""
194 echo "${!check_cmd}"
195 fi
196done
197
Patrick Williams12a27b22021-10-26 16:07:31 -0500198non_bbfiles=$(git ls-files -- \
199 ':!:poky/**' \
Brad Bishopbec4ebc2022-08-03 09:55:16 -0400200 ':!:meta-arm/**' \
Patrick Williams12a27b22021-10-26 16:07:31 -0500201 ':!:meta-security/**' \
202 ':!:meta-raspberrypi/**' \
203 ':!:meta-openembedded/**' \
204 | grep -v -e "\.patch$" -e "\.bb$" -e "\.bbappend$")
205
206for f in $non_bbfiles; do
Patrick Williams521d8f62021-10-27 09:30:41 -0500207 unset file_type
208 file_info=$(file "$f")
209 case $file_info in
Patrick Williams12a27b22021-10-26 16:07:31 -0500210 *shell\ script*)
Patrick Williams521d8f62021-10-27 09:30:41 -0500211 file_type="shell"
Patrick Williams12a27b22021-10-26 16:07:31 -0500212 ;;
213
Patrick Williams2ed00d82021-10-27 09:33:53 -0500214 *JSON\ data*)
215 file_type="json"
216 ;;
217
Patrick Williams12a27b22021-10-26 16:07:31 -0500218 *)
Patrick Williams521d8f62021-10-27 09:30:41 -0500219 case $f in
220 *.sh)
221 file_type="shell"
222 ;;
223
Patrick Williams2ed00d82021-10-27 09:33:53 -0500224 *.json)
225 file_type="json"
226 ;;
Patrick Williams521d8f62021-10-27 09:30:41 -0500227 esac
Patrick Williams12a27b22021-10-26 16:07:31 -0500228 esac
Patrick Williams521d8f62021-10-27 09:30:41 -0500229
230 if [ -n "$file_type" ]; then
231 check_cmd="check_${file_type}"
232 if ! eval "${!check_cmd} $f"; then
233 if [[ $lint_exempt == *$f* ]]; then
234 echo "EXEMPT: $f"
235 else
236 echo "FAILED: $f"
237 false
238 fi
239 fi
240 fi
241
Patrick Williams12a27b22021-10-26 16:07:31 -0500242done
243
Ed Tanousd5cea142021-09-09 11:42:05 -0700244echo "Repo test passed"