blob: dd6ecebeb4308850ddbb13d39add3dc5bd2ad715 [file] [log] [blame]
Andrew Geissler706d5aa2021-02-12 15:55:30 -06001From 77f98727f1d19a8fb327b55c92f1a9ee7b859e9f Mon Sep 17 00:00:00 2001
Brad Bishop19323692019-04-05 15:28:33 -04002From: Chen Qi <Qi.Chen@windriver.com>
3Date: Mon, 25 Feb 2019 14:56:21 +0800
Andrew Geissler706d5aa2021-02-12 15:55:30 -06004Subject: [PATCH] don't fail if GLOB_BRACE and GLOB_ALTDIRFUNC is not defined
Brad Bishop19323692019-04-05 15:28:33 -04005
6If the standard library doesn't provide brace
7expansion users just won't get it.
8
9Dont use GNU GLOB extentions on non-glibc systems
10
11Conditionalize use of GLOB_ALTDIRFUNC
12
13Upstream-Status: Inappropriate [musl specific]
14
15Signed-off-by: Khem Raj <raj.khem@gmail.com>
16Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Brad Bishopa34c0302019-09-23 22:34:48 -040017[rebased for systemd 243]
18Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Andrew Geissler706d5aa2021-02-12 15:55:30 -060019
Brad Bishop19323692019-04-05 15:28:33 -040020---
Brad Bishopa34c0302019-09-23 22:34:48 -040021 src/basic/glob-util.c | 12 ++++++++++++
Brad Bishopc342db32019-05-15 21:57:59 -040022 src/test/test-glob-util.c | 16 ++++++++++++++++
23 src/tmpfiles/tmpfiles.c | 10 ++++++++++
Brad Bishopa34c0302019-09-23 22:34:48 -040024 3 files changed, 38 insertions(+)
Brad Bishop19323692019-04-05 15:28:33 -040025
Andrew Geissler706d5aa2021-02-12 15:55:30 -060026Index: systemd-stable/src/basic/glob-util.c
27===================================================================
28--- systemd-stable.orig/src/basic/glob-util.c
29+++ systemd-stable/src/basic/glob-util.c
Andrew Geissler82c905d2020-04-13 13:39:40 -050030@@ -12,6 +12,12 @@
Brad Bishop19323692019-04-05 15:28:33 -040031 #include "path-util.h"
32 #include "strv.h"
Brad Bishopc342db32019-05-15 21:57:59 -040033
Brad Bishop19323692019-04-05 15:28:33 -040034+/* Don't fail if the standard library
35+ * doesn't provide brace expansion */
36+#ifndef GLOB_BRACE
37+#define GLOB_BRACE 0
38+#endif
Brad Bishopc342db32019-05-15 21:57:59 -040039+
Brad Bishop19323692019-04-05 15:28:33 -040040 static void closedir_wrapper(void* v) {
41 (void) closedir(v);
Brad Bishopc342db32019-05-15 21:57:59 -040042 }
Andrew Geissler82c905d2020-04-13 13:39:40 -050043@@ -19,6 +25,7 @@ static void closedir_wrapper(void* v) {
Brad Bishop19323692019-04-05 15:28:33 -040044 int safe_glob(const char *path, int flags, glob_t *pglob) {
45 int k;
46
47+#ifdef GLOB_ALTDIRFUNC
48 /* We want to set GLOB_ALTDIRFUNC ourselves, don't allow it to be set. */
49 assert(!(flags & GLOB_ALTDIRFUNC));
50
Andrew Geissler706d5aa2021-02-12 15:55:30 -060051@@ -32,9 +39,14 @@ int safe_glob(const char *path, int flag
Brad Bishop19323692019-04-05 15:28:33 -040052 pglob->gl_lstat = lstat;
53 if (!pglob->gl_stat)
54 pglob->gl_stat = stat;
55+#endif
56
57 errno = 0;
58+#ifdef GLOB_ALTDIRFUNC
59 k = glob(path, flags | GLOB_ALTDIRFUNC, NULL, pglob);
Brad Bishop19323692019-04-05 15:28:33 -040060+#else
61+ k = glob(path, flags, NULL, pglob);
62+#endif
63 if (k == GLOB_NOMATCH)
64 return -ENOENT;
65 if (k == GLOB_NOSPACE)
Andrew Geissler706d5aa2021-02-12 15:55:30 -060066Index: systemd-stable/src/test/test-glob-util.c
67===================================================================
68--- systemd-stable.orig/src/test/test-glob-util.c
69+++ systemd-stable/src/test/test-glob-util.c
Andrew Geissler82c905d2020-04-13 13:39:40 -050070@@ -12,6 +12,12 @@
Brad Bishop19323692019-04-05 15:28:33 -040071 #include "rm-rf.h"
72 #include "tmpfile-util.h"
Brad Bishopc342db32019-05-15 21:57:59 -040073
Brad Bishop19323692019-04-05 15:28:33 -040074+/* Don't fail if the standard library
75+ * doesn't provide brace expansion */
76+#ifndef GLOB_BRACE
77+#define GLOB_BRACE 0
78+#endif
Brad Bishopc342db32019-05-15 21:57:59 -040079+
Brad Bishop19323692019-04-05 15:28:33 -040080 static void test_glob_exists(void) {
81 char name[] = "/tmp/test-glob_exists.XXXXXX";
Brad Bishopc342db32019-05-15 21:57:59 -040082 int fd = -1;
Andrew Geissler82c905d2020-04-13 13:39:40 -050083@@ -39,11 +45,13 @@ static void test_glob_no_dot(void) {
Brad Bishop19323692019-04-05 15:28:33 -040084 const char *fn;
Brad Bishopc342db32019-05-15 21:57:59 -040085
Brad Bishop19323692019-04-05 15:28:33 -040086 _cleanup_globfree_ glob_t g = {
87+#ifdef GLOB_ALTDIRFUNC
88 .gl_closedir = closedir_wrapper,
89 .gl_readdir = (struct dirent *(*)(void *)) readdir_no_dot,
90 .gl_opendir = (void *(*)(const char *)) opendir,
91 .gl_lstat = lstat,
92 .gl_stat = stat,
93+#endif
94 };
Brad Bishop19323692019-04-05 15:28:33 -040095
Brad Bishopc342db32019-05-15 21:57:59 -040096 int r;
Andrew Geissler82c905d2020-04-13 13:39:40 -050097@@ -51,11 +59,19 @@ static void test_glob_no_dot(void) {
Brad Bishop19323692019-04-05 15:28:33 -040098 assert_se(mkdtemp(template));
99
100 fn = strjoina(template, "/*");
101+#ifdef GLOB_ALTDIRFUNC
102 r = glob(fn, GLOB_NOSORT|GLOB_BRACE|GLOB_ALTDIRFUNC, NULL, &g);
103+#else
104+ r = glob(fn, GLOB_NOSORT|GLOB_BRACE, NULL, &g);
105+#endif
106 assert_se(r == GLOB_NOMATCH);
107
108 fn = strjoina(template, "/.*");
109+#ifdef GLOB_ALTDIRFUNC
110 r = glob(fn, GLOB_NOSORT|GLOB_BRACE|GLOB_ALTDIRFUNC, NULL, &g);
111+#else
112+ r = glob(fn, GLOB_NOSORT|GLOB_BRACE, NULL, &g);
113+#endif
114 assert_se(r == GLOB_NOMATCH);
115
116 (void) rm_rf(template, REMOVE_ROOT|REMOVE_PHYSICAL);
Andrew Geissler706d5aa2021-02-12 15:55:30 -0600117Index: systemd-stable/src/tmpfiles/tmpfiles.c
118===================================================================
119--- systemd-stable.orig/src/tmpfiles/tmpfiles.c
120+++ systemd-stable/src/tmpfiles/tmpfiles.c
121@@ -59,6 +59,12 @@
Brad Bishop19323692019-04-05 15:28:33 -0400122 #include "umask-util.h"
123 #include "user-util.h"
Brad Bishopc342db32019-05-15 21:57:59 -0400124
Brad Bishop19323692019-04-05 15:28:33 -0400125+/* Don't fail if the standard library
126+ * doesn't provide brace expansion */
127+#ifndef GLOB_BRACE
128+#define GLOB_BRACE 0
129+#endif
Brad Bishopc342db32019-05-15 21:57:59 -0400130+
Brad Bishop19323692019-04-05 15:28:33 -0400131 /* This reads all files listed in /etc/tmpfiles.d/?*.conf and creates
132 * them in the file system. This is intended to be used to create
Brad Bishopc342db32019-05-15 21:57:59 -0400133 * properly owned directories beneath /tmp, /var/tmp, /run, which are
Andrew Geissler706d5aa2021-02-12 15:55:30 -0600134@@ -1867,7 +1873,9 @@ finish:
Brad Bishop19323692019-04-05 15:28:33 -0400135
136 static int glob_item(Item *i, action_t action) {
137 _cleanup_globfree_ glob_t g = {
138+#ifdef GLOB_ALTDIRFUNC
139 .gl_opendir = (void *(*)(const char *)) opendir_nomod,
140+#endif
141 };
142 int r = 0, k;
143 char **fn;
Andrew Geissler706d5aa2021-02-12 15:55:30 -0600144@@ -1887,7 +1895,9 @@ static int glob_item(Item *i, action_t a
Brad Bishop19323692019-04-05 15:28:33 -0400145
146 static int glob_item_recursively(Item *i, fdaction_t action) {
147 _cleanup_globfree_ glob_t g = {
148+#ifdef GLOB_ALTDIRFUNC
149 .gl_opendir = (void *(*)(const char *)) opendir_nomod,
150+#endif
151 };
152 int r = 0, k;
153 char **fn;