blob: ed85116c4f4c7b3750b5852697e46ff380b97ff7 [file] [log] [blame]
Andrew Geissler90fd73c2021-03-05 15:25:55 -06001From 1546e1f95a119175b7a4e4272a26dd85505e5ede Mon Sep 17 00:00:00 2001
Brad Bishop316dfdd2018-06-25 12:45:53 -04002From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
3Date: Wed, 15 Nov 2017 15:05:01 +0100
Brad Bishop1a4b7ee2018-12-16 17:11:34 -08004Subject: [PATCH] native_bindir
Brad Bishop316dfdd2018-06-25 12:45:53 -04005
6Some libraries, like QT, have pre-processors that convert their input
7files into something that the cross-compiler can process. We find the
8path of those pre-processors via pkg-config-native instead of
9pkg-config.
10
11This path forces the use of pkg-config-native for host_bins arguments.
12
13There are some discussions upstream to merge this patch, but I presonaly believe
14that is is OE only. https://github.com/mesonbuild/meson/issues/1849#issuecomment-303730323
15
16Upstream-Status: Inappropriate [OE specific]
17Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Andrew Geissler90fd73c2021-03-05 15:25:55 -060018
Brad Bishop316dfdd2018-06-25 12:45:53 -040019---
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080020 mesonbuild/dependencies/base.py | 19 +++++++++++--------
Brad Bishop316dfdd2018-06-25 12:45:53 -040021 mesonbuild/dependencies/ui.py | 6 +++---
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080022 2 files changed, 14 insertions(+), 11 deletions(-)
Brad Bishop316dfdd2018-06-25 12:45:53 -040023
24diff --git a/mesonbuild/dependencies/base.py b/mesonbuild/dependencies/base.py
Andrew Geissler90fd73c2021-03-05 15:25:55 -060025index cd77b4b..7e3f338 100644
Brad Bishop316dfdd2018-06-25 12:45:53 -040026--- a/mesonbuild/dependencies/base.py
27+++ b/mesonbuild/dependencies/base.py
Andrew Geissler90fd73c2021-03-05 15:25:55 -060028@@ -192,7 +192,7 @@ class Dependency:
Brad Bishop08902b02019-08-20 09:16:51 -040029 def get_exe_args(self, compiler):
30 return []
Andrew Geissler09209ee2020-12-13 08:44:15 -060031
32- def get_pkgconfig_variable(self, variable_name: str, kwargs: T.Dict[str, T.Any]) -> str:
33+ def get_pkgconfig_variable(self, variable_name: str, kwargs: T.Dict[str, T.Any], use_native=False) -> str:
Brad Bishop316dfdd2018-06-25 12:45:53 -040034 raise DependencyException('{!r} is not a pkgconfig dependency'.format(self.name))
Andrew Geissler09209ee2020-12-13 08:44:15 -060035
Brad Bishop316dfdd2018-06-25 12:45:53 -040036 def get_configtool_variable(self, variable_name):
Andrew Geissler90fd73c2021-03-05 15:25:55 -060037@@ -280,7 +280,7 @@ class InternalDependency(Dependency):
38 return True
39 return any(d.is_built() for d in self.ext_deps)
Andrew Geissler09209ee2020-12-13 08:44:15 -060040
41- def get_pkgconfig_variable(self, variable_name: str, kwargs: T.Dict[str, T.Any]) -> str:
42+ def get_pkgconfig_variable(self, variable_name: str, kwargs: T.Dict[str, T.Any], use_native=False) -> str:
Brad Bishop316dfdd2018-06-25 12:45:53 -040043 raise DependencyException('Method "get_pkgconfig_variable()" is '
44 'invalid for an internal dependency')
Andrew Geissler09209ee2020-12-13 08:44:15 -060045
Andrew Geissler90fd73c2021-03-05 15:25:55 -060046@@ -658,8 +658,11 @@ class PkgConfigDependency(ExternalDependency):
Brad Bishop316dfdd2018-06-25 12:45:53 -040047 return s.format(self.__class__.__name__, self.name, self.is_found,
48 self.version_reqs)
Andrew Geissler09209ee2020-12-13 08:44:15 -060049
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080050- def _call_pkgbin_real(self, args, env):
51- cmd = self.pkgbin.get_command() + args
52+ def _call_pkgbin_real(self, args, env, use_native=False):
53+ if use_native:
Brad Bishopf3fd2882019-06-21 08:06:37 -040054+ cmd = [self.pkgbin.get_command()[0] + "-native"] + args
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080055+ else:
56+ cmd = self.pkgbin.get_command() + args
William A. Kennington IIIc5966302020-03-20 13:04:31 -070057 p, out, err = Popen_safe(cmd, env=env)
58 rc, out, err = p.returncode, out.strip(), err.strip()
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080059 call = ' '.join(cmd)
Andrew Geissler90fd73c2021-03-05 15:25:55 -060060@@ -685,7 +688,7 @@ class PkgConfigDependency(ExternalDependency):
61 env['PKG_CONFIG_LIBDIR'] = new_pkg_config_libdir
Andrew Geissler09209ee2020-12-13 08:44:15 -060062 mlog.debug('PKG_CONFIG_LIBDIR: ' + new_pkg_config_libdir)
63
Brad Bishop316dfdd2018-06-25 12:45:53 -040064- def _call_pkgbin(self, args, env=None):
65+ def _call_pkgbin(self, args, env=None, use_native=False):
Brad Bishop08902b02019-08-20 09:16:51 -040066 # Always copy the environment since we're going to modify it
67 # with pkg-config variables
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080068 if env is None:
Andrew Geissler90fd73c2021-03-05 15:25:55 -060069@@ -699,7 +702,7 @@ class PkgConfigDependency(ExternalDependency):
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080070 targs = tuple(args)
71 cache = PkgConfigDependency.pkgbin_cache
72 if (self.pkgbin, targs, fenv) not in cache:
73- cache[(self.pkgbin, targs, fenv)] = self._call_pkgbin_real(args, env)
74+ cache[(self.pkgbin, targs, fenv)] = self._call_pkgbin_real(args, env, use_native)
75 return cache[(self.pkgbin, targs, fenv)]
Andrew Geissler09209ee2020-12-13 08:44:15 -060076
William A. Kennington IIIc5966302020-03-20 13:04:31 -070077 def _convert_mingw_paths(self, args: T.List[str]) -> T.List[str]:
Andrew Geissler90fd73c2021-03-05 15:25:55 -060078@@ -905,7 +908,7 @@ class PkgConfigDependency(ExternalDependency):
William A. Kennington IIIc5966302020-03-20 13:04:31 -070079 (self.name, out_raw))
80 self.link_args, self.raw_link_args = self._search_libs(out, out_raw)
Andrew Geissler09209ee2020-12-13 08:44:15 -060081
82- def get_pkgconfig_variable(self, variable_name: str, kwargs: T.Dict[str, T.Any]) -> str:
83+ def get_pkgconfig_variable(self, variable_name: str, kwargs: T.Dict[str, T.Any], use_native=False) -> str:
Brad Bishop316dfdd2018-06-25 12:45:53 -040084 options = ['--variable=' + variable_name, self.name]
Andrew Geissler09209ee2020-12-13 08:44:15 -060085
Brad Bishop316dfdd2018-06-25 12:45:53 -040086 if 'define_variable' in kwargs:
Andrew Geissler90fd73c2021-03-05 15:25:55 -060087@@ -918,7 +921,7 @@ class PkgConfigDependency(ExternalDependency):
Andrew Geissler09209ee2020-12-13 08:44:15 -060088
Brad Bishop316dfdd2018-06-25 12:45:53 -040089 options = ['--define-variable=' + '='.join(definition)] + options
Andrew Geissler09209ee2020-12-13 08:44:15 -060090
William A. Kennington IIIc5966302020-03-20 13:04:31 -070091- ret, out, err = self._call_pkgbin(options)
92+ ret, out, err = self._call_pkgbin(options, use_native=use_native)
Brad Bishop316dfdd2018-06-25 12:45:53 -040093 variable = ''
94 if ret != 0:
95 if self.required:
96diff --git a/mesonbuild/dependencies/ui.py b/mesonbuild/dependencies/ui.py
Andrew Geissler90fd73c2021-03-05 15:25:55 -060097index d897d76..a598d2e 100644
Brad Bishop316dfdd2018-06-25 12:45:53 -040098--- a/mesonbuild/dependencies/ui.py
99+++ b/mesonbuild/dependencies/ui.py
Andrew Geisslerc9f78652020-09-18 14:11:35 -0500100@@ -325,7 +325,7 @@ class QtBaseDependency(ExternalDependency):
Brad Bishop316dfdd2018-06-25 12:45:53 -0400101 self.bindir = self.get_pkgconfig_host_bins(core)
102 if not self.bindir:
103 # If exec_prefix is not defined, the pkg-config file is broken
104- prefix = core.get_pkgconfig_variable('exec_prefix', {})
105+ prefix = core.get_pkgconfig_variable('exec_prefix', {}, use_native=True)
106 if prefix:
107 self.bindir = os.path.join(prefix, 'bin')
Andrew Geissler09209ee2020-12-13 08:44:15 -0600108
Andrew Geisslerc9f78652020-09-18 14:11:35 -0500109@@ -528,7 +528,7 @@ class Qt4Dependency(QtBaseDependency):
Brad Bishop316dfdd2018-06-25 12:45:53 -0400110 applications = ['moc', 'uic', 'rcc', 'lupdate', 'lrelease']
111 for application in applications:
112 try:
113- return os.path.dirname(core.get_pkgconfig_variable('%s_location' % application, {}))
114+ return os.path.dirname(core.get_pkgconfig_variable('%s_location' % application, {}, use_native=True))
115 except MesonException:
116 pass
Andrew Geissler09209ee2020-12-13 08:44:15 -0600117
Andrew Geisslerc9f78652020-09-18 14:11:35 -0500118@@ -538,7 +538,7 @@ class Qt5Dependency(QtBaseDependency):
Brad Bishop316dfdd2018-06-25 12:45:53 -0400119 QtBaseDependency.__init__(self, 'qt5', env, kwargs)
Andrew Geissler09209ee2020-12-13 08:44:15 -0600120
Brad Bishop316dfdd2018-06-25 12:45:53 -0400121 def get_pkgconfig_host_bins(self, core):
122- return core.get_pkgconfig_variable('host_bins', {})
123+ return core.get_pkgconfig_variable('host_bins', {}, use_native=True)
Andrew Geissler09209ee2020-12-13 08:44:15 -0600124
Brad Bishop1a4b7ee2018-12-16 17:11:34 -0800125 def get_private_includes(self, mod_inc_dir, module):
126 return _qt_get_private_includes(mod_inc_dir, module, self.version)