| Brad Bishop | 96ff198 | 2019-08-19 13:50:42 -0400 | [diff] [blame^] | 1 | From aa7a9185a037ad59012bd46713ac340458e95209 Mon Sep 17 00:00:00 2001 |
| Patrick Williams | c0f7c04 | 2017-02-23 20:41:17 -0600 | [diff] [blame] | 2 | From: =?UTF-8?q?An=C3=ADbal=20Lim=C3=B3n?= <anibal.limon@linux.intel.com> |
| 3 | Date: Fri, 13 May 2016 11:11:28 -0500 |
| Brad Bishop | 96ff198 | 2019-08-19 13:50:42 -0400 | [diff] [blame^] | 4 | Subject: [PATCH] testcases/network/nfsv4/acl/acl1.c: Security fix on |
| 5 | string printf |
| Patrick Williams | c0f7c04 | 2017-02-23 20:41:17 -0600 | [diff] [blame] | 6 | MIME-Version: 1.0 |
| 7 | Content-Type: text/plain; charset=UTF-8 |
| 8 | Content-Transfer-Encoding: 8bit |
| 9 | |
| 10 | Fixes: |
| 11 | |
| 12 | acl1.c: In function 'test_acl_default': |
| 13 | acl1.c:317:2: error: format not a string literal and no format arguments |
| 14 | [-Werror=format-security] |
| 15 | printf(cmd); |
| 16 | |
| 17 | [YOCTO #9548] |
| 18 | |
| Patrick Williams | c0f7c04 | 2017-02-23 20:41:17 -0600 | [diff] [blame] | 19 | Upstream-Status: Pending |
| Brad Bishop | 96ff198 | 2019-08-19 13:50:42 -0400 | [diff] [blame^] | 20 | |
| 21 | Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> |
| Patrick Williams | c0f7c04 | 2017-02-23 20:41:17 -0600 | [diff] [blame] | 22 | --- |
| 23 | testcases/network/nfsv4/acl/acl1.c | 2 +- |
| 24 | 1 file changed, 1 insertion(+), 1 deletion(-) |
| 25 | |
| 26 | diff --git a/testcases/network/nfsv4/acl/acl1.c b/testcases/network/nfsv4/acl/acl1.c |
| Brad Bishop | 96ff198 | 2019-08-19 13:50:42 -0400 | [diff] [blame^] | 27 | index bdf0180..898b7ca 100644 |
| Patrick Williams | c0f7c04 | 2017-02-23 20:41:17 -0600 | [diff] [blame] | 28 | --- a/testcases/network/nfsv4/acl/acl1.c |
| 29 | +++ b/testcases/network/nfsv4/acl/acl1.c |
| Brad Bishop | 1a4b7ee | 2018-12-16 17:11:34 -0800 | [diff] [blame] | 30 | @@ -303,7 +303,7 @@ void test_acl_default(char *dir, acl_t acl) |
| Patrick Williams | c0f7c04 | 2017-02-23 20:41:17 -0600 | [diff] [blame] | 31 | char *cmd = malloc(256); |
| 32 | |
| 33 | strcpy(cmd, "chmod 7777 "); |
| 34 | - printf(cmd); |
| 35 | + printf(cmd, NULL); |
| 36 | strcat(cmd, dir); |
| 37 | system(cmd); |
| 38 | acl2 = acl_get_file(path, ACL_TYPE_ACCESS); |
| 39 | -- |
| Brad Bishop | 96ff198 | 2019-08-19 13:50:42 -0400 | [diff] [blame^] | 40 | 2.7.4 |
| Patrick Williams | c0f7c04 | 2017-02-23 20:41:17 -0600 | [diff] [blame] | 41 | |