blob: b5c265ec2bffbffd9e7b64f422aba28ec5b0cb04 [file] [log] [blame]
Andrew Geisslere34f8962021-04-15 15:53:51 -05001From f723458eb649a9ad1d5d0e3dd6e801b284680fa7 Mon Sep 17 00:00:00 2001
Brad Bishopd7bf8c12018-02-25 22:55:05 -05002From: Khem Raj <raj.khem@gmail.com>
3Date: Thu, 8 Jun 2017 16:50:59 -0700
Andrew Geisslere34f8962021-04-15 15:53:51 -05004Subject: [PATCH 6/6] use intptr_t to fix pointer-to-int-cast issues
Brad Bishopd7bf8c12018-02-25 22:55:05 -05005
6uintptr_t is guaranteed to be wide enough that
7converting a void* to uintptr_t and back again
8will yield the original pointer value
9
10Signed-off-by: Khem Raj <raj.khem@gmail.com>
11---
12 src/lib/src/fwts_acpi_tables.c | 4 ++--
13 src/lib/src/fwts_mmap.c | 2 +-
Andrew Geisslere34f8962021-04-15 15:53:51 -050014 src/lib/src/fwts_smbios.c | 2 +-
15 3 files changed, 4 insertions(+), 4 deletions(-)
Brad Bishopd7bf8c12018-02-25 22:55:05 -050016
Brad Bishopd7bf8c12018-02-25 22:55:05 -050017--- a/src/lib/src/fwts_acpi_tables.c
18+++ b/src/lib/src/fwts_acpi_tables.c
Andrew Geissler9aee5002022-03-30 16:27:02 +000019@@ -171,7 +171,7 @@ static fwts_acpi_table_rsdp *fwts_acpi_g
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080020 return NULL;
21 }
Brad Bishopd7bf8c12018-02-25 22:55:05 -050022
23- if ((mem = fwts_mmap((off_t)addr, sizeof(fwts_acpi_table_rsdp))) == FWTS_MAP_FAILED)
24+ if ((mem = fwts_mmap((uintptr_t)addr, sizeof(fwts_acpi_table_rsdp))) == FWTS_MAP_FAILED)
25 return NULL;
26
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080027 if (fwts_safe_memcpy(rsdp, mem, sizeof(fwts_acpi_table_rsdp)) != FWTS_OK) {
Andrew Geissler9aee5002022-03-30 16:27:02 +000028@@ -484,7 +484,7 @@ static int fwts_acpi_load_tables_from_fi
Brad Bishopd7bf8c12018-02-25 22:55:05 -050029 if ((rsdp = fwts_acpi_get_rsdp(fw, rsdp_addr, &rsdp_len)) == NULL)
30 return FWTS_ERROR;
31
32- fwts_acpi_add_table("RSDP", rsdp, (uint64_t)(off_t)rsdp_addr, rsdp_len, FWTS_ACPI_TABLE_FROM_FIRMWARE);
33+ fwts_acpi_add_table("RSDP", rsdp, (uint64_t)(uintptr_t)rsdp_addr, rsdp_len, FWTS_ACPI_TABLE_FROM_FIRMWARE);
34
35 /* Load any tables from XSDT if it's valid */
36 if (rsdp->xsdt_address) {
Brad Bishopd7bf8c12018-02-25 22:55:05 -050037--- a/src/lib/src/fwts_mmap.c
38+++ b/src/lib/src/fwts_mmap.c
Andrew Geissler9aee5002022-03-30 16:27:02 +000039@@ -82,7 +82,7 @@ int fwts_munmap(void *mem, const size_t
Brad Bishopd7bf8c12018-02-25 22:55:05 -050040 off_t offset;
41
42 page_size = fwts_page_size();
43- offset = ((off_t)(mem)) & (page_size - 1);
44+ offset = ((uintptr_t)(mem)) & (page_size - 1);
45
46 if (munmap((void *)((uint8_t *)mem - offset), size + offset) < 0)
47 return FWTS_ERROR;
Brad Bishopd7bf8c12018-02-25 22:55:05 -050048--- a/src/lib/src/fwts_smbios.c
49+++ b/src/lib/src/fwts_smbios.c
Andrew Geissler9aee5002022-03-30 16:27:02 +000050@@ -78,7 +78,7 @@ static void *fwts_smbios_find_entry_uefi
Andrew Geisslere34f8962021-04-15 15:53:51 -050051 if ((addr = fwts_scan_efi_systab(smbios)) != NULL) {
Brad Bishopd7bf8c12018-02-25 22:55:05 -050052 fwts_smbios_entry *mapped_entry;
53
Brad Bishop1a4b7ee2018-12-16 17:11:34 -080054- if ((mapped_entry = fwts_mmap((off_t)addr, size)) != FWTS_MAP_FAILED) {
55+ if ((mapped_entry = fwts_mmap((uintptr_t)addr, size)) != FWTS_MAP_FAILED) {
56 if (fwts_safe_memcpy(entry, mapped_entry, size) == FWTS_OK) {
57 (void)fwts_munmap(mapped_entry, size);
58 *type = FWTS_SMBIOS;