Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / 9c76a0acb0b1a0552ca732b1c62c777e7f1342df
commit9c76a0acb0b1a0552ca732b1c62c777e7f1342df[log] [tgz]
authorLei YU <yulei.sh@bytedance.com>Mon Mar 14 11:37:15 2022 +0800
committerLei YU <yulei.sh@bytedance.com>Mon Mar 14 13:35:15 2022 +0800
tree193458988ba76df06070c4f01cfff11aa7c20d57
parent88ba1f9ec712d82e8111952df0524bb460c2acb0 [diff]
item_updater: Fix crash in updateUbootEnvVars()

In 25773a7 there is a change in updateUbootEnvVars() to use
versions.find(versionId)->second->path() as the flashId to update.

However, the function may be called with an invalid versionId, e.g. if
the BMC has only one activation for static layout, resetUbootEnvVars()
will not find a valid `lowestPriorityVersion`, and it will pass an empty
string to `updateUbootEnvVars()`.

Fix the issue by adding a check and return if there is no such version
found.

Tested: Verify the BMC code update for static layout with one flash is
        OK.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I4bf8240fefca3ae919024a61e45cfe3d29ed01e7
1 file changed
tree: 193458988ba76df06070c4f01cfff11aa7c20d57
  1. mmc/
  2. static/
  3. subprojects/
  4. test/
  5. ubi/
  6. usb/
  7. xyz/
  8. .clang-format
  9. .gitignore
  10. activation.cpp
  11. activation.hpp
  12. download_manager.cpp
  13. download_manager.hpp
  14. download_manager_main.cpp
  15. elog-errors.hpp
  16. flash.hpp
  17. force-reboot.service.in
  18. gen-bios-tar
  19. image_manager.cpp
  20. image_manager.hpp
  21. image_manager_main.cpp
  22. image_verify.cpp
  23. image_verify.hpp
  24. images.cpp
  25. images.hpp
  26. item_updater.cpp
  27. item_updater.hpp
  28. item_updater_helper.hpp
  29. item_updater_main.cpp
  30. LICENSE
  31. MAINTAINERS
  32. meson.build
  33. meson_options.txt
  34. msl_verify.cpp
  35. msl_verify.hpp
  36. obmc-flash-bmc
  37. obmc-flash-bmc-setenv@.service.in
  38. obmc-flash-host-bios@.service.in
  39. openssl_alloc.cpp
  40. openssl_alloc.hpp
  41. OWNERS
  42. README.md
  43. reboot-guard-disable.service.in
  44. reboot-guard-enable.service.in
  45. serialize.cpp
  46. serialize.hpp
  47. software.conf
  48. sync_manager.cpp
  49. sync_manager.hpp
  50. sync_manager_main.cpp
  51. sync_watch.cpp
  52. sync_watch.hpp
  53. synclist
  54. usr-local.mount.in
  55. utils.cpp
  56. utils.hpp
  57. version.cpp
  58. version.hpp
  59. watch.cpp
  60. watch.hpp
  61. xyz.openbmc_project.Software.BMC.Updater.service.in
  62. xyz.openbmc_project.Software.Download.service.in
  63. xyz.openbmc_project.Software.Sync.service.in
  64. xyz.openbmc_project.Software.Version.service.in
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

  1. meson build
  2. ninja -C build

To clean the repository run rm -r build.