Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-bmc-code-mgmt / d7fbc1e319046bcc76eb793c5792612bafe0b676
commitd7fbc1e319046bcc76eb793c5792612bafe0b676[log] [tgz]
authorAdriana Kobylak <anoo@us.ibm.com>Sat Jun 06 07:46:40 2020 -0500
committerAdriana Kobylak <anoo@linux.ibm.com>Tue Jul 14 14:10:06 2020 +0000
treec577ace18a068fef661a660418d0f9a0ae247995
parent341243513d6da6e9d3ddf886c0d22029fad748a9 [diff]
mmc: Add mount services

The iterm updater relies on the versions being mounted in the
MEDIA_DIR in order to create the D-Bus objects when the BMC
first starts up.

Create two services: one to mount the emmc rootfs partitions
so that the version D-Bus objects get created, and another one
to unmount them after the item updater has run because there's
no need to keep the mounts around, actually they shouldn't be
mounted during a code update. The UBI layout does an unmount
at the start of an update, but it's less risky to just unmount
once the mount is no longer needed in case the update is done
manually by starting the update service file or directly
calling obmc-flash-bmc.

These services get started automatically by adding a dependency
to the item updater service:
"WantedBy=xyz.openbmc_project.Software.BMC.Updater.service"
The mount has a "Before" directive and the unmount has an "After"
directive. This allows the item updater to have the mounts
available for processing and they are unmounted once the processing
is complete.

Also add a dash "-" to ExecStart to ignore errors:
https://www.freedesktop.org/software/systemd/man/systemd.service.html#ExecStart=
This is needed since the non-running filesystem may had been
invalidated during a Delete operation. This directive still logs
an error but does not put the service file in Failed state: Ex:

Jul 11 16:36:07 rainier systemd[1]: Starting Mount BMC rofs volumes after a reboot...
Jul 11 16:36:07 rainier sh[423]: mount: /media/rofs-b: wrong fs type, bad option, bad superblock on /dev/mmcblk0p5, missing codepage or helper program, or other
 error.
Jul 11 16:36:07 rainier systemd[1]: obmc-flash-mmc-mount.service: Succeeded.
Jul 11 16:36:07 rainier systemd[1]: Finished Mount BMC rofs volumes after a reboot.
Jul 11 16:36:07 rainier systemd[1]: Started OpenBMC Software Update Manager.
Jul 11 16:36:07 rainier systemd[1]: Starting Unmount BMC rofs volumes...
Jul 11 16:36:08 rainier umount[427]: umount: /media/rofs-b: no mount point specified.
Jul 11 16:36:08 rainier systemd[1]: obmc-flash-mmc-umount.service: Succeeded.
Jul 11 16:36:08 rainier systemd[1]: Finished Unmount BMC rofs volumes.

Tested: Verified the D-Bus version objects are created after
BMC reboot, and the item updater service starts successfully
after a Delete operation.

Change-Id: Ic0c83391a2879b8508bf5aa9f18941590d96352d
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
3 files changed
tree: c577ace18a068fef661a660418d0f9a0ae247995
  1. mmc/
  2. static/
  3. test/
  4. ubi/
  5. xyz/
  6. .clang-format
  7. .gitignore
  8. activation.cpp
  9. activation.hpp
  10. download_manager.cpp
  11. download_manager.hpp
  12. download_manager_main.cpp
  13. elog-errors.hpp
  14. flash.hpp
  15. force-reboot.service.in
  16. gen-bios-tar
  17. image_manager.cpp
  18. image_manager.hpp
  19. image_manager_main.cpp
  20. image_verify.cpp
  21. image_verify.hpp
  22. images.hpp
  23. item_updater.cpp
  24. item_updater.hpp
  25. item_updater_helper.hpp
  26. item_updater_main.cpp
  27. LICENSE
  28. MAINTAINERS
  29. meson.build
  30. meson_options.txt
  31. obmc-flash-bmc
  32. obmc-flash-bmc-setenv@.service.in
  33. obmc-flash-host-bios@.service.in
  34. openssl_alloc.cpp
  35. openssl_alloc.hpp
  36. README.md
  37. reboot-guard-disable.service.in
  38. reboot-guard-enable.service.in
  39. serialize.cpp
  40. serialize.hpp
  41. software.conf
  42. sync_manager.cpp
  43. sync_manager.hpp
  44. sync_manager_main.cpp
  45. sync_watch.cpp
  46. sync_watch.hpp
  47. synclist
  48. usr-local.mount.in
  49. utils.cpp
  50. utils.hpp
  51. version.cpp
  52. version.hpp
  53. watch.cpp
  54. watch.hpp
  55. xyz.openbmc_project.Software.BMC.Updater.service.in
  56. xyz.openbmc_project.Software.Download.service.in
  57. xyz.openbmc_project.Software.Sync.service.in
  58. xyz.openbmc_project.Software.Version.service.in
README.md

phosphor-bmc-code-mgmt

Phosphor BMC Code Management provides a set of system software management applications. More information can be found at Software Architecture

To Build

To build this package, do the following steps:

  1. meson build
  2. ninja -C build

To clean the repository run rm -r build.