Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 1 | /** |
| 2 | * Copyright 2017 Google Inc. |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
Pete O_o | 765a6d8 | 2025-07-23 21:44:14 -0700 | [diff] [blame] | 16 | #include "config.h" |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 17 | |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 18 | #include "fancontroller.hpp" |
Patrick Venture | da4a5dd | 2018-08-31 09:42:48 -0700 | [diff] [blame] | 19 | |
Ed Tanous | f8b6e55 | 2025-06-27 13:27:50 -0700 | [diff] [blame] | 20 | #include "ec/pid.hpp" |
| 21 | #include "fan.hpp" |
| 22 | #include "pidcontroller.hpp" |
Patrick Venture | c32e3fc | 2019-02-28 10:01:11 -0800 | [diff] [blame] | 23 | #include "tuning.hpp" |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 24 | #include "util.hpp" |
Ed Tanous | f8b6e55 | 2025-06-27 13:27:50 -0700 | [diff] [blame] | 25 | #include "zone_interface.hpp" |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 26 | |
Patrick Venture | da4a5dd | 2018-08-31 09:42:48 -0700 | [diff] [blame] | 27 | #include <algorithm> |
Josh Lehan | ca79115 | 2020-09-20 23:41:39 -0700 | [diff] [blame] | 28 | #include <cmath> |
Ed Tanous | f8b6e55 | 2025-06-27 13:27:50 -0700 | [diff] [blame] | 29 | #include <cstdint> |
| 30 | #include <exception> |
Patrick Venture | da4a5dd | 2018-08-31 09:42:48 -0700 | [diff] [blame] | 31 | #include <iostream> |
Ed Tanous | f8b6e55 | 2025-06-27 13:27:50 -0700 | [diff] [blame] | 32 | #include <map> |
| 33 | #include <memory> |
| 34 | #include <string> |
| 35 | #include <utility> |
| 36 | #include <vector> |
Patrick Venture | da4a5dd | 2018-08-31 09:42:48 -0700 | [diff] [blame] | 37 | |
Patrick Venture | a076487 | 2020-08-08 07:48:43 -0700 | [diff] [blame] | 38 | namespace pid_control |
| 39 | { |
| 40 | |
Patrick Williams | bd63bca | 2024-08-16 15:21:10 -0400 | [diff] [blame] | 41 | std::unique_ptr<PIDController> FanController::createFanPid( |
| 42 | ZoneInterface* owner, const std::string& id, |
| 43 | const std::vector<std::string>& inputs, const ec::pidinfo& initial) |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 44 | { |
Patrick Venture | 566a151 | 2018-06-12 14:51:07 -0700 | [diff] [blame] | 45 | if (inputs.size() == 0) |
| 46 | { |
| 47 | return nullptr; |
| 48 | } |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 49 | auto fan = std::make_unique<FanController>(id, inputs, owner); |
Patrick Venture | 563a356 | 2018-10-30 09:31:26 -0700 | [diff] [blame] | 50 | ec::pid_info_t* info = fan->getPIDInfo(); |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 51 | |
Patrick Venture | 7af157b | 2018-10-30 11:24:40 -0700 | [diff] [blame] | 52 | initializePIDStruct(info, initial); |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 53 | |
| 54 | return fan; |
| 55 | } |
| 56 | |
Patrick Venture | 5f59c0f | 2018-11-11 12:55:14 -0800 | [diff] [blame] | 57 | double FanController::inputProc(void) |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 58 | { |
Josh Lehan | d38ae27 | 2020-11-13 02:59:30 -0800 | [diff] [blame] | 59 | double value = 0.0; |
| 60 | std::vector<double> values; |
| 61 | std::vector<double>::iterator result; |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 62 | |
| 63 | try |
| 64 | { |
| 65 | for (const auto& name : _inputs) |
| 66 | { |
Josh Lehan | d38ae27 | 2020-11-13 02:59:30 -0800 | [diff] [blame] | 67 | // Read the unscaled value, to correctly recover the RPM |
| 68 | value = _owner->getCachedValues(name).unscaled; |
| 69 | |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 70 | /* If we have a fan we can't read, its value will be 0 for at least |
| 71 | * some boards, while others... the fan will drop off dbus (if |
| 72 | * that's how it's being read and in that case its value will never |
| 73 | * be updated anymore, which is relatively harmless, except, when |
| 74 | * something tries to read its value through IPMI, and can't, they |
| 75 | * sort of have to guess -- all the other fans are reporting, why |
| 76 | * not this one? Maybe it's unable to be read, so it's "bad." |
| 77 | */ |
Josh Lehan | ca79115 | 2020-09-20 23:41:39 -0700 | [diff] [blame] | 78 | if (!(std::isfinite(value))) |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 79 | { |
Josh Lehan | ca79115 | 2020-09-20 23:41:39 -0700 | [diff] [blame] | 80 | continue; |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 81 | } |
Josh Lehan | d38ae27 | 2020-11-13 02:59:30 -0800 | [diff] [blame] | 82 | if (value <= 0.0) |
Josh Lehan | ca79115 | 2020-09-20 23:41:39 -0700 | [diff] [blame] | 83 | { |
| 84 | continue; |
| 85 | } |
| 86 | |
| 87 | values.push_back(value); |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 88 | } |
| 89 | } |
| 90 | catch (const std::exception& e) |
| 91 | { |
Patrick Venture | 563a356 | 2018-10-30 09:31:26 -0700 | [diff] [blame] | 92 | std::cerr << "exception on inputProc.\n"; |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 93 | throw; |
| 94 | } |
| 95 | |
Patrick Venture | 566a151 | 2018-06-12 14:51:07 -0700 | [diff] [blame] | 96 | /* Reset the value from the above loop. */ |
Josh Lehan | d38ae27 | 2020-11-13 02:59:30 -0800 | [diff] [blame] | 97 | value = 0.0; |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 98 | if (values.size() > 0) |
| 99 | { |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 100 | /* the fan PID algorithm was unstable with average, and seemed to work |
| 101 | * better with minimum. I had considered making this choice a variable |
Patrick Venture | df766f2 | 2018-10-13 09:30:58 -0700 | [diff] [blame] | 102 | * in the configuration, and it's a nice-to-have.. |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 103 | */ |
| 104 | result = std::min_element(values.begin(), values.end()); |
| 105 | value = *result; |
| 106 | } |
| 107 | |
Patrick Venture | 5f59c0f | 2018-11-11 12:55:14 -0800 | [diff] [blame] | 108 | return value; |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 109 | } |
| 110 | |
Patrick Venture | 5f59c0f | 2018-11-11 12:55:14 -0800 | [diff] [blame] | 111 | double FanController::setptProc(void) |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 112 | { |
Patrick Venture | f7a2dd5 | 2019-07-16 14:31:13 -0700 | [diff] [blame] | 113 | double maxRPM = _owner->getMaxSetPointRequest(); |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 114 | |
| 115 | // store for reference, and check if more or less. |
Patrick Venture | 5f59c0f | 2018-11-11 12:55:14 -0800 | [diff] [blame] | 116 | double prev = getSetpoint(); |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 117 | |
| 118 | if (maxRPM > prev) |
| 119 | { |
| 120 | setFanDirection(FanSpeedDirection::UP); |
| 121 | } |
| 122 | else if (prev > maxRPM) |
| 123 | { |
| 124 | setFanDirection(FanSpeedDirection::DOWN); |
| 125 | } |
| 126 | else |
| 127 | { |
| 128 | setFanDirection(FanSpeedDirection::NEUTRAL); |
| 129 | } |
| 130 | |
Patrick Venture | 563a356 | 2018-10-30 09:31:26 -0700 | [diff] [blame] | 131 | setSetpoint(maxRPM); |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 132 | |
| 133 | return (maxRPM); |
| 134 | } |
| 135 | |
Patrick Venture | 5f59c0f | 2018-11-11 12:55:14 -0800 | [diff] [blame] | 136 | void FanController::outputProc(double value) |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 137 | { |
Patrick Venture | 5f59c0f | 2018-11-11 12:55:14 -0800 | [diff] [blame] | 138 | double percent = value; |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 139 | |
Patrick Venture | de79ee0 | 2019-05-08 14:50:00 -0700 | [diff] [blame] | 140 | /* If doing tuning, don't go into failsafe mode. */ |
| 141 | if (!tuningEnabled) |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 142 | { |
Josh Lehan | df59765 | 2023-12-19 15:05:53 -0800 | [diff] [blame] | 143 | bool failsafeCurrState = _owner->getFailSafeMode(); |
| 144 | |
| 145 | // Note when failsafe state transitions happen |
| 146 | if (failsafePrevState != failsafeCurrState) |
| 147 | { |
| 148 | failsafePrevState = failsafeCurrState; |
| 149 | failsafeTransition = true; |
| 150 | } |
| 151 | |
| 152 | if (failsafeCurrState) |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 153 | { |
Brandon Kim | bcdeb83 | 2022-08-15 23:27:36 +0000 | [diff] [blame] | 154 | double failsafePercent = _owner->getFailSafePercent(); |
| 155 | |
| 156 | #ifdef STRICT_FAILSAFE_PWM |
| 157 | // Unconditionally replace the computed PWM with the |
| 158 | // failsafe PWM if STRICT_FAILSAFE_PWM is defined. |
| 159 | percent = failsafePercent; |
| 160 | #else |
| 161 | // Ensure PWM is never lower than the failsafe PWM. |
| 162 | // The computed PWM is still allowed to rise higher than |
| 163 | // failsafe PWM if STRICT_FAILSAFE_PWM is NOT defined. |
| 164 | // This is the default behavior. |
| 165 | if (percent < failsafePercent) |
Patrick Venture | c32e3fc | 2019-02-28 10:01:11 -0800 | [diff] [blame] | 166 | { |
Brandon Kim | bcdeb83 | 2022-08-15 23:27:36 +0000 | [diff] [blame] | 167 | percent = failsafePercent; |
Patrick Venture | c32e3fc | 2019-02-28 10:01:11 -0800 | [diff] [blame] | 168 | } |
Brandon Kim | bcdeb83 | 2022-08-15 23:27:36 +0000 | [diff] [blame] | 169 | #endif |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 170 | } |
Josh Lehan | df59765 | 2023-12-19 15:05:53 -0800 | [diff] [blame] | 171 | |
| 172 | // Always print if debug enabled |
| 173 | if (debugEnabled) |
| 174 | { |
| 175 | std::cerr << "Zone " << _owner->getZoneID() << " fans, " |
| 176 | << (failsafeCurrState ? "failsafe" : "normal") |
| 177 | << " mode, output pwm: " << percent << "\n"; |
| 178 | } |
Bonnie Lo | c51ba91 | 2022-10-12 14:07:22 +0800 | [diff] [blame] | 179 | else |
| 180 | { |
Josh Lehan | df59765 | 2023-12-19 15:05:53 -0800 | [diff] [blame] | 181 | // Only print once per transition when not debugging |
| 182 | if (failsafeTransition) |
Bonnie Lo | c51ba91 | 2022-10-12 14:07:22 +0800 | [diff] [blame] | 183 | { |
Josh Lehan | df59765 | 2023-12-19 15:05:53 -0800 | [diff] [blame] | 184 | failsafeTransition = false; |
| 185 | std::cerr << "Zone " << _owner->getZoneID() << " fans, " |
| 186 | << (failsafeCurrState ? "entering failsafe" |
| 187 | : "returning to normal") |
| 188 | << " mode, output pwm: " << percent << "\n"; |
Harvey Wu | a427007 | 2024-05-29 16:11:13 +0800 | [diff] [blame] | 189 | |
| 190 | std::map<std::string, std::pair<std::string, double>> |
| 191 | failSensorList = _owner->getFailSafeSensors(); |
| 192 | for (const auto& it : failSensorList) |
| 193 | { |
| 194 | std::cerr << "Fail sensor: " << it.first |
| 195 | << ", reason: " << it.second.first << "\n"; |
| 196 | } |
Bonnie Lo | c51ba91 | 2022-10-12 14:07:22 +0800 | [diff] [blame] | 197 | } |
| 198 | } |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 199 | } |
Josh Lehan | df59765 | 2023-12-19 15:05:53 -0800 | [diff] [blame] | 200 | else |
| 201 | { |
| 202 | if (debugEnabled) |
| 203 | { |
| 204 | std::cerr << "Zone " << _owner->getZoneID() |
| 205 | << " fans, tuning mode, bypassing failsafe, output pwm: " |
| 206 | << percent << "\n"; |
| 207 | } |
| 208 | } |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 209 | |
| 210 | // value and kFanFailSafeDutyCycle are 10 for 10% so let's fix that. |
Josh Lehan | d38ae27 | 2020-11-13 02:59:30 -0800 | [diff] [blame] | 211 | percent /= 100.0; |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 212 | |
| 213 | // PidSensorMap for writing. |
Patrick Venture | 4a2dc4d | 2018-10-23 09:02:55 -0700 | [diff] [blame] | 214 | for (const auto& it : _inputs) |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 215 | { |
Patrick Venture | a58197c | 2018-06-11 15:29:45 -0700 | [diff] [blame] | 216 | auto sensor = _owner->getSensor(it); |
Josh Lehan | a4146eb | 2020-10-01 11:49:09 -0700 | [diff] [blame] | 217 | auto redundantWrite = _owner->getRedundantWrite(); |
Josh Lehan | 3f0f7bc | 2023-02-13 01:45:29 -0800 | [diff] [blame] | 218 | int64_t rawWritten = -1; |
Josh Lehan | a4146eb | 2020-10-01 11:49:09 -0700 | [diff] [blame] | 219 | sensor->write(percent, redundantWrite, &rawWritten); |
Josh Lehan | b300575 | 2022-02-22 20:48:07 -0800 | [diff] [blame] | 220 | |
| 221 | // The outputCache will be used later, |
| 222 | // to store a record of the PWM commanded, |
| 223 | // so that this information can be included during logging. |
| 224 | auto unscaledWritten = static_cast<double>(rawWritten); |
| 225 | _owner->setOutputCache(sensor->getName(), {percent, unscaledWritten}); |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 226 | } |
| 227 | |
Patrick Venture | d801218 | 2018-03-08 08:21:38 -0800 | [diff] [blame] | 228 | return; |
| 229 | } |
Patrick Venture | a076487 | 2020-08-08 07:48:43 -0700 | [diff] [blame] | 230 | |
Patrick Rudolph | 7e63502 | 2023-10-13 12:40:14 +0200 | [diff] [blame] | 231 | FanController::~FanController() |
| 232 | { |
| 233 | #ifdef OFFLINE_FAILSAFE_PWM |
| 234 | double percent = _owner->getFailSafePercent(); |
| 235 | if (debugEnabled) |
| 236 | { |
| 237 | std::cerr << "Zone " << _owner->getZoneID() |
| 238 | << " offline fans output pwm: " << percent << "\n"; |
| 239 | } |
| 240 | |
| 241 | // value and kFanFailSafeDutyCycle are 10 for 10% so let's fix that. |
| 242 | percent /= 100.0; |
| 243 | |
| 244 | // PidSensorMap for writing. |
| 245 | for (const auto& it : _inputs) |
| 246 | { |
| 247 | auto sensor = _owner->getSensor(it); |
| 248 | auto redundantWrite = _owner->getRedundantWrite(); |
| 249 | int64_t rawWritten; |
| 250 | sensor->write(percent, redundantWrite, &rawWritten); |
| 251 | |
| 252 | // The outputCache will be used later, |
| 253 | // to store a record of the PWM commanded, |
| 254 | // so that this information can be included during logging. |
| 255 | auto unscaledWritten = static_cast<double>(rawWritten); |
| 256 | _owner->setOutputCache(sensor->getName(), {percent, unscaledWritten}); |
| 257 | } |
| 258 | #endif |
| 259 | } |
| 260 | |
Patrick Venture | a076487 | 2020-08-08 07:48:43 -0700 | [diff] [blame] | 261 | } // namespace pid_control |