Saqib Khan | b077470 | 2017-05-23 16:02:41 -0500 | [diff] [blame] | 1 | #include "activation.hpp" |
Lei YU | 1be8d50 | 2018-06-20 11:48:36 +0800 | [diff] [blame^] | 2 | #include "images.hpp" |
Saqib Khan | 4c1aec0 | 2017-07-06 11:46:13 -0500 | [diff] [blame] | 3 | #include "item_updater.hpp" |
Saqib Khan | 5d53267 | 2017-08-09 10:44:50 -0500 | [diff] [blame] | 4 | #include "serialize.hpp" |
Saqib Khan | b9da663 | 2017-09-13 09:48:37 -0500 | [diff] [blame] | 5 | #include <phosphor-logging/log.hpp> |
Adriana Kobylak | aea48f2 | 2018-07-10 10:20:56 -0500 | [diff] [blame] | 6 | #include <sdbusplus/exception.hpp> |
Saqib Khan | b9da663 | 2017-09-13 09:48:37 -0500 | [diff] [blame] | 7 | |
Jayanth Othayoth | 0e0c127 | 2018-02-21 05:46:36 -0600 | [diff] [blame] | 8 | #ifdef WANT_SIGNATURE_VERIFY |
| 9 | #include <phosphor-logging/elog.hpp> |
| 10 | #include <phosphor-logging/elog-errors.hpp> |
| 11 | #include <xyz/openbmc_project/Common/error.hpp> |
| 12 | #include "image_verify.hpp" |
Jayanth Othayoth | 0e0c127 | 2018-02-21 05:46:36 -0600 | [diff] [blame] | 13 | #endif |
| 14 | |
Saqib Khan | b077470 | 2017-05-23 16:02:41 -0500 | [diff] [blame] | 15 | namespace phosphor |
| 16 | { |
| 17 | namespace software |
| 18 | { |
| 19 | namespace updater |
| 20 | { |
| 21 | |
| 22 | namespace softwareServer = sdbusplus::xyz::openbmc_project::Software::server; |
| 23 | |
Saqib Khan | b9da663 | 2017-09-13 09:48:37 -0500 | [diff] [blame] | 24 | using namespace phosphor::logging; |
Adriana Kobylak | aea48f2 | 2018-07-10 10:20:56 -0500 | [diff] [blame] | 25 | using sdbusplus::exception::SdBusError; |
Saqib Khan | b9da663 | 2017-09-13 09:48:37 -0500 | [diff] [blame] | 26 | |
Jayanth Othayoth | 0e0c127 | 2018-02-21 05:46:36 -0600 | [diff] [blame] | 27 | #ifdef WANT_SIGNATURE_VERIFY |
| 28 | using InternalFailure = |
| 29 | sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure; |
Jayanth Othayoth | 9a9d7c2 | 2018-03-28 10:05:26 -0500 | [diff] [blame] | 30 | namespace control = sdbusplus::xyz::openbmc_project::Control::server; |
Jayanth Othayoth | 0e0c127 | 2018-02-21 05:46:36 -0600 | [diff] [blame] | 31 | #endif |
| 32 | |
Michael Tritz | bed88af | 2017-07-19 16:00:06 -0500 | [diff] [blame] | 33 | void Activation::subscribeToSystemdSignals() |
| 34 | { |
Adriana Kobylak | 2285fe0 | 2018-02-27 15:36:59 -0600 | [diff] [blame] | 35 | auto method = this->bus.new_method_call(SYSTEMD_BUSNAME, SYSTEMD_PATH, |
| 36 | SYSTEMD_INTERFACE, "Subscribe"); |
Adriana Kobylak | aea48f2 | 2018-07-10 10:20:56 -0500 | [diff] [blame] | 37 | try |
| 38 | { |
| 39 | this->bus.call_noreply(method); |
| 40 | } |
| 41 | catch (const SdBusError& e) |
| 42 | { |
| 43 | if (e.name() != nullptr && |
| 44 | strcmp("org.freedesktop.systemd1.AlreadySubscribed", e.name()) == 0) |
| 45 | { |
| 46 | // If an Activation attempt fails, the Unsubscribe method is not |
| 47 | // called. This may lead to an AlreadySubscribed error if the |
| 48 | // Activation is re-attempted. |
| 49 | } |
| 50 | else |
| 51 | { |
| 52 | log<level::ERR>("Error subscribing to systemd", |
| 53 | entry("ERROR=%s", e.what())); |
| 54 | } |
| 55 | } |
Michael Tritz | bed88af | 2017-07-19 16:00:06 -0500 | [diff] [blame] | 56 | |
| 57 | return; |
| 58 | } |
| 59 | |
Michael Tritz | f2b5e0d | 2017-07-25 14:39:34 -0500 | [diff] [blame] | 60 | void Activation::unsubscribeFromSystemdSignals() |
| 61 | { |
Adriana Kobylak | 2285fe0 | 2018-02-27 15:36:59 -0600 | [diff] [blame] | 62 | auto method = this->bus.new_method_call(SYSTEMD_BUSNAME, SYSTEMD_PATH, |
| 63 | SYSTEMD_INTERFACE, "Unsubscribe"); |
Michael Tritz | f2b5e0d | 2017-07-25 14:39:34 -0500 | [diff] [blame] | 64 | this->bus.call_noreply(method); |
| 65 | |
| 66 | return; |
| 67 | } |
| 68 | |
Adriana Kobylak | 2285fe0 | 2018-02-27 15:36:59 -0600 | [diff] [blame] | 69 | auto Activation::activation(Activations value) -> Activations |
Saqib Khan | b077470 | 2017-05-23 16:02:41 -0500 | [diff] [blame] | 70 | { |
Saqib Khan | 4c1aec0 | 2017-07-06 11:46:13 -0500 | [diff] [blame] | 71 | |
Adriana Kobylak | 8bd84c8 | 2018-01-24 14:19:24 -0600 | [diff] [blame] | 72 | if ((value != softwareServer::Activation::Activations::Active) && |
| 73 | (value != softwareServer::Activation::Activations::Activating)) |
Saqib Khan | 4c1aec0 | 2017-07-06 11:46:13 -0500 | [diff] [blame] | 74 | { |
| 75 | redundancyPriority.reset(nullptr); |
| 76 | } |
| 77 | |
Saqib Khan | b077470 | 2017-05-23 16:02:41 -0500 | [diff] [blame] | 78 | if (value == softwareServer::Activation::Activations::Activating) |
| 79 | { |
Lei YU | a7853ee | 2018-05-23 11:13:12 +0800 | [diff] [blame] | 80 | #ifdef UBIFS_LAYOUT |
Michael Tritz | bed88af | 2017-07-19 16:00:06 -0500 | [diff] [blame] | 81 | if (rwVolumeCreated == false && roVolumeCreated == false) |
Saqib Khan | b077470 | 2017-05-23 16:02:41 -0500 | [diff] [blame] | 82 | { |
Adriana Kobylak | aea48f2 | 2018-07-10 10:20:56 -0500 | [diff] [blame] | 83 | // Enable systemd signals |
| 84 | Activation::subscribeToSystemdSignals(); |
| 85 | |
Adriana Kobylak | 204e1e7 | 2018-01-24 16:00:05 -0600 | [diff] [blame] | 86 | parent.freeSpace(); |
| 87 | |
Michael Tritz | 0edd4ad | 2017-07-26 14:27:42 -0500 | [diff] [blame] | 88 | if (!activationProgress) |
| 89 | { |
Adriana Kobylak | 2285fe0 | 2018-02-27 15:36:59 -0600 | [diff] [blame] | 90 | activationProgress = |
| 91 | std::make_unique<ActivationProgress>(bus, path); |
Michael Tritz | 0edd4ad | 2017-07-26 14:27:42 -0500 | [diff] [blame] | 92 | } |
| 93 | |
Michael Tritz | bed88af | 2017-07-19 16:00:06 -0500 | [diff] [blame] | 94 | if (!activationBlocksTransition) |
| 95 | { |
| 96 | activationBlocksTransition = |
Adriana Kobylak | 2285fe0 | 2018-02-27 15:36:59 -0600 | [diff] [blame] | 97 | std::make_unique<ActivationBlocksTransition>(bus, path); |
Michael Tritz | bed88af | 2017-07-19 16:00:06 -0500 | [diff] [blame] | 98 | } |
Saqib Khan | 4c1aec0 | 2017-07-06 11:46:13 -0500 | [diff] [blame] | 99 | |
Jayanth Othayoth | 0e0c127 | 2018-02-21 05:46:36 -0600 | [diff] [blame] | 100 | #ifdef WANT_SIGNATURE_VERIFY |
Jayanth Othayoth | 0e0c127 | 2018-02-21 05:46:36 -0600 | [diff] [blame] | 101 | fs::path uploadDir(IMG_UPLOAD_DIR); |
Lei YU | 9053225 | 2018-05-24 11:15:24 +0800 | [diff] [blame] | 102 | if (!verifySignature(uploadDir / versionId, SIGNED_IMAGE_CONF_PATH)) |
Jayanth Othayoth | 0e0c127 | 2018-02-21 05:46:36 -0600 | [diff] [blame] | 103 | { |
Lei YU | 9053225 | 2018-05-24 11:15:24 +0800 | [diff] [blame] | 104 | onVerifyFailed(); |
Jayanth Othayoth | 9a9d7c2 | 2018-03-28 10:05:26 -0500 | [diff] [blame] | 105 | // Stop the activation process, if fieldMode is enabled. |
| 106 | if (parent.control::FieldMode::fieldModeEnabled()) |
| 107 | { |
| 108 | // Cleanup |
| 109 | activationBlocksTransition.reset(nullptr); |
| 110 | activationProgress.reset(nullptr); |
Jayanth Othayoth | 9a9d7c2 | 2018-03-28 10:05:26 -0500 | [diff] [blame] | 111 | return softwareServer::Activation::activation( |
| 112 | softwareServer::Activation::Activations::Failed); |
| 113 | } |
Jayanth Othayoth | 0e0c127 | 2018-02-21 05:46:36 -0600 | [diff] [blame] | 114 | } |
| 115 | #endif |
| 116 | |
Adriana Kobylak | 9f89e2e | 2018-05-30 13:16:20 -0500 | [diff] [blame] | 117 | flashWrite(); |
Michael Tritz | 0edd4ad | 2017-07-26 14:27:42 -0500 | [diff] [blame] | 118 | |
| 119 | activationProgress->progress(10); |
Michael Tritz | bed88af | 2017-07-19 16:00:06 -0500 | [diff] [blame] | 120 | } |
| 121 | else if (rwVolumeCreated == true && roVolumeCreated == true) |
Saqib Khan | 4c1aec0 | 2017-07-06 11:46:13 -0500 | [diff] [blame] | 122 | { |
Adriana Kobylak | 166bdf3 | 2018-04-09 14:24:06 -0500 | [diff] [blame] | 123 | if (ubootEnvVarsUpdated == false) |
Michael Tritz | bed88af | 2017-07-19 16:00:06 -0500 | [diff] [blame] | 124 | { |
Adriana Kobylak | 166bdf3 | 2018-04-09 14:24:06 -0500 | [diff] [blame] | 125 | activationProgress->progress(90); |
| 126 | |
| 127 | if (!redundancyPriority) |
| 128 | { |
| 129 | redundancyPriority = std::make_unique<RedundancyPriority>( |
| 130 | bus, path, *this, 0); |
| 131 | } |
Michael Tritz | bed88af | 2017-07-19 16:00:06 -0500 | [diff] [blame] | 132 | } |
Adriana Kobylak | 166bdf3 | 2018-04-09 14:24:06 -0500 | [diff] [blame] | 133 | else |
| 134 | { |
| 135 | activationProgress->progress(100); |
Saqib Khan | 4c1aec0 | 2017-07-06 11:46:13 -0500 | [diff] [blame] | 136 | |
Adriana Kobylak | 166bdf3 | 2018-04-09 14:24:06 -0500 | [diff] [blame] | 137 | activationBlocksTransition.reset(nullptr); |
| 138 | activationProgress.reset(nullptr); |
Michael Tritz | 0edd4ad | 2017-07-26 14:27:42 -0500 | [diff] [blame] | 139 | |
Adriana Kobylak | 166bdf3 | 2018-04-09 14:24:06 -0500 | [diff] [blame] | 140 | rwVolumeCreated = false; |
| 141 | roVolumeCreated = false; |
| 142 | ubootEnvVarsUpdated = false; |
| 143 | Activation::unsubscribeFromSystemdSignals(); |
Michael Tritz | f2b5e0d | 2017-07-25 14:39:34 -0500 | [diff] [blame] | 144 | |
Adriana Kobylak | 166bdf3 | 2018-04-09 14:24:06 -0500 | [diff] [blame] | 145 | // Remove version object from image manager |
| 146 | Activation::deleteImageManagerObject(); |
Michael Tritz | f2b5e0d | 2017-07-25 14:39:34 -0500 | [diff] [blame] | 147 | |
Adriana Kobylak | 166bdf3 | 2018-04-09 14:24:06 -0500 | [diff] [blame] | 148 | // Create active association |
| 149 | parent.createActiveAssociation(path); |
Saqib Khan | ee13e83 | 2017-10-23 12:53:11 -0500 | [diff] [blame] | 150 | |
Adriana Kobylak | 166bdf3 | 2018-04-09 14:24:06 -0500 | [diff] [blame] | 151 | return softwareServer::Activation::activation( |
| 152 | softwareServer::Activation::Activations::Active); |
| 153 | } |
Michael Tritz | bed88af | 2017-07-19 16:00:06 -0500 | [diff] [blame] | 154 | } |
Lei YU | a7853ee | 2018-05-23 11:13:12 +0800 | [diff] [blame] | 155 | #else // !UBIFS_LAYOUT |
| 156 | |
Lei YU | 9053225 | 2018-05-24 11:15:24 +0800 | [diff] [blame] | 157 | #ifdef WANT_SIGNATURE_VERIFY |
| 158 | fs::path uploadDir(IMG_UPLOAD_DIR); |
| 159 | if (!verifySignature(uploadDir / versionId, SIGNED_IMAGE_CONF_PATH)) |
| 160 | { |
| 161 | onVerifyFailed(); |
| 162 | // Stop the activation process, if fieldMode is enabled. |
| 163 | if (parent.control::FieldMode::fieldModeEnabled()) |
| 164 | { |
| 165 | return softwareServer::Activation::activation( |
| 166 | softwareServer::Activation::Activations::Failed); |
| 167 | } |
| 168 | } |
| 169 | #endif |
Lei YU | a7853ee | 2018-05-23 11:13:12 +0800 | [diff] [blame] | 170 | parent.freeSpace(); |
| 171 | |
| 172 | flashWrite(); |
| 173 | |
| 174 | if (!redundancyPriority) |
| 175 | { |
| 176 | redundancyPriority = |
| 177 | std::make_unique<RedundancyPriority>(bus, path, *this, 0); |
| 178 | } |
| 179 | |
| 180 | // Remove version object from image manager |
| 181 | Activation::deleteImageManagerObject(); |
| 182 | |
| 183 | // Create active association |
| 184 | parent.createActiveAssociation(path); |
| 185 | |
| 186 | log<level::INFO>("BMC image ready, need reboot to get activated."); |
| 187 | return softwareServer::Activation::activation( |
| 188 | softwareServer::Activation::Activations::Active); |
| 189 | #endif |
Saqib Khan | b077470 | 2017-05-23 16:02:41 -0500 | [diff] [blame] | 190 | } |
| 191 | else |
| 192 | { |
| 193 | activationBlocksTransition.reset(nullptr); |
Michael Tritz | 0edd4ad | 2017-07-26 14:27:42 -0500 | [diff] [blame] | 194 | activationProgress.reset(nullptr); |
Saqib Khan | b077470 | 2017-05-23 16:02:41 -0500 | [diff] [blame] | 195 | } |
| 196 | return softwareServer::Activation::activation(value); |
| 197 | } |
| 198 | |
Saqib Khan | ee13e83 | 2017-10-23 12:53:11 -0500 | [diff] [blame] | 199 | void Activation::deleteImageManagerObject() |
| 200 | { |
Saqib Khan | ee13e83 | 2017-10-23 12:53:11 -0500 | [diff] [blame] | 201 | // Call the Delete object for <versionID> inside image_manager |
Adriana Kobylak | 2285fe0 | 2018-02-27 15:36:59 -0600 | [diff] [blame] | 202 | auto method = this->bus.new_method_call(VERSION_BUSNAME, path.c_str(), |
| 203 | "xyz.openbmc_project.Object.Delete", |
| 204 | "Delete"); |
Adriana Kobylak | 00bd902 | 2018-01-24 13:55:58 -0600 | [diff] [blame] | 205 | auto mapperResponseMsg = bus.call(method); |
Adriana Kobylak | 2285fe0 | 2018-02-27 15:36:59 -0600 | [diff] [blame] | 206 | // Check that the bus call didn't result in an error |
Saqib Khan | ee13e83 | 2017-10-23 12:53:11 -0500 | [diff] [blame] | 207 | if (mapperResponseMsg.is_method_error()) |
| 208 | { |
| 209 | log<level::ERR>("Error in Deleting image from image manager", |
Adriana Kobylak | 596466b | 2018-02-13 14:48:53 -0600 | [diff] [blame] | 210 | entry("VERSIONPATH=%s", path.c_str())); |
Saqib Khan | ee13e83 | 2017-10-23 12:53:11 -0500 | [diff] [blame] | 211 | return; |
| 212 | } |
| 213 | } |
| 214 | |
Adriana Kobylak | 2285fe0 | 2018-02-27 15:36:59 -0600 | [diff] [blame] | 215 | auto Activation::requestedActivation(RequestedActivations value) |
| 216 | -> RequestedActivations |
Saqib Khan | b077470 | 2017-05-23 16:02:41 -0500 | [diff] [blame] | 217 | { |
Michael Tritz | bed88af | 2017-07-19 16:00:06 -0500 | [diff] [blame] | 218 | rwVolumeCreated = false; |
| 219 | roVolumeCreated = false; |
Adriana Kobylak | 166bdf3 | 2018-04-09 14:24:06 -0500 | [diff] [blame] | 220 | ubootEnvVarsUpdated = false; |
Michael Tritz | bed88af | 2017-07-19 16:00:06 -0500 | [diff] [blame] | 221 | |
Saqib Khan | b077470 | 2017-05-23 16:02:41 -0500 | [diff] [blame] | 222 | if ((value == softwareServer::Activation::RequestedActivations::Active) && |
| 223 | (softwareServer::Activation::requestedActivation() != |
Adriana Kobylak | 2285fe0 | 2018-02-27 15:36:59 -0600 | [diff] [blame] | 224 | softwareServer::Activation::RequestedActivations::Active)) |
Saqib Khan | b077470 | 2017-05-23 16:02:41 -0500 | [diff] [blame] | 225 | { |
| 226 | if ((softwareServer::Activation::activation() == |
Adriana Kobylak | 2285fe0 | 2018-02-27 15:36:59 -0600 | [diff] [blame] | 227 | softwareServer::Activation::Activations::Ready) || |
Saqib Khan | b077470 | 2017-05-23 16:02:41 -0500 | [diff] [blame] | 228 | (softwareServer::Activation::activation() == |
Adriana Kobylak | 2285fe0 | 2018-02-27 15:36:59 -0600 | [diff] [blame] | 229 | softwareServer::Activation::Activations::Failed)) |
Saqib Khan | b077470 | 2017-05-23 16:02:41 -0500 | [diff] [blame] | 230 | { |
| 231 | Activation::activation( |
Adriana Kobylak | 2285fe0 | 2018-02-27 15:36:59 -0600 | [diff] [blame] | 232 | softwareServer::Activation::Activations::Activating); |
Saqib Khan | b077470 | 2017-05-23 16:02:41 -0500 | [diff] [blame] | 233 | } |
| 234 | } |
| 235 | return softwareServer::Activation::requestedActivation(value); |
| 236 | } |
| 237 | |
Saqib Khan | 4c1aec0 | 2017-07-06 11:46:13 -0500 | [diff] [blame] | 238 | uint8_t RedundancyPriority::priority(uint8_t value) |
| 239 | { |
Adriana Kobylak | b77551c | 2017-10-27 12:46:23 -0500 | [diff] [blame] | 240 | // Set the priority value so that the freePriority() function can order |
| 241 | // the versions by priority. |
| 242 | auto newPriority = softwareServer::RedundancyPriority::priority(value); |
Saqib Khan | 5d53267 | 2017-08-09 10:44:50 -0500 | [diff] [blame] | 243 | storeToFile(parent.versionId, value); |
Adriana Kobylak | b77551c | 2017-10-27 12:46:23 -0500 | [diff] [blame] | 244 | parent.parent.freePriority(value, parent.versionId); |
| 245 | return newPriority; |
Saqib Khan | 4c1aec0 | 2017-07-06 11:46:13 -0500 | [diff] [blame] | 246 | } |
| 247 | |
Adriana Kobylak | b77551c | 2017-10-27 12:46:23 -0500 | [diff] [blame] | 248 | uint8_t RedundancyPriority::sdbusPriority(uint8_t value) |
Saqib Khan | f0382c3 | 2017-10-24 13:36:22 -0500 | [diff] [blame] | 249 | { |
Adriana Kobylak | b77551c | 2017-10-27 12:46:23 -0500 | [diff] [blame] | 250 | storeToFile(parent.versionId, value); |
| 251 | return softwareServer::RedundancyPriority::priority(value); |
Saqib Khan | f0382c3 | 2017-10-24 13:36:22 -0500 | [diff] [blame] | 252 | } |
| 253 | |
Michael Tritz | bed88af | 2017-07-19 16:00:06 -0500 | [diff] [blame] | 254 | void Activation::unitStateChange(sdbusplus::message::message& msg) |
| 255 | { |
Michael Tritz | 0edd4ad | 2017-07-26 14:27:42 -0500 | [diff] [blame] | 256 | if (softwareServer::Activation::activation() != |
Adriana Kobylak | 2285fe0 | 2018-02-27 15:36:59 -0600 | [diff] [blame] | 257 | softwareServer::Activation::Activations::Activating) |
Michael Tritz | 0edd4ad | 2017-07-26 14:27:42 -0500 | [diff] [blame] | 258 | { |
| 259 | return; |
| 260 | } |
| 261 | |
Adriana Kobylak | 3ce563a | 2018-06-06 16:41:15 -0500 | [diff] [blame] | 262 | onStateChanges(msg); |
Michael Tritz | bed88af | 2017-07-19 16:00:06 -0500 | [diff] [blame] | 263 | |
| 264 | return; |
| 265 | } |
| 266 | |
Lei YU | 9053225 | 2018-05-24 11:15:24 +0800 | [diff] [blame] | 267 | #ifdef WANT_SIGNATURE_VERIFY |
| 268 | bool Activation::verifySignature(const fs::path& imageDir, |
| 269 | const fs::path& confDir) |
| 270 | { |
| 271 | using Signature = phosphor::software::image::Signature; |
| 272 | |
| 273 | Signature signature(imageDir, confDir); |
| 274 | |
| 275 | return signature.verify(); |
| 276 | } |
| 277 | |
| 278 | void Activation::onVerifyFailed() |
| 279 | { |
| 280 | log<level::ERR>("Error occurred during image validation"); |
| 281 | report<InternalFailure>(); |
| 282 | } |
| 283 | #endif |
| 284 | |
Saqib Khan | f37cefc | 2017-09-12 08:44:41 -0500 | [diff] [blame] | 285 | void ActivationBlocksTransition::enableRebootGuard() |
| 286 | { |
| 287 | log<level::INFO>("BMC image activating - BMC reboots are disabled."); |
| 288 | |
Adriana Kobylak | 2285fe0 | 2018-02-27 15:36:59 -0600 | [diff] [blame] | 289 | auto method = bus.new_method_call(SYSTEMD_BUSNAME, SYSTEMD_PATH, |
| 290 | SYSTEMD_INTERFACE, "StartUnit"); |
Saqib Khan | f37cefc | 2017-09-12 08:44:41 -0500 | [diff] [blame] | 291 | method.append("reboot-guard-enable.service", "replace"); |
| 292 | bus.call_noreply(method); |
| 293 | } |
| 294 | |
| 295 | void ActivationBlocksTransition::disableRebootGuard() |
| 296 | { |
| 297 | log<level::INFO>("BMC activation has ended - BMC reboots are re-enabled."); |
| 298 | |
Adriana Kobylak | 2285fe0 | 2018-02-27 15:36:59 -0600 | [diff] [blame] | 299 | auto method = bus.new_method_call(SYSTEMD_BUSNAME, SYSTEMD_PATH, |
| 300 | SYSTEMD_INTERFACE, "StartUnit"); |
Saqib Khan | f37cefc | 2017-09-12 08:44:41 -0500 | [diff] [blame] | 301 | method.append("reboot-guard-disable.service", "replace"); |
| 302 | bus.call_noreply(method); |
| 303 | } |
Michael Tritz | bed88af | 2017-07-19 16:00:06 -0500 | [diff] [blame] | 304 | |
Saqib Khan | b077470 | 2017-05-23 16:02:41 -0500 | [diff] [blame] | 305 | } // namespace updater |
| 306 | } // namespace software |
| 307 | } // namespace phosphor |