blob: 5c78f3a153b54adeece27586ba57e87072b42dc1 [file] [log] [blame]
Ratan Gupta82549cc2017-04-21 08:45:23 +05301#include "config.h"
Ratan Gupta91a99cc2017-04-14 16:32:09 +05302#include "ethernet_interface.hpp"
Ratan Gupta2b106532017-07-25 16:05:02 +05303#include "ipaddress.hpp"
Ratan Gupta4f1c18b2017-05-25 12:59:35 +05304#include "network_manager.hpp"
Ratan Guptafc2c7242017-05-29 08:46:06 +05305#include "routing_table.hpp"
Ratan Gupta2b106532017-07-25 16:05:02 +05306#include "vlan_interface.hpp"
7#include "xyz/openbmc_project/Common/error.hpp"
Ratan Gupta91a99cc2017-04-14 16:32:09 +05308
Ratan Gupta2b106532017-07-25 16:05:02 +05309#include <phosphor-logging/elog-errors.hpp>
Ratan Gupta91a99cc2017-04-14 16:32:09 +053010#include <phosphor-logging/log.hpp>
11
Ratan Gupta82549cc2017-04-21 08:45:23 +053012#include <arpa/inet.h>
Ratan Gupta91a99cc2017-04-14 16:32:09 +053013#include <linux/ethtool.h>
Ratan Gupta91a99cc2017-04-14 16:32:09 +053014#include <linux/sockios.h>
Ratan Gupta2b106532017-07-25 16:05:02 +053015#include <net/if.h>
Ratan Gupta91a99cc2017-04-14 16:32:09 +053016#include <netinet/in.h>
17#include <sys/ioctl.h>
18#include <sys/socket.h>
19#include <unistd.h>
20
Ratan Gupta2b106532017-07-25 16:05:02 +053021
Ratan Gupta82549cc2017-04-21 08:45:23 +053022#include <algorithm>
23#include <experimental/filesystem>
Ratan Gupta2b106532017-07-25 16:05:02 +053024#include <fstream>
25#include <sstream>
26#include <string>
Ratan Gupta82549cc2017-04-21 08:45:23 +053027
Ratan Gupta91a99cc2017-04-14 16:32:09 +053028namespace phosphor
29{
30namespace network
31{
32
33using namespace phosphor::logging;
Ratan Gupta2b106532017-07-25 16:05:02 +053034using namespace sdbusplus::xyz::openbmc_project::Common::Error;
35
Ratan Gupta91a99cc2017-04-14 16:32:09 +053036constexpr auto MAC_ADDRESS_FORMAT = "%02X:%02X:%02X:%02X:%02X:%02X";
37constexpr size_t SIZE_MAC = 18;
38constexpr size_t SIZE_BUFF = 512;
39
40EthernetInterface::EthernetInterface(sdbusplus::bus::bus& bus,
41 const std::string& objPath,
Ratan Gupta4f1c18b2017-05-25 12:59:35 +053042 bool dhcpEnabled,
Ratan Gupta3d3e4fc2017-07-25 13:38:19 +053043 Manager& parent,
44 bool emitSignal) :
Ratan Gupta82549cc2017-04-21 08:45:23 +053045 Ifaces(bus, objPath.c_str(), true),
Ratan Gupta4f1c18b2017-05-25 12:59:35 +053046 bus(bus),
Ratan Gupta47722dc2017-05-26 18:32:23 +053047 manager(parent),
48 objPath(objPath)
Ratan Gupta91a99cc2017-04-14 16:32:09 +053049{
50 auto intfName = objPath.substr(objPath.rfind("/") + 1);
Ratan Gupta5978dd12017-07-25 13:47:13 +053051 std::replace(intfName.begin(), intfName.end(), '_', '.');
Ratan Gupta91a99cc2017-04-14 16:32:09 +053052 interfaceName(intfName);
53 dHCPEnabled(dhcpEnabled);
54 mACAddress(getMACAddress());
Ratan Gupta5978dd12017-07-25 13:47:13 +053055
Ratan Gupta29b0e432017-05-25 12:51:40 +053056 // Emit deferred signal.
Ratan Gupta3d3e4fc2017-07-25 13:38:19 +053057 if (emitSignal)
58 {
59 this->emit_object_added();
60 }
Ratan Gupta29b0e432017-05-25 12:51:40 +053061}
62
Ratan Gupta87c13982017-06-15 09:27:27 +053063void EthernetInterface::createIPAddressObjects()
Ratan Gupta29b0e432017-05-25 12:51:40 +053064{
Ratan Gupta82549cc2017-04-21 08:45:23 +053065 std::string gateway;
Ratan Gupta87c13982017-06-15 09:27:27 +053066 addrs.clear();
Ratan Gupta82549cc2017-04-21 08:45:23 +053067
Ratan Gupta87c13982017-06-15 09:27:27 +053068 auto addrs = getInterfaceAddrs()[interfaceName()];
Ratan Gupta5978dd12017-07-25 13:47:13 +053069
Ratan Gupta82549cc2017-04-21 08:45:23 +053070 IP::Protocol addressType = IP::Protocol::IPv4;
Ratan Gupta29b0e432017-05-25 12:51:40 +053071 IP::AddressOrigin origin = IP::AddressOrigin::Static;
Ratan Guptafc2c7242017-05-29 08:46:06 +053072 route::Table routingTable;
Ratan Gupta5978dd12017-07-25 13:47:13 +053073
Ratan Gupta6a387c12017-08-03 13:26:19 +053074 for (auto& addr : addrs)
Ratan Gupta82549cc2017-04-21 08:45:23 +053075 {
76 if (addr.addrType == AF_INET6)
77 {
78 addressType = IP::Protocol::IPv6;
79 }
Ratan Guptafc2c7242017-05-29 08:46:06 +053080 if (dHCPEnabled())
81 {
82 origin = IP::AddressOrigin::DHCP;
83 }
84 else if (isLinkLocal(addr.ipaddress))
85 {
86 origin = IP::AddressOrigin::LinkLocal;
87 }
88 gateway = routingTable.getGateway(addr.addrType, addr.ipaddress, addr.prefix);
Ratan Gupta82549cc2017-04-21 08:45:23 +053089
Ratan Gupta65e5abe2017-05-23 13:20:44 +053090 std::string ipAddressObjectPath = generateObjectPath(addressType,
91 addr.ipaddress,
92 addr.prefix,
93 gateway);
Ratan Guptafc2c7242017-05-29 08:46:06 +053094
Ratan Gupta82549cc2017-04-21 08:45:23 +053095 this->addrs.emplace(
Ratan Guptae578d562017-08-02 07:04:16 +053096 std::move(addr.ipaddress),
97 std::make_shared<phosphor::network::IPAddress>(
Ratan Gupta719f83a2017-06-02 11:54:53 +053098 bus,
99 ipAddressObjectPath.c_str(),
100 *this,
101 addressType,
Ratan Gupta82549cc2017-04-21 08:45:23 +0530102 addr.ipaddress,
Ratan Gupta29b0e432017-05-25 12:51:40 +0530103 origin,
Ratan Gupta719f83a2017-06-02 11:54:53 +0530104 addr.prefix,
Ratan Guptae578d562017-08-02 07:04:16 +0530105 gateway));
Ratan Gupta82549cc2017-04-21 08:45:23 +0530106 }
Ratan Guptafc2c7242017-05-29 08:46:06 +0530107
Ratan Gupta91a99cc2017-04-14 16:32:09 +0530108}
109
Ratan Gupta82549cc2017-04-21 08:45:23 +0530110void EthernetInterface::iP(IP::Protocol protType,
111 std::string ipaddress,
112 uint8_t prefixLength,
113 std::string gateway)
114{
Ratan Guptafc2c7242017-05-29 08:46:06 +0530115
116 if (dHCPEnabled())
117 {
Ratan Gupta82e1ef92017-06-15 08:39:15 +0530118 log<level::INFO>("DHCP enabled on the interface"),
119 entry("INTERFACE=%s",interfaceName());
Ratan Guptafc2c7242017-05-29 08:46:06 +0530120 return;
121 }
122
Ratan Gupta29b0e432017-05-25 12:51:40 +0530123 IP::AddressOrigin origin = IP::AddressOrigin::Static;
124
Ratan Gupta65e5abe2017-05-23 13:20:44 +0530125 std::string objectPath = generateObjectPath(protType,
126 ipaddress,
127 prefixLength,
128 gateway);
Ratan Gupta82549cc2017-04-21 08:45:23 +0530129 this->addrs.emplace(
Ratan Guptae578d562017-08-02 07:04:16 +0530130 std::move(ipaddress),
131 std::make_shared<phosphor::network::IPAddress>(
132 bus,
133 objectPath.c_str(),
134 *this,
135 protType,
136 ipaddress,
137 origin,
138 prefixLength,
139 gateway));
Ratan Gupta4f1c18b2017-05-25 12:59:35 +0530140
Ratan Gupta2b106532017-07-25 16:05:02 +0530141 writeConfigurationFile();
Ratan Gupta82549cc2017-04-21 08:45:23 +0530142}
143
144
Ratan Gupta91a99cc2017-04-14 16:32:09 +0530145/*
146Note: We don't have support for ethtool now
147will enable this code once we bring the ethtool
148in the image.
149TODO: https://github.com/openbmc/openbmc/issues/1484
150*/
Ratan Gupta82549cc2017-04-21 08:45:23 +0530151
Ratan Gupta91a99cc2017-04-14 16:32:09 +0530152InterfaceInfo EthernetInterface::getInterfaceInfo() const
153{
154 int sock{-1};
155 struct ifreq ifr{0};
156 struct ethtool_cmd edata{0};
157 LinkSpeed speed {0};
158 Autoneg autoneg {0};
159 DuplexMode duplex {0};
160 do
161 {
162 sock = socket(PF_INET, SOCK_DGRAM, IPPROTO_IP);
163 if (sock < 0)
164 {
165 log<level::ERR>("socket creation failed:",
166 entry("ERROR=%s", strerror(errno)));
167 break;
168 }
169
170 strncpy(ifr.ifr_name, interfaceName().c_str(), sizeof(ifr.ifr_name));
171 ifr.ifr_data = reinterpret_cast<char*>(&edata);
172
173 edata.cmd = ETHTOOL_GSET;
174
175 if (ioctl(sock, SIOCETHTOOL, &ifr) < 0)
176 {
177 log<level::ERR>("ioctl failed for SIOCETHTOOL:",
178 entry("ERROR=%s", strerror(errno)));
179 break;
180
181 }
182 speed = edata.speed;
183 duplex = edata.duplex;
184 autoneg = edata.autoneg;
185 }
186 while (0);
187
188 if (sock)
189 {
190 close(sock);
191 }
192 return std::make_tuple(speed, duplex, autoneg);
193}
194
195/** @brief get the mac address of the interface.
196 * @return macaddress on success
197 */
198
199std::string EthernetInterface::getMACAddress() const
200{
201 struct ifreq ifr;
202 struct ifconf ifc;
203 char buf[SIZE_BUFF];
204 char macAddress[SIZE_MAC] = "";
205
206 int sock = socket(AF_INET, SOCK_DGRAM, IPPROTO_IP);
207 if (sock < 0)
208 {
209 log<level::ERR>("socket creation failed:",
210 entry("ERROR=%s", strerror(errno)));
211 return macAddress;
212 }
213
214 ifc.ifc_len = sizeof(buf);
215 ifc.ifc_buf = buf;
216 if (ioctl(sock, SIOCGIFCONF, &ifc) < 0)
217 {
218 log<level::ERR>("ioctl failed for SIOCGIFCONF:",
219 entry("ERROR=%s", strerror(errno)));
220 return macAddress;
221 }
222
223 struct ifreq* it = ifc.ifc_req;
224 const struct ifreq* const end = it + (ifc.ifc_len / sizeof(struct ifreq));
225
226 for (; it != end; ++it)
227 {
228 if (interfaceName() == it->ifr_name)
229 {
230 break;
231 }
232 }
233 if (interfaceName() == it->ifr_name)
234 {
235 strcpy(ifr.ifr_name, it->ifr_name);
236 if (ioctl(sock, SIOCGIFHWADDR, &ifr) != 0)
237 {
238 log<level::ERR>("ioctl failed for SIOCGIFHWADDR:",
239 entry("ERROR=%s", strerror(errno)));
240 return macAddress;
241 }
242
243 snprintf(macAddress, SIZE_MAC, MAC_ADDRESS_FORMAT,
244 ifr.ifr_hwaddr.sa_data[0], ifr.ifr_hwaddr.sa_data[1],
245 ifr.ifr_hwaddr.sa_data[2], ifr.ifr_hwaddr.sa_data[3],
246 ifr.ifr_hwaddr.sa_data[4], ifr.ifr_hwaddr.sa_data[5]);
247 }
248 return macAddress;
249}
Ratan Gupta2eff84f2017-04-20 19:19:15 +0530250
Ratan Gupta65e5abe2017-05-23 13:20:44 +0530251std::string EthernetInterface::generateId(const std::string& ipaddress,
252 uint8_t prefixLength,
253 const std::string& gateway)
Ratan Gupta82549cc2017-04-21 08:45:23 +0530254{
Ratan Gupta65e5abe2017-05-23 13:20:44 +0530255 std::stringstream hexId;
256 std::string hashString = ipaddress;
257 hashString += std::to_string(prefixLength);
258 hashString += gateway;
Ratan Gupta82549cc2017-04-21 08:45:23 +0530259
Ratan Gupta65e5abe2017-05-23 13:20:44 +0530260 // Only want 8 hex digits.
261 hexId << std::hex << ((std::hash<std::string> {}(
Ratan Guptafc2c7242017-05-29 08:46:06 +0530262 hashString)) & 0xFFFFFFFF);
Ratan Gupta65e5abe2017-05-23 13:20:44 +0530263 return hexId.str();
Ratan Gupta82549cc2017-04-21 08:45:23 +0530264}
265
Ratan Gupta2eff84f2017-04-20 19:19:15 +0530266void EthernetInterface::deleteObject(const std::string& ipaddress)
267{
Ratan Gupta29b0e432017-05-25 12:51:40 +0530268 auto it = addrs.find(ipaddress);
Ratan Guptafc2c7242017-05-29 08:46:06 +0530269 if (it == addrs.end())
Ratan Gupta29b0e432017-05-25 12:51:40 +0530270 {
Ratan Guptafc2c7242017-05-29 08:46:06 +0530271 log<level::ERR>("DeleteObject:Unable to find the object.");
272 return;
Ratan Gupta29b0e432017-05-25 12:51:40 +0530273 }
274 this->addrs.erase(it);
Ratan Gupta2b106532017-07-25 16:05:02 +0530275 writeConfigurationFile();
Ratan Gupta82549cc2017-04-21 08:45:23 +0530276}
277
Ratan Guptabc886292017-07-25 18:29:57 +0530278void EthernetInterface::deleteVLANObject(const std::string& interface)
279{
280 using namespace std::string_literals;
281
282 auto it = vlanInterfaces.find(interface);
283 if (it == vlanInterfaces.end())
284 {
285 log<level::ERR>("DeleteVLANObject:Unable to find the object",
286 entry("INTERFACE=%s",interface.c_str()));
287 return;
288 }
289
290 auto confDir = manager.getConfDir();
291 fs::path networkFile = confDir;
292 networkFile /= systemd::config::networkFilePrefix + interface +
293 systemd::config::networkFileSuffix;
294
295 fs::path deviceFile = confDir;
296 deviceFile /= interface + systemd::config::deviceFileSuffix;
297
298 // delete the vlan network file
299 if (fs::is_regular_file(networkFile))
300 {
301 fs::remove(networkFile);
302 }
303
304 // delete the vlan device file
305 if (fs::is_regular_file(deviceFile))
306 {
307 fs::remove(deviceFile);
308 }
309 // delete the interface
310 vlanInterfaces.erase(it);
311 // restart the systemd-networkd
312
313 restartSystemdUnit("systemd-networkd.service");
314
315 // TODO systemd doesn't delete the virtual network interface
316 // even after deleting all the related configuartion.
317 // https://github.com/systemd/systemd/issues/6600
318 try
319 {
320 deleteInterface(interface);
321 }
322 catch (InternalFailure& e)
323 {
324 commit<InternalFailure>();
325 }
326}
327
Ratan Gupta65e5abe2017-05-23 13:20:44 +0530328std::string EthernetInterface::generateObjectPath(IP::Protocol addressType,
329 const std::string& ipaddress,
330 uint8_t prefixLength,
331 const std::string& gateway) const
Ratan Gupta82549cc2017-04-21 08:45:23 +0530332{
Ratan Gupta82549cc2017-04-21 08:45:23 +0530333 std::string type = convertForMessage(addressType);
Ratan Gupta29b0e432017-05-25 12:51:40 +0530334 type = type.substr(type.rfind('.') + 1);
Ratan Gupta82549cc2017-04-21 08:45:23 +0530335 std::transform(type.begin(), type.end(), type.begin(), ::tolower);
336
337 std::experimental::filesystem::path objectPath;
Ratan Gupta47722dc2017-05-26 18:32:23 +0530338 objectPath /= objPath;
Ratan Gupta82549cc2017-04-21 08:45:23 +0530339 objectPath /= type;
Ratan Gupta29b0e432017-05-25 12:51:40 +0530340 objectPath /= generateId(ipaddress, prefixLength, gateway);
Ratan Gupta82549cc2017-04-21 08:45:23 +0530341 return objectPath.string();
Ratan Gupta2eff84f2017-04-20 19:19:15 +0530342}
343
Ratan Gupta87c13982017-06-15 09:27:27 +0530344bool EthernetInterface::dHCPEnabled(bool value)
345{
Ratan Gupta5978dd12017-07-25 13:47:13 +0530346 if (value == EthernetInterfaceIntf::dHCPEnabled())
347 {
348 return value;
349 }
350
Ratan Gupta87c13982017-06-15 09:27:27 +0530351 EthernetInterfaceIntf::dHCPEnabled(value);
Ratan Gupta5978dd12017-07-25 13:47:13 +0530352 if (value)
Ratan Gupta87c13982017-06-15 09:27:27 +0530353 {
Ratan Gupta2b106532017-07-25 16:05:02 +0530354 writeConfigurationFile();
Ratan Gupta87c13982017-06-15 09:27:27 +0530355 createIPAddressObjects();
356 }
Ratan Gupta92bc2fe2017-07-26 22:40:21 +0530357
Ratan Gupta87c13982017-06-15 09:27:27 +0530358 return value;
359}
360
Ratan Gupta92bc2fe2017-07-26 22:40:21 +0530361void EthernetInterface::loadVLAN(VlanId id)
362{
363 std::string vlanInterfaceName = interfaceName() + "." +
364 std::to_string(id);
365 std::string path = objPath;
366 path += "_" + std::to_string(id);
367
Ratan Gupta6e8df632017-08-13 09:41:58 +0530368 auto dhcpEnabled = getDHCPValue(manager.getConfDir().string(),
369 vlanInterfaceName);
370
Ratan Gupta92bc2fe2017-07-26 22:40:21 +0530371 auto vlanIntf = std::make_unique<phosphor::network::VlanInterface>(
372 bus,
373 path.c_str(),
Ratan Gupta6e8df632017-08-13 09:41:58 +0530374 dhcpEnabled,
Ratan Gupta92bc2fe2017-07-26 22:40:21 +0530375 id,
376 *this,
377 manager);
378
379 // Fetch the ip address from the system
380 // and create the dbus object.
381 vlanIntf->createIPAddressObjects();
382
383 this->vlanInterfaces.emplace(std::move(vlanInterfaceName),
384 std::move(vlanIntf));
385}
386
Ratan Gupta5978dd12017-07-25 13:47:13 +0530387void EthernetInterface::createVLAN(VlanId id)
388{
389 std::string vlanInterfaceName = interfaceName() + "." +
390 std::to_string(id);
391 std::string path = objPath;
392 path += "_" + std::to_string(id);
393
394
395 auto vlanIntf = std::make_unique<phosphor::network::VlanInterface>(
396 bus,
397 path.c_str(),
398 EthernetInterfaceIntf::dHCPEnabled(),
399 id,
400 *this,
401 manager);
402
403 // write the device file for the vlan interface.
404 vlanIntf->writeDeviceFile();
405
Ratan Gupta6e8df632017-08-13 09:41:58 +0530406 this->vlanInterfaces.emplace(vlanInterfaceName,
Ratan Gupta5978dd12017-07-25 13:47:13 +0530407 std::move(vlanIntf));
408 // write the new vlan device entry to the configuration(network) file.
Ratan Gupta2b106532017-07-25 16:05:02 +0530409 writeConfigurationFile();
Ratan Gupta6e8df632017-08-13 09:41:58 +0530410
411 // Create the dbus object for the link local ipv6 address.
412 vlanInterfaces[vlanInterfaceName]->createIPAddressObjects();
413
Ratan Gupta5978dd12017-07-25 13:47:13 +0530414}
Ratan Gupta2b106532017-07-25 16:05:02 +0530415
416// Need to merge the below function with the code which writes the
417// config file during factory reset.
418// TODO openbmc/openbmc#1751
419
420void EthernetInterface::writeConfigurationFile()
421{
422 // write all the static ip address in the systemd-network conf file
423
424 using namespace std::string_literals;
425 using AddressOrigin =
426 sdbusplus::xyz::openbmc_project::Network::server::IP::AddressOrigin;
427 namespace fs = std::experimental::filesystem;
428 fs::path confPath = manager.getConfDir();
429
Ratan Guptabc886292017-07-25 18:29:57 +0530430 std::string fileName = systemd::config::networkFilePrefix + interfaceName() +
431 systemd::config::networkFileSuffix;
Ratan Gupta2b106532017-07-25 16:05:02 +0530432 confPath /= fileName;
433 std::fstream stream;
434
435 stream.open(confPath.c_str(), std::fstream::out);
436 if (!stream.is_open())
437 {
438 log<level::ERR>("Unable to open the file",
439 entry("FILE=%s", confPath.c_str()));
440 elog<InternalFailure>();
441 }
442
443 // Write the device
444 stream << "[" << "Match" << "]\n";
445 stream << "Name=" << interfaceName() << "\n";
446
447 auto addrs = getAddresses();
448
449 // write the network section
450 stream << "[" << "Network" << "]\n";
451 // DHCP
452 if (dHCPEnabled() == true)
453 {
454 // write the dhcp section if interface is
455 // configured as dhcp.
456 writeDHCPSection(stream);
457 stream.close();
458 return;
459 }
460 // Add the Vlan entry
461 for(const auto& intf: vlanInterfaces)
462 {
463 stream << "VLAN=" << intf.second->EthernetInterface::interfaceName() << "\n";
464 }
465
466 // Static
467 for (const auto& addr : addrs)
468 {
469 if (addr.second->origin() == AddressOrigin::Static)
470 {
471 std::string address = addr.second->address() + "/" + std::to_string(
472 addr.second->prefixLength());
473
474 stream << "Address=" << address << "\n";
475 }
476 }
477
478 if (manager.getSystemConf())
479 {
480 stream << "Gateway=" << manager.getSystemConf()->defaultGateway()
481 << "\n";
482 }
483 // write the route section
484 stream << "[" << "Route" << "]\n";
485 for(const auto& addr : addrs)
486 {
487 if (addr.second->origin() == AddressOrigin::Static)
488 {
489 int addressFamily = addr.second->type() == IP::Protocol::IPv4 ? AF_INET : AF_INET6;
490 std::string destination = getNetworkID(
491 addressFamily,
492 addr.second->address(),
493 addr.second->prefixLength());
494
495 if (addr.second->gateway() != "0.0.0.0" &&
496 addr.second->gateway() != "" &&
497 destination != "0.0.0.0" &&
498 destination != "")
499 {
500 stream << "Gateway=" << addr.second->gateway() << "\n";
501 stream << "Destination=" << destination << "\n";
502 }
503
504 }
505 }
506
507 stream.close();
508 restartSystemdUnit("systemd-networkd.service");
509}
510
511void EthernetInterface::writeDHCPSection(std::fstream& stream)
512{
513 using namespace std::string_literals;
514 stream << "DHCP=true\n";
515 // write the dhcp section
516 stream << "[DHCP]\n";
517
518 // Hardcoding the client identifier to mac, to address below issue
519 // https://github.com/openbmc/openbmc/issues/1280
520 stream << "ClientIdentifier=mac\n";
521 if (manager.getDHCPConf())
522 {
523 auto value = manager.getDHCPConf()->dNSEnabled() ? "true"s : "false"s;
524 stream << "UseDNS="s + value + "\n";
525
526 value = manager.getDHCPConf()->nTPEnabled() ? "true"s : "false"s;
527 stream << "UseNTP="s + value + "\n";
528
529 value = manager.getDHCPConf()->hostNameEnabled() ? "true"s : "false"s;
530 stream << "UseHostname="s + value + "\n";
531 }
532}
533
Ratan Gupta91a99cc2017-04-14 16:32:09 +0530534}//namespace network
535}//namespace phosphor